[GitHub] [solr] janhoy commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…

2022-10-27 Thread GitBox
janhoy commented on PR #1114: URL: https://github.com/apache/solr/pull/1114#issuecomment-1294522253 Maybe the gist of the networking page can be summarized as “Running distributed Zookeeper requires stable host names and IP addresses. Although possible, we discourage rolling your own zookee

[GitHub] [solr] patsonluk commented on a diff in pull request #1143: SOLR-16506 : Throws exception on core startup for node name mismatch

2022-10-27 Thread GitBox
patsonluk commented on code in PR #1143: URL: https://github.com/apache/solr/pull/1143#discussion_r1007601857 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2899,6 +2920,23 @@ public NotInClusterStateException(ErrorCode code, String msg) { } } +

[GitHub] [solr] noblepaul merged pull request #1136: Fix the Zookeeper docs URL link so that it will not get shown

2022-10-27 Thread GitBox
noblepaul merged PR #1136: URL: https://github.com/apache/solr/pull/1136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[GitHub] [solr] noblepaul commented on pull request #1139: Emphasize the meaning of using replicas without sharding

2022-10-27 Thread GitBox
noblepaul commented on PR #1139: URL: https://github.com/apache/solr/pull/1139#issuecomment-1294419167 TBH, I can't see any value add from adding that one line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [solr] noblepaul commented on a diff in pull request #1143: SOLR-16506 : Throws exception on core startup for node name mismatch

2022-10-27 Thread GitBox
noblepaul commented on code in PR #1143: URL: https://github.com/apache/solr/pull/1143#discussion_r1007585071 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2899,6 +2920,23 @@ public NotInClusterStateException(ErrorCode code, String msg) { } } +

[GitHub] [solr] risdenk commented on a diff in pull request #1128: SOLR-16427: Evaluate and fix errorprone rules - part 4

2022-10-27 Thread GitBox
risdenk commented on code in PR #1128: URL: https://github.com/apache/solr/pull/1128#discussion_r1007584865 ## solr/core/src/java/org/apache/solr/parser/QueryParserTokenManager.java: ## @@ -16,7 +17,9 @@ + /** Token Manager. */ +@Generated("JavaCC") Review Comment: fi

[GitHub] [solr] risdenk commented on a diff in pull request #1128: SOLR-16427: Evaluate and fix errorprone rules - part 4

2022-10-27 Thread GitBox
risdenk commented on code in PR #1128: URL: https://github.com/apache/solr/pull/1128#discussion_r1007579196 ## solr/core/src/test/org/apache/solr/response/TestRetrieveFieldsOptimizer.java: ## @@ -411,21 +411,20 @@ static enum TEST_TYPE { } static final Map solrClassMap =

[GitHub] [solr] patsonluk opened a new pull request, #1143: SOLR-16506 : Throws exception on core startup for node name mismatch

2022-10-27 Thread GitBox
patsonluk opened a new pull request, #1143: URL: https://github.com/apache/solr/pull/1143 https://issues.apache.org/jira/browse/SOLR-16506 # Description Please provide a short description of the changes you're making with this pull request. # Solution

[jira] [Commented] (SOLR-15731) Separate out a solrj-jdbc module

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625397#comment-17625397 ] David Smiley commented on SOLR-15731: - Curious; how much code is here independent of

[jira] [Updated] (SOLR-15215) SolrJ: Remove needless Netty dependency

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15215: Priority: Minor (was: Major) > SolrJ: Remove needless Netty dependency > -

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625393#comment-17625393 ] David Smiley commented on SOLR-15733: - In terms of the dependencies and thus how a us

[jira] [Commented] (SOLR-16367) Switch from CloudLegacySolrClient to CloudSolrClient

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625392#comment-17625392 ] David Smiley commented on SOLR-16367: - I've lately been thinking of this issue as +th

[jira] [Commented] (SOLR-16498) Tests need the URL from a SolrClient; don't require legacy clients

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625389#comment-17625389 ] David Smiley commented on SOLR-16498: - BTW I've decomposed the parent issue more (tra

[GitHub] [solr] dsmiley commented on a diff in pull request #1128: SOLR-16427: Evaluate and fix errorprone rules - part 4

2022-10-27 Thread GitBox
dsmiley commented on code in PR #1128: URL: https://github.com/apache/solr/pull/1128#discussion_r1007546724 ## solr/core/src/test/org/apache/solr/response/TestRetrieveFieldsOptimizer.java: ## @@ -411,21 +411,20 @@ static enum TEST_TYPE { } static final Map solrClassMap =

[jira] [Commented] (SOLR-16498) Tests need the URL from a SolrClient; don't require legacy clients

2022-10-27 Thread Joshua Ouma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625385#comment-17625385 ] Joshua Ouma commented on SOLR-16498: {quote}I am also happy to help in this if there

[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module

2022-10-27 Thread GitBox
risdenk commented on PR #1099: URL: https://github.com/apache/solr/pull/1099#issuecomment-1294361637 @joel-bernstein I don't see you listed here https://github.com/orgs/apache/teams/solr-committers/members?query=joel - its a private list if you are on it you can see it. I see your username

[GitHub] [solr] risdenk commented on pull request #464: SOLR-15861: ConcurrentUpdateSolrClient should work with ManagedExecutorService

2022-10-27 Thread GitBox
risdenk commented on PR #464: URL: https://github.com/apache/solr/pull/464#issuecomment-1294358452 > This is only really applicable to SolrJ where the client might provide an executor; right? So I have some doubt about making a sweeping change across the codebase for a fringe case only in S

[jira] [Updated] (SOLR-16506) Flag exception during startup if replica node name does not match zk info

2022-10-27 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patson Luk updated SOLR-16506: -- Description: h2. Description We have a scenario which 2 nodes (n1, n2) have under the data folder (`s

[jira] [Updated] (SOLR-16506) Flag exception during startup if replica node name does not match zk info

2022-10-27 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patson Luk updated SOLR-16506: -- Description: h2. Description We have a scenario which 2 nodes (n1, n2) have under the data folder (`s

[jira] [Created] (SOLR-16506) Flag exception during startup if replica node name does not match zk info

2022-10-27 Thread Patson Luk (Jira)
Patson Luk created SOLR-16506: - Summary: Flag exception during startup if replica node name does not match zk info Key: SOLR-16506 URL: https://issues.apache.org/jira/browse/SOLR-16506 Project: Solr

[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module

2022-10-27 Thread GitBox
joel-bernstein commented on PR #1099: URL: https://github.com/apache/solr/pull/1099#issuecomment-1294135600 I am also a member of the apache organization on github. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module

2022-10-27 Thread GitBox
joel-bernstein commented on PR #1099: URL: https://github.com/apache/solr/pull/1099#issuecomment-1294129147 2FA is enabled on github. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] madrob commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module

2022-10-27 Thread GitBox
madrob commented on PR #1099: URL: https://github.com/apache/solr/pull/1099#issuecomment-1294123389 Do you have 2FA enabled for your GitHub account? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module

2022-10-27 Thread GitBox
joel-bernstein commented on PR #1099: URL: https://github.com/apache/solr/pull/1099#issuecomment-1294121660 I checked my account at id.apache.org and my github account is there. So this may take a jira to infra to sort out. I have this branch squash merged to main locally and am runni

[jira] [Commented] (SOLR-16132) SmokeTester leaks GPG daemons

2022-10-27 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625344#comment-17625344 ] Houston Putman commented on SOLR-16132: --- I haven't touched the GPG in the smoke tes

[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module

2022-10-27 Thread GitBox
joel-bernstein commented on PR #1099: URL: https://github.com/apache/solr/pull/1099#issuecomment-1294085546 I don't have the merge button. Let me see if I can figure out why. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (SOLR-16132) SmokeTester leaks GPG daemons

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625340#comment-17625340 ] Kevin Risden commented on SOLR-16132: - FYI [~houston] not sure this is in the area th

[jira] [Commented] (SOLR-16132) SmokeTester leaks GPG daemons

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625339#comment-17625339 ] Kevin Risden commented on SOLR-16132: - This is still happening. I ran into this after

[jira] [Updated] (SOLR-16442) Upgrade to Lucene 9.4.1 (do and document)

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16442: Status: Patch Available (was: Open) > Upgrade to Lucene 9.4.1 (do and document) >

[jira] [Updated] (SOLR-16500) Enable JDK 19 preview options for MMapDirectory V2

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16500: Status: Patch Available (was: Open) > Enable JDK 19 preview options for MMapDirectory V2 > ---

[jira] [Commented] (SOLR-16287) MapStream - remap tuple value(s)

2022-10-27 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625335#comment-17625335 ] Joel Bernstein commented on SOLR-16287: --- I'll grab the assignee > MapStream - rema

[jira] [Assigned] (SOLR-16287) MapStream - remap tuple value(s)

2022-10-27 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein reassigned SOLR-16287: - Assignee: Joel Bernstein (was: Eric Pugh) > MapStream - remap tuple value(s) > ---

[GitHub] [solr] risdenk opened a new pull request, #1142: SOLR-16500: Enable JDK 19 preview options for MMapDirectory V2

2022-10-27 Thread GitBox
risdenk opened a new pull request, #1142: URL: https://github.com/apache/solr/pull/1142 https://issues.apache.org/jira/browse/SOLR-16500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Updated] (SOLR-16500) Enable JDK 19 preview options for MMapDirectory V2

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16500: Summary: Enable JDK 19 preview options for MMapDirectory V2 (was: pass {{--enable-preview}} to JVM

[jira] [Assigned] (SOLR-16500) pass {{--enable-preview}} to JVM if exactly Java 19

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16500: --- Assignee: Kevin Risden > pass {{--enable-preview}} to JVM if exactly Java 19 > -

[jira] [Updated] (SOLR-15733) Separate out a solrj-streaming module

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15733: Status: Patch Available (was: Open) > Separate out a solrj-streaming module >

[GitHub] [solr] risdenk commented on pull request #1099: SOLR-15733: Separate out a solrj-streaming module

2022-10-27 Thread GitBox
risdenk commented on PR #1099: URL: https://github.com/apache/solr/pull/1099#issuecomment-1294043754 @joel-bernstein I'd do that separately on branch_9x only - similar to https://github.com/apache/solr/commit/80889178990369617bb5edb0b284ad24e34d5ad3 -- This is an automated message from th

[GitHub] [solr] joel-bernstein commented on pull request #1099: SOLR-15733: Migrate streaming

2022-10-27 Thread GitBox
joel-bernstein commented on PR #1099: URL: https://github.com/apache/solr/pull/1099#issuecomment-1294024484 @risdenk, thanks for the commits on this! I pulled all the latest and things look good. Does the solrj build.gradle need to refer to solrj-streaming so 9x users don't have a b

[jira] [Updated] (SOLR-16503) Switch UpdateShardHandler.getDefaultHttpClient to Jetty HTTP2

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16503: Parent: SOLR-16367 Issue Type: Sub-task (was: Improvement) > Switch UpdateShardHandler.get

[jira] [Created] (SOLR-16505) Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2

2022-10-27 Thread David Smiley (Jira)
David Smiley created SOLR-16505: --- Summary: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 Key: SOLR-16505 URL: https://issues.apache.org/jira/browse/SOLR-16505 Project: Solr

[jira] [Commented] (SOLR-16287) MapStream - remap tuple value(s)

2022-10-27 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625304#comment-17625304 ] Eric Pugh commented on SOLR-16287: -- That makes snese to me, should you grab the assignee

[jira] [Updated] (SOLR-15861) ConcurrentUpdateSolrClient should work with ManagedExecutorService

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15861: Issue Type: Improvement (was: Bug) > ConcurrentUpdateSolrClient should work with ManagedExecutorSe

[jira] [Updated] (SOLR-15861) ConcurrentUpdateSolrClient should work with ManagedExecutorService

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15861: Priority: Minor (was: Major) > ConcurrentUpdateSolrClient should work with ManagedExecutorService

[jira] [Updated] (SOLR-16502) Multiple CopyField should not limit to first maxChars

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16502: Fix Version/s: 9.2 > Multiple CopyField should not limit to first maxChars > --

[jira] [Updated] (SOLR-16502) Multiple CopyField should not limit to first maxChars

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16502: Resolution: Fixed Status: Resolved (was: Patch Available) > Multiple CopyField should not

[jira] [Commented] (SOLR-16502) Multiple CopyField should not limit to first maxChars

2022-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625274#comment-17625274 ] ASF subversion and git services commented on SOLR-16502: Commit 7

[jira] [Assigned] (SOLR-15861) ConcurrentUpdateSolrClient should work with ManagedExecutorService

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-15861: --- Assignee: Kevin Risden > ConcurrentUpdateSolrClient should work with ManagedExecutorService

[jira] [Updated] (SOLR-16502) Multiple CopyField should not limit to first maxChars

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16502: Fix Version/s: main (10.0) > Multiple CopyField should not limit to first maxChars > --

[jira] [Commented] (SOLR-16502) Multiple CopyField should not limit to first maxChars

2022-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625270#comment-17625270 ] ASF subversion and git services commented on SOLR-16502: Commit b

[GitHub] [solr] risdenk merged pull request #1141: SOLR-16502: Multiple CopyField should not limit to first maxChars

2022-10-27 Thread GitBox
risdenk merged PR #1141: URL: https://github.com/apache/solr/pull/1141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16502) Multiple CopyField should not limit to first maxChars

2022-10-27 Thread Fredrik Rodland (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625267#comment-17625267 ] Fredrik Rodland commented on SOLR-16502: Thanks for fixing this so promptly [~kri

[jira] [Updated] (SOLR-15861) ConcurrentUpdateSolrClient should work with ManagedExecutorService

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15861: Status: Patch Available (was: Open) > ConcurrentUpdateSolrClient should work with ManagedExecutorS

[jira] [Commented] (SOLR-16287) MapStream - remap tuple value(s)

2022-10-27 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625266#comment-17625266 ] Joel Bernstein commented on SOLR-16287: --- SOLR-15733 is going to land soon, which mo

[GitHub] [solr] Jdurham2843 commented on pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-10-27 Thread GitBox
Jdurham2843 commented on PR #1126: URL: https://github.com/apache/solr/pull/1126#issuecomment-1293963646 I believe I've covered most of your first round of comments @gerlowskija , aside from tests and the uses of the squash method on the ListSnapshotAPI. I also responded to your thoughts on

[jira] [Comment Edited] (SOLR-16462) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-10-27 Thread John Durham (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625265#comment-17625265 ] John Durham edited comment on SOLR-16462 at 10/27/22 7:18 PM: -

[jira] [Commented] (SOLR-16462) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-10-27 Thread John Durham (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625265#comment-17625265 ] John Durham commented on SOLR-16462: I think what you described makes sense and think

[jira] [Assigned] (SOLR-16286) Topic stream not honoring initialCheckpoint in getPersistedCheckpoints

2022-10-27 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16286: Assignee: Eric Pugh > Topic stream not honoring initialCheckpoint in getPersistedCheckpoints > ---

[GitHub] [solr] epugh commented on pull request #935: SOLR-16286 : Topic stream not honoring initialCheckpoint in getPersis…

2022-10-27 Thread GitBox
epugh commented on PR #935: URL: https://github.com/apache/solr/pull/935#issuecomment-1293948741 i think some question about the docs. I like everything here ;-). I am going to add it to my "List of tickets to merge on Monday Oct 31st" so folks can weigh in ;-) -- This is an automate

[jira] [Commented] (SOLR-16287) MapStream - remap tuple value(s)

2022-10-27 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625258#comment-17625258 ] Eric Pugh commented on SOLR-16287: -- Just got reminder on the PR that we said this would

[GitHub] [solr] risdenk closed pull request #834: SOLR-16154: cancel running conf listeners on close

2022-10-27 Thread GitBox
risdenk closed pull request #834: SOLR-16154: cancel running conf listeners on close URL: https://github.com/apache/solr/pull/834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [solr] risdenk commented on pull request #834: SOLR-16154: cancel running conf listeners on close

2022-10-27 Thread GitBox
risdenk commented on PR #834: URL: https://github.com/apache/solr/pull/834#issuecomment-1293944524 I don't think we need this change. https://issues.apache.org/jira/browse/SOLR-16154 was resolved and the errors that we were trying to fix went away. -- This is an automated message from th

[jira] [Updated] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-14699: Status: Patch Available (was: Open) > Solr request logs should escape names, values > (SolrQueryR

[GitHub] [solr] HoustonPutman commented on pull request #314: SOLR-15658: First pass of testing with findify/s3mock

2022-10-27 Thread GitBox
HoustonPutman commented on PR #314: URL: https://github.com/apache/solr/pull/314#issuecomment-1293940988 Fair enough, good point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [solr] risdenk commented on pull request #893: SOLR-16234 : A raw Solr request

2022-10-27 Thread GitBox
risdenk commented on PR #893: URL: https://github.com/apache/solr/pull/893#issuecomment-1293938584 @noblepaul is this still being looked at? Looks like there was push back on the jira - https://issues.apache.org/jira/browse/SOLR-16234 -- This is an automated message from the Apache Git Se

[jira] [Updated] (SOLR-16234) An API to make raw requests and responses to Solr

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16234: Fix Version/s: (was: 9.1) > An API to make raw requests and responses to Solr > --

[jira] [Updated] (SOLR-16234) An API to make raw requests and responses to Solr

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16234: Status: Patch Available (was: Reopened) > An API to make raw requests and responses to Solr > ---

[jira] [Updated] (SOLR-16260) Handle JSR310 Date classes in JavaBinCodec

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16260: Status: Patch Available (was: Open) > Handle JSR310 Date classes in JavaBinCodec > ---

[GitHub] [solr] risdenk commented on pull request #936: SOLR-16287 : MapStream - remap tuple value(s)

2022-10-27 Thread GitBox
risdenk commented on PR #936: URL: https://github.com/apache/solr/pull/936#issuecomment-1293934021 @epugh ping ;) slightly more than a week or so. anything left to do here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Updated] (SOLR-16286) Topic stream not honoring initialCheckpoint in getPersistedCheckpoints

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16286: Status: Patch Available (was: Open) > Topic stream not honoring initialCheckpoint in getPersistedC

[jira] [Updated] (SOLR-16287) MapStream - remap tuple value(s)

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16287: Status: Patch Available (was: Open) > MapStream - remap tuple value(s) >

[GitHub] [solr] risdenk commented on pull request #778: Forbid 'String.matches(String)' API.

2022-10-27 Thread GitBox
risdenk commented on PR #778: URL: https://github.com/apache/solr/pull/778#issuecomment-1293929733 This in general seems like a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [solr] risdenk commented on a diff in pull request #778: Forbid 'String.matches(String)' API.

2022-10-27 Thread GitBox
risdenk commented on code in PR #778: URL: https://github.com/apache/solr/pull/778#discussion_r1007244154 ## solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java: ## @@ -255,15 +256,15 @@ public static void print(String color, Object message) { } public st

[GitHub] [solr] risdenk commented on pull request #156: SOLR-15446: Fix three off-by-one ArrayList initialCapacity choices when calling ZooKeeper.multi API.

2022-10-27 Thread GitBox
risdenk commented on PR #156: URL: https://github.com/apache/solr/pull/156#issuecomment-1293926770 Another idea might be `List.of()` which would avoid having to even keep track of the initial capacity at all? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [solr] risdenk commented on a diff in pull request #1141: SOLR-16502: Multiple CopyField should not limit to first maxChars

2022-10-27 Thread GitBox
risdenk commented on code in PR #1141: URL: https://github.com/apache/solr/pull/1141#discussion_r1007240914 ## solr/core/src/java/org/apache/solr/update/DocumentBuilder.java: ## @@ -336,16 +336,17 @@ private static boolean addCopyFields( + ": "

[jira] [Commented] (SOLR-16503) Switch UpdateShardHandler.getDefaultHttpClient to Jetty HTTP2

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625253#comment-17625253 ] David Smiley commented on SOLR-16503: - The tentacles of this are far-reaching.  It ma

[GitHub] [solr] risdenk commented on a diff in pull request #1141: SOLR-16502: Multiple CopyField should not limit to first maxChars

2022-10-27 Thread GitBox
risdenk commented on code in PR #1141: URL: https://github.com/apache/solr/pull/1141#discussion_r1007236566 ## solr/CHANGES.txt: ## @@ -84,6 +84,8 @@ Bug Fixes * SOLR-16274: HEAD request for managed resource returns 500 Server Error (Kevin Risden) +* SOLR-16502: Multiple C

[jira] [Updated] (SOLR-15438) Refactor: Simplify SolrDispatchFilter close/destroy

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15438: Status: Patch Available (was: Open) > Refactor: Simplify SolrDispatchFilter close/destroy > --

[GitHub] [solr] cpoerschke commented on a diff in pull request #1141: SOLR-16502: Multiple CopyField should not limit to first maxChars

2022-10-27 Thread GitBox
cpoerschke commented on code in PR #1141: URL: https://github.com/apache/solr/pull/1141#discussion_r1007236047 ## solr/CHANGES.txt: ## @@ -84,6 +84,8 @@ Bug Fixes * SOLR-16274: HEAD request for managed resource returns 500 Server Error (Kevin Risden) +* SOLR-16502: Multipl

[jira] [Commented] (SOLR-16367) Switch from CloudLegacySolrClient to CloudSolrClient

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625252#comment-17625252 ] David Smiley commented on SOLR-16367: - I've been decomposing this more into sub-tasks

[jira] [Updated] (SOLR-15446) fix some off-by-one initialCapacity choices when calling ZooKeeper.multi

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15446: Status: Patch Available (was: Open) > fix some off-by-one initialCapacity choices when calling Zoo

[GitHub] [solr] risdenk commented on pull request #156: SOLR-15446: Fix three off-by-one ArrayList initialCapacity choices when calling ZooKeeper.multi API.

2022-10-27 Thread GitBox
risdenk commented on PR #156: URL: https://github.com/apache/solr/pull/156#issuecomment-1293917179 looks like this just needs to be brought up to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (SOLR-15469) start/stop script fails on multiple instance

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15469: Status: Patch Available (was: Open) > start/stop script fails on multiple instance > -

[jira] [Updated] (SOLR-15546) shortestPath internally cannot handle ids with colons

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15546: Status: Patch Available (was: Open) > shortestPath internally cannot handle ids with colons >

[GitHub] [solr] cpoerschke commented on a diff in pull request #1141: SOLR-16502: Multiple CopyField should not limit to first maxChars

2022-10-27 Thread GitBox
cpoerschke commented on code in PR #1141: URL: https://github.com/apache/solr/pull/1141#discussion_r1007227616 ## solr/core/src/java/org/apache/solr/update/DocumentBuilder.java: ## @@ -336,16 +336,17 @@ private static boolean addCopyFields( + ": "

[GitHub] [solr] Jdurham2843 commented on a diff in pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-10-27 Thread GitBox
Jdurham2843 commented on code in PR #1126: URL: https://github.com/apache/solr/pull/1126#discussion_r1007230522 ## solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc: ## @@ -234,38 +234,43 @@ http://localhost:8983/solr/gettingstarted/replication?command=rest

[GitHub] [solr] Jdurham2843 commented on a diff in pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-10-27 Thread GitBox
Jdurham2843 commented on code in PR #1126: URL: https://github.com/apache/solr/pull/1126#discussion_r1007229294 ## solr/core/src/java/org/apache/solr/handler/admin/api/SnapshotAPI.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[jira] [Updated] (SOLR-15582) remove deprecated APIs in solrj Tuple class

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15582: Status: Patch Available (was: Open) > remove deprecated APIs in solrj Tuple class > --

[GitHub] [solr] risdenk commented on pull request #257: SOLR-15582: Remove deprecated APIs in solrj Tuple class.

2022-10-27 Thread GitBox
risdenk commented on PR #257: URL: https://github.com/apache/solr/pull/257#issuecomment-1293911693 Minus any merge conflicts this looks like it should be close and ready to go in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (SOLR-15658) Investigate replacing the S3Mock implementation for S3 testing

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625250#comment-17625250 ] Kevin Risden commented on SOLR-15658: - [~houston] I closed PR #314 since its been a w

[GitHub] [solr] risdenk closed pull request #314: SOLR-15658: First pass of testing with findify/s3mock

2022-10-27 Thread GitBox
risdenk closed pull request #314: SOLR-15658: First pass of testing with findify/s3mock URL: https://github.com/apache/solr/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [solr] risdenk commented on pull request #314: SOLR-15658: First pass of testing with findify/s3mock

2022-10-27 Thread GitBox
risdenk commented on PR #314: URL: https://github.com/apache/solr/pull/314#issuecomment-1293908627 I'm a little worried that findify/s3mock hasn't been updated in >3 years now. Might be worth looking at something else... -- This is an automated message from the Apache Git Service. To resp

[jira] [Updated] (SOLR-15685) Add Devcontainer to make building easier

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15685: Status: Patch Available (was: Open) > Add Devcontainer to make building easier > -

[jira] [Updated] (SOLR-13182) NullPointerException due to an invariant violation in org/apache/lucene/search/BooleanClause.java[60]

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-13182: Status: Patch Available (was: Open) > NullPointerException due to an invariant violation in > org

[jira] [Updated] (SOLR-14164) Replace Solr's FunctionRangeQuery with Lucene's

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-14164: Status: Patch Available (was: Open) > Replace Solr's FunctionRangeQuery with Lucene's > --

[jira] [Commented] (SOLR-16504) Convert CLI tools to Jetty HTTP 2 client.

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625247#comment-17625247 ] David Smiley commented on SOLR-16504: - org.apache.solr.util.SolrCLI#getJson(org.apach

[jira] [Updated] (SOLR-15390) Deprecate "segmentTerminateEarly" in favor of "minExactCount"

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15390: Status: Patch Available (was: Open) > Deprecate "segmentTerminateEarly" in favor of "minExactCount

[jira] [Updated] (SOLR-14597) Advanced Query Parser

2022-10-27 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-14597: Status: Patch Available (was: Open) > Advanced Query Parser > - > >

[jira] [Commented] (SOLR-16504) Convert CLI tools to Jetty HTTP 2 client.

2022-10-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625245#comment-17625245 ] David Smiley commented on SOLR-16504: - PackageTool will be a bit more work as it invo

[GitHub] [solr] Jdurham2843 commented on a diff in pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-10-27 Thread GitBox
Jdurham2843 commented on code in PR #1126: URL: https://github.com/apache/solr/pull/1126#discussion_r1007210960 ## solr/core/src/java/org/apache/solr/handler/admin/api/SnapshotAPI.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [solr] Jdurham2843 commented on a diff in pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-10-27 Thread GitBox
Jdurham2843 commented on code in PR #1126: URL: https://github.com/apache/solr/pull/1126#discussion_r1007209747 ## solr/core/src/java/org/apache/solr/handler/admin/CoreAdminOperation.java: ## @@ -278,31 +276,28 @@ public enum CoreAdminOperation implements CoreAdminOp { LI

  1   2   >