[jira] [Updated] (SOLR-16446) Remove redundant state.json update For PRS collection creation

2022-10-24 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-16446: Affects Version/s: (was: 9.1) > Remove redundant state.json update For PRS coll

[jira] [Updated] (SOLR-16446) Remove redundant state.json update For PRS collection creation

2022-10-24 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-16446: Fix Version/s: 9.1 > Remove redundant state.json update For PRS collection creation

[jira] [Commented] (SOLR-16446) Remove redundant state.json update For PRS collection creation

2022-10-24 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623571#comment-17623571 ] Ishan Chattopadhyaya commented on SOLR-16446: - Changing affectsVersion to fix

[jira] [Reopened] (SOLR-16440) Sporadic test failures with PRS

2022-10-24 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya reopened SOLR-16440: - Some other failures are back for this suite: https://ci-builds.apache.org/job/Solr/j

[GitHub] [solr] joshgog commented on a diff in pull request #1115: Created V2 equivalent of REPLACENODE

2022-10-24 Thread GitBox
joshgog commented on code in PR #1115: URL: https://github.com/apache/solr/pull/1115#discussion_r1003984443 ## solr/core/src/java/org/apache/solr/handler/admin/api/ReplaceNodeAPI.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [solr] noblepaul commented on a diff in pull request #1115: Created V2 equivalent of REPLACENODE

2022-10-24 Thread GitBox
noblepaul commented on code in PR #1115: URL: https://github.com/apache/solr/pull/1115#discussion_r1003210468 ## solr/core/src/java/org/apache/solr/handler/admin/api/ReplaceNodeAPI.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [solr] noblepaul commented on a diff in pull request #1115: Created V2 equivalent of REPLACENODE

2022-10-24 Thread GitBox
noblepaul commented on code in PR #1115: URL: https://github.com/apache/solr/pull/1115#discussion_r1003210468 ## solr/core/src/java/org/apache/solr/handler/admin/api/ReplaceNodeAPI.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[jira] [Updated] (SOLR-16363) DirectUpdateHandler2 should not throw UnknownFormatConversionException

2022-10-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16363: Status: Patch Available (was: Open) > DirectUpdateHandler2 should not throw UnknownFormatConversio

[jira] [Updated] (SOLR-16363) DirectUpdateHandler2 should not throw UnknownFormatConversionException

2022-10-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16363: Affects Version/s: 9.0 9.1 (was: main (10.0)) > D

[GitHub] [solr] risdenk opened a new pull request, #1121: SOLR-16363: DirectUpdateHandler2 should not throw UnknownFormatConversionException

2022-10-24 Thread GitBox
risdenk opened a new pull request, #1121: URL: https://github.com/apache/solr/pull/1121 https://issues.apache.org/jira/browse/SOLR-16363 TODO need to see if I can add a test for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (SOLR-16363) DirectUpdateHandler2 should not throw UnknownFormatConversionException

2022-10-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16363: Summary: DirectUpdateHandler2 should not throw UnknownFormatConversionException (was: addDoc() in

[jira] [Assigned] (SOLR-16363) addDoc() in DirectUpdateHandler2 needs additional Exception Handling

2022-10-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16363: --- Assignee: Kevin Risden > addDoc() in DirectUpdateHandler2 needs additional Exception Handlin

[jira] [Commented] (SOLR-16363) addDoc() in DirectUpdateHandler2 needs additional Exception Handling

2022-10-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623541#comment-17623541 ] Kevin Risden commented on SOLR-16363: - Ah so this is the only place in Solr code base

[jira] [Assigned] (SOLR-16459) Deprecate and remove /admin/cores?action=INVOKE

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-16459: -- Assignee: Jason Gerlowski > Deprecate and remove /admin/cores?action=INVOKE >

[jira] [Resolved] (SOLR-16459) Deprecate and remove /admin/cores?action=INVOKE

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-16459. Fix Version/s: main (10.0) 9.2 Resolution: Fixed > Deprecate and

[jira] [Updated] (SOLR-16346) Generate OpenAPI spec for v2 APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16346: --- Description: An integration with [OpenAPI|https://www.openapis.org/] and its tooling has a l

[jira] [Resolved] (SOLR-16346) Generate OpenAPI spec for v2 APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-16346. Fix Version/s: main (10.0) 9.2 Resolution: Fixed > Generate OpenA

[jira] [Updated] (SOLR-16346) Generate OpenAPI spec for v2 APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16346: --- Summary: Generate OpenAPI spec for v2 APIs (was: Generate (and use) OpenAPI spec for v2 APIs

[jira] [Commented] (SOLR-16346) Generate (and use) OpenAPI spec for v2 APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623516#comment-17623516 ] Jason Gerlowski commented on SOLR-16346: I backported this to 9.x earlier this mo

[jira] [Commented] (SOLR-16462) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623514#comment-17623514 ] Jason Gerlowski commented on SOLR-16462: Hey [~jdurham] - I suspect this is somet

[jira] [Updated] (SOLR-16458) Cosmetic, REST-fulness improvements to v2 node APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16458: --- Labels: newdev (was: ) > Cosmetic, REST-fulness improvements to v2 node APIs > -

[jira] [Commented] (SOLR-16458) Cosmetic, REST-fulness improvements to v2 node APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623508#comment-17623508 ] Jason Gerlowski commented on SOLR-16458: To be a little more explicit about the A

[jira] [Updated] (SOLR-16491) Create a v2 equivalent for /admin/info/key

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16491: --- Labels: newdev (was: ) > Create a v2 equivalent for /admin/info/key > --

[jira] [Commented] (SOLR-16491) Create a v2 equivalent for /admin/info/key

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623503#comment-17623503 ] Jason Gerlowski commented on SOLR-16491: A few other pointers that might be helpf

[jira] [Updated] (SOLR-16491) Create a v2 equivalent for /admin/info/key

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16491: --- Description: The /admin/info/key API has no equivalent in the v2 paradigm. We should close

[jira] [Created] (SOLR-16491) Create a v2 equivalent for /admin/info/key

2022-10-24 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-16491: -- Summary: Create a v2 equivalent for /admin/info/key Key: SOLR-16491 URL: https://issues.apache.org/jira/browse/SOLR-16491 Project: Solr Issue Type: Sub-t

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623490#comment-17623490 ] ASF subversion and git services commented on SOLR-16427: Commit 9

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623492#comment-17623492 ] ASF subversion and git services commented on SOLR-16427: Commit d

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623488#comment-17623488 ] ASF subversion and git services commented on SOLR-16427: Commit 0

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623493#comment-17623493 ] ASF subversion and git services commented on SOLR-16427: Commit 3

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623485#comment-17623485 ] ASF subversion and git services commented on SOLR-16427: Commit 5

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623484#comment-17623484 ] ASF subversion and git services commented on SOLR-16427: Commit c

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623491#comment-17623491 ] ASF subversion and git services commented on SOLR-16427: Commit c

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623487#comment-17623487 ] ASF subversion and git services commented on SOLR-16427: Commit 5

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623486#comment-17623486 ] ASF subversion and git services commented on SOLR-16427: Commit 9

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623489#comment-17623489 ] ASF subversion and git services commented on SOLR-16427: Commit d

[GitHub] [solr] risdenk commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-10-24 Thread GitBox
risdenk commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1289855920 part 3 continues here: https://github.com/apache/solr/pull/1116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [solr] ben-manes commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
ben-manes commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1289828195 > Actually this loop sometimes hits the assertion recently added in JDK 17. I'd rewrite that infinite loop to something more "CAS" like. Unfortunately the challenge with this method

[GitHub] [solr] patsonluk commented on pull request #1032: SOLR-16412 : Race condition in SizeLimitedDistributedMap for cleanup

2022-10-24 Thread GitBox
patsonluk commented on PR #1032: URL: https://github.com/apache/solr/pull/1032#issuecomment-1289822367 Can someone with write access please merge if it's all good? 😊 cc @noblepaul @chatman -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [solr] patsonluk commented on a diff in pull request #1032: SOLR-16412 : Race condition in SizeLimitedDistributedMap for cleanup

2022-10-24 Thread GitBox
patsonluk commented on code in PR #1032: URL: https://github.com/apache/solr/pull/1032#discussion_r1003888379 ## solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java: ## @@ -91,9 +91,13 @@ protected boolean lessThan(Long a, Long b) { for (String child :

[GitHub] [solr] patsonluk commented on pull request #1093: SOLR-16446: Avoid redundant state.json update for PRS collection creation

2022-10-24 Thread GitBox
patsonluk commented on PR #1093: URL: https://github.com/apache/solr/pull/1093#issuecomment-1289818691 @noblepaul @chatman please help to review and merge. Many thanks! 🙇🏼 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623463#comment-17623463 ] ASF subversion and git services commented on SOLR-16427: Commit 4

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623464#comment-17623464 ] ASF subversion and git services commented on SOLR-16427: Commit f

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623465#comment-17623465 ] ASF subversion and git services commented on SOLR-16427: Commit e

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623459#comment-17623459 ] ASF subversion and git services commented on SOLR-16427: Commit d

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623466#comment-17623466 ] ASF subversion and git services commented on SOLR-16427: Commit 3

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623468#comment-17623468 ] ASF subversion and git services commented on SOLR-16427: Commit e

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623461#comment-17623461 ] ASF subversion and git services commented on SOLR-16427: Commit 4

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623467#comment-17623467 ] ASF subversion and git services commented on SOLR-16427: Commit e

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623460#comment-17623460 ] ASF subversion and git services commented on SOLR-16427: Commit 9

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623462#comment-17623462 ] ASF subversion and git services commented on SOLR-16427: Commit a

[GitHub] [solr] risdenk merged pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-10-24 Thread GitBox
risdenk merged PR #1039: URL: https://github.com/apache/solr/pull/1039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] janhoy commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…

2022-10-24 Thread GitBox
janhoy commented on PR #1114: URL: https://github.com/apache/solr/pull/1114#issuecomment-1289735161 I feel that the entire "Solr in Docker" content needs a rewrite. It was dumped into the refguide, but was not initially written for the refguide. Personally I have never used the `solr-

[jira] [Commented] (SOLR-16469) On some systems ​ is inserted after every comma

2022-10-24 Thread dmitri maziuk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623451#comment-17623451 ] dmitri maziuk commented on SOLR-16469: -- I don't really have anything. Other than I a

[GitHub] [solr] epugh commented on pull request #1120: Fix typo in the user-managed mode explanation

2022-10-24 Thread GitBox
epugh commented on PR #1120: URL: https://github.com/apache/solr/pull/1120#issuecomment-1289718072 What do you think about `will be` ??? Thanks for chasing these grammer items! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [solr] uschindler commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
uschindler commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1289718016 > The threads got stuck in this [infinite loop](https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L2215-L22

[GitHub] [solr] uschindler commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
uschindler commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1289716808 > Is this perhaps related to the JIT loop unrolling bug ([ben-manes/caffeine#797](https://github.com/ben-manes/caffeine/issues/797), [SOLR-16463](https://issues.apache.org/jira/browse/SOL

[GitHub] [solr] epugh commented on pull request #1105: SOLR-13880: Add test that creates/reloads/deletes collections

2022-10-24 Thread GitBox
epugh commented on PR #1105: URL: https://github.com/apache/solr/pull/1105#issuecomment-1289712518 @risdenk what are your thoughts on the `CloudLegacySolrClient`? Did my explanation of why make sense? Likewise the api call methods, does that make sense? Or need reworking to have this rea

[GitHub] [solr] epugh commented on pull request #1107: SOLR-9775 fixed NPEs

2022-10-24 Thread GitBox
epugh commented on PR #1107: URL: https://github.com/apache/solr/pull/1107#issuecomment-1289705657 @cpoerschke thoughts on this PR? I think it's ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [solr] epugh commented on pull request #1107: SOLR-9775 fixed NPEs

2022-10-24 Thread GitBox
epugh commented on PR #1107: URL: https://github.com/apache/solr/pull/1107#issuecomment-1289705313 @risdenk that is sooo much better. I guess I don't have the courage of my convictions to change an array to a `List`! -- This is an automated message from the Apache Git Service. To res

[GitHub] [solr] jebnix opened a new pull request, #1120: Fix typo in the user-managed mode explanation

2022-10-24 Thread GitBox
jebnix opened a new pull request, #1120: URL: https://github.com/apache/solr/pull/1120 https://issues.apache.org/jira/browse/SOLR-X # Description Typo # Solution Fix it with better grammar # Tests # Checklist Please review t

[GitHub] [solr] jebnix commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…

2022-10-24 Thread GitBox
jebnix commented on PR #1114: URL: https://github.com/apache/solr/pull/1114#issuecomment-1289682417 @janhoy Great idea. I'll work on adding this page to this PR. I'll use this [blog post ](https://lucidworks.com/post/running-solr-on-kubernetes-part-1/)as a heavy inspiration. I'm not

[jira] [Commented] (SOLR-16459) Deprecate and remove /admin/cores?action=INVOKE

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623426#comment-17623426 ] ASF subversion and git services commented on SOLR-16459: Commit 9

[jira] [Commented] (SOLR-16392) Cosmetic, REST-fulness improvements to v2 shard, replica, and replicaprop CRUD APIs

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623423#comment-17623423 ] ASF subversion and git services commented on SOLR-16392: Commit 9

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1116: SOLR-16427: Evaluate and fix errorprone rules - part 3

2022-10-24 Thread GitBox
sonatype-lift[bot] commented on code in PR #1116: URL: https://github.com/apache/solr/pull/1116#discussion_r1003736640 ## solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java: ## @@ -131,24 +131,24 @@ public void init(UpdateHandler uhandler, SolrCore core) {

[jira] [Updated] (SOLR-16446) Remove redundant state.json update For PRS collection creation

2022-10-24 Thread Hitesh Khamesra (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra updated SOLR-16446: --- Priority: Blocker (was: Major) > Remove redundant state.json update For PRS collection creat

[jira] [Comment Edited] (SOLR-14679) TLOGs grow forever, never get out of BUFFERING state

2022-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622992#comment-17622992 ] Gaël Jourdan edited comment on SOLR-14679 at 10/24/22 8:04 PM:

[jira] [Comment Edited] (SOLR-14679) TLOGs grow forever, never get out of BUFFERING state

2022-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622992#comment-17622992 ] Gaël Jourdan edited comment on SOLR-14679 at 10/24/22 8:03 PM:

[GitHub] [solr] risdenk commented on a diff in pull request #1032: SOLR-16412 : Race condition in SizeLimitedDistributedMap for cleanup

2022-10-24 Thread GitBox
risdenk commented on code in PR #1032: URL: https://github.com/apache/solr/pull/1032#discussion_r1003701865 ## solr/core/src/java/org/apache/solr/cloud/SizeLimitedDistributedMap.java: ## @@ -91,9 +91,13 @@ protected boolean lessThan(Long a, Long b) { for (String child : c

[GitHub] [solr] patsonluk commented on pull request #1032: SOLR-16412 : Race condition in SizeLimitedDistributedMap for cleanup

2022-10-24 Thread GitBox
patsonluk commented on PR #1032: URL: https://github.com/apache/solr/pull/1032#issuecomment-1289523323 @risdenk would you mind to take a second look please? Many thanks! 🙇🏼 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Comment Edited] (SOLR-16489) CaffeineCache puts thread into infinite loop

2022-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623352#comment-17623352 ] Torsten Bøgh Köster edited comment on SOLR-16489 at 10/24/22 7:18 PM: -

[jira] [Commented] (SOLR-16489) CaffeineCache puts thread into infinite loop

2022-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623352#comment-17623352 ] Torsten Bøgh Köster commented on SOLR-16489: The issue occurred in the filter

[jira] [Comment Edited] (SOLR-16489) CaffeineCache puts thread into infinite loop

2022-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623352#comment-17623352 ] Torsten Bøgh Köster edited comment on SOLR-16489 at 10/24/22 7:17 PM: -

[GitHub] [solr] tboeghk commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
tboeghk commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1289479812 The threads got stuck in this [infinite loop](https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L2215-L2293)

[GitHub] [solr] iamsanjay opened a new pull request, #1119: [SOLR-16461] Create v2 equivalent of v1 ReplicationHandler 'BACKUP'

2022-10-24 Thread GitBox
iamsanjay opened a new pull request, #1119: URL: https://github.com/apache/solr/pull/1119 https://issues.apache.org/jira/browse/SOLR-16461 # Description A backup API for user manager cluster or single node installation has no v2 equivalent. This ticket is used to tr

[GitHub] [solr] tboeghk commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
tboeghk commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1289465929 We ran into the bug using JDK11, JDK17 and JDK19. I'll try to dig out the stack trace / thread dump the threads got stuck in! -- This is an automated message from the Apache Git Service. T

[GitHub] [solr] ben-manes commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
ben-manes commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1289464453 Can you try jdk12? Does the stacktrace look to be related to the linked patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [solr] tboeghk commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
tboeghk commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1289463719 We came across this bug using JDK11 and Solr 8.11.2, so this is unlikely the same as https://github.com/ben-manes/caffeine/issues/797. -- This is an automated message from the Apache Git S

[GitHub] [solr] ben-manes commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
ben-manes commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1289463410 > ConcurrentHashMap#put method does not terminate an endless loop. This could be a livelock if Solr is performing recursive writes (e.g. a write within a computation). That is not su

[GitHub] [solr] tboeghk commented on a diff in pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
tboeghk commented on code in PR #1118: URL: https://github.com/apache/solr/pull/1118#discussion_r1003649518 ## solr/core/src/java/org/apache/solr/search/CaffeineCache.java: ## @@ -275,7 +275,7 @@ public V computeIfAbsent(K key, IOFunction mappingFuncti @Override public V p

[GitHub] [solr] ben-manes commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
ben-manes commented on PR #1118: URL: https://github.com/apache/solr/pull/1118#issuecomment-1289458504 Is this perhaps related to the JIT loop unrolling bug (https://github.com/ben-manes/caffeine/issues/797, [SOLR-16463](https://issues.apache.org/jira/browse/SOLR-16463))? (/cc @uschindler)

[GitHub] [solr] dsmiley commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-10-24 Thread GitBox
dsmiley commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1289457488 +1 thanks Kevin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[jira] [Updated] (SOLR-16472) Remove redundant state.json update For PRS collection creation

2022-10-24 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patson Luk updated SOLR-16472: -- Affects Version/s: 9.1 > Remove redundant state.json update For PRS collection creation > -

[GitHub] [solr] janhoy commented on pull request #1114: Link Solr Operator for learning on Solr in Kubernetes, and better exp…

2022-10-24 Thread GitBox
janhoy commented on PR #1114: URL: https://github.com/apache/solr/pull/1114#issuecomment-1289441127 What about removing the entire page https://solr.apache.org/guide/solr/latest/deployment-guide/docker-networking.html? And add a new page "Solr in Kubernetes" which alongside or below "

[jira] [Commented] (SOLR-16489) CaffeineCache puts thread into infinite loop

2022-10-24 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623297#comment-17623297 ] Michael Gibney commented on SOLR-16489: --- Thanks for reporting! I'm curious, just fo

[GitHub] [solr] risdenk commented on a diff in pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

2022-10-24 Thread GitBox
risdenk commented on code in PR #1118: URL: https://github.com/apache/solr/pull/1118#discussion_r1003541142 ## solr/core/src/java/org/apache/solr/search/CaffeineCache.java: ## @@ -275,7 +275,7 @@ public V computeIfAbsent(K key, IOFunction mappingFuncti @Override public V p

[GitHub] [solr] risdenk commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-10-24 Thread GitBox
risdenk commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1289310500 I didn't make any changes to the underlying code - just updated all the commit messages. I don't plan on squashing these so its easier to revert any individual commits if necessary. -- Th

[jira] [Commented] (SOLR-16398) Cosmetic, REST-fulness improvements to miscellaneous coll/core APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623286#comment-17623286 ] Jason Gerlowski commented on SOLR-16398: There are a lot of APIs not covered unde

[jira] [Updated] (SOLR-16489) CaffeineCache puts thread into infinite loop

2022-10-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16489: Status: Patch Available (was: Open) > CaffeineCache puts thread into infinite loop > -

[jira] [Commented] (SOLR-16397) Cosmetic, REST-fulness improvements to v2 "core" APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623285#comment-17623285 ] Jason Gerlowski commented on SOLR-16397: To be a little more explicit about the A

[jira] [Comment Edited] (SOLR-16396) Cosmetic, REST-fulness improvements to v2 config APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623281#comment-17623281 ] Jason Gerlowski edited comment on SOLR-16396 at 10/24/22 4:35 PM: -

[jira] [Updated] (SOLR-16396) Cosmetic, REST-fulness improvements to v2 config APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16396: --- Labels: newdev (was: ) > Cosmetic, REST-fulness improvements to v2 config APIs > ---

[jira] [Commented] (SOLR-16396) Cosmetic, REST-fulness improvements to v2 config APIs

2022-10-24 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623281#comment-17623281 ] Jason Gerlowski commented on SOLR-16396: To be a little more explicit about the A

[jira] [Updated] (SOLR-16467) Upgrade semver4j to 2.2.0 to fix failures with some locales

2022-10-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16467: Priority: Major (was: Blocker) > Upgrade semver4j to 2.2.0 to fix failures with some locales > ---

[jira] [Commented] (SOLR-16467) Upgrade semver4j to 2.2.0 to fix failures with some locales

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623280#comment-17623280 ] ASF subversion and git services commented on SOLR-16467: Commit 3

[jira] [Updated] (SOLR-16467) Upgrade semver4j to 2.2.0 to fix failures with some locales

2022-10-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16467: Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade semver4j to 2.2.0 to f

[jira] [Updated] (SOLR-16467) Upgrade semver4j to 2.2.0 to fix failures with some locales

2022-10-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16467: Fix Version/s: main (10.0) > Upgrade semver4j to 2.2.0 to fix failures with some locales >

[jira] [Commented] (SOLR-16467) Upgrade semver4j to 2.2.0 to fix failures with some locales

2022-10-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623272#comment-17623272 ] ASF subversion and git services commented on SOLR-16467: Commit 8

[GitHub] [solr] risdenk merged pull request #1117: SOLR-16467: Upgrade semver4j to 2.2.0 to fix failures with some locales

2022-10-24 Thread GitBox
risdenk merged PR #1117: URL: https://github.com/apache/solr/pull/1117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Updated] (SOLR-16489) CaffeineCache puts thread into infinite loop

2022-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Bøgh Köster updated SOLR-16489: --- Description: Under heavy machine load, accessing any Solr CaffeineCache can lead to t

  1   2   >