[jira] [Comment Edited] (SOLR-11872) Refactor test infra to work with a managed SolrClient; ditch TestHarness

2022-10-20 Thread Afrin Jaman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620173#comment-17620173 ] Afrin Jaman edited comment on SOLR-11872 at 10/21/22 6:19 AM: -

[jira] [Commented] (SOLR-11028) Create a v2 API equivalent for REPLACENODE API

2022-10-20 Thread Joshua Ouma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621504#comment-17621504 ] Joshua Ouma commented on SOLR-11028: Great info ! > Create a v2 API equivalent for R

[GitHub] [solr] risdenk commented on pull request #585: SOLR-15955: Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on PR #585: URL: https://github.com/apache/solr/pull/585#issuecomment-1286445625 Shawn Heisey correctly pointed out to me that metrics-jetty9 was still being used. Upgraded to metrics-jetty10 in 3281463. That made me go back and check other Jetty 9 references and

[GitHub] [solr-operator] sanjay3290 opened a new issue, #483: Servicemonitor for prometheus exporter is referring to cluster port instead of metrics pod port

2022-10-20 Thread GitBox
sanjay3290 opened a new issue, #483: URL: https://github.com/apache/solr-operator/issues/483 I have followed the solr operator documentation to configure SolrPrometheusExporter, however after creating the servicemonitor, the service endpoint is going inactive. After further troubleshooting,

[GitHub] [solr] jebnix commented on pull request #1098: Add a reference for the S3BackupRepository for the supported backup r…

2022-10-20 Thread GitBox
jebnix commented on PR #1098: URL: https://github.com/apache/solr/pull/1098#issuecomment-1286366273 @epugh I also think that there should be better clarification as to what are snapshots, and what is the difference between snapshot and backup (with some help here I can add this in a separat

[GitHub] [solr] jebnix opened a new pull request, #1098: Add a reference for the S3BackupRepository for the supported backup r…

2022-10-20 Thread GitBox
jebnix opened a new pull request, #1098: URL: https://github.com/apache/solr/pull/1098 …epositories https://issues.apache.org/jira/browse/SOLR-X # Description While reading the page someone can think that there is no support for some `S3BackupRepository`.

[jira] [Commented] (SOLR-16465) Start the migration of the Admin UI to Angular

2022-10-20 Thread Jeb Nix (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621423#comment-17621423 ] Jeb Nix commented on SOLR-16465: Incremental migration to React is much better. Great ide

[jira] [Commented] (SOLR-16478) removing a replica should delete the PRS entry from the hostnode and not from overseer

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621422#comment-17621422 ] ASF subversion and git services commented on SOLR-16478: Commit a

[jira] [Commented] (SOLR-16478) removing a replica should delete the PRS entry from the hostnode and not from overseer

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621421#comment-17621421 ] ASF subversion and git services commented on SOLR-16478: Commit b

[jira] [Resolved] (SOLR-16478) removing a replica should delete the PRS entry from the hostnode and not from overseer

2022-10-20 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-16478. --- Fix Version/s: 9.1 Resolution: Fixed > removing a replica should delete the PRS entry from the

[jira] [Commented] (SOLR-16478) removing a replica should delete the PRS entry from the hostnode and not from overseer

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621420#comment-17621420 ] ASF subversion and git services commented on SOLR-16478: Commit 6

[jira] [Commented] (SOLR-16478) removing a replica should delete the PRS entry from the hostnode and not from overseer

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621419#comment-17621419 ] ASF subversion and git services commented on SOLR-16478: Commit 2

[GitHub] [solr] noblepaul merged pull request #1095: SOLR-16478 : Further changes to avoid PRS entry writes from overseer

2022-10-20 Thread GitBox
noblepaul merged PR #1095: URL: https://github.com/apache/solr/pull/1095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-8803) OOM killer for Windows

2022-10-20 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621403#comment-17621403 ] Shawn Heisey commented on SOLR-8803: {quote}If nearly every test were running in a pat

[jira] [Commented] (SOLR-16285) [CVE-2022-33980] Apache Commons Configuration performs variable interpolation, allowing properties to be dynamically evaluated and expanded

2022-10-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621376#comment-17621376 ] David Smiley commented on SOLR-16285: - Wether this is a security issue or not entirel

[jira] [Reopened] (SOLR-16285) [CVE-2022-33980] Apache Commons Configuration performs variable interpolation, allowing properties to be dynamically evaluated and expanded

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reopened SOLR-16285: - Assignee: Kevin Risden > [CVE-2022-33980] Apache Commons Configuration performs variable > int

[jira] [Resolved] (SOLR-16285) [CVE-2022-33980] Apache Commons Configuration performs variable interpolation, allowing properties to be dynamically evaluated and expanded

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-16285. - Resolution: Duplicate Duplicate of SOLR-16324 > [CVE-2022-33980] Apache Commons Configuration pe

[GitHub] [solr] risdenk commented on pull request #791: Refactor duplicate CLI options

2022-10-20 Thread GitBox
risdenk commented on PR #791: URL: https://github.com/apache/solr/pull/791#issuecomment-1286066219 Thanks @madrob -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [solr] risdenk merged pull request #791: Refactor duplicate CLI options

2022-10-20 Thread GitBox
risdenk merged PR #791: URL: https://github.com/apache/solr/pull/791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16222) Address Intellij WARNINGS in Test Code

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621342#comment-17621342 ] Kevin Risden commented on SOLR-16222: - SOLR-16427 is addressing some of these as well

[GitHub] [solr] risdenk commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-10-20 Thread GitBox
risdenk commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1286057920 yea I figured it would conflict after https://github.com/apache/solr/pull/953. gives me a chance to separate out the commits as @dsmiley rightly pointed out. -- This is an automated mess

[jira] [Updated] (SOLR-16311) Simplify logic in asserts by using most specific form

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16311: Fix Version/s: 9.2 > Simplify logic in asserts by using most specific form > --

[jira] [Updated] (SOLR-16311) Simplify logic in asserts by using most specific form

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16311: Resolution: Fixed Status: Resolved (was: Patch Available) > Simplify logic in asserts by u

[jira] [Commented] (SOLR-16311) Simplify logic in asserts by using most specific form

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621341#comment-17621341 ] ASF subversion and git services commented on SOLR-16311: Commit 8

[GitHub] [solr] risdenk commented on pull request #585: SOLR-15955: Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on PR #585: URL: https://github.com/apache/solr/pull/585#issuecomment-1286050882 After most recent changes :) ``` ./gradlew check -Pvalidation.errorprone=true BUILD SUCCESSFUL in 20m 58s 586 actionable tasks: 196 executed, 390 up-to-date ``` -- This is

[jira] [Commented] (SOLR-16412) Race condition could trigger error on concurrent SizeLimitedDistributedMap cleanup

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621338#comment-17621338 ] Kevin Risden commented on SOLR-16412: - SOLR-16175 has a branch but not PR with this c

[jira] [Commented] (SOLR-16412) Race condition could trigger error on concurrent SizeLimitedDistributedMap cleanup

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621337#comment-17621337 ] Kevin Risden commented on SOLR-16412: - duplicate of SOLR-16175? > Race condition cou

[jira] [Resolved] (SOLR-16175) race condition SizeLimitedDistributedMap

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-16175. - Resolution: Duplicate > race condition SizeLimitedDistributedMap > --

[jira] [Commented] (SOLR-16099) HTTP Client threads can hang in Jetty's InputStreamResponseListener when using HTTP2 - impacts intra-node communication

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621333#comment-17621333 ] Kevin Risden commented on SOLR-16099: - https://issues.apache.org/jira/browse/SOLR-159

[jira] [Updated] (SOLR-15955) Update Jetty dependency to 10

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15955: Component/s: Server > Update Jetty dependency to 10 > - > >

[jira] [Assigned] (SOLR-15955) Update Jetty dependency to 10

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-15955: --- Assignee: Kevin Risden (was: Mark Robert Miller) > Update Jetty dependency to 10 >

[jira] [Updated] (SOLR-15955) Update Jetty dependency to 10

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15955: Status: Patch Available (was: Open) > Update Jetty dependency to 10 >

[jira] [Commented] (SOLR-15955) Update Jetty dependency to 10

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621328#comment-17621328 ] Kevin Risden commented on SOLR-15955: - https://github.com/apache/solr/pull/585 is up

[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1001028813 ## versions.lock: ## @@ -369,8 +367,8 @@ org.apache.kerby:kerb-common:1.0.1 (2 constraints: a51841ca) org.apache.kerby:kerb-identity:1.0.1 (1 constraints: 5f0cb602) org.ap

[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1001025879 ## versions.lock: ## @@ -369,8 +367,8 @@ org.apache.kerby:kerb-common:1.0.1 (2 constraints: a51841ca) org.apache.kerby:kerb-identity:1.0.1 (1 constraints: 5f0cb602) org.ap

[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1001023796 ## solr/test-framework/build.gradle: ## @@ -57,12 +57,12 @@ dependencies { implementation 'com.google.guava:guava' implementation 'io.dropwizard.metrics:metrics-core'

[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1001023589 ## solr/modules/s3-repository/build.gradle: ## @@ -77,8 +79,9 @@ dependencies { testImplementation 'commons-io:commons-io' testImplementation 'org.apache.commons:com

[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1001013851 ## solr/test-framework/build.gradle: ## @@ -57,12 +57,12 @@ dependencies { implementation 'com.google.guava:guava' implementation 'io.dropwizard.metrics:metrics-core'

[GitHub] [solr] risdenk commented on pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on PR #585: URL: https://github.com/apache/solr/pull/585#issuecomment-1286004520 Well this was unexpected first time after fixing the static build stuff: ``` ./gradlew clean ... ./gradlew check -Pvalidation.errorprone=true BUILD SUCCESSFUL in 20m 50s 58

[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1001008455 ## solr/solrj/build.gradle: ## @@ -75,6 +76,7 @@ dependencies { testImplementation 'commons-io:commons-io' testImplementation 'javax.servlet:javax.servlet-api' Revi

[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1001008219 ## solr/core/build.gradle: ## @@ -90,6 +90,7 @@ dependencies { implementation 'org.apache.httpcomponents:httpcore' compileOnlyApi 'javax.servlet:javax.servlet-api' +

[jira] [Commented] (SOLR-15748) Create v2 equivalent of v1 'CLUSTERSTATUS' (or document alternatives)

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621317#comment-17621317 ] ASF subversion and git services commented on SOLR-15748: Commit 8

[GitHub] [solr] gerlowskija merged pull request #1085: SOLR-16459: Remove 'invoke' /admin/cores command

2022-10-20 Thread GitBox
gerlowskija merged PR #1085: URL: https://github.com/apache/solr/pull/1085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-16459) Deprecate and remove /admin/cores?action=INVOKE

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621316#comment-17621316 ] ASF subversion and git services commented on SOLR-16459: Commit a

[jira] [Commented] (SOLR-8803) OOM killer for Windows

2022-10-20 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621313#comment-17621313 ] Shawn Heisey commented on SOLR-8803: Thinking out loud:  Could we have the gradle buil

[jira] [Updated] (SOLR-16484) Remove gpg from docker image

2022-10-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16484: --- Fix Version/s: 9.2 > Remove gpg from docker image > > >

[jira] [Commented] (SOLR-16484) Remove gpg from docker image

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621312#comment-17621312 ] ASF subversion and git services commented on SOLR-16484: Commit b

[jira] [Resolved] (SOLR-16484) Remove gpg from docker image

2022-10-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16484. Resolution: Fixed > Remove gpg from docker image > > >

[jira] [Commented] (SOLR-16484) Remove gpg from docker image

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621311#comment-17621311 ] ASF subversion and git services commented on SOLR-16484: Commit e

[GitHub] [solr] janhoy merged pull request #1084: SOLR-16484 Remove gpg from image, slimming it down some Mb

2022-10-20 Thread GitBox
janhoy merged PR #1084: URL: https://github.com/apache/solr/pull/1084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Created] (SOLR-16484) Remove gpg from docker image

2022-10-20 Thread Jira
Jan Høydahl created SOLR-16484: -- Summary: Remove gpg from docker image Key: SOLR-16484 URL: https://issues.apache.org/jira/browse/SOLR-16484 Project: Solr Issue Type: Improvement Security

[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1000978526 ## solr/modules/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java: ## @@ -320,17 +340,113 @@ protected URI getBaseUri() throws URISyntaxException { }

[jira] [Updated] (SOLR-16311) Simplify logic in asserts by using most specific form

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16311: Fix Version/s: main (10.0) > Simplify logic in asserts by using most specific form > --

[jira] [Commented] (SOLR-16311) Simplify logic in asserts by using most specific form

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621301#comment-17621301 ] ASF subversion and git services commented on SOLR-16311: Commit 9

[GitHub] [solr] risdenk merged pull request #953: SOLR-16311: Simplify assert statement

2022-10-20 Thread GitBox
risdenk merged PR #953: URL: https://github.com/apache/solr/pull/953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1000954236 ## versions.lock: ## @@ -230,30 +230,30 @@ org.codehaus.janino:commons-compiler:3.1.8 (2 constraints: 2f1983ec) org.codehaus.janino:janino:3.1.8 (1 constraints: 640dbc2c)

[GitHub] [solr] HoustonPutman commented on pull request #1089: SOLR-16475 Make the default replica placement plugin configurable

2022-10-20 Thread GitBox
HoustonPutman commented on PR #1089: URL: https://github.com/apache/solr/pull/1089#issuecomment-1285909573 > Hmm, I wonder if I prefer `solr.placementplugin.default` and `SOLR_PLACEMENTPLUGIN_DEFAULT` to keep with the dot separated lowercased convention. And that the env.var is the same in

[GitHub] [solr] mkhludnev commented on a diff in pull request #1045: SOLR-16420: {!mlt_content}

2022-10-20 Thread GitBox
mkhludnev commented on code in PR #1045: URL: https://github.com/apache/solr/pull/1045#discussion_r1000923299 ## solr/core/src/test/org/apache/solr/search/mlt/CloudMLTQContentParserTest.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] patsonluk commented on pull request #1095: SOLR-16478 : Further changes to avoid PRS entry writes from overseer

2022-10-20 Thread GitBox
patsonluk commented on PR #1095: URL: https://github.com/apache/solr/pull/1095#issuecomment-1285908103 > @patsonluk the changes are correct and we need to update the `testZkNodeVersions()` reflect it. > > I think this should go into `9.1` Thanks @noblepaul ! I have added anothe

[GitHub] [solr] risdenk commented on pull request #953: SOLR-16311: Simplify assert statement

2022-10-20 Thread GitBox
risdenk commented on PR #953: URL: https://github.com/apache/solr/pull/953#issuecomment-1285907045 ``` ./gradlew clean ... ./gradlew check -Pvalidation.errorprone=true ... BUILD SUCCESSFUL in 22m 31s 586 actionable tasks: 576 executed, 10 up-to-date ``` -- This is an a

[GitHub] [solr] risdenk commented on pull request #585: SOLR-15955 Update Jetty dependency to 10

2022-10-20 Thread GitBox
risdenk commented on PR #585: URL: https://github.com/apache/solr/pull/585#issuecomment-1285894978 > I’m happy to treat jetty.xml as an implantation detail, really only concerned with the semi odd shock of not being able to start up with an existing, unmodified file. If people are okay with

[GitHub] [solr] janhoy commented on pull request #1092: Use lazy-evaluated vars in docker gradle build

2022-10-20 Thread GitBox
janhoy commented on PR #1092: URL: https://github.com/apache/solr/pull/1092#issuecomment-1285879709 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [solr] risdenk commented on pull request #953: SOLR-16311: Simplify assert statement

2022-10-20 Thread GitBox
risdenk commented on PR #953: URL: https://github.com/apache/solr/pull/953#issuecomment-1285878072 one last merge of main. running tests again locally just to make sure. planning to merge this today -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [solr] janhoy commented on pull request #1089: SOLR-16475 Make the default replica placement plugin configurable

2022-10-20 Thread GitBox
janhoy commented on PR #1089: URL: https://github.com/apache/solr/pull/1089#issuecomment-1285876102 Hmm, I wonder if I prefer `solr.placementplugin.default` and `SOLR_PLACEMENTPLUGIN_DEFAULT` to keep with the dot separated lowercased convention. And that the env.var is the same in uppercase

[jira] [Updated] (SOLR-16483) Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16483: Fix Version/s: 9.2 > Fix IndexOutOfBounds in RecursiveNumericEvaluator > ---

[jira] [Commented] (SOLR-16483) Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621241#comment-17621241 ] ASF subversion and git services commented on SOLR-16483: Commit 8

[jira] [Updated] (SOLR-16483) Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16483: Resolution: Fixed Status: Resolved (was: Patch Available) > Fix IndexOutOfBounds in Recur

[jira] [Updated] (SOLR-16483) Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16483: Fix Version/s: main (10.0) > Fix IndexOutOfBounds in RecursiveNumericEvaluator > ---

[GitHub] [solr] risdenk commented on pull request #1054: SOLR-16483: Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-20 Thread GitBox
risdenk commented on PR #1054: URL: https://github.com/apache/solr/pull/1054#issuecomment-1285859948 Thanks @acsbendi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Commented] (SOLR-16483) Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621237#comment-17621237 ] ASF subversion and git services commented on SOLR-16483: Commit b

[GitHub] [solr] risdenk merged pull request #1054: SOLR-16483: Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-20 Thread GitBox
risdenk merged PR #1054: URL: https://github.com/apache/solr/pull/1054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Resolved] (SOLR-16317) GCS Backup Logging is Broken

2022-10-20 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16317. --- Fix Version/s: 9.1 main (10.0) Assignee: Houston Putman Res

[jira] [Commented] (SOLR-8803) OOM killer for Windows

2022-10-20 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621227#comment-17621227 ] Shawn Heisey commented on SOLR-8803: {quote}Or copy Solr to the correct installation l

[jira] [Created] (SOLR-16483) RecursiveNumericEvaluator IndexOutOfBounds

2022-10-20 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-16483: --- Summary: RecursiveNumericEvaluator IndexOutOfBounds Key: SOLR-16483 URL: https://issues.apache.org/jira/browse/SOLR-16483 Project: Solr Issue Type: Bug S

[jira] [Updated] (SOLR-16483) Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16483: Summary: Fix IndexOutOfBounds in RecursiveNumericEvaluator(was: RecursiveNumericEvaluator Inde

[jira] [Updated] (SOLR-16483) RecursiveNumericEvaluator IndexOutOfBounds

2022-10-20 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16483: Status: Patch Available (was: Open) > RecursiveNumericEvaluator IndexOutOfBounds > ---

[jira] [Commented] (SOLR-15955) Update Jetty dependency to 10

2022-10-20 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621214#comment-17621214 ] Shawn Heisey commented on SOLR-15955: - [~markrmiller] as you know, this is now ancien

[jira] [Commented] (SOLR-16482) Introduce internal envVar for passing props from the Dockerfile to bin/solr

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621213#comment-17621213 ] ASF subversion and git services commented on SOLR-16482: Commit 6

[jira] [Resolved] (SOLR-16482) Introduce internal envVar for passing props from the Dockerfile to bin/solr

2022-10-20 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16482. --- Fix Version/s: 9.1 main (10.0) Assignee: Houston Putman Res

[jira] [Commented] (SOLR-16482) Introduce internal envVar for passing props from the Dockerfile to bin/solr

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621212#comment-17621212 ] ASF subversion and git services commented on SOLR-16482: Commit 6

[jira] [Comment Edited] (SOLR-11028) Create a v2 API equivalent for REPLACENODE API

2022-10-20 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621208#comment-17621208 ] Jason Gerlowski edited comment on SOLR-11028 at 10/20/22 3:59 PM: -

[jira] [Commented] (SOLR-16482) Introduce internal envVar for passing props from the Dockerfile to bin/solr

2022-10-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621210#comment-17621210 ] ASF subversion and git services commented on SOLR-16482: Commit f

[GitHub] [solr] HoustonPutman merged pull request #1096: SOLR-16482: Add internal envVar for passing opts to solr/bin

2022-10-20 Thread GitBox
HoustonPutman merged PR #1096: URL: https://github.com/apache/solr/pull/1096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-11028) Create a v2 API equivalent for REPLACENODE API

2022-10-20 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621208#comment-17621208 ] Jason Gerlowski commented on SOLR-11028: If you wanted to write that test, I thin

[GitHub] [solr-docker] janhoy merged pull request #12: Replace openjdk:11-jre with eclipse-temurin:11-jre for 8.11 images

2022-10-20 Thread GitBox
janhoy merged PR #12: URL: https://github.com/apache/solr-docker/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-8803) OOM killer for Windows

2022-10-20 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621205#comment-17621205 ] Uwe Schindler commented on SOLR-8803: - Or copy Solr to the correct installation locati

[jira] [Commented] (SOLR-8803) OOM killer for Windows

2022-10-20 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621202#comment-17621202 ] Uwe Schindler commented on SOLR-8803: - The easiest is to setup a username with white s

[jira] [Commented] (SOLR-8803) OOM killer for Windows

2022-10-20 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621195#comment-17621195 ] Shawn Heisey commented on SOLR-8803: I need to always use a directory with a space and

[GitHub] [solr-docker] HoustonPutman commented on pull request #12: Replace openjdk:11-jre with eclipse-temurin:11-jre for 8.11 images

2022-10-20 Thread GitBox
HoustonPutman commented on PR #12: URL: https://github.com/apache/solr-docker/pull/12#issuecomment-1285747908 Nah don't want to touch it for now. Go ahead with this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] gerlowskija commented on a diff in pull request #1080: SOLR 15749 created a v2 equivalent of v1 'rename'

2022-10-20 Thread GitBox
gerlowskija commented on code in PR #1080: URL: https://github.com/apache/solr/pull/1080#discussion_r999861225 ## solr/core/src/java/org/apache/solr/handler/admin/api/RenameCollectionAPI.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] HoustonPutman commented on pull request #1014: Refactor SolrZkclient to use a Builder pattern

2022-10-20 Thread GitBox
HoustonPutman commented on PR #1014: URL: https://github.com/apache/solr/pull/1014#issuecomment-1285735665 > Just a quick comment: Does the move to Overseer render SolrZkClient obsolete @HoustonPutman ? Thus should we bother with changing SolrZkClient if it's going away any month now? Maybe

[GitHub] [solr] HoustonPutman opened a new pull request, #1097: NO-JIRA: Add docs in the header of the antora.yml

2022-10-20 Thread GitBox
HoustonPutman opened a new pull request, #1097: URL: https://github.com/apache/solr/pull/1097 This is in response to https://github.com/apache/solr/pull/1068. This is kind of explained in the solr-ref-guide README, but to be safe it should be called out in the file itself. We can p

[GitHub] [solr-docker] janhoy commented on pull request #12: Replace openjdk:11-jre with eclipse-temurin:11-jre for 8.11 images

2022-10-20 Thread GitBox
janhoy commented on PR #12: URL: https://github.com/apache/solr-docker/pull/12#issuecomment-1285718500 > It looks like there is no longer any difference between 8.11-slim and 8.11 now Yea, temurin is quite slim already. Don't know if it's worth the effort since this is a short-lived

[GitHub] [solr] HoustonPutman commented on pull request #1068: NO JIRA: start validateRefGuideFiles gradle task

2022-10-20 Thread GitBox
HoustonPutman commented on PR #1068: URL: https://github.com/apache/solr/pull/1068#issuecomment-1285712667 Hey Christine, I appreciate the thought here, but I'm not sure its actually the logic that we want. The `antora.yaml` file is used to generate the official ref guide for that br

[GitHub] [solr] HoustonPutman opened a new pull request, #1096: SOLR-16482: Add internal envVar for passing opts to solr/bin

2022-10-20 Thread GitBox
HoustonPutman opened a new pull request, #1096: URL: https://github.com/apache/solr/pull/1096 https://issues.apache.org/jira/browse/SOLR-16482 The name of the envVar is `SOLR_OPTS_INTERNAL` -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Created] (SOLR-16482) Introduce internal envVar for passing props from the Dockerfile to bin/solr

2022-10-20 Thread Houston Putman (Jira)
Houston Putman created SOLR-16482: - Summary: Introduce internal envVar for passing props from the Dockerfile to bin/solr Key: SOLR-16482 URL: https://issues.apache.org/jira/browse/SOLR-16482 Project:

[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285592668 @HoustonPutman, I'll focus on the move to solrj-streaming since thats what is needed for 9x. For Solr 10 we can decide between a module or solr-core. I'm fine with either appro

[GitHub] [solr-docker] HoustonPutman commented on pull request #12: Replace openjdk:11-jre with eclipse-temurin:11-jre for 8.11 images

2022-10-20 Thread GitBox
HoustonPutman commented on PR #12: URL: https://github.com/apache/solr-docker/pull/12#issuecomment-1285588320 > How come https://github.com/docker-library/official-images/blob/master/library/solr still references docker-solr repo and not solr-docker repo for 8.11? Our "official-images" for

[GitHub] [solr-operator] HoustonPutman merged pull request #482: Remove redundant docs for zk.provided.zookeeperPodPolicy.affinity

2022-10-20 Thread GitBox
HoustonPutman merged PR #482: URL: https://github.com/apache/solr-operator/pull/482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] HoustonPutman commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
HoustonPutman commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285573279 This sounds good to me, although I'm not sure why the streaming expressions stuff would really need to go into a module instead of solr-core. Does it require any dependencies that Solr

  1   2   >