[GitHub] [solr] dsmiley commented on pull request #1014: Refactor SolrZkclient to use a Builder pattern

2022-09-23 Thread GitBox
dsmiley commented on PR #1014: URL: https://github.com/apache/solr/pull/1014#issuecomment-1256684384 Just a quick comment: Does the move to Overseer render SolrZkClient obsolete @HoustonPutman ? Thus should we bother with changing SolrZkClient if it's going away any month now? Maybe this

[jira] [Commented] (SOLR-16430) AbstractIncrementalBackupTest fails on the macOS tests

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608911#comment-17608911 ] ASF subversion and git services commented on SOLR-16430: Commit 9

[jira] [Commented] (SOLR-16430) AbstractIncrementalBackupTest fails on the macOS tests

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608912#comment-17608912 ] ASF subversion and git services commented on SOLR-16430: Commit 7

[GitHub] [solr] dsmiley commented on a diff in pull request #1038: document the various code quality tools in our Developer FAQ

2022-09-23 Thread GitBox
dsmiley commented on code in PR #1038: URL: https://github.com/apache/solr/pull/1038#discussion_r979062578 ## dev-docs/FAQ.adoc: ## @@ -51,3 +51,37 @@ Run `gradle dev`, and then `cd ./packaging/build/dev/`. Fire up your cluster via `bin/solr start -e cloud -noprompt` and then

[jira] [Created] (SOLR-16430) AbstractIncrementalBackupTest fails on the macOS tests

2022-09-23 Thread Houston Putman (Jira)
Houston Putman created SOLR-16430: - Summary: AbstractIncrementalBackupTest fails on the macOS tests Key: SOLR-16430 URL: https://issues.apache.org/jira/browse/SOLR-16430 Project: Solr Issue T

[GitHub] [solr] dsmiley commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-23 Thread GitBox
dsmiley commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1256674360 Thanks for this. It'd help reviewing if you did the work in separate commits. That way I could look at the commits and maybe review some commits of interest to me. For example inlining

[GitHub] [solr] gerlowskija opened a new pull request, #1043: SOLR-16346: Fix intermittent 'check' error

2022-09-23 Thread GitBox
gerlowskija opened a new pull request, #1043: URL: https://github.com/apache/solr/pull/1043 # Description A previous commit for SOLR-16346 introduced a usedUndeclared 'check' error that only showed up in some limited environments. # Solution This commit fixes that check

[GitHub] [solr] dsmiley commented on a diff in pull request #1040: SOLR-16428: Add "permissive" mode to IgnoreLargeDocumentsProcessorFactory

2022-09-23 Thread GitBox
dsmiley commented on code in PR #1040: URL: https://github.com/apache/solr/pull/1040#discussion_r979055239 ## solr/core/src/java/org/apache/solr/update/processor/IgnoreLargeDocumentProcessorFactory.java: ## @@ -59,15 +71,25 @@ public void init(NamedList args) { public UpdateR

[jira] [Commented] (SOLR-16078) New solrj-core module

2022-09-23 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608909#comment-17608909 ] Houston Putman commented on SOLR-16078: --- {quote}Thus the statement "we are already

[jira] [Commented] (SOLR-16346) Generate (and use) OpenAPI spec for v2 APIs

2022-09-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608883#comment-17608883 ] Jason Gerlowski commented on SOLR-16346: Still not sure why Mike sees this behavi

[jira] [Commented] (SOLR-16078) New solrj-core module

2022-09-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608876#comment-17608876 ] David Smiley commented on SOLR-16078: - The maven manipulations I refer to in my last

[jira] [Commented] (SOLR-16346) Generate (and use) OpenAPI spec for v2 APIs

2022-09-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608870#comment-17608870 ] Jason Gerlowski commented on SOLR-16346: I also haven't been able to reproduce ye

[jira] [Assigned] (SOLR-16346) Generate (and use) OpenAPI spec for v2 APIs

2022-09-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-16346: -- Assignee: Jason Gerlowski > Generate (and use) OpenAPI spec for v2 APIs >

[jira] [Commented] (SOLR-16368) Refactoring: Use SolrClient type instead of overly specific subclasses

2022-09-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608867#comment-17608867 ] David Smiley commented on SOLR-16368: - For a bit I was thinking maybe we need some ba

[jira] [Commented] (SOLR-16346) Generate (and use) OpenAPI spec for v2 APIs

2022-09-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608862#comment-17608862 ] Kevin Risden commented on SOLR-16346: - Interestingly - I don't see what [~mdrob] is s

[jira] [Commented] (SOLR-16429) Missing dependency for STS - Cannot leverage Web Identity Tokens

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608861#comment-17608861 ] ASF subversion and git services commented on SOLR-16429: Commit e

[jira] [Commented] (SOLR-16429) Missing dependency for STS - Cannot leverage Web Identity Tokens

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608858#comment-17608858 ] ASF subversion and git services commented on SOLR-16429: Commit d

[GitHub] [solr] HoustonPutman merged pull request #1041: SOLR-16429: Add AWS STS support in s3-repository

2022-09-23 Thread GitBox
HoustonPutman merged PR #1041: URL: https://github.com/apache/solr/pull/1041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[GitHub] [solr] joshsouza commented on pull request #1041: SOLR-16429: Add AWS STS support in s3-repository

2022-09-23 Thread GitBox
joshsouza commented on PR #1041: URL: https://github.com/apache/solr/pull/1041#issuecomment-1256482385 @HoustonPutman This looks 1000x better than what I put together with zero knowledge of the right way to do it. Thank you! As far as I can tell, this should solve things handily. -- Th

[GitHub] [solr] HoustonPutman closed pull request #1042: Add the `sts` module to the gradle build

2022-09-23 Thread GitBox
HoustonPutman closed pull request #1042: Add the `sts` module to the gradle build URL: https://github.com/apache/solr/pull/1042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [solr] HoustonPutman commented on pull request #1042: Add the `sts` module to the gradle build

2022-09-23 Thread GitBox
HoustonPutman commented on PR #1042: URL: https://github.com/apache/solr/pull/1042#issuecomment-1256473436 Hey josh, I took your 8.11 code and got started in #1041. I think it should be good to go, if you have some time to look it over. -- This is an automated message from the Apache Git

[jira] [Commented] (SOLR-16429) Missing dependency for STS - Cannot leverage Web Identity Tokens

2022-09-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608856#comment-17608856 ] Kevin Risden commented on SOLR-16429: - Ah interesting thanks [~houston] and [~joshsou

[jira] [Commented] (SOLR-16429) Missing dependency for STS - Cannot leverage Web Identity Tokens

2022-09-23 Thread Josh Souza (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608855#comment-17608855 ] Josh Souza commented on SOLR-16429: --- Yeah, as far as I could tell this isn't referenced

[jira] [Commented] (SOLR-16429) Missing dependency for STS - Cannot leverage Web Identity Tokens

2022-09-23 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608854#comment-17608854 ] Houston Putman commented on SOLR-16429: --- [~krisden] the sts artifact is not include

[GitHub] [solr] joshsouza opened a new pull request, #1042: Add the `sts` module to the gradle build

2022-09-23 Thread GitBox
joshsouza opened a new pull request, #1042: URL: https://github.com/apache/solr/pull/1042 https://issues.apache.org/jira/browse/SOLR-16429 # Description This PR adds `software.amazon.awssdk:sts` to the dependencies for the `s3-repository` module so that IRSA/Web Identity Tokens

[GitHub] [solr] HoustonPutman commented on pull request #1041: SOLR-16429: Add AWS STS support in s3-repository

2022-09-23 Thread GitBox
HoustonPutman commented on PR #1041: URL: https://github.com/apache/solr/pull/1041#issuecomment-1256460739 @joshsouza let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [solr] HoustonPutman opened a new pull request, #1041: SOLR-16429: Add AWS STS support in s3-repository

2022-09-23 Thread GitBox
HoustonPutman opened a new pull request, #1041: URL: https://github.com/apache/solr/pull/1041 https://issues.apache.org/jira/browse/SOLR-16429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr-operator] risdenk commented on issue #475: Backups via S3 using Web Identity Tokens not working

2022-09-23 Thread GitBox
risdenk commented on issue #475: URL: https://github.com/apache/solr-operator/issues/475#issuecomment-1256455987 @joshsouza opened https://issues.apache.org/jira/browse/SOLR-16429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (SOLR-16429) Missing dependency for STS - Cannot leverage Web Identity Tokens

2022-09-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608853#comment-17608853 ] Kevin Risden commented on SOLR-16429: - [~joshsouza] have you looked at the Solr 9 Doc

[jira] [Resolved] (SOLR-16404) Use HTTP2 Solr clients in the Prometheus Exporter

2022-09-23 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16404. --- Fix Version/s: 9.1 main (10.0) Resolution: Done > Use HTTP2 Solr cl

[jira] [Updated] (SOLR-16404) Use HTTP2 Solr clients in the Prometheus Exporter

2022-09-23 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16404: -- Description: The HTTP2 clients are non-deprecated, and as such we should be using the non-depre

[jira] [Commented] (SOLR-16404) Use HTTP2 Solr clients in the Prometheus Exporter

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608851#comment-17608851 ] ASF subversion and git services commented on SOLR-16404: Commit d

[jira] [Updated] (SOLR-16232) Fix EnvVar bugs in bin/solr

2022-09-23 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16232: -- Fix Version/s: 9.1 main (10.0) Resolution: Fixed Status: Re

[jira] [Updated] (SOLR-16404) Use HTTP2 Solr clients in the Prometheus Exporter

2022-09-23 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16404: -- Summary: Use HTTP2 Solr clients in the Prometheus Exporter (was: Use non-deprecated Solr clien

[jira] [Commented] (SOLR-16232) Fix EnvVar bugs in bin/solr

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608849#comment-17608849 ] ASF subversion and git services commented on SOLR-16232: Commit 1

[jira] [Commented] (SOLR-16232) Fix EnvVar bugs in bin/solr

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608848#comment-17608848 ] ASF subversion and git services commented on SOLR-16232: Commit 5

[GitHub] [solr] HoustonPutman merged pull request #892: SOLR-16232: Fix EnvVar usage in bin/solr

2022-09-23 Thread GitBox
HoustonPutman merged PR #892: URL: https://github.com/apache/solr/pull/892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-16404) Use non-deprecated Solr clients in the Prometheus Exporter

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608847#comment-17608847 ] ASF subversion and git services commented on SOLR-16404: Commit 9

[GitHub] [solr] HoustonPutman merged pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-23 Thread GitBox
HoustonPutman merged PR #1004: URL: https://github.com/apache/solr/pull/1004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[jira] [Commented] (SOLR-16368) Refactoring: Use SolrClient type instead of overly specific subclasses

2022-09-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608845#comment-17608845 ] Eric Pugh commented on SOLR-16368: -- So, most of the references to the HttpSolrClient in

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-23 Thread GitBox
HoustonPutman commented on code in PR #1004: URL: https://github.com/apache/solr/pull/1004#discussion_r978853742 ## solr/CHANGES.txt: ## @@ -89,6 +89,8 @@ Improvements * SOLR-16361: mod() is now accurate for all integers, floats, doubles and longs upto 2^52 (Dan Rosher via E

[jira] [Commented] (SOLR-16346) Generate (and use) OpenAPI spec for v2 APIs

2022-09-23 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608834#comment-17608834 ] Mike Drob commented on SOLR-16346: -- {noformat} Bisecting: 0 revisions left to test after

[jira] [Created] (SOLR-16429) Missing dependency for STS - Cannot leverage Web Identity Tokens

2022-09-23 Thread Josh Souza (Jira)
Josh Souza created SOLR-16429: - Summary: Missing dependency for STS - Cannot leverage Web Identity Tokens Key: SOLR-16429 URL: https://issues.apache.org/jira/browse/SOLR-16429 Project: Solr Issu

[GitHub] [solr-operator] HoustonPutman commented on issue #475: Backups via S3 using Web Identity Tokens not working

2022-09-23 Thread GitBox
HoustonPutman commented on issue #475: URL: https://github.com/apache/solr-operator/issues/475#issuecomment-1256338814 Hey y'all thanks for this discussion! If y'all make a Solr issue (and/or PR, we always love new contributors!) then I'll help shepherd it through. I'm out for the next two

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608784#comment-17608784 ] ASF subversion and git services commented on SOLR-16427: Commit c

[GitHub] [solr] NazerkeBS commented on a diff in pull request #1027: Add logs and comments to split workflow

2022-09-23 Thread GitBox
NazerkeBS commented on code in PR #1027: URL: https://github.com/apache/solr/pull/1027#discussion_r978739951 ## solr/core/src/java/org/apache/solr/handler/admin/SplitOp.java: ## @@ -189,6 +205,7 @@ public void execute(CoreAdminHandler.CallInfo it) throws Exception { pare

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2022-09-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608744#comment-17608744 ] Kevin Risden commented on SOLR-16427: - merged part 1 to main and hasn't caused any is

[GitHub] [solr] risdenk commented on a diff in pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-23 Thread GitBox
risdenk commented on code in PR #1039: URL: https://github.com/apache/solr/pull/1039#discussion_r978661778 ## solr/benchmark/src/java/org/apache/solr/bench/generators/Lists.java: ## @@ -32,17 +31,13 @@ public final class Lists { private Lists() {} static Gen> listsOf(Ge

[GitHub] [solr] risdenk commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-23 Thread GitBox
risdenk commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1256195026 > `./gradlew :solr:core:test --tests "org.apache.solr.core.TestCoreContainer"` @epugh I'm not seeing that test fail. I ran it ~10 times and no failures. -- This is an automated mess

[GitHub] [solr] risdenk commented on a diff in pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-23 Thread GitBox
risdenk commented on code in PR #1039: URL: https://github.com/apache/solr/pull/1039#discussion_r978615551 ## solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/InnerJoinStream.java: ## @@ -32,10 +32,14 @@ * @since 6.0.0 */ public class InnerJoinStream extends BiJoi

[GitHub] [solr] epugh commented on pull request #1038: document the various code quality tools in our Developer FAQ

2022-09-23 Thread GitBox
epugh commented on PR #1038: URL: https://github.com/apache/solr/pull/1038#issuecomment-1256109410 Do we think it's useful to add the RAT and other validations???Or are we going beyond FAQ... I was on the fence about OWASP... -- This is an automated message from the Apache Git Servi

[GitHub] [solr] epugh commented on a diff in pull request #1038: document the various code quality tools in our Developer FAQ

2022-09-23 Thread GitBox
epugh commented on code in PR #1038: URL: https://github.com/apache/solr/pull/1038#discussion_r978549344 ## dev-docs/FAQ.adoc: ## @@ -51,3 +51,36 @@ Run `gradle dev`, and then `cd ./packaging/build/dev/`. Fire up your cluster via `bin/solr start -e cloud -noprompt` and then a

[GitHub] [solr] epugh commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-23 Thread GitBox
epugh commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1256108074 THis is failing... ``` gradlew :solr:core:test --tests "org.apache.solr.core.TestCoreContainer.classMethod" -Ptests.jvms=4 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCa

[GitHub] [solr] epugh commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-09-23 Thread GitBox
epugh commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1256103905 Your most recent fix JUST fixed the test error I was getting... `./gradlew :solr:core:test --tests "org.apache.solr.handler.component.DistributedFacetPivotLargeTest"` passes now for me!