[GitHub] [solr] dsmiley opened a new pull request, #1013: SOLR-15342 Solrj-Zookeeper: opt-out on 9x

2022-09-14 Thread GitBox
dsmiley opened a new pull request, #1013: URL: https://github.com/apache/solr/pull/1013 **On 9.x,** Solrj-Zookeeper should be "opt-out", thus a user needs to opt-out if they don't want it. Don't change main (opt-in). I looked at the upgrade docs for 9.1 in `solr-upgrade-notes.adoc` a

[GitHub] [solr-sandbox] markrmiller merged pull request #41: Improve test to cover a bit more.

2022-09-14 Thread GitBox
markrmiller merged PR #41: URL: https://github.com/apache/solr-sandbox/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[GitHub] [solr-sandbox] markrmiller merged pull request #40: Cleanup Kafka config class.

2022-09-14 Thread GitBox
markrmiller merged PR #40: URL: https://github.com/apache/solr-sandbox/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[GitHub] [solr-sandbox] markrmiller merged pull request #39: Config override test and cleanup.

2022-09-14 Thread GitBox
markrmiller merged PR #39: URL: https://github.com/apache/solr-sandbox/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[GitHub] [solr-sandbox] markrmiller merged pull request #38: Flush producer on close to prevent losing any pending updates.

2022-09-14 Thread GitBox
markrmiller merged PR #38: URL: https://github.com/apache/solr-sandbox/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[jira] [Commented] (SOLR-16099) HTTP Client threads can hang in Jetty's InputStreamResponseListener when using HTTP2 - impacts intra-node communication

2022-09-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604980#comment-17604980 ] Chris M. Hostetter commented on SOLR-16099: --- FYI: * a new [Jetty Issue#8558|ht

[GitHub] [solr] janhoy merged pull request #850: Add the .gradletasknamecache file to .gitignore

2022-09-14 Thread GitBox
janhoy merged PR #850: URL: https://github.com/apache/solr/pull/850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-09-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604960#comment-17604960 ] ASF subversion and git services commented on SOLR-16230: Commit d

[jira] [Updated] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-09-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16230: --- Fix Version/s: 9.1 Resolution: Fixed Status: Resolved (was: Patch Available) > JWT

[GitHub] [solr] dsmiley commented on pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-09-14 Thread GitBox
dsmiley commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1247265686 > Thoughts on introducing a getHttp1Client method in the base test class that would take a SolrClient and could interrogate it and return the httpClient? That would remove a ton of places wh

[jira] [Commented] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-09-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604950#comment-17604950 ] ASF subversion and git services commented on SOLR-16230: Commit 1

[GitHub] [solr] janhoy merged pull request #890: SOLR-16230: JWT nested roles support

2022-09-14 Thread GitBox
janhoy merged PR #890: URL: https://github.com/apache/solr/pull/890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] epugh commented on pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-09-14 Thread GitBox
epugh commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1247162304 One thing I've noticed is a lot of places where we cast to a specific client just to get the httpClient. We do it all over the place in the tests... ``` solrClient = getCloudSolrClie

[GitHub] [solr] epugh opened a new pull request, #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-09-14 Thread GitBox
epugh opened a new pull request, #1012: URL: https://github.com/apache/solr/pull/1012 https://issues.apache.org/jira/browse/SOLR-16368 # Description Where can we use `SolrClient` or `SolrCloudClient` instead of the sub classes? # Solution hunting through source!

[GitHub] [solr] HoustonPutman commented on pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-14 Thread GitBox
HoustonPutman commented on PR #1004: URL: https://github.com/apache/solr/pull/1004#issuecomment-1247124002 > > Looking at @dsmiley comment, does that suggest that the "how we use newer clients" is still being worked out a bit? > > I don't think "how we use newer clients" is still being

[GitHub] [solr] mkhludnev commented on pull request #1010: SOLR-7883: /mlt handler to support facets

2022-09-14 Thread GitBox
mkhludnev commented on PR #1010: URL: https://github.com/apache/solr/pull/1010#issuecomment-1247059232 I suppose facets worked in mlt handler in the beginning (though w/o test coverage) until FacetModule/Context were introduced. > Do we know if paging and filtering work? Excuse me, @e

[GitHub] [solr] cpoerschke commented on pull request #916: SOLR-16318: Use up to JDK 11 features (avoid type declaration when <> can be used)

2022-09-14 Thread GitBox
cpoerschke commented on PR #916: URL: https://github.com/apache/solr/pull/916#issuecomment-1247055012 > I would love to see these get merged, as keeping this patch up to date is going to get harder... Do we have consensus on merging it? Just resolved the merge conflict. And noting tha

[GitHub] [solr-operator] joshsouza commented on issue #471: How to prevent node rotation behavior from causing cluster instability

2022-09-14 Thread GitBox
joshsouza commented on issue #471: URL: https://github.com/apache/solr-operator/issues/471#issuecomment-1247042942 Just had a thought on this after perusing the docs further to see if there's anything I could find to support our end goals within current constraints: https://kubernetes.io/do

[GitHub] [solr-operator] joshsouza commented on issue #471: How to prevent node rotation behavior from causing cluster instability

2022-09-14 Thread GitBox
joshsouza commented on issue #471: URL: https://github.com/apache/solr-operator/issues/471#issuecomment-1247027292 (Read up more carefully on the docs, we can't use the sidecar idea, because it would indicate the whole pod isn't ready, and drop it from the service) -- This is an automated

[GitHub] [solr-operator] joshsouza commented on issue #471: How to prevent node rotation behavior from causing cluster instability

2022-09-14 Thread GitBox
joshsouza commented on issue #471: URL: https://github.com/apache/solr-operator/issues/471#issuecomment-1247002626 Ideas our team has been tossing around in discussions: `startupProbe` may also reduce risk (though still allows for some edge cases). If a newly starting pod had a startu

[GitHub] [solr-operator] joshsouza commented on issue #471: How to prevent node rotation behavior from causing cluster instability

2022-09-14 Thread GitBox
joshsouza commented on issue #471: URL: https://github.com/apache/solr-operator/issues/471#issuecomment-1246994429 I 100% support adding a cluster-level PDB here, as that's definitely a first step towards success. My concern is that the PDB will ensure we don't take a pod down if one is

[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-09-14 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1246901949 > This has been out for a while I'm thinking that it's worth committing? Any other changes you want? No changes so far -- This is an automated message from the Apache Git Servic

[GitHub] [solr] risdenk commented on a diff in pull request #1011: SOLR-16410: Upgrade build tool versions

2022-09-14 Thread GitBox
risdenk commented on code in PR #1011: URL: https://github.com/apache/solr/pull/1011#discussion_r970889719 ## solr/core/build.gradle: ## @@ -81,9 +81,12 @@ dependencies { implementation 'javax.servlet:javax.servlet-api' - implementation "org.glassfish.jersey.containers:j

[jira] [Updated] (SOLR-16410) Upgrade build tool versions

2022-09-14 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16410: Description: Upgrades across the build process. ||Gradle Plugin Name||Old Version||New Version|| |

[jira] [Resolved] (SOLR-16279) Remove unused imports from test

2022-09-14 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16279. -- Resolution: Abandoned Instead of fixing issues in tests one by one, we'll do them package by package t

[jira] [Resolved] (SOLR-16311) Simplify logic in asserts by using most specific form

2022-09-14 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16311. -- Resolution: Abandoned Instead of fixing issues in tests one by one, we'll do them package by package t

[jira] [Resolved] (SOLR-16277) Remove commented out code from Tests

2022-09-14 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16277. -- Resolution: Abandoned Instead of fixing issues in tests one by one, we'll do them package by package t

[jira] [Commented] (SOLR-16314) Annotations like @Before etc should be public visiblity

2022-09-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604685#comment-17604685 ] ASF subversion and git services commented on SOLR-16314: Commit a

[jira] [Assigned] (SOLR-16314) Annotations like @Before etc should be public visiblity

2022-09-14 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16314: Assignee: Eric Pugh > Annotations like @Before etc should be public visiblity > --

[jira] [Resolved] (SOLR-16314) Annotations like @Before etc should be public visiblity

2022-09-14 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16314. -- Fix Version/s: 9.1 main (10.0) Resolution: Fixed > Annotations like @Before e

[jira] [Commented] (SOLR-16314) Annotations like @Before etc should be public visiblity

2022-09-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604683#comment-17604683 ] ASF subversion and git services commented on SOLR-16314: Commit 3

[GitHub] [solr] epugh merged pull request #954: SOLR-16314: fix warnings about method visibility

2022-09-14 Thread GitBox
epugh merged PR #954: URL: https://github.com/apache/solr/pull/954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org F

[jira] [Updated] (SOLR-16410) Upgrade build tool versions

2022-09-14 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16410: Description: Upgrades across the build process. ||Gradle Plugin Name||Old Version||New Version|| |

[jira] [Updated] (SOLR-16410) Upgrade build tool versions

2022-09-14 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16410: Description: Upgrades across the build process. ||Gradle Plugin Name||Old Version||New Version|| |

[jira] [Updated] (SOLR-16410) Upgrade build tool versions

2022-09-14 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16410: Status: Patch Available (was: Open) > Upgrade build tool versions > --- >

[GitHub] [solr] risdenk commented on a diff in pull request #1011: SOLR-16410: Upgrade build tool versions

2022-09-14 Thread GitBox
risdenk commented on code in PR #1011: URL: https://github.com/apache/solr/pull/1011#discussion_r970789240 ## solr/modules/jwt-auth/build.gradle: ## @@ -19,7 +19,15 @@ apply plugin: 'java-library' description = 'JWT / OpenID Connect / OAuth2 authentication plugin' +configur

[GitHub] [solr] risdenk commented on a diff in pull request #1011: SOLR-16410: Upgrade build tool versions

2022-09-14 Thread GitBox
risdenk commented on code in PR #1011: URL: https://github.com/apache/solr/pull/1011#discussion_r970786980 ## solr/modules/clustering/build.gradle: ## @@ -29,7 +29,7 @@ dependencies { implementation 'org.slf4j:slf4j-api' testImplementation project(':solr:test-framework')

[GitHub] [solr] risdenk commented on a diff in pull request #1011: SOLR-16410: Upgrade build tool versions

2022-09-14 Thread GitBox
risdenk commented on code in PR #1011: URL: https://github.com/apache/solr/pull/1011#discussion_r970786446 ## solr/solrj/build.gradle: ## @@ -51,7 +51,7 @@ dependencies { testImplementation 'org.apache.zookeeper:zookeeper' permitTestUnusedDeclared 'org.apache.zookeeper:zoo

[GitHub] [solr] risdenk commented on a diff in pull request #1011: SOLR-16410: Upgrade build tool versions

2022-09-14 Thread GitBox
risdenk commented on code in PR #1011: URL: https://github.com/apache/solr/pull/1011#discussion_r970774519 ## solr/core/build.gradle: ## @@ -81,9 +81,12 @@ dependencies { implementation 'javax.servlet:javax.servlet-api' - implementation "org.glassfish.jersey.containers:j

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-14 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604066#comment-17604066 ] Kevin Risden commented on SOLR-16347: - Under SOLR-16410 I put a PR that addresses the

[jira] [Commented] (SOLR-16410) Upgrade build tool versions

2022-09-14 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604065#comment-17604065 ] Kevin Risden commented on SOLR-16410: - Draft PR - https://github.com/apache/solr/pull

[GitHub] [solr] risdenk opened a new pull request, #1011: SOLR-16410: Upgrade build tool versions

2022-09-14 Thread GitBox
risdenk opened a new pull request, #1011: URL: https://github.com/apache/solr/pull/1011 https://issues.apache.org/jira/browse/SOLR-16410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Created] (SOLR-16410) Upgrade build tool versions

2022-09-14 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-16410: --- Summary: Upgrade build tool versions Key: SOLR-16410 URL: https://issues.apache.org/jira/browse/SOLR-16410 Project: Solr Issue Type: Task Security Level:

[jira] [Commented] (SOLR-15730) Modularize SolrJ

2022-09-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604064#comment-17604064 ] David Smiley commented on SOLR-15730: - Right. I'll do a PR. > Modularize SolrJ > --

[GitHub] [solr] dsmiley commented on pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-14 Thread GitBox
dsmiley commented on PR #1004: URL: https://github.com/apache/solr/pull/1004#issuecomment-1246707836 I don't think "how we use newer clients" is still being worked out. To be clear SOLR-16368 is a pure refactoring; no actual change in which SolrClients are actually being used. It's a

[GitHub] [solr] epugh commented on pull request #954: SOLR-16314: fix warnings about method visibility

2022-09-14 Thread GitBox
epugh commented on PR #954: URL: https://github.com/apache/solr/pull/954#issuecomment-1246676110 I don't want to lose the work, so I'm retesting it now and will commit it. And per the discussion on https://lists.apache.org/thread/5k1x8rb67gh2f2kcjqwk3hbbprq9xt2r, will move to fixing the t

[GitHub] [solr] epugh commented on pull request #971: SOLR-11033: introduce multilingual configset

2022-09-14 Thread GitBox
epugh commented on PR #971: URL: https://github.com/apache/solr/pull/971#issuecomment-1246667183 @thelabdude I just heard the very first rumbling of a 9.1 release Have you had a chance to think more about this approach? Does this need a discussion on the mailing list? -- This is

[GitHub] [solr] epugh commented on pull request #977: Add shard-split.adoc

2022-09-14 Thread GitBox
epugh commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1246665602 This has been out for a while I'm thinking that it's worth committing? Any other changes you want? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [solr] epugh commented on pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

2022-09-14 Thread GitBox
epugh commented on PR #1004: URL: https://github.com/apache/solr/pull/1004#issuecomment-1246664043 I tried to dig into SOLR-16368, and it was hard... I was hoping this PR would be a good model for what the upgrade path should look like! Looking at @dsmiley comment, does that suggest tha

[jira] [Assigned] (SOLR-7883) MoreLikeThis is incompatible with facets

2022-09-14 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-7883: --- Assignee: Eric Pugh (was: Shalin Shekhar Mangar) > MoreLikeThis is incompatible with facets > --

[jira] [Commented] (SOLR-7883) MoreLikeThis is incompatible with facets

2022-09-14 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604045#comment-17604045 ] Eric Pugh commented on SOLR-7883: - As I mentioned on the new PR, in the ref guide it appea

[GitHub] [solr] epugh commented on pull request #1010: SOLR-7883: /mlt handler to support facets

2022-09-14 Thread GitBox
epugh commented on PR #1010: URL: https://github.com/apache/solr/pull/1010#issuecomment-1246646488 I was expecting to find no mention of facets on https://solr.apache.org/guide/solr/latest/query-guide/morelikethis.html#request-handler-parameters, and turn out to be wrong... Prior to

[GitHub] [solr-sandbox] markrmiller merged pull request #37: SSL config passed on to Kafka and a variety of general cleanup.

2022-09-14 Thread GitBox
markrmiller merged PR #37: URL: https://github.com/apache/solr-sandbox/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[GitHub] [solr] mkhludnev opened a new pull request, #1010: SOLR-7883: /mlt handler to support facets

2022-09-14 Thread GitBox
mkhludnev opened a new pull request, #1010: URL: https://github.com/apache/solr/pull/1010 Just a no brainer fix with a shallow test coverage. I'm not sure who need this standalone handler still. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (SOLR-16302) Backup restore silently skips config restore if config with same name already exists (in cloud mode)

2022-09-14 Thread Albert Moser (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603946#comment-17603946 ] Albert Moser commented on SOLR-16302: - [~gerlowskija] I created a PR with the change

[GitHub] [solr] AlbertMoser opened a new pull request, #1009: SOLR-16302: change to warn from info; make message clearer what is ha…

2022-09-14 Thread GitBox
AlbertMoser opened a new pull request, #1009: URL: https://github.com/apache/solr/pull/1009 …ppening https://issues.apache.org/jira/browse/SOLR-16302 # Description Changed the log from info to warn and added more text to note that the upload to Zookeeper is s