[GitHub] [solr] col-panic commented on a diff in pull request #890: SOLR-16230: JWT nested roles support

2022-09-13 Thread GitBox
col-panic commented on code in PR #890: URL: https://github.com/apache/solr/pull/890#discussion_r970319709 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -598,12 +599,48 @@ protected JWTAuthenticationResponse authenticate(String authori

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603866#comment-17603866 ] Kevin Risden commented on SOLR-16347: - I think I'll have a PR tomorrow that should fi

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603827#comment-17603827 ] Kevin Risden commented on SOLR-16347: - So I added those checks so I keep an eye on th

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603824#comment-17603824 ] Jason Gerlowski edited comment on SOLR-16347 at 9/14/22 12:47 AM: -

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603824#comment-17603824 ] Jason Gerlowski commented on SOLR-16347: Ah, fair enough, maybe I should have bee

[jira] [Assigned] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-16347: -- Assignee: Jason Gerlowski > Add JAX-RS integration for defining v2 APIs >

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603818#comment-17603818 ] Shawn Heisey commented on SOLR-16347: - {quote}When I run {{{}gradlew check{}}}, I can

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603815#comment-17603815 ] Jason Gerlowski commented on SOLR-16347: Hey [~krisden], thanks for the heads up.

[jira] [Commented] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603807#comment-17603807 ] Jan Høydahl commented on SOLR-16141: Thanks for prompting this [~ivan.viaznikov]. So

[jira] [Commented] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603806#comment-17603806 ] ASF subversion and git services commented on SOLR-16141: Commit 3

[jira] [Updated] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16141: --- Fix Version/s: 9.1 Resolution: Fixed Status: Resolved (was: Patch Available) > Upg

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603803#comment-17603803 ] Kevin Risden edited comment on SOLR-16347 at 9/13/22 10:41 PM:

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603803#comment-17603803 ] Kevin Risden commented on SOLR-16347: - FYI I haven't looked at how/why but this chang

[jira] [Commented] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603800#comment-17603800 ] ASF subversion and git services commented on SOLR-16141: Commit 2

[GitHub] [solr] janhoy merged pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4

2022-09-13 Thread GitBox
janhoy merged PR #1008: URL: https://github.com/apache/solr/pull/1008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Updated] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16141: Component/s: contrib - Solr Cell (Tika extraction) > Upgrade Apache Tika to 1.28.4 > --

[jira] [Updated] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16141: Issue Type: Task (was: Wish) > Upgrade Apache Tika to 1.28.4 > - > >

[jira] [Updated] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16141: Status: Patch Available (was: Open) > Upgrade Apache Tika to 1.28.4 >

[GitHub] [solr] risdenk commented on a diff in pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4

2022-09-13 Thread GitBox
risdenk commented on code in PR #1008: URL: https://github.com/apache/solr/pull/1008#discussion_r970129470 ## versions.props: ## @@ -50,7 +50,7 @@ org.apache.kerby:*=1.0.1 org.apache.logging.log4j:*=2.17.1 Review Comment: It doesn't matter in this case - but since the versi

[GitHub] [solr] janhoy commented on a diff in pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4

2022-09-13 Thread GitBox
janhoy commented on code in PR #1008: URL: https://github.com/apache/solr/pull/1008#discussion_r970129021 ## versions.props: ## @@ -50,7 +50,7 @@ org.apache.kerby:*=1.0.1 org.apache.logging.log4j:*=2.17.1 Review Comment: Done (not sure why it would matter though). -- Th

[GitHub] [solr-sandbox] markrmiller merged pull request #36: Explicit SSL Config

2022-09-13 Thread GitBox
markrmiller merged PR #36: URL: https://github.com/apache/solr-sandbox/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[GitHub] [solr-operator] HoustonPutman commented on issue #472: Helm zk.provided.zookeeperPodPolicy documentation issues

2022-09-13 Thread GitBox
HoustonPutman commented on issue #472: URL: https://github.com/apache/solr-operator/issues/472#issuecomment-1245954537 Thanks for finding these @alexangas ! Feel free to open a PR to fix them, but if not I can get to it eventually 🙂 -- This is an automated message from the Apache G

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #473: Add a podDisruptionBudget for the whole cloud

2022-09-13 Thread GitBox
HoustonPutman opened a new pull request, #473: URL: https://github.com/apache/solr-operator/pull/473 Fixes #471 I also had to upgrade the Kubernetes libraries in go to 1.21, in order to get the v1 version of the `PodDisruptionBudget`. That is why there are so many documentation cha

[GitHub] [solr-operator] HoustonPutman commented on issue #471: How to prevent node rotation behavior from causing cluster instability

2022-09-13 Thread GitBox
HoustonPutman commented on issue #471: URL: https://github.com/apache/solr-operator/issues/471#issuecomment-1245949988 This is a very good callout, so thank you for bringing it up. We can easily add a PodDisruptionBudget for the entire SolrCloud cluster, and the `maxUnavailable` can b

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603754#comment-17603754 ] ASF subversion and git services commented on SOLR-16347: Commit 8

[GitHub] [solr] gerlowskija merged pull request #975: SOLR-16347: Allow JAX-RS v2 API definition

2022-09-13 Thread GitBox
gerlowskija merged PR #975: URL: https://github.com/apache/solr/pull/975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[GitHub] [solr] epugh commented on pull request #768: Add hl.queryFieldPattern input to Admin UI

2022-09-13 Thread GitBox
epugh commented on PR #768: URL: https://github.com/apache/solr/pull/768#issuecomment-1245876869 Once you get your PR done for SOLR-16409, then maybe this PR can be closed in favour of the more general solution! -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [solr] jeanielamwh commented on pull request #768: Add hl.queryFieldPattern input to Admin UI

2022-09-13 Thread GitBox
jeanielamwh commented on PR #768: URL: https://github.com/apache/solr/pull/768#issuecomment-1245869954 Created [SOLR-16409](https://issues.apache.org/jira/browse/SOLR-16409) based on @epugh's suggestions. -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (SOLR-16409) Admin UI - Expose all highlighting parameters in the Query UI

2022-09-13 Thread Jeanie Lam (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603744#comment-17603744 ] Jeanie Lam commented on SOLR-16409: --- I would be happy to try adding the suggested UI co

[jira] [Created] (SOLR-16409) Admin UI - Expose all highlighting parameters in the Query UI

2022-09-13 Thread Jeanie Lam (Jira)
Jeanie Lam created SOLR-16409: - Summary: Admin UI - Expose all highlighting parameters in the Query UI Key: SOLR-16409 URL: https://issues.apache.org/jira/browse/SOLR-16409 Project: Solr Issue T

[GitHub] [solr-sandbox] anshumg merged pull request #35: Configuration improvements, cleanup, minor fixes.

2022-09-13 Thread GitBox
anshumg merged PR #35: URL: https://github.com/apache/solr-sandbox/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[GitHub] [solr] risdenk commented on a diff in pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4

2022-09-13 Thread GitBox
risdenk commented on code in PR #1008: URL: https://github.com/apache/solr/pull/1008#discussion_r969991839 ## versions.props: ## @@ -50,7 +50,7 @@ org.apache.kerby:*=1.0.1 org.apache.logging.log4j:*=2.17.1 Review Comment: This should be bumped to 2.17.2 based on `versions.l

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: SOLR-16347: Allow JAX-RS v2 API definition

2022-09-13 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r969971947 ## solr/solrj/src/java/org/apache/solr/common/util/Utils.java: ## @@ -916,7 +926,10 @@ public static void reflectWrite( } private static List getReflectData( Rev

[jira] [Commented] (SOLR-16406) Module loading does not work when using SOLR_MODULES in solr.in.sh

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603713#comment-17603713 ] Jan Høydahl commented on SOLR-16406: There is never a schedule. A new release is star

[jira] [Commented] (SOLR-15730) Modularize SolrJ

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603708#comment-17603708 ] Jan Høydahl commented on SOLR-15730: So you suggest to effectively users opt-out of s

[GitHub] [solr] janhoy commented on pull request #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4

2022-09-13 Thread GitBox
janhoy commented on PR #1008: URL: https://github.com/apache/solr/pull/1008#issuecomment-1245791076 I ran all tests, and the only failures I saw was unrelated. The modules/extraction tests all run fine. Will commit tomorrow if no objections, and backport to 9x -- This is an automated mes

[GitHub] [solr] dsmiley commented on a diff in pull request #975: SOLR-16347: Allow JAX-RS v2 API definition

2022-09-13 Thread GitBox
dsmiley commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r969938336 ## solr/solrj/src/java/org/apache/solr/common/util/Utils.java: ## @@ -916,7 +926,10 @@ public static void reflectWrite( } private static List getReflectData( Review

[jira] [Commented] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603686#comment-17603686 ] Kevin Risden commented on SOLR-16141: - Thanks for checking on upgraded Tika [~janhoy]

[GitHub] [solr] janhoy opened a new pull request, #1008: SOLR-16141 Upgrade Apache Tika to 1.28.4

2022-09-13 Thread GitBox
janhoy opened a new pull request, #1008: URL: https://github.com/apache/solr/pull/1008 https://issues.apache.org/jira/browse/SOLR-16141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Commented] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603683#comment-17603683 ] Jan Høydahl commented on SOLR-16141: [~krisden] Wrt upgrading to 2.x, the Tika site s

[jira] [Commented] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603680#comment-17603680 ] Jan Høydahl commented on SOLR-16141: Targeting 9.1 for this. If someone else wants to

[jira] [Updated] (SOLR-16141) Upgrade Apache Tika to 1.28.4

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16141: --- Summary: Upgrade Apache Tika to 1.28.4 (was: Update Apache Tika to 1.28.4) > Upgrade Apache Tika to

[jira] [Updated] (SOLR-16141) Update Apache Tika to 1.28.4

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16141: --- Description: org.apache.solr:solr-cell module uses Apache POI. Apache POI version 5.2.1 includes sev

[jira] [Commented] (SOLR-16141) Update Apache poi to the version 5.2.1

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603679#comment-17603679 ] Jan Høydahl commented on SOLR-16141: You will get POI 5.2.2 by upgrading Apacke Tika

[jira] [Assigned] (SOLR-16141) Update Apache Tika to 1.28.4

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-16141: -- Assignee: Jan Høydahl > Update Apache Tika to 1.28.4 > > >

[jira] [Updated] (SOLR-16141) Update Apache Tika to 1.28.4

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16141: --- Summary: Update Apache Tika to 1.28.4 (was: Update Apache poi to the version 5.2.1) > Update Apache

[GitHub] [solr-operator] alexangas opened a new issue, #472: Helm zk.provided.zookeeperPodPolicy documentation issues

2022-09-13 Thread GitBox
alexangas opened a new issue, #472: URL: https://github.com/apache/solr-operator/issues/472 Noticed that the affinity property on https://github.com/apache/solr-operator/blob/v0.6.0/helm/solr/README.md?plain=1#L180 looks wrong as this property is already described a few lines later.

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: SOLR-16347: Allow JAX-RS v2 API definition

2022-09-13 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r969831939 ## solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[GitHub] [solr] janhoy commented on a diff in pull request #890: SOLR-16230: JWT nested roles support

2022-09-13 Thread GitBox
janhoy commented on code in PR #890: URL: https://github.com/apache/solr/pull/890#discussion_r969555443 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -598,12 +599,48 @@ protected JWTAuthenticationResponse authenticate(String authorizat

[jira] [Commented] (SOLR-15715) Dedicated query coordinator nodes in the solr cluster

2022-09-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603545#comment-17603545 ] ASF subversion and git services commented on SOLR-15715: Commit d

[GitHub] [solr] noblepaul merged pull request #996: SOLR-15715: Dedicated query coordinator nodes in the solr cluster

2022-09-13 Thread GitBox
noblepaul merged PR #996: URL: https://github.com/apache/solr/pull/996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] col-panic commented on a diff in pull request #890: SOLR-16230: JWT nested roles support

2022-09-13 Thread GitBox
col-panic commented on code in PR #890: URL: https://github.com/apache/solr/pull/890#discussion_r969520862 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -598,12 +599,48 @@ protected JWTAuthenticationResponse authenticate(String authori

[GitHub] [solr] janhoy commented on a diff in pull request #890: SOLR-16230: JWT nested roles support

2022-09-13 Thread GitBox
janhoy commented on code in PR #890: URL: https://github.com/apache/solr/pull/890#discussion_r969444744 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -598,12 +599,48 @@ protected JWTAuthenticationResponse authenticate(String authorizat

[jira] [Commented] (SOLR-16406) Module loading does not work when using SOLR_MODULES in solr.in.sh

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603435#comment-17603435 ] Thomas Wöckinger commented on SOLR-16406: - Is there already a schedule for the ne

[GitHub] [solr] janhoy commented on pull request #1007: SOLR-16406: Take SOLR_MODULES into account

2022-09-13 Thread GitBox
janhoy commented on PR #1007: URL: https://github.com/apache/solr/pull/1007#issuecomment-1245028728 @thomaswoeckinger can you add a CHANGES.txt entry for 9.1, under bugfixes, then we can merge. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (SOLR-16406) Module loading does not work when using SOLR_MODULES in solr.in.sh

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603434#comment-17603434 ] Jan Høydahl commented on SOLR-16406: I abandoned my workaround PR, and approved your

[GitHub] [solr] janhoy closed pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh

2022-09-13 Thread GitBox
janhoy closed pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh URL: https://github.com/apache/solr/pull/1006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] janhoy commented on a diff in pull request #1006: SOLR-16406: Clarify how to add SOLR_MODULES to solr.in.sh

2022-09-13 Thread GitBox
janhoy commented on code in PR #1006: URL: https://github.com/apache/solr/pull/1006#discussion_r969263259 ## solr/bin/solr.in.sh: ## @@ -280,4 +280,4 @@ # SOLR_OPTS="$SOLR_OPTS -Dlog4j2.formatMsgNoLookups=true" # The bundled plugins in the "modules" folder can easily be enab