[jira] [Commented] (SOLR-16403) SPLITSHARD should delete the parent shard after success

2022-09-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601118#comment-17601118 ] David Smiley commented on SOLR-16403: - Changing the default behavior for Solr 10 woul

[jira] [Commented] (SOLR-16192) Add ZK credentials injectors

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601089#comment-17601089 ] ASF subversion and git services commented on SOLR-16192: Commit 4

[jira] [Updated] (SOLR-16324) CVE-2022-33980 in commons-configuration2

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16324: Priority: Minor (was: Major) > CVE-2022-33980 in commons-configuration2 >

[jira] [Commented] (SOLR-16324) CVE-2022-33980 in commons-configuration2

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601081#comment-17601081 ] Kevin Risden commented on SOLR-16324: - Backport to branch_8_11: https://github.com/ap

[jira] [Updated] (SOLR-16324) CVE-2022-33980 in commons-configuration2

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16324: Fix Version/s: 9.1 main (10.0) > CVE-2022-33980 in commons-configuration2 >

[jira] [Commented] (SOLR-16324) CVE-2022-33980 in commons-configuration2

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601072#comment-17601072 ] ASF subversion and git services commented on SOLR-16324: Commit c

[jira] [Commented] (SOLR-16324) CVE-2022-33980 in commons-configuration2

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601070#comment-17601070 ] ASF subversion and git services commented on SOLR-16324: Commit e

[GitHub] [solr] risdenk merged pull request #999: SOLR-16324: Upgrade commons-configuration2 to 2.8.0 and commons-text to 1.8

2022-09-06 Thread GitBox
risdenk merged PR #999: URL: https://github.com/apache/solr/pull/999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] noblepaul commented on pull request #965: SOLR-16328 : intern() strings in DocCollection to reduce memory footp…

2022-09-06 Thread GitBox
noblepaul commented on PR #965: URL: https://github.com/apache/solr/pull/965#issuecomment-1238787574 unfortunately we don't have a choice. We have to upgrade error-prone as well ``` > Could not resolve com.google.errorprone:error_prone_annotations:2.11.0. Required by:

[jira] [Commented] (SOLR-16192) Add ZK credentials injectors

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601065#comment-17601065 ] ASF subversion and git services commented on SOLR-16192: Commit 9

[GitHub] [solr] HoustonPutman merged pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-09-06 Thread GitBox
HoustonPutman merged PR #857: URL: https://github.com/apache/solr/pull/857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[GitHub] [solr] noblepaul commented on a diff in pull request #996: SOLR-15715: Dedicated query coordinator nodes in the solr cluster

2022-09-06 Thread GitBox
noblepaul commented on code in PR #996: URL: https://github.com/apache/solr/pull/996#discussion_r964280654 ## solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java: ## @@ -137,7 +140,15 @@ public SolrDispatchFilter() {} public void init(FilterConfig config) throw

[GitHub] [solr] epugh commented on pull request #916: SOLR-16318: Use up to JDK 11 features (avoid type declaration when <> can be used)

2022-09-06 Thread GitBox
epugh commented on PR #916: URL: https://github.com/apache/solr/pull/916#issuecomment-1238702042 I would love to see these get merged, as keeping this patch up to date is going to get harder...Do we have consensus on merging it? -- This is an automated message from the Apache Git Serv

[GitHub] [solr] risdenk commented on pull request #999: SOLR-16324: Upgrade commons-configuration2 to 2.8.0 and commons-text to 1.8

2022-09-06 Thread GitBox
risdenk commented on PR #999: URL: https://github.com/apache/solr/pull/999#issuecomment-1238665743 > Backport also to 9x and 8x? definitely to 9.x. I can take a look at how hard it is to backport to 8.x. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (SOLR-16324) CVE-2022-33980 in commons-configuration2

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16324: Status: Patch Available (was: Open) > CVE-2022-33980 in commons-configuration2 > -

[GitHub] [solr] risdenk opened a new pull request, #999: SOLR-16324: Upgrade commons-configuration2 to 2.8.0 and commons-text to 1.8

2022-09-06 Thread GitBox
risdenk opened a new pull request, #999: URL: https://github.com/apache/solr/pull/999 https://issues.apache.org/jira/browse/SOLR-16324 * Upgrade commons-configuration2 to 2.8.0 due to CVE-2022-33980 * Upgrade commons-text to 1.9 since it gets upgraded with commons-configuration2

[jira] [Created] (SOLR-16404) Use non-deprecated Solr clients in the Prometheus Exporter

2022-09-06 Thread Houston Putman (Jira)
Houston Putman created SOLR-16404: - Summary: Use non-deprecated Solr clients in the Prometheus Exporter Key: SOLR-16404 URL: https://issues.apache.org/jira/browse/SOLR-16404 Project: Solr Iss

[GitHub] [solr] HoustonPutman commented on pull request #984: SOLR-16340 Provide a cluster_id label for all metrics exposed by the Solr Prometheus Exporter

2022-09-06 Thread GitBox
HoustonPutman commented on PR #984: URL: https://github.com/apache/solr/pull/984#issuecomment-1238603018 Here is an example of using zkConnectionString as cluster_id: https://user-images.githubusercontent.com/3376422/188729137-3f9f7267-7a51-4b91-9cf8-fbc816d27dbd.png";> -- This

[jira] [Assigned] (SOLR-16324) CVE-2022-33980 in commons-configuration2

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16324: --- Assignee: Kevin Risden > CVE-2022-33980 in commons-configuration2 >

[jira] [Assigned] (SOLR-16402) Update GSON dependency for CVE 2022-24657

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16402: --- Assignee: Kevin Risden > Update GSON dependency for CVE 2022-24657 > ---

[jira] [Updated] (SOLR-16402) Update GSON dependency for CVE 2022-24657

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16402: Status: Patch Available (was: Open) > Update GSON dependency for CVE 2022-24657 >

[jira] [Commented] (SOLR-16402) Update GSON dependency for CVE 2022-24657

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600949#comment-17600949 ] Kevin Risden commented on SOLR-16402: - PR - https://github.com/apache/solr/pull/998

[GitHub] [solr] risdenk opened a new pull request, #998: SOLR-16403: Bump google-cloud-bom to 0.178.0

2022-09-06 Thread GitBox
risdenk opened a new pull request, #998: URL: https://github.com/apache/solr/pull/998 https://issues.apache.org/jira/browse/SOLR-16403 * Upgrades GSON to 2.9.1 due to CVE-2022-25647 * Upgrades Guava to 31.1-jre -- This is an automated message from the Apache Git Service. To respo

[jira] [Commented] (SOLR-16403) SPLITSHARD should delete the parent shard after success

2022-09-06 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600944#comment-17600944 ] Gus Heck commented on SOLR-16403: - My vague recollection/feeling is that this didn't dele

[jira] [Commented] (SOLR-16402) Update GSON dependency for CVE 2022-24657

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600943#comment-17600943 ] Kevin Risden commented on SOLR-16402: - I would guess just bumping `com.google.cloud:g

[GitHub] [solr] HoustonPutman commented on pull request #984: SOLR-16340 Provide a cluster_id label for all metrics exposed by the Solr Prometheus Exporter

2022-09-06 Thread GitBox
HoustonPutman commented on PR #984: URL: https://github.com/apache/solr/pull/984#issuecomment-1238533794 Ok the dashboard looks good! Just a few changes from my end, mainly that "Shard Leaders", "Replica State History" and "QPS (Collection)" Did not specify the cluster_id, and "QPS (Collect

[jira] [Commented] (SOLR-16403) SPLITSHARD should delete the parent shard after success

2022-09-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600939#comment-17600939 ] David Smiley commented on SOLR-16403: - Possible issues: * ensuring that requests-in-p

[jira] [Created] (SOLR-16403) SPLITSHARD should delete the parent shard after success

2022-09-06 Thread David Smiley (Jira)
David Smiley created SOLR-16403: --- Summary: SPLITSHARD should delete the parent shard after success Key: SOLR-16403 URL: https://issues.apache.org/jira/browse/SOLR-16403 Project: Solr Issue Type

[GitHub] [solr] madrob commented on pull request #996: SOLR-15715: Dedicated query coordinator nodes in the solr cluster

2022-09-06 Thread GitBox
madrob commented on PR #996: URL: https://github.com/apache/solr/pull/996#issuecomment-1238434121 Left some comments. I tried to go in with fresh eyes, so I don't know how many are repeated from the last PR. In general, when you close and start new PRs we lose all of the discussion history

[GitHub] [solr] madrob commented on a diff in pull request #996: SOLR-15715: Dedicated query coordinator nodes in the solr cluster

2022-09-06 Thread GitBox
madrob commented on code in PR #996: URL: https://github.com/apache/solr/pull/996#discussion_r963947450 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] madrob closed pull request #559: SOLR-15715: coordinator role

2022-09-06 Thread GitBox
madrob closed pull request #559: SOLR-15715: coordinator role URL: https://github.com/apache/solr/pull/559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [solr] madrob commented on pull request #965: SOLR-16328 : intern() strings in DocCollection to reduce memory footp…

2022-09-06 Thread GitBox
madrob commented on PR #965: URL: https://github.com/apache/solr/pull/965#issuecomment-1238393512 The failure is ```/home/runner/work/solr/solr/solr/solrj/src/java/org/apache/solr/common/cloud/CompositeIdRouter.java:238: warning: [NarrowCalculation] This product of integers could overflow b

[GitHub] [solr] heythm commented on a diff in pull request #962: SOLR-16296: Load elevate.xml in a more secure way

2022-09-06 Thread GitBox
heythm commented on code in PR #962: URL: https://github.com/apache/solr/pull/962#discussion_r963886690 ## solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java: ## @@ -413,17 +414,16 @@ private ElevationProvider loadElevationProvider(SolrCore core)

[GitHub] [solr] dsmiley commented on a diff in pull request #962: SOLR-16296: Load elevate.xml in a more secure way

2022-09-06 Thread GitBox
dsmiley commented on code in PR #962: URL: https://github.com/apache/solr/pull/962#discussion_r963878466 ## solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java: ## @@ -413,17 +414,16 @@ private ElevationProvider loadElevationProvider(SolrCore core)

[jira] [Created] (SOLR-16402) Update GSON dependency for CVE 2022-24657

2022-09-06 Thread Cassandra Targett (Jira)
Cassandra Targett created SOLR-16402: Summary: Update GSON dependency for CVE 2022-24657 Key: SOLR-16402 URL: https://issues.apache.org/jira/browse/SOLR-16402 Project: Solr Issue Type: Ta

[jira] [Updated] (SOLR-16401) Test thread leak linger should be 1s

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16401: Fix Version/s: 9.1 main (10.0) Resolution: Fixed Status: Resolv

[jira] [Commented] (SOLR-16401) Test thread leak linger should be 1s

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600842#comment-17600842 ] ASF subversion and git services commented on SOLR-16401: Commit 5

[jira] [Commented] (SOLR-16401) Test thread leak linger should be 1s

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600840#comment-17600840 ] ASF subversion and git services commented on SOLR-16401: Commit 2

[GitHub] [solr] risdenk merged pull request #997: SOLR-16401: Test thread leak linger should be 1s

2022-09-06 Thread GitBox
risdenk merged PR #997: URL: https://github.com/apache/solr/pull/997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Updated] (SOLR-16399) ExportWriter fails with max values for fields

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16399: Fix Version/s: main (10.0) > ExportWriter fails with max values for fields > --

[jira] [Updated] (SOLR-16187) ExecutorUtil#awaitTermination shouldn't wait forever

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16187: Fix Version/s: main (10.0) > ExecutorUtil#awaitTermination shouldn't wait forever > ---

[jira] [Commented] (SOLR-16046) Thread leak in TestLeaderElectionZkExpiry

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600810#comment-17600810 ] Kevin Risden commented on SOLR-16046: - I merged https://github.com/apache/solr/pull/8

[jira] [Commented] (SOLR-16046) Thread leak in TestLeaderElectionZkExpiry

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600809#comment-17600809 ] ASF subversion and git services commented on SOLR-16046: Commit 1

[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-09-06 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1238258620 > maybe adding the `documentation` label would bring in more reviewers? I didn't create a jira issue for this; not sure if it is worth it. -- This is an automated message from the A

[jira] [Updated] (SOLR-16046) Thread leak in TestLeaderElectionZkExpiry

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16046: Issue Type: Test (was: Bug) > Thread leak in TestLeaderElectionZkExpiry >

[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-09-06 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1238257202 > Also, did you drop an explicit note to dev mailing list? yes, i did; it has a title `Shard Split Documentation`. -- This is an automated message from the Apache Git Service. To res

[jira] [Commented] (SOLR-16046) Thread leak in TestLeaderElectionZkExpiry

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600805#comment-17600805 ] ASF subversion and git services commented on SOLR-16046: Commit e

[jira] [Updated] (SOLR-16046) Thread leak in TestLeaderElectionZkExpiry

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16046: Priority: Minor (was: Major) > Thread leak in TestLeaderElectionZkExpiry > ---

[jira] [Updated] (SOLR-16046) Thread leak in TestLeaderElectionZkExpiry

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16046: Component/s: Tests > Thread leak in TestLeaderElectionZkExpiry > --

[GitHub] [solr] risdenk merged pull request #841: SOLR-16046: Thread leak in TestLeaderElectionZkExpiry

2022-09-06 Thread GitBox
risdenk merged PR #841: URL: https://github.com/apache/solr/pull/841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Updated] (SOLR-16401) Test thread leak linger should be 1s

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16401: Status: Patch Available (was: Open) > Test thread leak linger should be 1s > -

[GitHub] [solr] risdenk opened a new pull request, #997: SOLR-16401: Test thread leak linger should be 1s

2022-09-06 Thread GitBox
risdenk opened a new pull request, #997: URL: https://github.com/apache/solr/pull/997 https://issues.apache.org/jira/browse/SOLR-16401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (SOLR-16187) ExecutorUtil#awaitTermination shouldn't wait forever

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16187: Fix Version/s: 9.1 > ExecutorUtil#awaitTermination shouldn't wait forever > ---

[jira] [Updated] (SOLR-16187) ExecutorUtil#awaitTermination shouldn't wait forever

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16187: Priority: Minor (was: Major) > ExecutorUtil#awaitTermination shouldn't wait forever >

[jira] [Updated] (SOLR-16187) ExecutorUtil#awaitTermination shouldn't wait forever

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16187: Resolution: Fixed Status: Resolved (was: Patch Available) > ExecutorUtil#awaitTermination

[jira] [Commented] (SOLR-15660) Remove universal 10 second test thread leak linger.

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600802#comment-17600802 ] Kevin Risden commented on SOLR-15660: - I created SOLR-16401 to track adding the 1s th

[jira] [Created] (SOLR-16401) Test thread leak linger should be 1s

2022-09-06 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-16401: --- Summary: Test thread leak linger should be 1s Key: SOLR-16401 URL: https://issues.apache.org/jira/browse/SOLR-16401 Project: Solr Issue Type: Test Securi

[jira] [Commented] (SOLR-16187) ExecutorUtil#awaitTermination shouldn't wait forever

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600801#comment-17600801 ] Kevin Risden commented on SOLR-16187: - I created SOLR-16401 to track adding the 1s th

[GitHub] [solr] heythm commented on pull request #962: SOLR-16296: Load elevate.xml in a more secure way

2022-09-06 Thread GitBox
heythm commented on PR #962: URL: https://github.com/apache/solr/pull/962#issuecomment-1238238797 @noblepaul - I want your opinion on merging this PR? This now only includes not using XmlConfigFile in QEC, but also a small cleanup of XmlConfigFile/SafeXMLParsing for handling untrusted/untru

[jira] [Commented] (SOLR-16187) ExecutorUtil#awaitTermination shouldn't wait forever

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600797#comment-17600797 ] ASF subversion and git services commented on SOLR-16187: Commit 4

[jira] [Commented] (SOLR-16187) ExecutorUtil#awaitTermination shouldn't wait forever

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600795#comment-17600795 ] ASF subversion and git services commented on SOLR-16187: Commit f

[GitHub] [solr] risdenk merged pull request #840: SOLR-16187: ExecutorUtil#awaitTermination shouldn't wait forever

2022-09-06 Thread GitBox
risdenk merged PR #840: URL: https://github.com/apache/solr/pull/840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Updated] (SOLR-16399) ExportWriter fails with max values for fields

2022-09-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16399: Fix Version/s: 9.1 Resolution: Fixed Status: Resolved (was: Patch Available) > E

[jira] [Commented] (SOLR-16399) ExportWriter fails with max values for fields

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600794#comment-17600794 ] ASF subversion and git services commented on SOLR-16399: Commit a

[jira] [Commented] (SOLR-16399) ExportWriter fails with max values for fields

2022-09-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600792#comment-17600792 ] ASF subversion and git services commented on SOLR-16399: Commit 2

[GitHub] [solr] risdenk merged pull request #995: SOLR-16399: ExportWriter fails with max values for fields

2022-09-06 Thread GitBox
risdenk merged PR #995: URL: https://github.com/apache/solr/pull/995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] HoustonPutman commented on pull request #984: SOLR-16340 Provide a cluster_id label for all metrics exposed by the Solr Prometheus Exporter

2022-09-06 Thread GitBox
HoustonPutman commented on PR #984: URL: https://github.com/apache/solr/pull/984#issuecomment-1238170410 > Looking forward to final reviews. Going to spin this up today with a few clusters and poke around! -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [solr] epugh commented on pull request #962: SOLR-16296: Load elevate.xml in a more secure way

2022-09-06 Thread GitBox
epugh commented on PR #962: URL: https://github.com/apache/solr/pull/962#issuecomment-1238040908 Thanks for your persistence on this @heythm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [solr] heythm commented on pull request #962: SOLR-16296: Load elevate.xml in a more secure way

2022-09-06 Thread GitBox
heythm commented on PR #962: URL: https://github.com/apache/solr/pull/962#issuecomment-1237955386 Update: I will limit the scope of this work to only removing the use of XmlConfigFile from QEC following up on [this discussion](https://github.com/apache/solr/pull/994#issuecomment-1237687932)