[GitHub] [solr] noblepaul commented on a diff in pull request #965: SOLR-16328 : intern() strings in DocCollection to reduce memory footp…

2022-08-30 Thread GitBox
noblepaul commented on code in PR #965: URL: https://github.com/apache/solr/pull/965#discussion_r959170545 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -383,6 +388,7 @@ public CoreContainer(NodeConfig config, CoresLocator locator, boolean asyncSolrC

[GitHub] [solr] noblepaul commented on a diff in pull request #965: SOLR-16328 : intern() strings in DocCollection to reduce memory footp…

2022-08-30 Thread GitBox
noblepaul commented on code in PR #965: URL: https://github.com/apache/solr/pull/965#discussion_r959170422 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2424,6 +2430,32 @@ public PlacementPluginFactory getPlacementPlugi public void runAsync(Runnable r)

[GitHub] [solr] dsmiley commented on a diff in pull request #990: SOLR-16362: Truncate logs when they are too long

2022-08-30 Thread GitBox
dsmiley commented on code in PR #990: URL: https://github.com/apache/solr/pull/990#discussion_r959140016 ## solr/core/src/java/org/apache/solr/update/DocumentBuilder.java: ## @@ -161,14 +162,21 @@ public static Document toDocument( && !sfield.multiValued()

[jira] [Commented] (SOLR-16362) Truncate logs when they are too long

2022-08-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598158#comment-17598158 ] David Smiley commented on SOLR-16362: - Can you show an example of what it looks like

[GitHub] [solr] stillalex commented on a diff in pull request #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes

2022-08-30 Thread GitBox
stillalex commented on code in PR #985: URL: https://github.com/apache/solr/pull/985#discussion_r959131445 ## solr/CHANGES.txt: ## @@ -118,6 +118,8 @@ Bug Fixes * SOLR-16316: Fix debugQuery clicking on the Query UI does not show the debug.explain.structured option. (Shiming

[jira] [Created] (SOLR-16363) addDoc() in DirectUpdateHandler2 needs additional Exception Handling

2022-08-30 Thread Aman Verma (Jira)
Aman Verma created SOLR-16363: - Summary: addDoc() in DirectUpdateHandler2 needs additional Exception Handling Key: SOLR-16363 URL: https://issues.apache.org/jira/browse/SOLR-16363 Project: Solr

[GitHub] [solr] NazerkeBS opened a new pull request, #990: SOLR-16362: Truncate logs when they are too long

2022-08-30 Thread GitBox
NazerkeBS opened a new pull request, #990: URL: https://github.com/apache/solr/pull/990 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution Pl

[jira] [Updated] (SOLR-16362) Truncate logs when they are too long

2022-08-30 Thread Nazerke Seidan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nazerke Seidan updated SOLR-16362: -- Summary: Truncate logs when they are too long (was: Truncate logs with extremely long values)

[jira] [Created] (SOLR-16362) Truncate logs with extremely long values

2022-08-30 Thread Nazerke Seidan (Jira)
Nazerke Seidan created SOLR-16362: - Summary: Truncate logs with extremely long values Key: SOLR-16362 URL: https://issues.apache.org/jira/browse/SOLR-16362 Project: Solr Issue Type: Improveme

[GitHub] [solr] janhoy commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-30 Thread GitBox
janhoy commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r958606212 ## solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java: ## @@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) { } @GET - @Produces("applica

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-30 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r958598470 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -362,14 +363,15 @@ private void invokeJerseyRequest(CoreContainer cores, SolrCore core, Application

[GitHub] [solr] dsmiley commented on a diff in pull request #962: SOLR-16296: Load elevate.xml in a more secure way

2022-08-30 Thread GitBox
dsmiley commented on code in PR #962: URL: https://github.com/apache/solr/pull/962#discussion_r958585230 ## solr/core/src/java/org/apache/solr/core/SolrConfig.java: ## @@ -413,7 +413,7 @@ private void readXml( Map configCache, ResourceProvider rp) throws IOE

[GitHub] [solr] madrob commented on a diff in pull request #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes

2022-08-30 Thread GitBox
madrob commented on code in PR #985: URL: https://github.com/apache/solr/pull/985#discussion_r958504710 ## solr/CHANGES.txt: ## @@ -118,6 +118,8 @@ Bug Fixes * SOLR-16316: Fix debugQuery clicking on the Query UI does not show the debug.explain.structured option. (Shiming Li

[GitHub] [solr] madrob commented on a diff in pull request #965: SOLR-16328 : intern() strings in DocCollection to reduce memory footp…

2022-08-30 Thread GitBox
madrob commented on code in PR #965: URL: https://github.com/apache/solr/pull/965#discussion_r958487650 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2424,6 +2430,32 @@ public PlacementPluginFactory getPlacementPlugi public void runAsync(Runnable r) {

[jira] [Commented] (SOLR-16359) Reindex without delete old index data

2022-08-30 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597875#comment-17597875 ] Shawn Heisey commented on SOLR-16359: - Jira is not the correct replace for support re

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-30 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r958476775 ## solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java: ## @@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) { } @GET - @Produces("ap

[GitHub] [solr] dsmiley commented on a diff in pull request #962: SOLR-16296: Load elevate.xml in a more secure way

2022-08-30 Thread GitBox
dsmiley commented on code in PR #962: URL: https://github.com/apache/solr/pull/962#discussion_r958450880 ## solr/core/src/java/org/apache/solr/core/XmlConfigFile.java: ## @@ -59,60 +51,18 @@ */ public class XmlConfigFile { // formerly simply "Config" private static final L

[GitHub] [solr] danrosher opened a new pull request, #989: SOLR-16361

2022-08-30 Thread GitBox
danrosher opened a new pull request, #989: URL: https://github.com/apache/solr/pull/989 https://issues.apache.org/jira/browse/SOLR-16361 # Description use double instead of float for mod function query # Solution use double instead of float for mod function query

[GitHub] [solr] danrosher commented on pull request #988: SOLR-16361

2022-08-30 Thread GitBox
danrosher commented on PR #988: URL: https://github.com/apache/solr/pull/988#issuecomment-1231546337 mistakenly opened -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [solr] danrosher closed pull request #988: SOLR-16361

2022-08-30 Thread GitBox
danrosher closed pull request #988: SOLR-16361 URL: https://github.com/apache/solr/pull/988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [solr] epugh commented on a diff in pull request #988: SOLR-16361

2022-08-30 Thread GitBox
epugh commented on code in PR #988: URL: https://github.com/apache/solr/pull/988#discussion_r958365604 ## solr/core/src/java/org/apache/solr/search/ValueSourceParser.java: ## @@ -100,12 +100,7 @@ import org.apache.solr.search.facet.UniqueBlockFieldAgg; import org.apache.solr.s

[GitHub] [solr] danrosher opened a new pull request, #988: SOLR-16361

2022-08-30 Thread GitBox
danrosher opened a new pull request, #988: URL: https://github.com/apache/solr/pull/988 https://issues.apache.org/jira/browse/SOLR-16361 # Description use double instead of float for modulus # Solution use double instead of float for modulus # Checklist

[jira] [Created] (SOLR-16361) 'mod' function query casts to float, returns wrong modulus for large ints

2022-08-30 Thread Dan Rosher (Jira)
Dan Rosher created SOLR-16361: - Summary: 'mod' function query casts to float, returns wrong modulus for large ints Key: SOLR-16361 URL: https://issues.apache.org/jira/browse/SOLR-16361 Project: Solr

[GitHub] [solr] heythm commented on pull request #962: SOLR-16296: Load elevate.xml in a more secure way

2022-08-30 Thread GitBox
heythm commented on PR #962: URL: https://github.com/apache/solr/pull/962#issuecomment-1231420169 In the end, I reverted the major refactorings to do a resolution by simply overloading `SafeXMLParsing.parseConfigXml`. -- This is an automated message from the Apache Git Service. To respond