[GitHub] [solr] dsmiley commented on pull request #943: SOLR-15342: Separate out a SolrJ-Zookeeper module

2022-07-29 Thread GitBox
dsmiley commented on PR #943: URL: https://github.com/apache/solr/pull/943#issuecomment-1200090588 @haythemkh I know you are using the Google Java Format IntelliJ plugin but not the IntelliJ code style that accompanies it, which ensures that the import wildcards are configured correctly (th

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-07-29 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573176#comment-17573176 ] Ben Manes commented on SOLR-15859: -- - {{Caffeine.recordStats()}} enables basic statistic

[GitHub] [solr] andywebb1975 commented on pull request #875: SOLR-9359: Make Config API work for warming queries

2022-07-29 Thread GitBox
andywebb1975 commented on PR #875: URL: https://github.com/apache/solr/pull/875#issuecomment-1199971214 Good shout @epugh! I've added some further notes - how does that look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [solr] madrob commented on a diff in pull request #940: SOLR-16292 : NVector for alternative great-circle distance calculations

2022-07-29 Thread GitBox
madrob commented on code in PR #940: URL: https://github.com/apache/solr/pull/940#discussion_r927733523 ## solr/core/src/java/org/apache/solr/schema/NVectorField.java: ## @@ -0,0 +1,285 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[jira] [Commented] (SOLR-14319) Add ability to select replicatype to admin ui collection creation

2022-07-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573128#comment-17573128 ] Eric Pugh commented on SOLR-14319: -- [~GoodmanR] so, I don't know why I didn't make a pro

[GitHub] [solr] epugh commented on pull request #958: SOLR-14319: specify replica types in UI when creating a collection

2022-07-29 Thread GitBox
epugh commented on PR #958: URL: https://github.com/apache/solr/pull/958#issuecomment-1199820402 So.. one question that came up, can you specify `replicationFactor` and the specific counts per type? https://solr.apache.org/guide/solr/latest/deployment-guide/collection-management.htm

[GitHub] [solr] epugh opened a new pull request, #958: SOLR-14319: specify replica types in UI when creating a collection

2022-07-29 Thread GitBox
epugh opened a new pull request, #958: URL: https://github.com/apache/solr/pull/958 https://issues.apache.org/jira/browse/SOLR-14319 # Description This PR is based on a patch from early 2022 by Richard Goodman. # Solution Add ability to specify replica types in UI,

[GitHub] [solr] cpoerschke commented on pull request #943: SOLR-15342: Separate out a SolrJ-Zookeeper module

2022-07-29 Thread GitBox
cpoerschke commented on PR #943: URL: https://github.com/apache/solr/pull/943#issuecomment-1199778111 > oops, was trying to be helpful resolving the merge conflict but forgot to compile locally before pushing, sorry. will try to fix, or else commit reversion logically should also be possibl

[jira] [Commented] (SOLR-16295) Modernize and Standardize Solr description across all platforms

2022-07-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573075#comment-17573075 ] Eric Pugh commented on SOLR-16295: -- I can go with that Until streaming expressions

[jira] [Commented] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573071#comment-17573071 ] ASF subversion and git services commented on SOLR-16316: Commit 6

[jira] [Resolved] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16316. -- Fix Version/s: 9.1 main (10.0) Resolution: Fixed Thank you for the fix! > De

[GitHub] [solr] madrob commented on a diff in pull request #931: SOLR-16282: Update core admin handler to use pluggable custom actions

2022-07-29 Thread GitBox
madrob commented on code in PR #931: URL: https://github.com/apache/solr/pull/931#discussion_r933473915 ## solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java: ## @@ -132,6 +133,14 @@ public static NodeConfig fromConfig(Path solrHome, XmlConfigFile config, boolean S

[jira] [Commented] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573070#comment-17573070 ] ASF subversion and git services commented on SOLR-16316: Commit 9

[GitHub] [solr] epugh merged pull request #956: SOLR-16316: Fix debug query clicking on the query UI does not show the debug.explain.structured option

2022-07-29 Thread GitBox
epugh merged PR #956: URL: https://github.com/apache/solr/pull/956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org F

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-07-29 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573061#comment-17573061 ] Shawn Heisey commented on SOLR-15859: - [~ben.manes] Can you provide some insight int

[jira] [Commented] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573058#comment-17573058 ] Eric Pugh commented on SOLR-16316: -- !screenshot-1.png! Any thoughts about making the

[jira] [Updated] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16316: - Attachment: screenshot-1.png > DebugQuery clicking on the Query UI does not show the > debug.explain.str

[GitHub] [solr] epugh commented on pull request #916: SOLR-16318: Use up to JDK 11 features (avoid type declaration when <> can be used)

2022-07-29 Thread GitBox
epugh commented on PR #916: URL: https://github.com/apache/solr/pull/916#issuecomment-1199722049 Makes sense to me...I wonder if we need to have a conversation on dev mailing list related to when we merge this? I know @dsmiley is interested in seeing #943 get merged soon, and this migh

[GitHub] [solr] cpoerschke commented on pull request #943: SOLR-15342: Separate out a SolrJ-Zookeeper module

2022-07-29 Thread GitBox
cpoerschke commented on PR #943: URL: https://github.com/apache/solr/pull/943#issuecomment-1199648743 oops, was trying to be helpful resolving the merge conflict but forgot to compile locally before pushing, sorry. will try to fix, or else commit reversion logically should also be possible?

[jira] [Created] (SOLR-16318) Use up to JDK 11 features

2022-07-29 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-16318: -- Summary: Use up to JDK 11 features Key: SOLR-16318 URL: https://issues.apache.org/jira/browse/SOLR-16318 Project: Solr Issue Type: Task

[jira] [Created] (SOLR-16317) GCS Backup Logging is Broken

2022-07-29 Thread Mike Drob (Jira)
Mike Drob created SOLR-16317: Summary: GCS Backup Logging is Broken Key: SOLR-16317 URL: https://issues.apache.org/jira/browse/SOLR-16317 Project: Solr Issue Type: Task Components: cont

[jira] [Assigned] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16316: Assignee: Eric Pugh > DebugQuery clicking on the Query UI does not show the > debug.explain.struc

[jira] [Commented] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573019#comment-17573019 ] Eric Pugh commented on SOLR-16316: -- Oddly enough, yesterday I was showing something to a

[jira] [Resolved] (SOLR-16217) SortingMergePolicy: test coverage for dual-field sort

2022-07-29 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-16217. Fix Version/s: 9.1 main (10.0) Resolution: Fixed > Sortin

[jira] [Commented] (SOLR-16217) SortingMergePolicy: test coverage for dual-field sort

2022-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573015#comment-17573015 ] ASF subversion and git services commented on SOLR-16217: Commit 1

[jira] [Commented] (SOLR-16217) SortingMergePolicy: test coverage for dual-field sort

2022-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573011#comment-17573011 ] ASF subversion and git services commented on SOLR-16217: Commit 5

[GitHub] [solr] cpoerschke merged pull request #883: SOLR-16217: SortingMergePolicy: test coverage for dual-field sort

2022-07-29 Thread GitBox
cpoerschke merged PR #883: URL: https://github.com/apache/solr/pull/883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

[jira] [Commented] (SOLR-16287) MapStream - remap tuple value(s)

2022-07-29 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573010#comment-17573010 ] Christine Poerschke commented on SOLR-16287: {quote}And/Or the reverse transf

[jira] [Commented] (SOLR-16287) MapStream - remap tuple value(s)

2022-07-29 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573007#comment-17573007 ] Christine Poerschke commented on SOLR-16287: I'd wondered about alternatives

[GitHub] [solr] cpoerschke commented on a diff in pull request #954: SOLR-16314: fix warnings about method visibility

2022-07-29 Thread GitBox
cpoerschke commented on code in PR #954: URL: https://github.com/apache/solr/pull/954#discussion_r933306494 ## solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKGEquiv.java: ## @@ -103,7 +103,7 @@ public class TestCloudJSONFacetSKGEquiv extends SolrCloudTestCa

[GitHub] [solr] cpoerschke commented on a diff in pull request #951: SOLR-16304 De-annotate some slow tests

2022-07-29 Thread GitBox
cpoerschke commented on code in PR #951: URL: https://github.com/apache/solr/pull/951#discussion_r933300224 ## gradle/testing/randomization.gradle: ## @@ -85,7 +85,6 @@ allprojects { [propName: 'tests.timezone', value: "random", description: "Sets the default time zo

[GitHub] [solr] cpoerschke commented on a diff in pull request #951: SOLR-16304 De-annotate some slow tests

2022-07-29 Thread GitBox
cpoerschke commented on code in PR #951: URL: https://github.com/apache/solr/pull/951#discussion_r933286618 ## solr/core/src/test/org/apache/solr/security/TestAuthorizationFramework.java: ## @@ -52,53 +55,45 @@ public void distribSetUp() throws Exception { zkStateReader

[GitHub] [solr] limingnihao opened a new pull request, #956: SOLR-16316: Fix debug query clicking on the query UI does not show the debug.explain.structured option

2022-07-29 Thread GitBox
limingnihao opened a new pull request, #956: URL: https://github.com/apache/solr/pull/956 https://issues.apache.org/jira/browse/SOLR-16316 # Description DebugQuery should display the debug.explain.structured option, which can be checked to generate debug.explain.structured=true for

[jira] [Updated] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread Shiming Li (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shiming Li updated SOLR-16316: -- Description: DebugQuery should display the debug.explain.structured option, which can be checked to gen

[jira] [Updated] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread Shiming Li (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shiming Li updated SOLR-16316: -- Affects Version/s: 9.0 9.1 > DebugQuery clicking on the Query UI does not show t

[jira] [Created] (SOLR-16316) DebugQuery clicking on the Query UI does not show the debug.explain.structured option

2022-07-29 Thread Shiming Li (Jira)
Shiming Li created SOLR-16316: - Summary: DebugQuery clicking on the Query UI does not show the debug.explain.structured option Key: SOLR-16316 URL: https://issues.apache.org/jira/browse/SOLR-16316 Projec