[
https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572136#comment-17572136
]
Joel Bernstein edited comment on SOLR-16287 at 7/27/22 9:36 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572136#comment-17572136
]
Joel Bernstein edited comment on SOLR-16287 at 7/27/22 9:36 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572136#comment-17572136
]
Joel Bernstein edited comment on SOLR-16287 at 7/27/22 9:36 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572136#comment-17572136
]
Joel Bernstein commented on SOLR-16287:
---
We could also make the function name speci
HoustonPutman merged PR #460:
URL: https://github.com/apache/solr-operator/pull/460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
gerlowskija commented on PR #460:
URL: https://github.com/apache/solr-operator/pull/460#issuecomment-1197090088
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
gerlowskija closed issue #435: Allow option to pass ZKCLI_JVM_FLAGS to
cloud-scripts zkcli.sh
URL: https://github.com/apache/solr-operator/issues/435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gerlowskija commented on PR #456:
URL: https://github.com/apache/solr-operator/pull/456#issuecomment-1196862728
Hah, but it lets me Approve despite having the latest commits on the branch
🤷
Thanks for the review Houston!
Bit more manual testing but plan to merge this afternoon
gerlowskija merged PR #456:
URL: https://github.com/apache/solr-operator/pull/456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sol
[
https://issues.apache.org/jira/browse/SOLR-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571946#comment-17571946
]
Eric Pugh commented on SOLR-16287:
--
Can you elaborate on NestStream?I think at first
gerlowskija commented on code in PR #456:
URL: https://github.com/apache/solr-operator/pull/456#discussion_r930985956
##
controllers/controller_utils_test.go:
##
@@ -506,36 +507,32 @@ func filterVarsByName(envVars []corev1.EnvVar, f
func(string) bool) []corev1.Env
}
func te
gerlowskija commented on PR #456:
URL: https://github.com/apache/solr-operator/pull/456#issuecomment-1196645422
Alright, I've taken a crack at the remaining TODOs (tests, helm chart
exposure, and docs). This should be ready for review if anyone gets a chance!
--
This is an automated mess
12 matches
Mail list logo