ackepenek commented on PR #934:
URL: https://github.com/apache/solr/pull/934#issuecomment-1179304334
unittest:`org.apache.solr.client.solrj.impl.CloudSolrClientTest.testPerReplicaStateCollection`
is failed but I can not reproduce on my local:
Resolution: Fixed
> Admin UI doesn't allow add
[
https://issues.apache.org/jira/browse/SOLR-16005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564404#comment-17564404
]
ASF subversion and git services commented on SOLR-16005:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564406#comment-17564406
]
ASF subversion and git services commented on SOLR-16005:
Commit f
epugh merged PR #753:
URL: https://github.com/apache/solr/pull/753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
F
ackepenek commented on PR #934:
URL: https://github.com/apache/solr/pull/934#issuecomment-1179255123
@epugh I fixed the broken unit test. I also thought that I add a few unit
tests for expressions but I found some statement inside of [unit
tests](https://github.com/apache/solr/blob/main/sol
anshumg merged PR #29:
URL: https://github.com/apache/solr-sandbox/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
laminelam commented on code in PR #857:
URL: https://github.com/apache/solr/pull/857#discussion_r916945182
##
solr/solrj/src/java/org/apache/solr/common/cloud/acl/DigestZkCredentialsProvider.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
laminelam commented on code in PR #857:
URL: https://github.com/apache/solr/pull/857#discussion_r916920876
##
solr/solrj/src/java/org/apache/solr/common/cloud/DigestZkCredentialsProvider.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
cpoerschke commented on PR #927:
URL: https://github.com/apache/solr/pull/927#issuecomment-1179084190
> > Yea, I don't have strong feelings about leaving the loggers in over
taking them out, do what you gotta do man.
>
> @cpoerschke want to be tie breaker?
No strong views eithe
cpoerschke commented on code in PR #927:
URL: https://github.com/apache/solr/pull/927#discussion_r916884938
##
solr/core/src/test/org/apache/solr/search/TestStressVersions.java:
##
@@ -116,7 +112,6 @@ public void run() {
}
int id = rand.ne
epugh commented on PR #934:
URL: https://github.com/apache/solr/pull/934#issuecomment-1179070871
@ackepenek can you look at why the unit test fails?
```
./gradlew :solr:solrj:test --tests
"org.apache.solr.client.solrj.io.TestLang.testLang" -Ptests.jvms=1
"-Ptests.jvmargs=-XX:Tiere
[
https://issues.apache.org/jira/browse/SOLR-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-15853.
--
Fix Version/s: 9.1
main (10.0)
Resolution: Fixed
> Managed ParamSets in the S
[
https://issues.apache.org/jira/browse/SOLR-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564299#comment-17564299
]
ASF subversion and git services commented on SOLR-15853:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564298#comment-17564298
]
ASF subversion and git services commented on SOLR-15853:
Commit 2
epugh merged PR #923:
URL: https://github.com/apache/solr/pull/923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
F
betulince commented on PR #923:
URL: https://github.com/apache/solr/pull/923#issuecomment-1179022308
Thank you for the review! Can't wait to see it :)
On Wed, Jul 6, 2022, 6:56 PM Eric Pugh ***@***.***> wrote:
> I'd love to get this comitted tomorrow if folks want to review? I'd
epugh commented on PR #934:
URL: https://github.com/apache/solr/pull/934#issuecomment-1179013449
I tested, and this does now run when you pick the "explanation" option. I
wish we had a unit test...
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
epugh commented on PR #927:
URL: https://github.com/apache/solr/pull/927#issuecomment-1178992013
There are enoguh changes, I'll make sure to rerun all the tests when we get
this to ready!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
epugh commented on PR #927:
URL: https://github.com/apache/solr/pull/927#issuecomment-1178981351
> Yea, I don't have strong feelings about leaving the loggers in over taking
them out, do what you gotta do man.
@cpoerschke want to be tie breaker?
--
This is an automated message f
epugh commented on code in PR #927:
URL: https://github.com/apache/solr/pull/927#discussion_r916807573
##
solr/core/src/test/org/apache/solr/handler/ThrowErrorOnInitRequestHandler.java:
##
@@ -1,52 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or mor
epugh commented on code in PR #927:
URL: https://github.com/apache/solr/pull/927#discussion_r916801978
##
solr/core/src/test/org/apache/solr/handler/ThrowErrorOnInitRequestHandler.java:
##
@@ -1,52 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or mor
epugh commented on code in PR #927:
URL: https://github.com/apache/solr/pull/927#discussion_r916800392
##
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##
@@ -377,37 +377,6 @@ public void testEmptyLineBehaviourCSV() throws Exception {
}
}
- publi
epugh commented on code in PR #927:
URL: https://github.com/apache/solr/pull/927#discussion_r916798521
##
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##
@@ -377,37 +377,6 @@ public void testEmptyLineBehaviourCSV() throws Exception {
}
}
- publi
epugh commented on code in PR #927:
URL: https://github.com/apache/solr/pull/927#discussion_r916782318
##
solr/core/src/test/org/apache/solr/cloud/DistributedVersionInfoTest.java:
##
@@ -330,9 +330,8 @@ protected void assertDocsExistInAllReplicas(
if (deletedDocs != nul
cpoerschke commented on code in PR #927:
URL: https://github.com/apache/solr/pull/927#discussion_r916660164
##
solr/core/src/test/org/apache/solr/cloud/TestDistribDocBasedVersion.java:
##
@@ -38,7 +36,6 @@ public class TestDistribDocBasedVersion extends
AbstractFullDistribZkTes
28 matches
Mail list logo
