[jira] [Commented] (SOLR-16263) Migrate tests from deprecate http clients to http2 equivalents

2022-06-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558715#comment-17558715 ] David Smiley commented on SOLR-16263: - I would prefer to take this on Eric if you don

[jira] [Updated] (SOLR-16266) Http2SolrClient: Replace ByteArrayOutputStream.toByteArray() w/BAOS.getbuf()

2022-06-24 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-16266: -- Attachment: SOLR-16266.patch Status: Open (was: Open) > Http2SolrClient: Repla

[jira] [Created] (SOLR-16266) Http2SolrClient: Replace ByteArrayOutputStream.toByteArray() w/BAOS.getbuf()

2022-06-24 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-16266: - Summary: Http2SolrClient: Replace ByteArrayOutputStream.toByteArray() w/BAOS.getbuf() Key: SOLR-16266 URL: https://issues.apache.org/jira/browse/SOLR-16266

[jira] [Commented] (SOLR-16265) reduce memory usage of ContentWriter based requests in Http2SolrClient

2022-06-24 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558690#comment-17558690 ] Chris M. Hostetter commented on SOLR-16265: --- Given that {{Http2SolrClient.creat

[jira] [Created] (SOLR-16265) reduce memory usage of ContentWriter based requests in Http2SolrClient

2022-06-24 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-16265: - Summary: reduce memory usage of ContentWriter based requests in Http2SolrClient Key: SOLR-16265 URL: https://issues.apache.org/jira/browse/SOLR-16265 Projec

[GitHub] [solr] sgift commented on a diff in pull request #913: SOLR-16260: Add support for Instant, LocalDate and ZonedDateTime to JavaBinCodec

2022-06-24 Thread GitBox
sgift commented on code in PR #913: URL: https://github.com/apache/solr/pull/913#discussion_r906395456 ## solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java: ## @@ -1080,6 +1083,15 @@ public boolean writePrimitive(Object val) throws IOException { daos.writ

[GitHub] [solr] HoustonPutman opened a new pull request, #917: SOLR-16264: Set versions for all Antora build tools

2022-06-24 Thread GitBox
HoustonPutman opened a new pull request, #917: URL: https://github.com/apache/solr/pull/917 https://issues.apache.org/jira/browse/SOLR-16264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (SOLR-16258) gradle should not normally use 'errorprone'

2022-06-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558669#comment-17558669 ] Dawid Weiss commented on SOLR-16258: Hi Chris. This looks good to me. > gradle shoul

[GitHub] [solr] madrob commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-24 Thread GitBox
madrob commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r906356207 ## solr/solr-ref-guide/modules/deployment-guide/pages/zookeeper-access-control.adoc: ## @@ -56,9 +56,37 @@ ACLs describe who is allowed to read, update, delete, create, etc.

[jira] [Updated] (SOLR-16261) User guide typo: Backup/Restore Storage Repositories "LocalFileSytemRepository"

2022-06-24 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-16261: --- Fix Version/s: 9.0.1 > User guide typo: Backup/Restore Storage Repositories > "Local

[jira] [Commented] (SOLR-16261) User guide typo: Backup/Restore Storage Repositories "LocalFileSytemRepository"

2022-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558661#comment-17558661 ] ASF subversion and git services commented on SOLR-16261: Commit 4

[GitHub] [solr] cpoerschke opened a new pull request, #916: experimental sub-set 1 of "WIP - Use up to JDK 11 features"

2022-06-24 Thread GitBox
cpoerschke opened a new pull request, #916: URL: https://github.com/apache/solr/pull/916 sub-set of the current #912 changes, experimentally identified with a `./dev-tools/scripts/branchSplitter.py 56842452026` script run (script included in the branch history but not in the branch content

[GitHub] [solr] HoustonPutman commented on pull request #914: SOLR-16261: fix typo in backup-restore.adoc in solr-ref-guide

2022-06-24 Thread GitBox
HoustonPutman commented on PR #914: URL: https://github.com/apache/solr/pull/914#issuecomment-1165797126 @cpoerschke if you backport to 9_0, this will be reflected in the current latest ref guide 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Resolved] (SOLR-16261) User guide typo: Backup/Restore Storage Repositories "LocalFileSytemRepository"

2022-06-24 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-16261. Fix Version/s: 9.1 main (10.0) Resolution: Fixed Thanks [

[jira] [Commented] (SOLR-16261) User guide typo: Backup/Restore Storage Repositories "LocalFileSytemRepository"

2022-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558626#comment-17558626 ] ASF subversion and git services commented on SOLR-16261: Commit 8

[jira] [Commented] (SOLR-16261) User guide typo: Backup/Restore Storage Repositories "LocalFileSytemRepository"

2022-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558624#comment-17558624 ] ASF subversion and git services commented on SOLR-16261: Commit 5

[jira] [Resolved] (SOLR-16237) Broken link to reference guide on index.html for Query Syntax and Parsers

2022-06-24 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16237. --- Fix Version/s: 9.1 9.0.1 Assignee: Houston Putman Resolutio

[GitHub] [solr] cpoerschke merged pull request #914: SOLR-16261: fix typo in backup-restore.adoc in solr-ref-guide

2022-06-24 Thread GitBox
cpoerschke merged PR #914: URL: https://github.com/apache/solr/pull/914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

[jira] [Resolved] (SOLR-16231) Fix ref-guide links across the codebase

2022-06-24 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16231. --- Fix Version/s: 9.1 9.0.1 Resolution: Fixed All links in the 9x rele

[jira] [Commented] (SOLR-16231) Fix ref-guide links across the codebase

2022-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558613#comment-17558613 ] ASF subversion and git services commented on SOLR-16231: Commit 0

[jira] [Created] (SOLR-16264) Set versions for all build tools and dependencies in Antora build

2022-06-24 Thread Houston Putman (Jira)
Houston Putman created SOLR-16264: - Summary: Set versions for all build tools and dependencies in Antora build Key: SOLR-16264 URL: https://issues.apache.org/jira/browse/SOLR-16264 Project: Solr

[jira] [Commented] (SOLR-16231) Fix ref-guide links across the codebase

2022-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558588#comment-17558588 ] ASF subversion and git services commented on SOLR-16231: Commit b

[jira] [Commented] (SOLR-16231) Fix ref-guide links across the codebase

2022-06-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558580#comment-17558580 ] ASF subversion and git services commented on SOLR-16231: Commit 4

[GitHub] [solr] HoustonPutman merged pull request #891: SOLR-16231: Fix links to ref-guide pages

2022-06-24 Thread GitBox
HoustonPutman merged PR #891: URL: https://github.com/apache/solr/pull/891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[GitHub] [solr] risdenk commented on pull request #912: WIP - Use up to JDK 11 features

2022-06-24 Thread GitBox
risdenk commented on PR #912: URL: https://github.com/apache/solr/pull/912#issuecomment-1165760542 @epugh mostly an FYI since you were going through intelli warnings - these are also intellij warnings/findings behind the scenes. -- This is an automated message from the Apache Git Service.

[GitHub] [solr] epugh commented on pull request #912: WIP - Use up to JDK 11 features

2022-06-24 Thread GitBox
epugh commented on PR #912: URL: https://github.com/apache/solr/pull/912#issuecomment-1165759795 I am not really up on the new stuff in JDK 11 @risdenk so probably not the best person to review... ;-) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr-site] HoustonPutman merged pull request #78: Redirect /guide/solr to /guide/solr/latest

2022-06-24 Thread GitBox
HoustonPutman merged PR #78: URL: https://github.com/apache/solr-site/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.ap

[GitHub] [solr] cpoerschke commented on a diff in pull request #904: SOLR-16246: Introduced pre-filtering in KnnQParser

2022-06-24 Thread GitBox
cpoerschke commented on code in PR #904: URL: https://github.com/apache/solr/pull/904#discussion_r906238869 ## solr/core/src/java/org/apache/solr/search/QueryUtils.java: ## @@ -215,4 +221,38 @@ public static Query combineQueryAndFilter(Query scoreQuery, Query filterQuery) {

[GitHub] [solr-site] HoustonPutman commented on pull request #78: Redirect /guide/solr to /guide/solr/latest

2022-06-24 Thread GitBox
HoustonPutman commented on PR #78: URL: https://github.com/apache/solr-site/pull/78#issuecomment-1165755994 Related to https://github.com/apache/solr/pull/891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [solr-site] HoustonPutman opened a new pull request, #78: Redirect /guide/solr to /guide/solr/latest

2022-06-24 Thread GitBox
HoustonPutman opened a new pull request, #78: URL: https://github.com/apache/solr-site/pull/78 This is much like this line generated by antora: https://github.com/apache/solr-site/blob/main/themes/solr/templates/htaccess.ref-guide-antora#L2, however without the requirement to have `index.ht

[jira] [Created] (SOLR-16263) Migrate tests from deprecate http clients to http2 equivalents

2022-06-24 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16263: Summary: Migrate tests from deprecate http clients to http2 equivalents Key: SOLR-16263 URL: https://issues.apache.org/jira/browse/SOLR-16263 Project: Solr Issue Ty

[GitHub] [solr] HoustonPutman commented on a diff in pull request #891: SOLR-16231: Fix links to ref-guide pages

2022-06-24 Thread GitBox
HoustonPutman commented on code in PR #891: URL: https://github.com/apache/solr/pull/891#discussion_r906211336 ## README.md: ## @@ -28,7 +28,7 @@ result faceting and highlighting. ## Online Documentation This README file only contains basic setup instructions. For more -com

[GitHub] [solr] HoustonPutman commented on a diff in pull request #891: SOLR-16231: Fix links to ref-guide pages

2022-06-24 Thread GitBox
HoustonPutman commented on code in PR #891: URL: https://github.com/apache/solr/pull/891#discussion_r906211336 ## README.md: ## @@ -28,7 +28,7 @@ result faceting and highlighting. ## Online Documentation This README file only contains basic setup instructions. For more -com

[GitHub] [solr] HoustonPutman commented on a diff in pull request #913: SOLR-16260: Add support for Instant, LocalDate and ZonedDateTime to JavaBinCodec

2022-06-24 Thread GitBox
HoustonPutman commented on code in PR #913: URL: https://github.com/apache/solr/pull/913#discussion_r906209908 ## solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java: ## @@ -1080,6 +1083,15 @@ public boolean writePrimitive(Object val) throws IOException { d

[jira] [Updated] (SOLR-16258) gradle should not normally use 'errorprone'

2022-06-24 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-16258: -- Attachment: SOLR-16258.patch Assignee: Chris M. Hostetter Status: Open (w

[GitHub] [solr] epugh commented on a diff in pull request #891: SOLR-16231: Fix links to ref-guide pages

2022-06-24 Thread GitBox
epugh commented on code in PR #891: URL: https://github.com/apache/solr/pull/891#discussion_r906195750 ## README.md: ## @@ -28,7 +28,7 @@ result faceting and highlighting. ## Online Documentation This README file only contains basic setup instructions. For more -comprehensi

[GitHub] [solr-operator] susheelks opened a new issue, #448: Allow option to specify init-containers (check-zk, cp-solr-xml etc.) resources when ResourcesQuota is in place

2022-06-24 Thread GitBox
susheelks opened a new issue, #448: URL: https://github.com/apache/solr-operator/issues/448 Currently Solr operator doesn't allow setting init-containers resource limits and resulting into Solr pods to fail when ResourceQuota is in place. Error === create Pod wm-solrcloud-0 in

[jira] [Resolved] (SOLR-16212) DocBasedVersionConstraintsProcessor's deleteById creates non existing docs

2022-06-24 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine resolved SOLR-16212. --- Resolution: Won't Fix   I feel this is not solvable in the state of the art. The issue here is you cannot m

[jira] [Updated] (SOLR-16212) DocBasedVersionConstraintsProcessor's deleteById creates non existing docs

2022-06-24 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16212: -- Description:  Calling _deleteById_ in _DocBasedVersionConstraintsProcessor_ adds the document (As tombstone) e

[jira] [Updated] (SOLR-16212) DocBasedVersionConstraintsProcessor's deleteById creates non existing docs

2022-06-24 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16212: -- Description:  Calling _deleteById_ in _DocBasedVersionConstraintsProcessor_ adds the document (As tombstone) e

[jira] [Updated] (SOLR-16212) DocBasedVersionConstraintsProcessor's deleteById creates non existing docs

2022-06-24 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16212: -- Description:  Calling deleteById in adds the documents (As tombstone) even if the doc does not exist.    

[jira] [Updated] (SOLR-16212) DocBasedVersionConstraintsProcessor's deleteById creates non existing docs

2022-06-24 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16212: -- Description:  Calling _deleteById_ in _DocBasedVersionConstraintsProcessor_ adds the document (As tombstone) e

[jira] [Updated] (SOLR-16212) DocBasedVersionConstraintsProcessor's deleteById creates non existing docs

2022-06-24 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16212: -- Description:  Calling deleteById in adds the documents (As tombestone) even if the doc does not exist.    

[GitHub] [solr] sgift commented on a diff in pull request #913: SOLR-16260: Add support for Instant, LocalDate and ZonedDateTime to JavaBinCodec

2022-06-24 Thread GitBox
sgift commented on code in PR #913: URL: https://github.com/apache/solr/pull/913#discussion_r905825991 ## solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java: ## @@ -24,6 +24,10 @@ import java.lang.invoke.MethodHandles; import java.nio.ByteBuffer; import java.ni