[jira] [Commented] (SOLR-16002) FilterQuery (`filter([some_query])`) can be double-cached when used in certain contexts

2022-02-13 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491816#comment-17491816 ] Mikhail Khludnev commented on SOLR-16002: - +1 > FilterQuery (`filter([some_query

[GitHub] [solr] mkhludnev commented on pull request #625: SOLR-16004: Add support for minShouldMatch and tolerateOtherTerms in {!terms} TermsQParserPlugin

2022-02-13 Thread GitBox
mkhludnev commented on pull request #625: URL: https://github.com/apache/solr/pull/625#issuecomment-1038705030 Hi. Briefly looked through. Seems like something what make sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (SOLR-15949) Use Java 17 in docker

2022-02-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491808#comment-17491808 ] ASF subversion and git services commented on SOLR-15949: Commit c

[GitHub] [solr] dsmiley merged pull request #556: SOLR-15949: Docker, use Java 17

2022-02-13 Thread GitBox
dsmiley merged pull request #556: URL: https://github.com/apache/solr/pull/556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] dsmiley commented on a change in pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-13 Thread GitBox
dsmiley commented on a change in pull request #624: URL: https://github.com/apache/solr/pull/624#discussion_r805495496 ## File path: solr/core/src/test/org/apache/solr/search/TestFiltersQueryCaching.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [solr] mkhludnev commented on a change in pull request #623: WIP {!join cacheEventually=true ...}...

2022-02-13 Thread GitBox
mkhludnev commented on a change in pull request #623: URL: https://github.com/apache/solr/pull/623#discussion_r80464 ## File path: solr/core/src/java/org/apache/solr/search/JoinQParserPlugin.java ## @@ -194,6 +195,47 @@ public QParser createParser(String qstr, SolrParams l

[GitHub] [solr] risdenk commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-02-13 Thread GitBox
risdenk commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1037254994 So I pushed changes that address most of the review comments so far. There is a big change that helps alleviate future Hadoop dependency issues. This uses the `hadoop-client-api`, `

[GitHub] [solr] risdenk edited a comment on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-02-13 Thread GitBox
risdenk edited a comment on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1035162389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [solr] dsmiley commented on a change in pull request #624: SOLR-16002: don't double-cache FilterQuery

2022-02-13 Thread GitBox
dsmiley commented on a change in pull request #624: URL: https://github.com/apache/solr/pull/624#discussion_r805215814 ## File path: solr/core/src/test/org/apache/solr/search/TestFiltersQueryCaching.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #560: SOLR-15951: Local packages

2022-02-13 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r805289794 ## File path: solr/core/src/java/org/apache/solr/util/PackageTool.java ## @@ -105,12 +120,38 @@ protected void runImpl(CommandLine cli) throws Excep

[GitHub] [solr] dsmiley commented on pull request #617: SOLR-15991: analysis-extras module tests shouldn't rely on log4j dependency

2022-02-13 Thread GitBox
dsmiley commented on pull request #617: URL: https://github.com/apache/solr/pull/617#issuecomment-1037543173 BTW this sort of minor detail doesn't need a JIRA or CHANGES.txt entry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [solr] risdenk commented on a change in pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-02-13 Thread GitBox
risdenk commented on a change in pull request #553: URL: https://github.com/apache/solr/pull/553#discussion_r805171301 ## File path: solr/test-framework/src/java/org/apache/solr/util/BadHdfsThreadsFilter.java ## @@ -41,6 +41,10 @@ public boolean reject(Thread t) { retur

[GitHub] [solr] uschindler merged pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler merged pull request #631: URL: https://github.com/apache/solr/pull/631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr-site] epugh merged pull request #71: SOLR-15432: update link to current irc home

2022-02-13 Thread GitBox
epugh merged pull request #71: URL: https://github.com/apache/solr-site/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [solr] uschindler edited a comment on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler edited a comment on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038279478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [solr] epugh commented on pull request #495: SOLR-15116: Support a HEAD request for managed resources

2022-02-13 Thread GitBox
epugh commented on pull request #495: URL: https://github.com/apache/solr/pull/495#issuecomment-1037318826 I've done a bit more poking @gerlowskija and haven't had much luck.I'm going to go with committing what I have, and closing it. -- This is an automated message from the Apache G

[GitHub] [solr] epugh merged pull request #495: SOLR-15116: Support a HEAD request for managed resources

2022-02-13 Thread GitBox
epugh merged pull request #495: URL: https://github.com/apache/solr/pull/495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@so

[GitHub] [solr] epugh commented on pull request #630: SOLR-13737 Moving SolrCloud up on the README

2022-02-13 Thread GitBox
epugh commented on pull request #630: URL: https://github.com/apache/solr/pull/630#issuecomment-1038011302 How does this look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [solr] uschindler commented on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler commented on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038279478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [solr] uschindler edited a comment on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler edited a comment on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038366508 Oh, Windows does not allow symlinks, so in the git checkout are just files that contain the file name. No symlink. Why the hell do we have symlinks in the git checko

[jira] [Commented] (SOLR-14290) Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x

2022-02-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491708#comment-17491708 ] Jan Høydahl commented on SOLR-14290: Ok, who prepares the PR for this? One of the las

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491679#comment-17491679 ] Uwe Schindler commented on SOLR-15556: -- Hi, looks like on Policeman Jenkins the git

[jira] [Resolved] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved SOLR-15556. -- Resolution: Fixed > Ref Guide Redesign Phase 3: Replace Jekyll > --

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491676#comment-17491676 ] Uwe Schindler commented on SOLR-15556: -- Hi, after merging the PR to main, 9x and 9.0

[GitHub] [solr] uschindler merged pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler merged pull request #631: URL: https://github.com/apache/solr/pull/631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] uschindler commented on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler commented on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038366508 Oh, Windows does not allow symlinks, so in the git checkout are just files that contain the file name. No symlink. Why the hell do we have symlinks in the git checkout? Not

[GitHub] [solr] uschindler commented on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler commented on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038354645 Ah I know where this comes from... I am looking for a fix. In short: All the example java files only contain the target path of the file. On linux the contents are there.

[jira] [Commented] (SOLR-15913) Override the use of the word Overriden with Overridden in Code

2022-02-13 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491657#comment-17491657 ] Eric Pugh commented on SOLR-15913: -- I wonder if there is a way to add words like this to

[GitHub] [solr] epugh opened a new pull request #632: SOLR-15913: fix typo for word overridden

2022-02-13 Thread GitBox
epugh opened a new pull request #632: URL: https://github.com/apache/solr/pull/632 https://issues.apache.org/jira/browse/SOLR-15913 # Description Spelling error has crept in. # Solution Fix spelling. # Tests Ran tests. # Checklist Pleas

[GitHub] [solr] uschindler edited a comment on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler edited a comment on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038291525 While building the site on Windows it still produces a load of warnings in JSON format: Mainly messages like this: `"msg":"tag 'solrj-json-query-macro-expansion' no

[GitHub] [solr] uschindler commented on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler commented on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038291525 While building the site on Windows it still produces a load of warnings in JSON format: ``` > Task :solr:solr-ref-guide:buildLocalAntoraSite {"level":"warn","time":1

[GitHub] [solr] uschindler edited a comment on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler edited a comment on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038290447 I fixed the link to the Solr Javadocs page, it was not related to source_url, but extraArgs passed to NPN. The link must be a valid URL, not some FS path. ```groovy

[GitHub] [solr] uschindler commented on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler commented on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038290447 I fixed the link to the Solr Javadocs page, it was not related to source_url, but extraArgs passed to NPN: ```groovy "--attribute", "page-solr-javadocs=${project(':so

[GitHub] [solr] uschindler edited a comment on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler edited a comment on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038279478 This still has a problem with the source_url, because on WIndows it does not start with "/". We need to convert it to a real URL instead of a plain file system path.

[GitHub] [solr] uschindler commented on pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler commented on pull request #631: URL: https://github.com/apache/solr/pull/631#issuecomment-1038279478 This still has a problem with the source_url, because on WIndows it does not start with "/". We need to convert it to a real URL instead of a plain file system path. -- This i

[jira] [Comment Edited] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491629#comment-17491629 ] Uwe Schindler edited comment on SOLR-15556 at 2/13/22, 5:07 PM: ---

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491629#comment-17491629 ] Uwe Schindler commented on SOLR-15556: -- What do we learn: When ever you do templatin

[jira] [Comment Edited] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491611#comment-17491611 ] Uwe Schindler edited comment on SOLR-15556 at 2/13/22, 5:03 PM: ---

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491628#comment-17491628 ] Uwe Schindler commented on SOLR-15556: -- I opened PR: https://github.com/apache/solr/

[GitHub] [solr] uschindler opened a new pull request #631: Fix escaping in playbook/antora templates: Use single quotes and escape all single quotes by duplicating them

2022-02-13 Thread GitBox
uschindler opened a new pull request #631: URL: https://github.com/apache/solr/pull/631 See https://issues.apache.org/jira/browse/SOLR-15556?focusedCommentId=17491611&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17491611 -- This is an automated message fr

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491611#comment-17491611 ] Uwe Schindler commented on SOLR-15556: -- I figured out what the problem is: The new b

[jira] [Comment Edited] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491599#comment-17491599 ] Uwe Schindler edited comment on SOLR-15556 at 2/13/22, 3:21 PM: ---

[jira] [Reopened] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-13 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reopened SOLR-15556: -- Hi, on Jenkins (Windows) and on my local windows machine, the ANtora Build fails for some reason n

[jira] [Commented] (SOLR-15853) Managed ParamSets in the Solr Admin

2022-02-13 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491578#comment-17491578 ] Eric Pugh commented on SOLR-15853: -- Hey [~betulince]I finally got to try out the code, a

[jira] [Assigned] (SOLR-15853) Managed ParamSets in the Solr Admin

2022-02-13 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-15853: Assignee: Eric Pugh > Managed ParamSets in the Solr Admin > --- >

[GitHub] [solr] epugh commented on pull request #630: SOLR-13737 Moving SolrCloud up on the README

2022-02-13 Thread GitBox
epugh commented on pull request #630: URL: https://github.com/apache/solr/pull/630#issuecomment-1038011302 How does this look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co