[GitHub] [solr] dsmiley opened a new pull request #583: SOLR-14686: fix MDC log clear in SolrCore.close

2022-01-31 Thread GitBox
dsmiley opened a new pull request #583: URL: https://github.com/apache/solr/pull/583 https://issues.apache.org/jira/browse/SOLR-14686 Fixing my mistake. Ensure MDC is cleared right before this method returns. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [solr] dsmiley commented on a change in pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar

2022-01-31 Thread GitBox
dsmiley commented on a change in pull request #582: URL: https://github.com/apache/solr/pull/582#discussion_r796219783 ## File path: versions.lock ## @@ -29,7 +29,7 @@ com.google.cloud:google-cloud-core:1.94.3 (3 constraints: da2307c0) com.google.cloud:google-cloud-core-http:

[GitHub] [solr] madrob commented on a change in pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar

2022-01-31 Thread GitBox
madrob commented on a change in pull request #582: URL: https://github.com/apache/solr/pull/582#discussion_r796202923 ## File path: solr/modules/gcs-repository/build.gradle ## @@ -51,6 +56,7 @@ dependencies { implementation('io.opencensus:opencensus-api') { transitive = fa

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-01-31 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r796191450 ## File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java ## @@ -96,6 +95,6 @@ public Weight createWeight(IndexSearcher searcher, Scor

[GitHub] [solr] janhoy opened a new pull request #582: SOLR-15966 Get rid of WEB-INF/lib/jsr305-3.0.2.jar

2022-01-31 Thread GitBox
janhoy opened a new pull request #582: URL: https://github.com/apache/solr/pull/582 https://issues.apache.org/jira/browse/SOLR-15966 WIP attempt of excluding jsr305 and javax.annotations jars from the release. I did a full `gradlew check` on this branch, and it succeeded, so I

[GitHub] [solr] madrob commented on a change in pull request #581: SOLR-15852 Update smoketester for 9.0

2022-01-31 Thread GitBox
madrob commented on a change in pull request #581: URL: https://github.com/apache/solr/pull/581#discussion_r796170114 ## File path: dev-tools/scripts/scriptutil.py ## @@ -156,7 +156,10 @@ def download(name, urlString, tmpDir, quiet=False, force_clean=True): def attemptDow

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-01-31 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r796137646 ## File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java ## @@ -96,6 +95,6 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode scoreM

[GitHub] [solr] janhoy opened a new pull request #581: SOLR-15852 Update smoketester for 9.0

2022-01-31 Thread GitBox
janhoy opened a new pull request #581: URL: https://github.com/apache/solr/pull/581 https://issues.apache.org/jira/browse/SOLR-15852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-01-31 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r794843972 ## File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java ## @@ -96,6 +95,6 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode scoreM

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-01-31 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r794843972 ## File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java ## @@ -96,6 +95,6 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode scoreM

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-01-31 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r796137646 ## File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java ## @@ -96,6 +95,6 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode scoreM

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-01-31 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r796128037 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-01-31 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r796128037 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-01-31 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r796127161 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java ## @@ -234,9 +234,8 @@ public Query createDomainQuery(FacetContext fcontext) thr

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-01-31 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484976#comment-17484976 ] Houston Putman commented on SOLR-15556: --- I've pushed some changes now. * {{antora.

[GitHub] [solr] markrmiller commented on pull request #574: Configuring a shardHandlerFactory on the /select requestHandler results in HTTP 401 when searching on alias in secured Solr

2022-01-31 Thread GitBox
markrmiller commented on pull request #574: URL: https://github.com/apache/solr/pull/574#issuecomment-1026273549 No should be good if you want to take a look. Just marked it as draft because I had converted it from 8x and didn't know if a fail I was seeing consistently was somehow related,

[GitHub] [solr] iMichka commented on pull request #250: SOLR-15558: Identify zombie processes when stopping

2022-01-31 Thread GitBox
iMichka commented on pull request #250: URL: https://github.com/apache/solr/pull/250#issuecomment-1026260307 Hi. I am maintainer of Homebrew, a package manager for macOS and Linux. We build and test `solr` in docker, and we have been hit by this issue. I tested your patch https://githu

[GitHub] [solr] anshumg commented on pull request #574: Configuring a shardHandlerFactory on the /select requestHandler results in HTTP 401 when searching on alias in secured Solr

2022-01-31 Thread GitBox
anshumg commented on pull request #574: URL: https://github.com/apache/solr/pull/574#issuecomment-1026244621 Hey @markrmiller, is this still a draft ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Updated] (SOLR-15966) Get rid of WEB-INF/lib/jsr305-3.0.2.jar

2022-01-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15966: --- Description: Smoke tester found this {code:java} RuntimeError: JAR file "/private/tmp/smoke_solr_9.0

[jira] [Updated] (SOLR-15966) Get rid of WEB-INF/lib/jsr305-3.0.2.jar

2022-01-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15966: --- Fix Version/s: 9.0 > Get rid of WEB-INF/lib/jsr305-3.0.2.jar > --

[jira] [Commented] (SOLR-15966) Get rid of WEB-INF/lib/jsr305-3.0.2.jar

2022-01-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484954#comment-17484954 ] Jan Høydahl commented on SOLR-15966: I did not manage to get rid of it unless I added

[jira] [Updated] (SOLR-15966) Get rid of WEB-INF/lib/jsr305-3.0.2.jar

2022-01-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15966: --- Priority: Blocker (was: Major) > Get rid of WEB-INF/lib/jsr305-3.0.2.jar > -

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-31 Thread Istvan Farkas (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484952#comment-17484952 ] Istvan Farkas commented on SOLR-14660: -- Thanks for all the help [~krisden], [~dsmile

[jira] [Created] (SOLR-15966) Get rid of WEB-INF/lib/jsr305-3.0.2.jar from gradle build

2022-01-31 Thread Jira
Jan Høydahl created SOLR-15966: -- Summary: Get rid of WEB-INF/lib/jsr305-3.0.2.jar from gradle build Key: SOLR-15966 URL: https://issues.apache.org/jira/browse/SOLR-15966 Project: Solr Issue Type

[jira] [Updated] (SOLR-15966) Get rid of WEB-INF/lib/jsr305-3.0.2.jar

2022-01-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15966: --- Summary: Get rid of WEB-INF/lib/jsr305-3.0.2.jar (was: Get rid of WEB-INF/lib/jsr305-3.0.2.jar from

[GitHub] [solr] risdenk commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-31 Thread GitBox
risdenk commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1026217867 Now that SOLR-14660 has been merged - working on cleaning this up. I put it back in draft for now. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [solr] risdenk commented on pull request #324: SOLR-14660 - move HDFS to a module

2022-01-31 Thread GitBox
risdenk commented on pull request #324: URL: https://github.com/apache/solr/pull/324#issuecomment-1026198195 Big shout out to @warperwolf who did 99% of the heavy lifting here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (SOLR-14660) Migrating HDFS into a module

2022-01-31 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-14660: Resolution: Fixed Status: Resolved (was: Patch Available) All credit for this goes to [~wa

[GitHub] [solr] risdenk closed pull request #324: SOLR-14660 - move HDFS to a module

2022-01-31 Thread GitBox
risdenk closed pull request #324: URL: https://github.com/apache/solr/pull/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484937#comment-17484937 ] ASF subversion and git services commented on SOLR-14660: Commit 7

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484938#comment-17484938 ] ASF subversion and git services commented on SOLR-14660: Commit f

[GitHub] [solr] risdenk commented on pull request #324: SOLR-14660 - move HDFS to a module

2022-01-31 Thread GitBox
risdenk commented on pull request #324: URL: https://github.com/apache/solr/pull/324#issuecomment-1026197123 Merged in https://github.com/apache/solr/commit/cb2e58f6569704c45387a8d094625ba8e014776b -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484935#comment-17484935 ] ASF subversion and git services commented on SOLR-14660: Commit c

[jira] [Commented] (SOLR-15942) Upgrade Hadoop to 3.3.1

2022-01-31 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484842#comment-17484842 ] Kevin Risden commented on SOLR-15942: - Thanks Mike - yea agree on both parts. > Upgr

[jira] [Commented] (SOLR-15942) Upgrade Hadoop to 3.3.1

2022-01-31 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484798#comment-17484798 ] Mike Drob commented on SOLR-15942: -- Can we benefit from HADOOP-15681 and remove some of

[GitHub] [solr] murblanc commented on pull request #580: SOLR-15964: Transient cores: don't evict open ones

2022-01-31 Thread GitBox
murblanc commented on pull request #580: URL: https://github.com/apache/solr/pull/580#issuecomment-1026003814 I assume that in purpose for now only the test is in the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Resolved] (SOLR-15956) Add documentation for creating a docker image from the binary distribution

2022-01-31 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-15956. --- Resolution: Done > Add documentation for creating a docker image from the binary distribution

[jira] [Commented] (SOLR-15956) Add documentation for creating a docker image from the binary distribution

2022-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484774#comment-17484774 ] ASF subversion and git services commented on SOLR-15956: Commit 9

[jira] [Commented] (SOLR-15956) Add documentation for creating a docker image from the binary distribution

2022-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484773#comment-17484773 ] ASF subversion and git services commented on SOLR-15956: Commit b

[jira] [Commented] (SOLR-15956) Add documentation for creating a docker image from the binary distribution

2022-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484767#comment-17484767 ] ASF subversion and git services commented on SOLR-15956: Commit f

[GitHub] [solr] HoustonPutman merged pull request #572: SOLR-15956: Docs for building a Docker image from the TGZ

2022-01-31 Thread GitBox
HoustonPutman merged pull request #572: URL: https://github.com/apache/solr/pull/572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [solr] dsmiley opened a new pull request #580: SOLR-15964: Transient cores: don't evict open ones

2022-01-31 Thread GitBox
dsmiley opened a new pull request #580: URL: https://github.com/apache/solr/pull/580 https://issues.apache.org/jira/browse/SOLR-15964 First commit shows the test that fails, subsequent will fix the bug. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [solr] epugh commented on pull request #577: SOLR-15745: Convert remaining 'core-admin' v2 APIs to annotations

2022-01-31 Thread GitBox
epugh commented on pull request #577: URL: https://github.com/apache/solr/pull/577#issuecomment-1025861321 Looks great, I love seeing some of those "shim" like classes like `CoreApiMapping` get removed in favour of what seems more straightforward java code! -- This is an automated messa

[GitHub] [solr] epugh commented on a change in pull request #577: SOLR-15745: Convert remaining 'core-admin' v2 APIs to annotations

2022-01-31 Thread GitBox
epugh commented on a change in pull request #577: URL: https://github.com/apache/solr/pull/577#discussion_r795760367 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/PrepareCoreRecoveryPayload.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

[GitHub] [solr] epugh commented on a change in pull request #577: SOLR-15745: Convert remaining 'core-admin' v2 APIs to annotations

2022-01-31 Thread GitBox
epugh commented on a change in pull request #577: URL: https://github.com/apache/solr/pull/577#discussion_r795758440 ## File path: solr/core/src/java/org/apache/solr/handler/admin/api/RequestCoreCommandStatusAPI.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] [solr] asalamon74 commented on a change in pull request #462: SOLR-15830 Concurrent core reloads mess up commits when using Schema API

2022-01-31 Thread GitBox
asalamon74 commented on a change in pull request #462: URL: https://github.com/apache/solr/pull/462#discussion_r795691216 ## File path: solr/core/src/test-files/solr/configsets/cloud-managed-autocommit/conf/solrconfig.xml ## @@ -0,0 +1,61 @@ + + + + + + + + + ${solr.data.dir:

[jira] [Created] (SOLR-15964) Transient cores should not be unloaded/evicted while it's being used

2022-01-31 Thread David Smiley (Jira)
David Smiley created SOLR-15964: --- Summary: Transient cores should not be unloaded/evicted while it's being used Key: SOLR-15964 URL: https://issues.apache.org/jira/browse/SOLR-15964 Project: Solr

[jira] [Commented] (SOLR-15959) Deprecate loading of solr.xml from ZK

2022-01-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484607#comment-17484607 ] Jan Høydahl commented on SOLR-15959: Name change could help people visualize what sho