[GitHub] [solr-operator] HoustonPutman merged pull request #361: Add support for more ZK Pod options.

2021-11-03 Thread GitBox
HoustonPutman merged pull request #361: URL: https://github.com/apache/solr-operator/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr] thelabdude merged pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude merged pull request #394: URL: https://github.com/apache/solr/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr-operator] HoustonPutman closed issue #347: Remove SolrBackup Persistence option

2021-11-03 Thread GitBox
HoustonPutman closed issue #347: URL: https://github.com/apache/solr-operator/issues/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr] mkhludnev edited a comment on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
mkhludnev edited a comment on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-959942709 @madrob, honestly, I hardly follow. > we don't want to change things to strict. .. then we log it and ask the person to create an issue we do logging when refcoun

[GitHub] [solr] cpoerschke commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI

2021-11-03 Thread GitBox
cpoerschke commented on a change in pull request #392: URL: https://github.com/apache/solr/pull/392#discussion_r742143497 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType)) return new ZkMkrootTool

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #288: SOLR-15705: A deleteById request without _route_ param for compositeid or implicit router could be sent to all shard lead

2021-11-03 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #288: URL: https://github.com/apache/solr/pull/288#discussion_r742198500 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java ## @@ -383,47 +419,7 @@ protected void doDelete

[GitHub] [solr] markrmiller closed pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

2021-11-03 Thread GitBox
markrmiller closed pull request #311: URL: https://github.com/apache/solr/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [solr-operator] HoustonPutman commented on pull request #358: Specify individual backupRepo availability in SolrCloud Status

2021-11-03 Thread GitBox
HoustonPutman commented on pull request #358: URL: https://github.com/apache/solr-operator/pull/358#issuecomment-960252308 Will test (and fix if need be) and merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [solr] cpoerschke commented on a change in pull request #288: SOLR-15705: A deleteById request without _route_ param for compositeid or implicit router could be sent to all shard leaders

2021-11-03 Thread GitBox
cpoerschke commented on a change in pull request #288: URL: https://github.com/apache/solr/pull/288#discussion_r742125759 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java ## @@ -316,6 +317,41 @@ public void processDelete(Delet

[GitHub] [solr] madrob commented on a change in pull request #389: SOLR-15477: Logging Performance

2021-11-03 Thread GitBox
madrob commented on a change in pull request #389: URL: https://github.com/apache/solr/pull/389#discussion_r742170960 ## File path: solr/bin/solr ## @@ -1973,7 +1973,7 @@ fi LOG4J_CONFIG=() if [ -n "$LOG4J_PROPS" ]; then - LOG4J_CONFIG+=("-Dlog4j.configurationFile=$LOG4J_P

[GitHub] [solr] thelabdude merged pull request #393: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude merged pull request #393: URL: https://github.com/apache/solr/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] madrob commented on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
madrob commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-960003705 I thought the problem here was that we end up calling close too many times, right? So like on SolrCore, if we call close on the hook multiple times we could log about it instead of s

[GitHub] [solr] janhoy commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI

2021-11-03 Thread GitBox
janhoy commented on a change in pull request #392: URL: https://github.com/apache/solr/pull/392#discussion_r742244476 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType)) return new ZkMkrootTool();

[GitHub] [solr-operator] HoustonPutman merged pull request #357: Remove Persistence option for SolrBackup.

2021-11-03 Thread GitBox
HoustonPutman merged pull request #357: URL: https://github.com/apache/solr-operator/pull/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr] madrob commented on pull request #338: @sayandigital SOLR-13182 - NullPointerException

2021-11-03 Thread GitBox
madrob commented on pull request #338: URL: https://github.com/apache/solr/pull/338#issuecomment-959367416 I think this looks fine to me, but I'm thinking about whether it makes more sense to return a useful error message in this case rather than silently defaulting to no parent query. @ds

[GitHub] [solr] markrmiller closed pull request #300: SOLR-15644: Test thread leak management.

2021-11-03 Thread GitBox
markrmiller closed pull request #300: URL: https://github.com/apache/solr/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [solr] epugh commented on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
epugh commented on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959966356 Thanks! WE are getting closer to our magic future of just having everything delegate credential look ups! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [solr] janhoy commented on pull request #375: SOLR-15728: Remove dead, unused log rotation code from SolrCLI

2021-11-03 Thread GitBox
janhoy commented on pull request #375: URL: https://github.com/apache/solr/pull/375#issuecomment-959285752 > Seems to be a test problem: https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/ Yep, there are java unit tests that should also have been removed. Will handle now. -

[GitHub] [solr] markrmiller commented on pull request #300: SOLR-15644: Test thread leak management.

2021-11-03 Thread GitBox
markrmiller commented on pull request #300: URL: https://github.com/apache/solr/pull/300#issuecomment-958959533 Won't do. Will avoid ideal solution for these rarer of cases, will do waits / hacks / alternatives in line with current approaches in individual issues as necessary. -- This i

[GitHub] [solr] janhoy merged pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI

2021-11-03 Thread GitBox
janhoy merged pull request #392: URL: https://github.com/apache/solr/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] dweiss commented on pull request #349: Dependency tune-up of solr-core

2021-11-03 Thread GitBox
dweiss commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-958724294 > I'm confused about versions.props. I thought this pinned our versions but it seems not because this is what is in there: > org.codehaus.janino:*=3.0.9 > Yet Gradle selected 3.0

[GitHub] [solr] dsmiley merged pull request #349: Dependency tune-up of solr-core

2021-11-03 Thread GitBox
dsmiley merged pull request #349: URL: https://github.com/apache/solr/pull/349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] markrmiller merged pull request #367: SOLR-15647: TestRebalanceLeaders#testRebalanceLeaders can be abysmall…

2021-11-03 Thread GitBox
markrmiller merged pull request #367: URL: https://github.com/apache/solr/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [solr] markrmiller commented on pull request #375: SOLR-15728: Remove dead, unused log rotation code from SolrCLI

2021-11-03 Thread GitBox
markrmiller commented on pull request #375: URL: https://github.com/apache/solr/pull/375#issuecomment-958681681 Seems to be a test problem: https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/ -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [solr] thelabdude commented on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude commented on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959941548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [solr] thelabdude edited a comment on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude edited a comment on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959956128 Yeah, just verified ... `"role": null` doesn't do anything when just using the `BasicAuthPlugin` unless `"blockUnknown": false` ... here's my config: ``` authenticatio

[GitHub] [solr] madrob commented on pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-11-03 Thread GitBox
madrob commented on pull request #160: URL: https://github.com/apache/solr/pull/160#issuecomment-959382186 It's a wildcard import and we generally stay away from those as a project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [solr] markrmiller commented on pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

2021-11-03 Thread GitBox
markrmiller commented on pull request #311: URL: https://github.com/apache/solr/pull/311#issuecomment-958967962 This can be worked around using the system property that disables all secure random usage. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [solr] epugh commented on pull request #393: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
epugh commented on pull request #393: URL: https://github.com/apache/solr/pull/393#issuecomment-959616329 Quick read through and LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] cpoerschke commented on pull request #288: SOLR-15705: A deleteById request without _route_ param for compositeid or implicit router could be sent to all shard leaders

2021-11-03 Thread GitBox
cpoerschke commented on pull request #288: URL: https://github.com/apache/solr/pull/288#issuecomment-959652732 > This also affected the Implicit Router as it will now broadcast the delete-by-id request if the route is missing, so I updated a failing test. I'd like some feedback on this, as

[GitHub] [solr] mkhludnev commented on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
mkhludnev commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-959942709 @madrob, honestly, I hardly follow. > we don't want to change things to strict. .. then we log it and ask the person to create an issue we do logging when refcount==-1, but

[GitHub] [solr-operator] HoustonPutman closed issue #352: Add possibility to annotate zookeeper to trigger rolling update

2021-11-03 Thread GitBox
HoustonPutman closed issue #352: URL: https://github.com/apache/solr-operator/issues/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman closed issue #352: Add possibility to annotate zookeeper to trigger rolling update

2021-11-03 Thread GitBox
HoustonPutman closed issue #352: URL: https://github.com/apache/solr-operator/issues/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr] dweiss commented on pull request #349: Dependency tune-up of solr-core

2021-11-03 Thread GitBox
dweiss commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-958724294 > I'm confused about versions.props. I thought this pinned our versions but it seems not because this is what is in there: > org.codehaus.janino:*=3.0.9 > Yet Gradle selected 3.0

[GitHub] [solr] dsmiley merged pull request #349: Dependency tune-up of solr-core

2021-11-03 Thread GitBox
dsmiley merged pull request #349: URL: https://github.com/apache/solr/pull/349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] markrmiller commented on pull request #375: SOLR-15728: Remove dead, unused log rotation code from SolrCLI

2021-11-03 Thread GitBox
markrmiller commented on pull request #375: URL: https://github.com/apache/solr/pull/375#issuecomment-958681681 Seems to be a test problem: https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/ -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [solr] mkhludnev commented on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
mkhludnev commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-959942709 @madrob, honestly, I hardly follow. > we don't want to change things to strict. .. then we log it and ask the person to create an issue we do logging when refcount==-1, but

[GitHub] [solr-operator] HoustonPutman merged pull request #357: Remove Persistence option for SolrBackup.

2021-11-03 Thread GitBox
HoustonPutman merged pull request #357: URL: https://github.com/apache/solr-operator/pull/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [solr] madrob commented on pull request #338: @sayandigital SOLR-13182 - NullPointerException

2021-11-03 Thread GitBox
madrob commented on pull request #338: URL: https://github.com/apache/solr/pull/338#issuecomment-959367416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [solr] markrmiller closed pull request #300: SOLR-15644: Test thread leak management.

2021-11-03 Thread GitBox
markrmiller closed pull request #300: URL: https://github.com/apache/solr/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [solr-operator] HoustonPutman merged pull request #361: Add support for more ZK Pod options.

2021-11-03 Thread GitBox
HoustonPutman merged pull request #361: URL: https://github.com/apache/solr-operator/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [solr] thelabdude merged pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude merged pull request #394: URL: https://github.com/apache/solr/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [solr-operator] HoustonPutman closed issue #347: Remove SolrBackup Persistence option

2021-11-03 Thread GitBox
HoustonPutman closed issue #347: URL: https://github.com/apache/solr-operator/issues/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[GitHub] [solr] cpoerschke commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI

2021-11-03 Thread GitBox
cpoerschke commented on a change in pull request #392: URL: https://github.com/apache/solr/pull/392#discussion_r742143497 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType)) return new ZkMkrootTool

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #288: SOLR-15705: A deleteById request without _route_ param for compositeid or implicit router could be sent to all shard lead

2021-11-03 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #288: URL: https://github.com/apache/solr/pull/288#discussion_r742198500 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java ## @@ -383,47 +419,7 @@ protected void doDelete

[GitHub] [solr] markrmiller closed pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

2021-11-03 Thread GitBox
markrmiller closed pull request #311: URL: https://github.com/apache/solr/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [solr] epugh commented on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
epugh commented on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959966356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [solr] janhoy commented on pull request #375: SOLR-15728: Remove dead, unused log rotation code from SolrCLI

2021-11-03 Thread GitBox
janhoy commented on pull request #375: URL: https://github.com/apache/solr/pull/375#issuecomment-959285752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [solr] markrmiller commented on pull request #300: SOLR-15644: Test thread leak management.

2021-11-03 Thread GitBox
markrmiller commented on pull request #300: URL: https://github.com/apache/solr/pull/300#issuecomment-958959533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [solr] janhoy merged pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI

2021-11-03 Thread GitBox
janhoy merged pull request #392: URL: https://github.com/apache/solr/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sol

[GitHub] [solr-operator] HoustonPutman commented on pull request #358: Specify individual backupRepo availability in SolrCloud Status

2021-11-03 Thread GitBox
HoustonPutman commented on pull request #358: URL: https://github.com/apache/solr-operator/pull/358#issuecomment-960252308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [solr] markrmiller merged pull request #367: SOLR-15647: TestRebalanceLeaders#testRebalanceLeaders can be abysmall…

2021-11-03 Thread GitBox
markrmiller merged pull request #367: URL: https://github.com/apache/solr/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [solr] thelabdude commented on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude commented on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959941548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [solr] thelabdude edited a comment on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude edited a comment on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959956128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [solr] cpoerschke commented on a change in pull request #288: SOLR-15705: A deleteById request without _route_ param for compositeid or implicit router could be sent to all shard leaders

2021-11-03 Thread GitBox
cpoerschke commented on a change in pull request #288: URL: https://github.com/apache/solr/pull/288#discussion_r742125759 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java ## @@ -316,6 +317,41 @@ public void processDelete(Delet

[GitHub] [solr] madrob commented on a change in pull request #389: SOLR-15477: Logging Performance

2021-11-03 Thread GitBox
madrob commented on a change in pull request #389: URL: https://github.com/apache/solr/pull/389#discussion_r742170960 ## File path: solr/bin/solr ## @@ -1973,7 +1973,7 @@ fi LOG4J_CONFIG=() if [ -n "$LOG4J_PROPS" ]; then - LOG4J_CONFIG+=("-Dlog4j.configurationFile=$LOG4J_P

[GitHub] [solr] thelabdude merged pull request #393: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
thelabdude merged pull request #393: URL: https://github.com/apache/solr/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [solr] mkhludnev edited a comment on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
mkhludnev edited a comment on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-959942709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [solr] madrob commented on pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-11-03 Thread GitBox
madrob commented on pull request #160: URL: https://github.com/apache/solr/pull/160#issuecomment-959382186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [solr] markrmiller commented on pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

2021-11-03 Thread GitBox
markrmiller commented on pull request #311: URL: https://github.com/apache/solr/pull/311#issuecomment-958967962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [solr] epugh commented on pull request #393: SOLR-15721: Support editing Basic auth config when using the MultiAuthPlugin

2021-11-03 Thread GitBox
epugh commented on pull request #393: URL: https://github.com/apache/solr/pull/393#issuecomment-959616329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [solr] madrob commented on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
madrob commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-960003705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [solr] janhoy commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI

2021-11-03 Thread GitBox
janhoy commented on a change in pull request #392: URL: https://github.com/apache/solr/pull/392#discussion_r742244476 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType)) return new ZkMkrootTool();

[GitHub] [solr] cpoerschke commented on pull request #288: SOLR-15705: A deleteById request without _route_ param for compositeid or implicit router could be sent to all shard leaders

2021-11-03 Thread GitBox
cpoerschke commented on pull request #288: URL: https://github.com/apache/solr/pull/288#issuecomment-959652732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [solr] mkhludnev commented on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
mkhludnev commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-959942709 @madrob, honestly, I hardly follow. > we don't want to change things to strict. .. then we log it and ask the person to create an issue we do logging when refcount==-1, but

[GitHub] [solr-operator] HoustonPutman closed issue #352: Add possibility to annotate zookeeper to trigger rolling update

2021-11-03 Thread GitBox
HoustonPutman closed issue #352: URL: https://github.com/apache/solr-operator/issues/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr] janhoy merged pull request #375: SOLR-15728: Remove dead, unused log rotation code from SolrCLI

2021-11-03 Thread GitBox
janhoy merged pull request #375: URL: https://github.com/apache/solr/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] janhoy merged pull request #381: Bump owasp-dependencycheck to 6.4.1.1

2021-11-03 Thread GitBox
janhoy merged pull request #381: URL: https://github.com/apache/solr/pull/381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] dweiss commented on pull request #349: Dependency tune-up of solr-core

2021-11-03 Thread GitBox
dweiss commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-958724294 > I'm confused about versions.props. I thought this pinned our versions but it seems not because this is what is in there: > org.codehaus.janino:*=3.0.9 > Yet Gradle selected 3.0

[GitHub] [solr] dsmiley merged pull request #349: Dependency tune-up of solr-core

2021-11-03 Thread GitBox
dsmiley merged pull request #349: URL: https://github.com/apache/solr/pull/349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Comment Edited] (SOLR-15762) IllegalStateException: Recursive update thrown when executing complex Join queries

2021-11-03 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438350#comment-17438350 ] Joel Bernstein edited comment on SOLR-15762 at 11/4/21, 12:11 AM: -

[GitHub] [solr] markrmiller commented on pull request #375: SOLR-15728: Remove dead, unused log rotation code from SolrCLI

2021-11-03 Thread GitBox
markrmiller commented on pull request #375: URL: https://github.com/apache/solr/pull/375#issuecomment-958681681 Seems to be a test problem: https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/ -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Commented] (SOLR-15762) IllegalStateException: Recursive update thrown when executing complex Join queries

2021-11-03 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438350#comment-17438350 ] Joel Bernstein commented on SOLR-15762: --- I don't think we can keep this as a blocke

[GitHub] [solr-operator] HoustonPutman commented on pull request #358: Specify individual backupRepo availability in SolrCloud Status

2021-11-03 Thread GitBox
HoustonPutman commented on pull request #358: URL: https://github.com/apache/solr-operator/pull/358#issuecomment-960252308 Will test (and fix if need be) and merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [solr-operator] HoustonPutman closed issue #352: Add possibility to annotate zookeeper to trigger rolling update

2021-11-03 Thread GitBox
HoustonPutman closed issue #352: URL: https://github.com/apache/solr-operator/issues/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman merged pull request #361: Add support for more ZK Pod options.

2021-11-03 Thread GitBox
HoustonPutman merged pull request #361: URL: https://github.com/apache/solr-operator/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr] thelabdude opened a new pull request #395: SOLR-15767: Prometheus alert rules for monitoring SolrCloud clusters on Kubernetes

2021-11-03 Thread GitBox
thelabdude opened a new pull request #395: URL: https://github.com/apache/solr/pull/395 https://issues.apache.org/jira/browse/SOLR-15767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [solr] madrob commented on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
madrob commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-960003705 I thought the problem here was that we end up calling close too many times, right? So like on SolrCore, if we call close on the hook multiple times we could log about it instead of s

[GitHub] [solr-operator] HoustonPutman merged pull request #357: Remove Persistence option for SolrBackup.

2021-11-03 Thread GitBox
HoustonPutman merged pull request #357: URL: https://github.com/apache/solr-operator/pull/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] HoustonPutman closed issue #347: Remove SolrBackup Persistence option

2021-11-03 Thread GitBox
HoustonPutman closed issue #347: URL: https://github.com/apache/solr-operator/issues/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr] thelabdude edited a comment on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude edited a comment on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959956128 Yeah, just verified ... `"role": null` doesn't do anything when just using the `BasicAuthPlugin` unless `"blockUnknown": false` ... here's my config: ``` authenticatio

[GitHub] [solr] epugh commented on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
epugh commented on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959966356 Thanks! WE are getting closer to our magic future of just having everything delegate credential look ups! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [solr] thelabdude commented on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude commented on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959956128 Yeah, just verified ... `"role": null` doesn't do anything when just using the `BasicAuthPlugin` unless `"blockUnknown": false` ... here's my config: ``` authentication":{

[GitHub] [solr] mkhludnev edited a comment on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
mkhludnev edited a comment on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-959942709 @madrob, honestly, I hardly follow. > we don't want to change things to strict. .. then we log it and ask the person to create an issue we do logging when refcoun

[GitHub] [solr] mkhludnev commented on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-03 Thread GitBox
mkhludnev commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-959942709 @madrob, honestly, I hardly follow. > we don't want to change things to strict. .. then we log it and ask the person to create an issue we do logging when refcount==-1, but

[GitHub] [solr] thelabdude commented on pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude commented on pull request #394: URL: https://github.com/apache/solr/pull/394#issuecomment-959941548 I don't think `"role": null` works unless you `"blockUnknown": false` ... otherwise, requests would never make it to the endpoint, but let me verify with just the basic auth plugi

[jira] [Assigned] (SOLR-12505) Streaming expressions - fetch() does not work as expected

2021-11-03 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-12505: -- Assignee: David Eric Pugh (was: Joel Bernstein) > Streaming expressions - fetch() doe

[jira] [Commented] (SOLR-15766) MultiAuthPlugin doesn't handle missing Header requests

2021-11-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438271#comment-17438271 ] ASF subversion and git services commented on SOLR-15766: Commit a

[jira] [Updated] (SOLR-15767) Include a core set of Prometheus alert rules for monitoring SolrCloud on K8s

2021-11-03 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15767: -- Description: As promised in my ApacheCon talk (recording here: https://www.youtube.com/watch?v

[jira] [Resolved] (SOLR-15766) MultiAuthPlugin doesn't handle missing Header requests

2021-11-03 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15766. --- Resolution: Fixed > MultiAuthPlugin doesn't handle missing Header requests >

[jira] [Commented] (SOLR-15766) MultiAuthPlugin doesn't handle missing Header requests

2021-11-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438267#comment-17438267 ] ASF subversion and git services commented on SOLR-15766: Commit b

[jira] [Commented] (SOLR-15766) MultiAuthPlugin doesn't handle missing Header requests

2021-11-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438268#comment-17438268 ] ASF subversion and git services commented on SOLR-15766: Commit b

[GitHub] [solr] thelabdude merged pull request #394: SOLR-15766: MultiAuthPlugin should send non-AJAX anonymous requests to the plugin that allows anonymous requests

2021-11-03 Thread GitBox
thelabdude merged pull request #394: URL: https://github.com/apache/solr/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Created] (SOLR-15767) Include a core set of Prometheus alert rules for monitoring SolrCloud on K8s

2021-11-03 Thread Timothy Potter (Jira)
Timothy Potter created SOLR-15767: - Summary: Include a core set of Prometheus alert rules for monitoring SolrCloud on K8s Key: SOLR-15767 URL: https://issues.apache.org/jira/browse/SOLR-15767 Project:

[jira] [Commented] (SOLR-14049) Disable Config APIs by default

2021-11-03 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438263#comment-17438263 ] Jan Høydahl commented on SOLR-14049: Perhaps we can display a more scary looking, big

[jira] [Updated] (SOLR-14049) Disable Config APIs by default

2021-11-03 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14049: --- Attachment: Skjermbilde 2021-11-03 kl. 20.14.26.png > Disable Config APIs by default > --

[jira] [Commented] (SOLR-15762) IllegalStateException: Recursive update thrown when executing complex Join queries

2021-11-03 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438261#comment-17438261 ] Mike Drob commented on SOLR-15762: -- Looking. > It is not that easy to force the excepti

[jira] [Commented] (SOLR-15728) Remove dead, unused log rotation code from SolrCLI

2021-11-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438253#comment-17438253 ] ASF subversion and git services commented on SOLR-15728: Commit c

[GitHub] [solr] janhoy merged pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI

2021-11-03 Thread GitBox
janhoy merged pull request #392: URL: https://github.com/apache/solr/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] janhoy commented on a change in pull request #392: SOLR-15728 Clean up remains of "utils" tool in SolrCLI

2021-11-03 Thread GitBox
janhoy commented on a change in pull request #392: URL: https://github.com/apache/solr/pull/392#discussion_r742244476 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -384,8 +384,6 @@ else if ("mkroot".equals(toolType)) return new ZkMkrootTool();

  1   2   >