[GitHub] [solr] dsmiley commented on a change in pull request #330: SOLR-14781 Delete unused classes

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #330: URL: https://github.com/apache/solr/pull/330#discussion_r724648382 ## File path: solr/core/src/java/org/apache/solr/handler/NotFoundRequestHandler.java ## @@ -1,38 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (A

[jira] [Commented] (SOLR-15613) Address error-prone URLEqualsHashCode warning

2021-10-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425916#comment-17425916 ] ASF subversion and git services commented on SOLR-15613: Commit 0

[GitHub] [solr] madrob merged pull request #333: SOLR-15613: Address error-prone URLEqualsHashCode warning

2021-10-07 Thread GitBox
madrob merged pull request #333: URL: https://github.com/apache/solr/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] madrob commented on a change in pull request #333: SOLR-15613: Address error-prone URLEqualsHashCode warning

2021-10-07 Thread GitBox
madrob commented on a change in pull request #333: URL: https://github.com/apache/solr/pull/333#discussion_r724278442 ## File path: solr/core/src/test/org/apache/solr/search/function/TestMinMaxOnMultiValuedField.java ## @@ -895,8 +895,8 @@ private void testExpectedSortOrdering

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #335: Drive JMH benchmarks via Apache Zeppelin.

2021-10-07 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #335: URL: https://github.com/apache/solr/pull/335#discussion_r724644502 ## File path: zeppelin-jmh-interpreter/build.gradle ## @@ -0,0 +1,102 @@ +/* + * This file was generated by the Gradle 'init' task. + */ + +plugins

[GitHub] [solr] markrmiller opened a new pull request #335: Drive JMH benchmarks via Apache Zeppelin.

2021-10-07 Thread GitBox
markrmiller opened a new pull request #335: URL: https://github.com/apache/solr/pull/335 This is some early work that allows using Apache Zeppelin to drive, organize, visualize, and explore our jmh benchmarks. It's not quite ready to be used more broadly, there are a few things that

[jira] [Updated] (SOLR-15629) replace SolrException.ignorePatterns with a a new test-framework Rule

2021-10-07 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15629: -- Attachment: SOLR-15629.patch Assignee: Chris M. Hostetter Status: Open (w

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r723654321 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -87,20 +80,61 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] HoustonPutman commented on pull request #323: SOLR-15670: Introduce Gradle parameter to skip ref-guide tasks

2021-10-07 Thread GitBox
HoustonPutman commented on pull request #323: URL: https://github.com/apache/solr/pull/323#issuecomment-937860850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [solr] madrob commented on a change in pull request #316: SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…

2021-10-07 Thread GitBox
madrob commented on a change in pull request #316: URL: https://github.com/apache/solr/pull/316#discussion_r724387682 ## File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java ## @@ -150,6 +151,14 @@ public void checkSyspropForceBeforeAssumptionFailure() {

[GitHub] [solr] atris commented on pull request #332: SOLR-15578 Add Support for HSTS Security Protocol

2021-10-07 Thread GitBox
atris commented on pull request #332: URL: https://github.com/apache/solr/pull/332#issuecomment-937666333 Should we be committing this PR before SOLR-14903 is fixed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [solr] asalamon74 commented on pull request #326: SOLR-15301 Eliminate repetitive index size calculation for Solr metrics

2021-10-07 Thread GitBox
asalamon74 commented on pull request #326: URL: https://github.com/apache/solr/pull/326#issuecomment-937498518 Thanks @dsmiley, committed the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [solr-operator] thelabdude commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thelabdude commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937833823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [solr] anshumg commented on a change in pull request #286: SOLR-14892 - shards.info with shards.tolerant can yield an empty key

2021-10-07 Thread GitBox
anshumg commented on a change in pull request #286: URL: https://github.com/apache/solr/pull/286#discussion_r724472266 ## File path: solr/core/src/test/org/apache/solr/cloud/TestNoDuplicateKeysInShardsInfoWhenShardsDown.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache S

[GitHub] [solr] markrmiller merged pull request #301: SOLR-15640: Flush / Shutdown Async Loggers and LogManager after a test.

2021-10-07 Thread GitBox
markrmiller merged pull request #301: URL: https://github.com/apache/solr/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [solr] TheSench edited a comment on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
TheSench edited a comment on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-937823770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [solr] markrmiller commented on a change in pull request #316: SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…

2021-10-07 Thread GitBox
markrmiller commented on a change in pull request #316: URL: https://github.com/apache/solr/pull/316#discussion_r724462011 ## File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java ## @@ -150,6 +151,14 @@ public void checkSyspropForceBeforeAssumptionFailure()

[GitHub] [solr] NazerkeBS commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
NazerkeBS commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724023093 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -78,28 +80,30 @@ private static ConfigSetService instantiate(CoreContainer

[GitHub] [solr] cpoerschke commented on a change in pull request #328: SOLR-15676: add UpdateLogCloudTest

2021-10-07 Thread GitBox
cpoerschke commented on a change in pull request #328: URL: https://github.com/apache/solr/pull/328#discussion_r724007730 ## File path: solr/core/src/test/org/apache/solr/handler/component/UpdateLogCloudTest.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [solr] bszabo97 closed pull request #266: SOLR-15578 Add Support for HSTS Security Protocol

2021-10-07 Thread GitBox
bszabo97 closed pull request #266: URL: https://github.com/apache/solr/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [solr] HoustonPutman closed pull request #323: SOLR-15670: Introduce Gradle parameter to skip ref-guide tasks

2021-10-07 Thread GitBox
HoustonPutman closed pull request #323: URL: https://github.com/apache/solr/pull/323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [solr] epugh commented on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
epugh commented on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-937781867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [solr-operator] thomaswoeckinger edited a comment on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thomaswoeckinger edited a comment on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937882238 Yes created before, also the serviceAccount has privileged SCC granted -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [solr] dsmiley merged pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley merged pull request #322: URL: https://github.com/apache/solr/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] epugh merged pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
epugh merged pull request #296: URL: https://github.com/apache/solr/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@so

[GitHub] [solr] anshumg commented on a change in pull request #328: SOLR-15676: add UpdateLogCloudTest

2021-10-07 Thread GitBox
anshumg commented on a change in pull request #328: URL: https://github.com/apache/solr/pull/328#discussion_r723693570 ## File path: solr/core/src/test/org/apache/solr/handler/component/UpdateLogCloudTest.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [solr-operator] thomaswoeckinger commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thomaswoeckinger commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937775624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [solr] asalamon74 closed pull request #326: SOLR-15301 Eliminate repetitive index size calculation for Solr metrics

2021-10-07 Thread GitBox
asalamon74 closed pull request #326: URL: https://github.com/apache/solr/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] cpoerschke merged pull request #328: SOLR-15676: add UpdateLogCloudTest

2021-10-07 Thread GitBox
cpoerschke merged pull request #328: URL: https://github.com/apache/solr/pull/328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] markrmiller merged pull request #316: SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…

2021-10-07 Thread GitBox
markrmiller merged pull request #316: URL: https://github.com/apache/solr/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [solr] bszabo97 commented on pull request #266: SOLR-15578 Add Support for HSTS Security Protocol

2021-10-07 Thread GitBox
bszabo97 commented on pull request #266: URL: https://github.com/apache/solr/pull/266#issuecomment-937656753 This PR is out-dated, created new one with tests in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] TheSench commented on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
TheSench commented on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-937390843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [solr] dsmiley commented on pull request #323: SOLR-15670: Introduce Gradle parameter to skip ref-guide tasks

2021-10-07 Thread GitBox
dsmiley commented on pull request #323: URL: https://github.com/apache/solr/pull/323#issuecomment-937257916 Assuming we do this (maybe not based on Dawid's comment), the `gradlew dev` task should skip the ref guide by default. -- This is an automated message from the Apache Git Service.

[GitHub] [solr-operator] HoustonPutman commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
HoustonPutman commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937914493 That's a good catch Tim! Yeah, Solr definitely expects a port in the ZKConnectionString. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Created] (SOLR-15682) Add a CONTRIBUTING file

2021-10-07 Thread Jira
Jan Høydahl created SOLR-15682: -- Summary: Add a CONTRIBUTING file Key: SOLR-15682 URL: https://issues.apache.org/jira/browse/SOLR-15682 Project: Solr Issue Type: Task Security Level: Publi

[jira] [Commented] (SOLR-15675) Zookeeper flag ignored when enabling authentication in 8.10.0

2021-10-07 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425806#comment-17425806 ] Houston Putman commented on SOLR-15675: --- I believe you can get the NoNode error whe

[jira] [Commented] (SOLR-15640) Flush / Shutdown (whatever you are supposed to do) log4j2 Async Loggers and LogManager after a test is run.

2021-10-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425793#comment-17425793 ] ASF subversion and git services commented on SOLR-15640: Commit 0

[GitHub] [solr] markrmiller merged pull request #301: SOLR-15640: Flush / Shutdown Async Loggers and LogManager after a test.

2021-10-07 Thread GitBox
markrmiller merged pull request #301: URL: https://github.com/apache/solr/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [solr] HoustonPutman commented on pull request #323: SOLR-15670: Introduce Gradle parameter to skip ref-guide tasks

2021-10-07 Thread GitBox
HoustonPutman commented on pull request #323: URL: https://github.com/apache/solr/pull/323#issuecomment-938147535 Reopening and re-implementing based on Dawid's patch in the JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (SOLR-15659) ObjectReleaseTracker is now in the wrong class, should leave no grace time.

2021-10-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425778#comment-17425778 ] ASF subversion and git services commented on SOLR-15659: Commit 0

[GitHub] [solr] markrmiller merged pull request #316: SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…

2021-10-07 Thread GitBox
markrmiller merged pull request #316: URL: https://github.com/apache/solr/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [solr] anshumg commented on a change in pull request #286: SOLR-14892 - shards.info with shards.tolerant can yield an empty key

2021-10-07 Thread GitBox
anshumg commented on a change in pull request #286: URL: https://github.com/apache/solr/pull/286#discussion_r724472266 ## File path: solr/core/src/test/org/apache/solr/cloud/TestNoDuplicateKeysInShardsInfoWhenShardsDown.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache S

[GitHub] [solr] markrmiller commented on a change in pull request #316: SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…

2021-10-07 Thread GitBox
markrmiller commented on a change in pull request #316: URL: https://github.com/apache/solr/pull/316#discussion_r724462011 ## File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java ## @@ -150,6 +151,14 @@ public void checkSyspropForceBeforeAssumptionFailure()

[jira] [Commented] (SOLR-15676) PeerSync failure due to RealTimeGetComponent.getUpdates returning duplicate DBQs

2021-10-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425721#comment-17425721 ] Christine Poerschke commented on SOLR-15676: bq. ... which it seems can happe

[GitHub] [solr] cpoerschke opened a new pull request #334: SOLR-15676: (do not) add UpdateLogCloudRollingRestartsTest

2021-10-07 Thread GitBox
cpoerschke opened a new pull request #334: URL: https://github.com/apache/solr/pull/334 https://issues.apache.org/jira/browse/SOLR-15676 This pull request contains a (very slow) `UpdateLogCloudRollingRestartsTest` to help verify the #329 and #331 changes (which are also included in t

[GitHub] [solr] madrob commented on a change in pull request #316: SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…

2021-10-07 Thread GitBox
madrob commented on a change in pull request #316: URL: https://github.com/apache/solr/pull/316#discussion_r724387682 ## File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java ## @@ -150,6 +151,14 @@ public void checkSyspropForceBeforeAssumptionFailure() {

[jira] [Commented] (SOLR-15675) Zookeeper flag ignored when enabling authentication in 8.10.0

2021-10-07 Thread Jose Antonio Carmona (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425702#comment-17425702 ] Jose Antonio Carmona commented on SOLR-15675: - Okay, so that explains why usi

[jira] [Commented] (SOLR-15591) NullPointerException in ExternalPaths.determineSourceHome makes debugging cumbersome

2021-10-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425676#comment-17425676 ] Mike Drob commented on SOLR-15591: -- Hi Carlos, yes, that sounds correct. Thanks, and let

[GitHub] [solr-operator] thomaswoeckinger commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thomaswoeckinger commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937947843 Why not work with the defaults if not specifying? CloudSolrClient and CloudSolrClient.Duilder are also working without specifying the port. Anyway at least there sh

[jira] [Commented] (SOLR-15681) Customization of S3 client retry/throttling logic

2021-10-07 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425657#comment-17425657 ] Houston Putman commented on SOLR-15681: --- We should also make sure we are using the

[jira] [Resolved] (SOLR-15258) ConfigSetService: add CRUD operations, subsume ZkConfigManager

2021-10-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15258. - Resolution: Fixed > ConfigSetService: add CRUD operations, subsume ZkConfigManager > ---

[GitHub] [solr-operator] HoustonPutman commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
HoustonPutman commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937914493 That's a good catch Tim! Yeah, Solr definitely expects a port in the ZKConnectionString. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425639#comment-17425639 ] Dawid Weiss commented on SOLR-15670: This is globally defined, you'd need to substitu

[jira] [Commented] (SOLR-15258) ConfigSetService: add CRUD operations, subsume ZkConfigManager

2021-10-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425640#comment-17425640 ] ASF subversion and git services commented on SOLR-15258: Commit e

[GitHub] [solr] dsmiley merged pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley merged pull request #322: URL: https://github.com/apache/solr/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr-operator] thelabdude commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thelabdude commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937913355 I don't think it's related to the basic auth secret ... looks like it may be this check here (looking for a colon and port on your zk connnection string): ``` // Only cre

[jira] [Created] (SOLR-15681) Customization of S3 client retry/throttling logic

2021-10-07 Thread Houston Putman (Jira)
Houston Putman created SOLR-15681: - Summary: Customization of S3 client retry/throttling logic Key: SOLR-15681 URL: https://issues.apache.org/jira/browse/SOLR-15681 Project: Solr Issue Type:

[jira] [Created] (SOLR-15680) Allow for client-side encryption of backup data with S3

2021-10-07 Thread Houston Putman (Jira)
Houston Putman created SOLR-15680: - Summary: Allow for client-side encryption of backup data with S3 Key: SOLR-15680 URL: https://issues.apache.org/jira/browse/SOLR-15680 Project: Solr Issue

[GitHub] [solr-operator] thomaswoeckinger commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thomaswoeckinger commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937887394 Below the mentioned secret ``` kind: Secret apiVersion: v1 metadata: name: basic-auth namespace: solr uid: bb5dac9a-da20-4f34-8e0b-760762a59c34

[GitHub] [solr-operator] thomaswoeckinger edited a comment on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thomaswoeckinger edited a comment on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937882238 Yes created before, also the serviceAccount has privileged SCC granted -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [solr-operator] thomaswoeckinger commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thomaswoeckinger commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937882238 yes create before, also the serviceAccount has privileged SCC granted -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [solr] epugh commented on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
epugh commented on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-937863808 Thanks @TheSench for your persistence, and sorry it took me so long to get comfortable with the patch, mostly due to my own nerves ;-) Feel free to tag me on any future PR's ;-) -

[jira] [Commented] (SOLR-15626) config-read permission does not allow access to /solr/admin/configs?action=LIST

2021-10-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425611#comment-17425611 ] ASF subversion and git services commented on SOLR-15626: Commit 1

[GitHub] [solr] HoustonPutman commented on pull request #323: SOLR-15670: Introduce Gradle parameter to skip ref-guide tasks

2021-10-07 Thread GitBox
HoustonPutman commented on pull request #323: URL: https://github.com/apache/solr/pull/323#issuecomment-937860850 Closing as Dawid's patch in the Jira is far better. @dsmiley, I think it would be hard to have `gradlew dev` skip the ref guide, because (from my memory) it basically jus

[GitHub] [solr] HoustonPutman closed pull request #323: SOLR-15670: Introduce Gradle parameter to skip ref-guide tasks

2021-10-07 Thread GitBox
HoustonPutman closed pull request #323: URL: https://github.com/apache/solr/pull/323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Comment Edited] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-07 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425608#comment-17425608 ] Houston Putman edited comment on SOLR-15670 at 10/7/21, 2:40 PM: --

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-07 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425608#comment-17425608 ] Houston Putman commented on SOLR-15670: --- Ok yeah your patch works like a charm! +1

[jira] [Resolved] (SOLR-15626) config-read permission does not allow access to /solr/admin/configs?action=LIST

2021-10-07 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh resolved SOLR-15626. Resolution: Fixed > config-read permission does not allow access to > /solr/admin/configs?

[jira] [Commented] (SOLR-15626) config-read permission does not allow access to /solr/admin/configs?action=LIST

2021-10-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425605#comment-17425605 ] ASF subversion and git services commented on SOLR-15626: Commit d

[jira] [Updated] (SOLR-15626) config-read permission does not allow access to /solr/admin/configs?action=LIST

2021-10-07 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh updated SOLR-15626: --- Fix Version/s: 8.11 main (9.0) > config-read permission does not allow acc

[jira] [Assigned] (SOLR-15626) config-read permission does not allow access to /solr/admin/configs?action=LIST

2021-10-07 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-15626: -- Assignee: David Eric Pugh > config-read permission does not allow access to > /solr/a

[GitHub] [solr] epugh merged pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
epugh merged pull request #296: URL: https://github.com/apache/solr/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@so

[GitHub] [solr] TheSench edited a comment on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
TheSench edited a comment on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-937823770 The next Solr 8 would be ideal, but only so that more users can benefit. I'm using a workaround already on my end, so I wouldn't be personally impacted if this waited until S

[GitHub] [solr] TheSench edited a comment on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
TheSench edited a comment on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-937823770 The next Solr 8 would be ideal, but only so that more users can benefit. I'm using a workaround already on my end, so I wouldn't be personally impacted of this waited until S

[GitHub] [solr] TheSench edited a comment on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
TheSench edited a comment on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-937823770 The next Solr 8 would be ideal, but only so that more users can benefit. In using a workaround already on my end. -- This is an automated message from the Apache Git Servic

[GitHub] [solr-operator] thelabdude commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thelabdude commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937833823 Does the `basic-auth` secret exist? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [solr] TheSench commented on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
TheSench commented on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-937823770 The next Solr would be ideal, but only so that more users can benefit. In using a workaround already on my end. -- This is an automated message from the Apache Git Service. To res

[GitHub] [solr] epugh commented on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-07 Thread GitBox
epugh commented on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-937781867 I went to merge this, and had a hangup on which CHANGES.txt file this goes in... @TheSench I am assuming you want this in the next Solr 8 release? If you don't care, I could just mer

[GitHub] [solr] Caa52 opened a new pull request #333: SOLR-15613: Address error-prone URLEqualsHashCode warning

2021-10-07 Thread GitBox
Caa52 opened a new pull request #333: URL: https://github.com/apache/solr/pull/333 https://issues.apache.org/jira/browse/SOLR-15613 # Description Enforce error-prone checks to catch all `URLEqualsHashCode `violations # Solution Fixed every `URLEqualsHashCode` viol

[GitHub] [solr-operator] thomaswoeckinger commented on issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thomaswoeckinger commented on issue #335: URL: https://github.com/apache/solr-operator/issues/335#issuecomment-937775624 Any suggestions to get out a bit more information? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [solr-operator] thomaswoeckinger opened a new issue #335: Unable to create SolrCloud in OKD

2021-10-07 Thread GitBox
thomaswoeckinger opened a new issue #335: URL: https://github.com/apache/solr-operator/issues/335 Solr Operator is configured without zookeeper support. Following helm script is executed: ``` helm upgrade --install --set replicas=3 --set addressability.commonServicePort=898

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724149383 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -78,28 +80,30 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724146920 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -87,20 +80,61 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724146920 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -87,20 +80,61 @@ private static ConfigSetService instantiate(CoreContainer c

[GitHub] [solr] dsmiley commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
dsmiley commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724146043 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -78,28 +80,30 @@ private static ConfigSetService instantiate(CoreContainer c

[jira] [Commented] (SOLR-15578) Add Support for HSTS Security Protocol

2021-10-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425469#comment-17425469 ] Jan Høydahl commented on SOLR-15578: Can someone explain why HSTS this makes a differ

[GitHub] [solr] atris commented on pull request #332: SOLR-15578 Add Support for HSTS Security Protocol

2021-10-07 Thread GitBox
atris commented on pull request #332: URL: https://github.com/apache/solr/pull/332#issuecomment-937666333 Should we be committing this PR before SOLR-14903 is fixed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [solr] bszabo97 closed pull request #266: SOLR-15578 Add Support for HSTS Security Protocol

2021-10-07 Thread GitBox
bszabo97 closed pull request #266: URL: https://github.com/apache/solr/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [solr] bszabo97 commented on pull request #266: SOLR-15578 Add Support for HSTS Security Protocol

2021-10-07 Thread GitBox
bszabo97 commented on pull request #266: URL: https://github.com/apache/solr/pull/266#issuecomment-937656753 This PR is out-dated, created new one with tests in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (SOLR-15578) Add Support for HSTS Security Protocol

2021-10-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425462#comment-17425462 ] Bence Szabó commented on SOLR-15578: Hi! I created a new pull request for this issue

[GitHub] [solr] bszabo97 opened a new pull request #332: SOLR-15578 Add Support for HSTS Security Protocol

2021-10-07 Thread GitBox
bszabo97 opened a new pull request #332: URL: https://github.com/apache/solr/pull/332 Change-Id: I5c87491bd875351e46774dc4ff5652deda6808c3 https://issues.apache.org/jira/browse/SOLR-15578 # Description Adding support for HSTS Security Protocol in jetty.xml.

[GitHub] [solr] NazerkeBS commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
NazerkeBS commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724035366 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -78,28 +80,30 @@ private static ConfigSetService instantiate(CoreContainer

[GitHub] [solr] NazerkeBS commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
NazerkeBS commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724035366 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -78,28 +80,30 @@ private static ConfigSetService instantiate(CoreContainer

[GitHub] [solr] NazerkeBS commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
NazerkeBS commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724024433 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -87,20 +80,61 @@ private static ConfigSetService instantiate(CoreContainer

[GitHub] [solr] NazerkeBS commented on a change in pull request #322: SOLR-15258: ConfigSetService supports bootstrap_conf

2021-10-07 Thread GitBox
NazerkeBS commented on a change in pull request #322: URL: https://github.com/apache/solr/pull/322#discussion_r724023093 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -78,28 +80,30 @@ private static ConfigSetService instantiate(CoreContainer

[jira] [Commented] (SOLR-15676) PeerSync failure due to RealTimeGetComponent.getUpdates returning duplicate DBQs

2021-10-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425433#comment-17425433 ] ASF subversion and git services commented on SOLR-15676: Commit 7

[GitHub] [solr] cpoerschke merged pull request #328: SOLR-15676: add UpdateLogCloudTest

2021-10-07 Thread GitBox
cpoerschke merged pull request #328: URL: https://github.com/apache/solr/pull/328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] cpoerschke commented on a change in pull request #328: SOLR-15676: add UpdateLogCloudTest

2021-10-07 Thread GitBox
cpoerschke commented on a change in pull request #328: URL: https://github.com/apache/solr/pull/328#discussion_r724007730 ## File path: solr/core/src/test/org/apache/solr/handler/component/UpdateLogCloudTest.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Fou