[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396345#comment-17396345
]
ASF subversion and git services commented on SOLR-15428:
Commit 8
markrmiller merged pull request #214:
URL: https://github.com/apache/solr/pull/214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
HoustonPutman commented on a change in pull request #120:
URL: https://github.com/apache/solr/pull/120#discussion_r685545982
##
File path:
solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java
##
@@ -0,0 +1,568 @@
+/*
+ * Licensed to the Apache Software F
[
https://issues.apache.org/jira/browse/SOLR-15501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396279#comment-17396279
]
Jason Gerlowski commented on SOLR-15501:
There's definitely no support for that t
[
https://issues.apache.org/jira/browse/SOLR-15500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396272#comment-17396272
]
Jason Gerlowski commented on SOLR-15500:
Thanks for offering to help out Sayan, m
[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396248#comment-17396248
]
Mark Robert Miller commented on SOLR-15428:
---
There may be a couple things to tw
HoustonPutman commented on a change in pull request #120:
URL: https://github.com/apache/solr/pull/120#discussion_r685478067
##
File path:
solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java
##
@@ -0,0 +1,568 @@
+/*
+ * Licensed to the Apache Software F
HoustonPutman commented on a change in pull request #120:
URL: https://github.com/apache/solr/pull/120#discussion_r685477187
##
File path:
solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java
##
@@ -0,0 +1,568 @@
+/*
+ * Licensed to the Apache Software F
markrmiller commented on pull request #214:
URL: https://github.com/apache/solr/pull/214#issuecomment-895496028
> Do we need to include a JFR or async-profiler recording profile?
There is a sample config for JFR (that essentially turns on everything), but
in general, these options ar
athrog commented on a change in pull request #120:
URL: https://github.com/apache/solr/pull/120#discussion_r685474300
##
File path:
solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java
##
@@ -0,0 +1,568 @@
+/*
+ * Licensed to the Apache Software Foundati
HoustonPutman commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-895492702
> I have a local commit that explicitly excludes those libs and doesn't
negatively impact s3mock, will do some testing around that and push in a bit.
That would be aweso
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-895489520
One more comment since I saw you updated the `versions.lock` file. I noticed
that the s3mock project pulls in a few new versions of libs that solr uses.
This seemed like a bad thing t
ben-manes commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r685465632
##
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##
@@ -176,33 +198,95 @@ public V get(K key) {
return cache.getIfPresent(key)
madrob commented on pull request #230:
URL: https://github.com/apache/solr/pull/230#issuecomment-895478529
Rebased and squashed, would appreciate another look-over from folks that
have participated. Working on additional performance testing before committing,
but otherwise I think this is
HoustonPutman commented on a change in pull request #120:
URL: https://github.com/apache/solr/pull/120#discussion_r685457939
##
File path:
solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java
##
@@ -0,0 +1,568 @@
+/*
+ * Licensed to the Apache Software F
HoustonPutman commented on a change in pull request #120:
URL: https://github.com/apache/solr/pull/120#discussion_r685450117
##
File path:
solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java
##
@@ -0,0 +1,568 @@
+/*
+ * Licensed to the Apache Software F
HoustonPutman commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-895465966
I've been testing out with real S3, but will test it out with mock s3 now.
Thanks for finding the issue.
--
This is an automated message from the Apache Git Service.
To respo
athrog commented on a change in pull request #120:
URL: https://github.com/apache/solr/pull/120#discussion_r685446342
##
File path:
solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java
##
@@ -0,0 +1,568 @@
+/*
+ * Licensed to the Apache Software Foundati
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-895462948
Thanks again @HoustonPutman for your time and energy on this PR.
> This is a major change, but I think a big improvement in terms of
usability. Is there a reason why you mandate
HoustonPutman commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-895311438
I've made two commits to fix some of the precommit issues, but there are two
that remain that still need to be addressed.
- [ ] Run `./gradlew :solr:contrib:s3-repository
[
https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395947#comment-17395947
]
Jan Høydahl commented on SOLR-14414:
I'd very much like for YASA to succeed, or any o
21 matches
Mail list logo
