[GitHub] [solr] dsmiley commented on a change in pull request #230: SOLR-15555 Improved caching on FilterQuery

2021-07-29 Thread GitBox
dsmiley commented on a change in pull request #230: URL: https://github.com/apache/solr/pull/230#discussion_r679492857 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -804,15 +806,39 @@ public BitDocSet getDocSetBits(Query q) throws IOExcep

[jira] [Commented] (SOLR-15540) changes in internal usage of _root_ field cause failures to deleteById or duplicate docs when updating after upgrading from Solr7 to Solr8

2021-07-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390157#comment-17390157 ] David Smiley commented on SOLR-15540: - Nice analysis Hoss. An intrepid developer cou

[GitHub] [solr] thelabdude merged pull request #239: SOLR-15567: Document Schema Designer screen in ref guide.

2021-07-29 Thread GitBox
thelabdude merged pull request #239: URL: https://github.com/apache/solr/pull/239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (SOLR-15567) Add docs for the Schema Designer UI to the ref guide

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390151#comment-17390151 ] ASF subversion and git services commented on SOLR-15567: Commit 0

[GitHub] [solr] thelabdude commented on a change in pull request #239: SOLR-15567: Document Schema Designer screen in ref guide.

2021-07-29 Thread GitBox
thelabdude commented on a change in pull request #239: URL: https://github.com/apache/solr/pull/239#discussion_r679431593 ## File path: solr/solr-ref-guide/src/schema-designer.adoc ## @@ -0,0 +1,229 @@ += Schema Designer +// Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [solr] ctargett commented on a change in pull request #209: SOLR-15527: Security admin screen for managing users, roles, and permissions

2021-07-29 Thread GitBox
ctargett commented on a change in pull request #209: URL: https://github.com/apache/solr/pull/209#discussion_r679427510 ## File path: solr/solr-ref-guide/src/security-ui.adoc ## @@ -0,0 +1,108 @@ += Security UI +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [solr] ctargett commented on a change in pull request #239: SOLR-15567: Document Schema Designer screen in ref guide.

2021-07-29 Thread GitBox
ctargett commented on a change in pull request #239: URL: https://github.com/apache/solr/pull/239#discussion_r679380240 ## File path: solr/solr-ref-guide/src/schema-designer.adoc ## @@ -0,0 +1,229 @@ += Schema Designer +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-29 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r679384376 ## File path: solr/benchmark/jmh.sh ## @@ -0,0 +1,48 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [solr] cpoerschke commented on pull request #236: SOLR-15546: ShortestPathStream to handle ids with colons.

2021-07-29 Thread GitBox
cpoerschke commented on pull request #236: URL: https://github.com/apache/solr/pull/236#issuecomment-889321148 > ... text with a quote character in the middle. ... I would speculate that somehow encoding the id might be one approach? The text could contain quotes in the middle or apo

[GitHub] [solr] cpoerschke commented on a change in pull request #236: SOLR-15546: ShortestPathStream to handle ids with colons.

2021-07-29 Thread GitBox
cpoerschke commented on a change in pull request #236: URL: https://github.com/apache/solr/pull/236#discussion_r679338951 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/graph/ShortestPathStream.java ## @@ -433,7 +433,7 @@ public JoinRunner(List nodes) {

[GitHub] [solr] madrob commented on pull request #236: SOLR-15546: ShortestPathStream to handle ids with colons.

2021-07-29 Thread GitBox
madrob commented on pull request #236: URL: https://github.com/apache/solr/pull/236#issuecomment-889317880 I didn’t even consider the “quoted” case, I was thinking of text with a quote character in the middle. But I’m glad that we are thinking about that one too! -- This is an automated

[jira] [Commented] (SOLR-15566) Ref guide docs on select * are slightly misleading

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390029#comment-17390029 ] ASF subversion and git services commented on SOLR-15566: Commit 3

[jira] [Commented] (SOLR-15540) changes in internal usage of _root_ field cause failures to deleteById or duplicate docs when updating after upgrading from Solr7 to Solr8

2021-07-29 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390028#comment-17390028 ] Chris M. Hostetter commented on SOLR-15540: --- /cc [~dsmiley] , [~mkhl] , [~moshe

[jira] [Updated] (SOLR-15540) changes in internal usage of _root_ field cause failures to deleteById or duplicate docs when updating after upgrading from Solr7 to Solr8

2021-07-29 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15540: -- Summary: changes in internal usage of _root_ field cause failures to deleteById or dupl

[jira] [Comment Edited] (SOLR-14414) New Admin UI

2021-07-29 Thread Almog Tavor (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389085#comment-17389085 ] Almog Tavor edited comment on SOLR-14414 at 7/29/21, 4:46 PM: -

[jira] [Commented] (SOLR-15540) Duplicated adding document for update when Solr7 upgrade to Solr8

2021-07-29 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390025#comment-17390025 ] Chris M. Hostetter commented on SOLR-15540: --- FWIW... {quote}Add some fields in

[jira] [Commented] (SOLR-15540) Duplicated adding document for update when Solr7 upgrade to Solr8

2021-07-29 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390024#comment-17390024 ] Chris M. Hostetter commented on SOLR-15540: --- in Solr7 the treatment of the {{_r

[jira] [Resolved] (SOLR-15566) Ref guide docs on select * are slightly misleading

2021-07-29 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15566. --- Fix Version/s: 8.10 main (9.0) Resolution: Fixed > Ref guide docs o

[GitHub] [solr] thelabdude merged pull request #237: SOLR-15566: Clarify ref guide documentation about SQL queries with SELECT * requiring a LIMIT clause

2021-07-29 Thread GitBox
thelabdude merged pull request #237: URL: https://github.com/apache/solr/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (SOLR-15566) Ref guide docs on select * are slightly misleading

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390010#comment-17390010 ] ASF subversion and git services commented on SOLR-15566: Commit 6

[jira] [Resolved] (SOLR-15568) Enable/disable Schema Designer features based on user's permissions

2021-07-29 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15568. --- Fix Version/s: main (9.0) Resolution: Fixed > Enable/disable Schema Designer features

[jira] [Commented] (SOLR-15568) Enable/disable Schema Designer features based on user's permissions

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390009#comment-17390009 ] ASF subversion and git services commented on SOLR-15568: Commit d

[GitHub] [solr] thelabdude merged pull request #240: SOLR-15568: Don't render the Schema Designer screen if user is not authorized

2021-07-29 Thread GitBox
thelabdude merged pull request #240: URL: https://github.com/apache/solr/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] thelabdude commented on pull request #239: SOLR-15567: Document Schema Designer screen in ref guide.

2021-07-29 Thread GitBox
thelabdude commented on pull request #239: URL: https://github.com/apache/solr/pull/239#issuecomment-889274506 Ended up putting it under `solr-schema` but I kept the link on the `admin-ui` page as well. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (SOLR-15482) Cross-collection join when document is missing 'from' field throws NPE

2021-07-29 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389994#comment-17389994 ] Chris M. Hostetter commented on SOLR-15482: --- Sorry folks, Not sure how i screwe

[jira] [Commented] (SOLR-15482) Cross-collection join when document is missing 'from' field throws NPE

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389991#comment-17389991 ] ASF subversion and git services commented on SOLR-15482: Commit 7

[jira] [Commented] (SOLR-15531) IllegalArgumentException while executing streaming expression with significantTerms on an empty collection

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389992#comment-17389992 ] ASF subversion and git services commented on SOLR-15531: Commit 7

[jira] [Commented] (SOLR-15531) IllegalArgumentException while executing streaming expression with significantTerms on an empty collection

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389989#comment-17389989 ] ASF subversion and git services commented on SOLR-15531: Commit 1

[jira] [Commented] (SOLR-15482) Cross-collection join when document is missing 'from' field throws NPE

2021-07-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389988#comment-17389988 ] ASF subversion and git services commented on SOLR-15482: Commit 1

[GitHub] [solr] thelabdude commented on pull request #239: SOLR-15567: Document Schema Designer screen in ref guide.

2021-07-29 Thread GitBox
thelabdude commented on pull request #239: URL: https://github.com/apache/solr/pull/239#issuecomment-889254379 Sounds great, thanks for the guidance here. Will move it under `fields-schema-design.adoc`. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [solr] ctargett edited a comment on pull request #239: SOLR-15567: Document Schema Designer screen in ref guide.

2021-07-29 Thread GitBox
ctargett edited a comment on pull request #239: URL: https://github.com/apache/solr/pull/239#issuecomment-889231635 With the changes I made in the recent big re-org, one thing I did was break up all the Admin UI pages and spread them around so they're adjacent to the docs for whatever the

[GitHub] [solr] ctargett commented on pull request #239: SOLR-15567: Document Schema Designer screen in ref guide.

2021-07-29 Thread GitBox
ctargett commented on pull request #239: URL: https://github.com/apache/solr/pull/239#issuecomment-889231635 With the changes I made in the recent big re-org, one thing I did was break up all the Admin UI pages and spread them around so they're adjacent to the docs for whatever the UI prov

[jira] [Updated] (SOLR-15564) Improve filtering expressions in /admin/metrics

2021-07-29 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15564: Fix Version/s: 8.10 > Improve filtering expressions in /admin/metrics > ---

[jira] [Updated] (SOLR-15564) Improve filtering expressions in /admin/metrics

2021-07-29 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15564: Component/s: metrics > Improve filtering expressions in /admin/metrics > --

[jira] [Commented] (SOLR-15564) Improve filtering expressions in /admin/metrics

2021-07-29 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389951#comment-17389951 ] Andrzej Bialecki commented on SOLR-15564: - This patch adds support for  {{expr}} 

[jira] [Updated] (SOLR-15564) Improve filtering expressions in /admin/metrics

2021-07-29 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15564: Attachment: SOLR-15564.patch > Improve filtering expressions in /admin/metrics > --

[jira] [Commented] (SOLR-15531) IllegalArgumentException while executing streaming expression with significantTerms on an empty collection

2021-07-29 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389860#comment-17389860 ] Cassandra Targett commented on SOLR-15531: -- The last 2 commits here should have

[jira] [Commented] (SOLR-15482) Cross-collection join when document is missing 'from' field throws NPE

2021-07-29 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389856#comment-17389856 ] Cassandra Targett commented on SOLR-15482: -- The commits to fix this were acciden

[GitHub] [solr] KennyKnecht commented on a change in pull request #236: SOLR-15546: ShortestPathStream to handle ids with colons.

2021-07-29 Thread GitBox
KennyKnecht commented on a change in pull request #236: URL: https://github.com/apache/solr/pull/236#discussion_r679059202 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/graph/ShortestPathStream.java ## @@ -433,7 +433,7 @@ public JoinRunner(List nodes) {

[jira] [Created] (SOLR-15571) Content of some fiels not return in streaming expressions

2021-07-29 Thread Kenny Knecht (Jira)
Kenny Knecht created SOLR-15571: --- Summary: Content of some fiels not return in streaming expressions Key: SOLR-15571 URL: https://issues.apache.org/jira/browse/SOLR-15571 Project: Solr Issue Ty

[jira] [Updated] (SOLR-15571) Content of some fields not return in streaming expressions

2021-07-29 Thread Kenny Knecht (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenny Knecht updated SOLR-15571: Summary: Content of some fields not return in streaming expressions (was: Content of some fiels no