[
https://issues.apache.org/jira/browse/SOLR-15503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371092#comment-17371092
]
Dawid Weiss commented on SOLR-15503:
Hi Mike. I think this should be implemented as a
madrob commented on a change in pull request #191:
URL: https://github.com/apache/solr/pull/191#discussion_r660288462
##
File path: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java
##
@@ -1853,21 +1853,18 @@ public void testParallelTimeSeriesGrouping() throws
Exc
[
https://issues.apache.org/jira/browse/SOLR-15504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371045#comment-17371045
]
Mike Drob commented on SOLR-15504:
--
cc: [~gus]
> RoutedAlias::fromProps false advertise
Mike Drob created SOLR-15504:
Summary: RoutedAlias::fromProps false advertises about properties
type parameterization
Key: SOLR-15504
URL: https://issues.apache.org/jira/browse/SOLR-15504
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371043#comment-17371043
]
Mike Drob commented on SOLR-13375:
--
[~gus] - is this complete? Should it be closed? What
gerlowskija edited a comment on pull request #190:
URL: https://github.com/apache/solr/pull/190#issuecomment-870154214
This LGTM and is a huge step forward for the ref-guide!
The biggest nitpick I probably have here is that the breaking up of the old
"Admin UI" section (a change I'm
gerlowskija commented on pull request #190:
URL: https://github.com/apache/solr/pull/190#issuecomment-870154214
This LGTM and is a huge step forward for the ref-guide!
The biggest nitpick I probably have here is that the breaking up of the old
"Admin UI" section (a change I'm hugely
cpoerschke edited a comment on pull request #196:
URL: https://github.com/apache/solr/pull/196#issuecomment-870063569
> How are you arriving at the resulting changes after removing some of the
files? For example, in the original PR, the changes to DeleteBackupCmd seem
pretty uninteresting
thelabdude opened a new pull request #197:
URL: https://github.com/apache/solr/pull/197
https://issues.apache.org/jira/browse/SOLR-15499
# Description
See JIRA
# Solution
StatsStream implements ParallelMetricsRollup
# Tests
Needs more testing
madrob commented on a change in pull request #196:
URL: https://github.com/apache/solr/pull/196#discussion_r660138975
##
File path: solr/core/src/test/org/apache/solr/TestRandomDVFaceting.java
##
@@ -125,7 +125,7 @@ void deleteSomeDocs() {
int percent = rand.nextInt(100);
cpoerschke commented on pull request #196:
URL: https://github.com/apache/solr/pull/196#issuecomment-870063569
> How are you arriving at the resulting changes after removing some of the
files? For example, in the original PR, the changes to DeleteBackupCmd seem
pretty uninteresting but the
madrob commented on a change in pull request #196:
URL: https://github.com/apache/solr/pull/196#discussion_r660134018
##
File path: solr/core/src/test/org/apache/solr/util/SolrPluginUtilsTest.java
##
@@ -248,7 +248,7 @@ public void testDisjunctionMaxQueryParser() throws
Except
cpoerschke commented on a change in pull request #196:
URL: https://github.com/apache/solr/pull/196#discussion_r660122371
##
File path: solr/core/src/test/org/apache/solr/TestRandomDVFaceting.java
##
@@ -125,7 +125,7 @@ void deleteSomeDocs() {
int percent = rand.nextInt(10
madrob commented on pull request #196:
URL: https://github.com/apache/solr/pull/196#issuecomment-870059189
Also, I'd like to note that I'm totally fine with splitting this into
whatever reviewable chunks you feel comfortable with, and I appreciate that
you're saving us both time by going a
madrob commented on pull request #196:
URL: https://github.com/apache/solr/pull/196#issuecomment-870027164
How are you arriving at the resulting changes after removing some of the
files? For example, in the original PR, the changes to DeleteBackupCmd seem
pretty uninteresting but they don'
Mike Drob created SOLR-15503:
Summary: Record current number of warnings and fail the build if
that number is exceeded
Key: SOLR-15503
URL: https://issues.apache.org/jira/browse/SOLR-15503
Project: Solr
cpoerschke commented on pull request #196:
URL: https://github.com/apache/solr/pull/196#issuecomment-870020965
It's a bit unusual perhaps but I'd like to try and do one more round of pull
request splitting please:
* #195 had 93 files with "easy" changes left after splitting,
* #196 he
[
https://issues.apache.org/jira/browse/SOLR-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370823#comment-17370823
]
Aroop edited comment on SOLR-15467 at 6/28/21, 7:52 PM:
+1 to wha
[
https://issues.apache.org/jira/browse/SOLR-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370823#comment-17370823
]
Aroop commented on SOLR-15467:
--
+1 to what Cassandra suggested. As a consumer of Solr, I don
madrob opened a new pull request #196:
URL: https://github.com/apache/solr/pull/196
https://issues.apache.org/jira/browse/SOLR-15385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/SOLR-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370809#comment-17370809
]
Cassandra Targett commented on SOLR-15467:
--
What do folks think about renaming t
madrob merged pull request #195:
URL: https://github.com/apache/solr/pull/195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
[
https://issues.apache.org/jira/browse/SOLR-15385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370806#comment-17370806
]
ASF subversion and git services commented on SOLR-15385:
Commit 5
cpoerschke commented on pull request #195:
URL: https://github.com/apache/solr/pull/195#issuecomment-869944074
Merging of this first batch and then a new PR for rest would be my
preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370799#comment-17370799
]
Mike Drob commented on SOLR-15474:
--
Can we mark these APIs as experimental so that we do
madrob commented on a change in pull request #195:
URL: https://github.com/apache/solr/pull/195#discussion_r660007488
##
File path:
solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java
##
@@ -442,23 +442,23 @@ public void modifyRequest(ResponseBuilder rb,
madrob commented on pull request #195:
URL: https://github.com/apache/solr/pull/195#issuecomment-869894976
@cpoerschke so this is the "easy" changes left in here, right? Do you want
me to open a new PR for the remaining 254+5 files or did you mean to add them
back here once you were done w
markrmiller commented on pull request #177:
URL: https://github.com/apache/solr/pull/177#issuecomment-869880889
I took a look at a flag to pull the change regarding the filter, expression,
reduction rule that I removed, but initially I ended up leaving it for a couple
of reasons:
*
psalagnac commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-869802855
Hey @gerlowskija,
Sorry for the late answer here.
Thanks for you feedback. I think we reached an agreement to
keep`BlobIndexInput` and remove the abstraction of the generi
[
https://issues.apache.org/jira/browse/SOLR-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370665#comment-17370665
]
Jason Gerlowski commented on SOLR-15089:
x-posting a comment from GH, in case you
gerlowskija commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-869787293
Hey @athrog - anything holding this up, or did you just miss the
notification on the latest round of comments? (If it's a time thing, lmk and I
can try to help out a bit myself.
[
https://issues.apache.org/jira/browse/SOLR-15502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370652#comment-17370652
]
Bernd Wahlen commented on SOLR-15502:
-
thanks a lot for the detailed explanation.
>A
[
https://issues.apache.org/jira/browse/SOLR-15502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370644#comment-17370644
]
Cassandra Targett commented on SOLR-15502:
--
The documentation for 8.9 is at
htt
[
https://issues.apache.org/jira/browse/SOLR-15502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bernd Wahlen updated SOLR-15502:
Summary: MetricsCollectorHandler deprecated warning (missing documentation)
(was: MetricsCollector
Bernd Wahlen created SOLR-15502:
---
Summary: MetricsCollectorHandler warning
Key: SOLR-15502
URL: https://issues.apache.org/jira/browse/SOLR-15502
Project: Solr
Issue Type: Improvement
Secu
Jacek Kikiewicz created SOLR-15501:
--
Summary: GCSBackupRepository - allow bucket connection without
credentials
Key: SOLR-15501
URL: https://issues.apache.org/jira/browse/SOLR-15501
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-15500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370488#comment-17370488
]
Sayan Das commented on SOLR-15500:
--
I am willing to contribute. If we can confirm over t
Sayan Das created SOLR-15500:
Summary: Compressed Backup
Key: SOLR-15500
URL: https://issues.apache.org/jira/browse/SOLR-15500
Project: Solr
Issue Type: New Feature
Security Level: Public (
janhoy commented on a change in pull request #193:
URL: https://github.com/apache/solr/pull/193#discussion_r659568848
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java
##
@@ -33,16 +33,32 @@
public abstract class CircuitBreaker {
publ
[
https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Atri Sharma reassigned SOLR-15474:
--
Assignee: Atri Sharma
> pluggable support for custom circuit breakers
> --
atris commented on pull request #193:
URL: https://github.com/apache/solr/pull/193#issuecomment-869413150
@janhoy @dsmiley @cpoerschke Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
41 matches
Mail list logo
