[GitHub] [solr] noblepaul commented on a change in pull request #115: SOLR-15392 Tracing span operation name and tags

2021-05-20 Thread GitBox
noblepaul commented on a change in pull request #115: URL: https://github.com/apache/solr/pull/115#discussion_r636641248 ## File path: solr/core/src/java/org/apache/solr/api/V2HttpCall.java ## @@ -360,6 +366,85 @@ protected void execute(SolrQueryResponse rsp) { SolrCore.po

[jira] [Commented] (SOLR-15412) Strict validation on Replica metadata can cause complete outage

2021-05-20 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348972#comment-17348972 ] Noble Paul commented on SOLR-15412: --- {quote}Perhaps "assert" on read to help us further

[jira] [Commented] (SOLR-15420) Exception thrown during intensive batch partial updating and segment merging

2021-05-20 Thread Florin Babes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348970#comment-17348970 ] Florin Babes commented on SOLR-15420: - We do not have documents that big. Our entire

[jira] [Commented] (SOLR-15412) Strict validation on Replica metadata can cause complete outage

2021-05-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348957#comment-17348957 ] David Smiley commented on SOLR-15412: - {quote}My suggestion is, all the validations m

[GitHub] [solr] dsmiley commented on pull request #129: SOLR-15407 untokenized field type with sow=false fix + tests

2021-05-20 Thread GitBox
dsmiley commented on pull request #129: URL: https://github.com/apache/solr/pull/129#issuecomment-845620763 I'll look closer at this PR (e.g. in a debugger etc.) possibly tomorrow or if not then this weekend. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [solr] dsmiley closed pull request #124: source patterns: allow "var" usage

2021-05-20 Thread GitBox
dsmiley closed pull request #124: URL: https://github.com/apache/solr/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[jira] [Commented] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

2021-05-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348946#comment-17348946 ] David Smiley commented on SOLR-15421: - {quote}...if we accidentally create an empty c

[GitHub] [solr] dsmiley merged pull request #138: GitHub PR Template: Add JIRA issue URL

2021-05-20 Thread GitBox
dsmiley merged pull request #138: URL: https://github.com/apache/solr/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[jira] [Commented] (SOLR-15419) Exception thrown during intensive batch partial updating and segment merging

2021-05-20 Thread Takashi Sasaki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348846#comment-17348846 ] Takashi Sasaki commented on SOLR-15419: --- Hello, [~florin.babes]   This is probabl

[GitHub] [solr] cpoerschke commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-20 Thread GitBox
cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r636516706 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java ## @@ -41,25 +37,33 @@ import org.apache.lucene.search.ScoreMode

[jira] [Commented] (SOLR-15416) Remove metrics history collection (and MetricsHistoryHandler)

2021-05-20 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348805#comment-17348805 ] Andrzej Bialecki commented on SOLR-15416: - Good point - yes, we need to deprecate

[jira] [Commented] (SOLR-14679) TLOGs grow forever, never get out of BUFFERING state

2021-05-20 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348803#comment-17348803 ] Timothy Potter commented on SOLR-14679: --- Going to research this issue a bit ... >

[jira] [Resolved] (SOLR-12100) TestPullReplica.testKillLeader fails when PULL replica has the same version but different generation from the leader

2021-05-20 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-12100. --- Fix Version/s: 8.9 main (9.0) Resolution: Fixed > TestPullReplica.t

[jira] [Commented] (SOLR-15399) TestPullReplica and TestPullReplicaWithAuth are flaky

2021-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348717#comment-17348717 ] ASF subversion and git services commented on SOLR-15399: Commit d

[jira] [Resolved] (SOLR-15399) TestPullReplica and TestPullReplicaWithAuth are flaky

2021-05-20 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15399. --- Fix Version/s: 8.9 main (9.0) Resolution: Fixed > TestPullReplica a

[GitHub] [solr-operator] HoustonPutman opened a new issue #271: Upgrade Zookeeper Operator dependency to v0.2.10

2021-05-20 Thread GitBox
HoustonPutman opened a new issue #271: URL: https://github.com/apache/solr-operator/issues/271 The Zookeeper Operator v0.2.10 has been released: https://github.com/pravega/zookeeper-operator/releases/tag/v0.2.10 We should upgrade our dependency, and add support for new options. --

[GitHub] [solr] HoustonPutman commented on pull request #42: SOLR-15277: Schema designer UI and supporting backend

2021-05-20 Thread GitBox
HoustonPutman commented on pull request #42: URL: https://github.com/apache/solr/pull/42#issuecomment-845376159 Some thoughts while playing around: - [ ] I would like to be able to populate the example document with a document that exists. Maybe a button in the query results. - [

[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-20 Thread GitBox
tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r636367520 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java ## @@ -41,25 +37,33 @@ import org.apache.lucene.search.ScoreMode; i

[GitHub] [solr] thelabdude merged pull request #133: SOLR-15399: IndexFetcher should not issue a local commit for PULL replicas

2021-05-20 Thread GitBox
thelabdude merged pull request #133: URL: https://github.com/apache/solr/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Commented] (SOLR-15399) TestPullReplica and TestPullReplicaWithAuth are flaky

2021-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348676#comment-17348676 ] ASF subversion and git services commented on SOLR-15399: Commit c

[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-20 Thread GitBox
tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r636336976 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -23,24 +23,34 @@ import java.util.Set; import org.apache.l

[jira] [Resolved] (SOLR-14749) Provide a clean API for cluster-level event processing

2021-05-20 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14749. - Resolution: Fixed > Provide a clean API for cluster-level event processing >

[jira] [Resolved] (SOLR-15379) Fix API incompatibility after LUCENE-9905

2021-05-20 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-15379. - Fix Version/s: main (9.0) Resolution: Fixed > Fix API incompatibility after LUCENE

[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-20 Thread GitBox
tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r636315533 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -106,18 +106,29 @@ public FieldValueFeatureWeight(IndexSearche

[GitHub] [solr] ctargett commented on pull request #138: GitHub PR Template: Add JIRA issue URL

2021-05-20 Thread GitBox
ctargett commented on pull request #138: URL: https://github.com/apache/solr/pull/138#issuecomment-845314584 +1, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [solr] dsmiley opened a new pull request #138: GitHub PR Template: Add JIRA issue URL

2021-05-20 Thread GitBox
dsmiley opened a new pull request #138: URL: https://github.com/apache/solr/pull/138 I wish our PRs *always* started with a convenient link to the JIRA issue. Here, I am modifying the PR template to put it up front. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr] HoustonPutman commented on a change in pull request #135: SOLR-15421 ConfigSetService.checkConfigExists accepts empty configs

2021-05-20 Thread GitBox
HoustonPutman commented on a change in pull request #135: URL: https://github.com/apache/solr/pull/135#discussion_r636294243 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -151,6 +151,19 @@ public boolean checkConfigExists(String configName

[jira] [Commented] (SOLR-15418) V2 API for GET to a collection's handler fails, complaining about bad contentType

2021-05-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348634#comment-17348634 ] David Smiley commented on SOLR-15418: - This fix in the PR is not to the V2 API but in

[jira] [Assigned] (SOLR-14679) TLOGs grow forever, never get out of BUFFERING state

2021-05-20 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter reassigned SOLR-14679: - Assignee: Timothy Potter > TLOGs grow forever, never get out of BUFFERING state > --

[jira] [Commented] (SOLR-15416) Remove metrics history collection (and MetricsHistoryHandler)

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348614#comment-17348614 ] Jan Høydahl commented on SOLR-15416: Guess this needs to be first deprecated in a 8.x

[GitHub] [solr] dsmiley commented on pull request #133: SOLR-15399: IndexFetcher should not issue a local commit for PULL replicas

2021-05-20 Thread GitBox
dsmiley commented on pull request #133: URL: https://github.com/apache/solr/pull/133#issuecomment-845254919 Impressive work to track this down! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (SOLR-12779) Force field/term centric matching mode for multi-term synonyms with sow=false

2021-05-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348599#comment-17348599 ] David Smiley commented on SOLR-12779: - Also of interest: * Doug Turnbull's blog post

[jira] [Updated] (SOLR-12779) Force field/term centric matching mode for multi-term synonyms with sow=false

2021-05-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12779: Summary: Force field/term centric matching mode for multi-term synonyms with sow=false (was: Force

[jira] [Updated] (SOLR-15425) Upgrade to Metrics 4.2.0

2021-05-20 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15425: Description: In addition to many fixes and compatibility with new Java versions this releas

[jira] [Created] (SOLR-15425) Upgrade to Metrics 4.2.0

2021-05-20 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-15425: --- Summary: Upgrade to Metrics 4.2.0 Key: SOLR-15425 URL: https://issues.apache.org/jira/browse/SOLR-15425 Project: Solr Issue Type: Improvement Sec

[jira] [Updated] (SOLR-15416) Remove metrics history collection (and MetricsHistoryHandler)

2021-05-20 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15416: Summary: Remove metrics history collection (and MetricsHistoryHandler) (was: Consider remo

[jira] [Commented] (SOLR-15416) Consider removing metrics history collection (and MetricsHistoryHandler)

2021-05-20 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348578#comment-17348578 ] Andrzej Bialecki commented on SOLR-15416: - This patch removes MetricsHistoryHandl

[jira] [Updated] (SOLR-15416) Consider removing metrics history collection (and MetricsHistoryHandler)

2021-05-20 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15416: Attachment: SOLR-15416.patch > Consider removing metrics history collection (and MetricsHis

[GitHub] [solr] dsmiley commented on a change in pull request #115: SOLR-15392 Tracing span operation name and tags

2021-05-20 Thread GitBox
dsmiley commented on a change in pull request #115: URL: https://github.com/apache/solr/pull/115#discussion_r636115151 ## File path: solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java ## @@ -202,7 +202,7 @@ public void handleRequest(SolrQueryRequest req, SolrQu

[jira] [Comment Edited] (SOLR-15424) Solr replication UI wraps ETA time

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348502#comment-17348502 ] Jan Høydahl edited comment on SOLR-15424 at 5/20/21, 1:02 PM: -

[jira] [Updated] (SOLR-15424) Solr replication UI wraps ETA time

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15424: --- Attachment: Skjermbilde 2021-05-20 kl. 15.01.35.png > Solr replication UI wraps ETA time > --

[jira] [Commented] (SOLR-15424) Solr replication UI wraps ETA time

2021-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348504#comment-17348504 ] ASF subversion and git services commented on SOLR-15424: Commit 5

[jira] [Resolved] (SOLR-15424) Solr replication UI wraps ETA time

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15424. Fix Version/s: 8.9 Resolution: Fixed > Solr replication UI wraps ETA time >

[GitHub] [solr] janhoy merged pull request #137: SOLR-15424: Solr replication UI wraps ETA time

2021-05-20 Thread GitBox
janhoy merged pull request #137: URL: https://github.com/apache/solr/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[jira] [Commented] (SOLR-15424) Solr replication UI wraps ETA time

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348502#comment-17348502 ] Jan Høydahl commented on SOLR-15424: Easily fixed by allowing more space with CSS, se

[jira] [Commented] (SOLR-15424) Solr replication UI wraps ETA time

2021-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348503#comment-17348503 ] ASF subversion and git services commented on SOLR-15424: Commit f

[GitHub] [solr] janhoy opened a new pull request #137: SOLR-15424: Solr replication UI wraps ETA time

2021-05-20 Thread GitBox
janhoy opened a new pull request #137: URL: https://github.com/apache/solr/pull/137 See https://issues.apache.org/jira/browse/SOLR-15424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Updated] (SOLR-15424) Solr replication UI wraps ETA time

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15424: --- Description: See screenshot. If the time string is long, such as "ETA: 1h 10m 20s", it wraps on top

[jira] [Created] (SOLR-15424) Solr replication UI wraps ETA time

2021-05-20 Thread Jira
Jan Høydahl created SOLR-15424: -- Summary: Solr replication UI wraps ETA time Key: SOLR-15424 URL: https://issues.apache.org/jira/browse/SOLR-15424 Project: Solr Issue Type: Bug Security Le

[jira] [Commented] (SOLR-9539) UI freeze if Zookeeper is down

2021-05-20 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348326#comment-17348326 ] David Eric Pugh commented on SOLR-9539: --- Thanks [~tsasaki609] for retesting this.   

[jira] [Resolved] (SOLR-9539) UI freeze if Zookeeper is down

2021-05-20 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh resolved SOLR-9539. --- Resolution: Cannot Reproduce > UI freeze if Zookeeper is down > --

[jira] [Updated] (SOLR-15423) JWTAuthPlugin support for custom truststore

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15423: --- Issue Type: Improvement (was: New Feature) > JWTAuthPlugin support for custom truststore > -

[jira] [Commented] (SOLR-15420) Exception thrown during intensive batch partial updating and segment merging

2021-05-20 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348322#comment-17348322 ] Adrien Grand commented on SOLR-15420: - This error suggests that a single document gro

[jira] [Commented] (SOLR-9539) UI freeze if Zookeeper is down

2021-05-20 Thread Takashi Sasaki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348304#comment-17348304 ] Takashi Sasaki commented on SOLR-9539: -- Hello, [~mkhl]  I was curious about this is

[GitHub] [solr] tomglk commented on pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

2021-05-20 Thread GitBox
tomglk commented on pull request #123: URL: https://github.com/apache/solr/pull/123#issuecomment-844998271 Hi @cpoerschke , feel free to directly commit to the branch. :) Your idea to make a new jira ticket and PR to break backwards compatibility sounds good to me. It would be use

[GitHub] [solr] cpoerschke commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

2021-05-20 Thread GitBox
cpoerschke commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r635980115 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java ## @@ -41,25 +37,33 @@ import org.apache.lucene.search.ScoreMode

[jira] [Commented] (SOLR-15420) Exception thrown during intensive batch partial updating and segment merging

2021-05-20 Thread Florin Babes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348211#comment-17348211 ] Florin Babes commented on SOLR-15420: - Hello [~janhoy] , Yes, I am doing atomic updat

[jira] [Created] (SOLR-15423) JWTAuthPlugin support for custom truststore

2021-05-20 Thread Jira
Jan Høydahl created SOLR-15423: -- Summary: JWTAuthPlugin support for custom truststore Key: SOLR-15423 URL: https://issues.apache.org/jira/browse/SOLR-15423 Project: Solr Issue Type: New Feature

[GitHub] [solr] asalamon74 opened a new pull request #136: SOLR-15422 Remove commons-lang2 license files

2021-05-20 Thread GitBox
asalamon74 opened a new pull request #136: URL: https://github.com/apache/solr/pull/136 # Description We no longer need these files. # Solution Remove the files # Tests ./gradlew precommit # Checklist Please review the following an

[jira] [Commented] (SOLR-14430) Authorization plugins should check roles from request

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348200#comment-17348200 ] Jan Høydahl commented on SOLR-14430: [~mdrob] can this be closed, now that SOLR-12131

[jira] [Created] (SOLR-15422) Remove commons-lang2 license files

2021-05-20 Thread Andras Salamon (Jira)
Andras Salamon created SOLR-15422: - Summary: Remove commons-lang2 license files Key: SOLR-15422 URL: https://issues.apache.org/jira/browse/SOLR-15422 Project: Solr Issue Type: Improvement

[GitHub] [solr] haythemkh commented on a change in pull request #115: SOLR-15392 Tracing span operation name and tags

2021-05-20 Thread GitBox
haythemkh commented on a change in pull request #115: URL: https://github.com/apache/solr/pull/115#discussion_r635960344 ## File path: solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java ## @@ -202,7 +202,7 @@ public void handleRequest(SolrQueryRequest req, Solr

[jira] [Commented] (SOLR-15420) Exception thrown during intensive batch partial updating and segment merging

2021-05-20 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348190#comment-17348190 ] Dawid Weiss commented on SOLR-15420: Hmmm... I think this is valid code - ByteBuffers

[jira] [Commented] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

2021-05-20 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348188#comment-17348188 ] Andras Salamon commented on SOLR-15421: --- I was not brave enough to modify checkConf

[GitHub] [solr] asalamon74 opened a new pull request #135: SOLR-15421 ConfigSetService.checkConfigExists accepts empty configs

2021-05-20 Thread GitBox
asalamon74 opened a new pull request #135: URL: https://github.com/apache/solr/pull/135 # Description Both FileSystemConfigSetService and ZkConfigSetService only checks the existence of the directory only in checkConfigExists. # Solution Create a new method

[jira] [Created] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

2021-05-20 Thread Andras Salamon (Jira)
Andras Salamon created SOLR-15421: - Summary: ConfigSetService.checkConfigExists accepts empty configs Key: SOLR-15421 URL: https://issues.apache.org/jira/browse/SOLR-15421 Project: Solr Issue

[jira] [Commented] (SOLR-15420) Exception thrown during intensive batch partial updating and segment merging

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348162#comment-17348162 ] Jan Høydahl commented on SOLR-15420: [~florin.babes] can you add some more details on

[jira] [Commented] (SOLR-15420) Exception thrown during intensive batch partial updating and segment merging

2021-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348158#comment-17348158 ] Jan Høydahl commented on SOLR-15420: [~dawid.weiss] you seem to have introduced the M