Re: [PR] GH-3070: Add Variant logical type annotation to parquet-java [parquet-java]

2025-03-26 Thread via GitHub
aihuaxu commented on code in PR #3072: URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2014751901 ## parquet-column/src/test/java/org/apache/parquet/schema/TestTypeBuilders.java: ## @@ -1414,6 +1415,26 @@ public void testTimestampLogicalTypeWithUTCParameter() {

Re: [PR] GH-473: Add variant version [parquet-format]

2025-03-26 Thread via GitHub
rdblue merged PR #474: URL: https://github.com/apache/parquet-format/pull/474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet

Re: [PR] GH-3070: Add Variant logical type annotation to parquet-java [parquet-java]

2025-03-26 Thread via GitHub
aihuaxu commented on code in PR #3072: URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2014723424 ## parquet-format-structures/src/main/java/org/apache/parquet/format/LogicalTypes.java: ## @@ -53,4 +53,5 @@ public static LogicalType DECIMAL(int scale, int preci

Re: [PR] GH-3070: Add Variant logical type annotation to parquet-java [parquet-java]

2025-03-26 Thread via GitHub
aihuaxu commented on code in PR #3072: URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2014723424 ## parquet-format-structures/src/main/java/org/apache/parquet/format/LogicalTypes.java: ## @@ -53,4 +53,5 @@ public static LogicalType DECIMAL(int scale, int preci

Re: [PR] Add test file with unknown logical type [parquet-testing]

2025-03-26 Thread via GitHub
wgtmac merged PR #72: URL: https://github.com/apache/parquet-testing/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.

Re: [PR] Add test file with unknown logical type [parquet-testing]

2025-03-26 Thread via GitHub
wgtmac commented on PR #72: URL: https://github.com/apache/parquet-testing/pull/72#issuecomment-2754258488 I've merged this. Thanks @paleolimbot and @pitrou! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov