Re: [PR] GH-3070: Add Variant logical type annotation to parquet-java [parquet-java]

2025-03-24 Thread via GitHub
aihuaxu commented on code in PR #3072: URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2011120803 ## parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java: ## @@ -447,4 +449,30 @@ public void testEmbeddedAnnotations() { MessageType

Re: [PR] GH-3070: Add Variant logical type annotation to parquet-java [parquet-java]

2025-03-24 Thread via GitHub
rdblue commented on code in PR #3072: URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2010869031 ## parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java: ## @@ -56,6 +56,12 @@ protected LogicalTypeAnnotation fromString(List params)

Re: [PR] GH-3070: Add Variant logical type annotation to parquet-java [parquet-java]

2025-03-24 Thread via GitHub
aihuaxu commented on code in PR #3072: URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2011120803 ## parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java: ## @@ -447,4 +449,30 @@ public void testEmbeddedAnnotations() { MessageType

Re: [I] Make ParquetFileReader extensible [parquet-java]

2025-03-24 Thread via GitHub
kenwenzel commented on issue #3006: URL: https://github.com/apache/parquet-java/issues/3006#issuecomment-2748585018 @gszadovszky I use it directly via Java API: https://github.com/linkedfactory/linkedfactory-pod/blob/f47949823cb96e92e2754f02d411c6290cbef63e/bundles/io.github.linkedfactory

Re: [I] Make ParquetFileReader extensible [parquet-java]

2025-03-24 Thread via GitHub
gszadovszky commented on issue #3006: URL: https://github.com/apache/parquet-java/issues/3006#issuecomment-2748630510 Thanks, @kenwenzel, I've misunderstood the situation then. So, I would keep this issue to it's original title and description to make the parquet-java API more extensible.

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-24 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2010582563 ## parquet-variant/src/main/java/org/apache/parquet/variant/VariantUtil.java: ## @@ -0,0 +1,718 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-24 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2010578002 ## parquet-variant/src/main/java/org/apache/parquet/variant/VariantUtil.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-24 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2010580196 ## parquet-variant/src/main/java/org/apache/parquet/variant/Variant.java: ## @@ -0,0 +1,586 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-24 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2010583174 ## parquet-variant/src/main/java/org/apache/parquet/variant/VariantUtil.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-24 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2010588511 ## parquet-variant/src/main/java/org/apache/parquet/variant/VariantUtil.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-24 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2010592872 ## parquet-variant/src/main/java/org/apache/parquet/variant/Variant.java: ## @@ -0,0 +1,586 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] GH-3070: Add Variant logical type annotation to parquet-java [parquet-java]

2025-03-24 Thread via GitHub
aihuaxu commented on code in PR #3072: URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2011120803 ## parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java: ## @@ -447,4 +449,30 @@ public void testEmbeddedAnnotations() { MessageType

Re: [PR] GH-3070: Add Variant logical type annotation to parquet-java [parquet-java]

2025-03-24 Thread via GitHub
aihuaxu commented on code in PR #3072: URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2011149328 ## parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java: ## @@ -447,4 +449,30 @@ public void testEmbeddedAnnotations() { MessageType

[PR] [MINOR] Enable jitpack.io repo only when brotli is required [parquet-java]

2025-03-24 Thread via GitHub
pan3793 opened a new pull request, #3180: URL: https://github.com/apache/parquet-java/pull/3180 ### Rationale for this change `jitpack.io` Maven repo is added globally but for conditionally `brotli-codec`, my network is very slow to access `jitpack.io` and I'm using an Apple

Re: [I] Make ParquetFileReader extensible [parquet-java]

2025-03-24 Thread via GitHub
kenwenzel commented on issue #3006: URL: https://github.com/apache/parquet-java/issues/3006#issuecomment-2747521352 @gszadovszky My use case is repeated access to the same Parquet files where historical time-series data is retrieved. Our SPARQL-based query engine allows joins between time-s

Re: [PR] PARQUET-2417: Add support for geometry logical type [parquet-java]

2025-03-24 Thread via GitHub
mkaravel commented on code in PR #2971: URL: https://github.com/apache/parquet-java/pull/2971#discussion_r2011234930 ## parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowGeospatialStatisticsCommand.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Fo