Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-21 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2008444043 ## parquet-variant/src/main/java/org/apache/parquet/variant/Variant.java: ## @@ -0,0 +1,444 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-21 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2008458830 ## parquet-variant/src/main/java/org/apache/parquet/variant/VariantSizeLimitException.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-21 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2008466414 ## parquet-variant/src/main/java/org/apache/parquet/variant/VariantUtil.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-21 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2008472927 ## parquet-variant/src/main/java/org/apache/parquet/variant/VariantUtil.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-21 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2008474086 ## parquet-variant/src/main/java/org/apache/parquet/variant/VariantUtil.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] GH-3116: Implement the Variant binary encoding [parquet-java]

2025-03-21 Thread via GitHub
rdblue commented on code in PR #3117: URL: https://github.com/apache/parquet-java/pull/3117#discussion_r2008353653 ## parquet-variant/src/main/java/org/apache/parquet/variant/VariantBuilder.java: ## @@ -0,0 +1,629 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under