[PR] GH-3099 add libthrift to parquet-cli shaded jar [parquet-java]

2024-12-08 Thread via GitHub
Arnaud-Nauwynck opened a new pull request, #3100: URL: https://github.com/apache/parquet-java/pull/3100 ### Rationale for this change see issue [(https://github.com/apache/parquet-java/issues/3099)] the parquet-cli shaded "runtime.jar" does not work. Getting NoClassDefFoundError on

[I] NoClassDefFoundError using parquet-cli shaded jar (building with mvn -Plocal) [parquet-java]

2024-12-08 Thread via GitHub
Arnaud-Nauwynck opened a new issue, #3099: URL: https://github.com/apache/parquet-java/issues/3099 ### Describe the bug, including details regarding any error messages, version, and platform. building parquet-cli shaded jar, and running, I get NoClassDefFoundError on class thrift

Re: [PR] GH-463: Add more types - time, nano timestamps, UUID to Variant spec [parquet-format]

2024-12-08 Thread via GitHub
emkornfield commented on code in PR #464: URL: https://github.com/apache/parquet-format/pull/464#discussion_r1875068044 ## VariantEncoding.md: ## @@ -373,25 +374,37 @@ The Decimal type contains a scale, but no precision. The implied precision of a | Object | `2` | A coll

Re: [PR] GH-463: Add more types - time, nano timestamps, UUID to Variant spec [parquet-format]

2024-12-08 Thread via GitHub
emkornfield commented on code in PR #464: URL: https://github.com/apache/parquet-format/pull/464#discussion_r1875068149 ## VariantEncoding.md: ## @@ -373,25 +374,37 @@ The Decimal type contains a scale, but no precision. The implied precision of a | Object | `2` | A coll

Re: [PR] GH-463: Add more types - time, nano timestamps, UUID to Variant spec [parquet-format]

2024-12-08 Thread via GitHub
emkornfield commented on PR #464: URL: https://github.com/apache/parquet-format/pull/464#issuecomment-2526418545 @aihuaxu sorry two small suggestions to avoid overloading "Logical Type" which is already a separate concept in Parquet. -- This is an automated message from the Apache Git Ser

Re: [PR] GH-463: Add more types - time, nano timestamps, UUID to Variant spec [parquet-format]

2024-12-08 Thread via GitHub
aihuaxu commented on PR #464: URL: https://github.com/apache/parquet-format/pull/464#issuecomment-2526537292 > @aihuaxu sorry two small suggestions to avoid overloading "Logical Type" which is already a separate concept in Parquet. Yeah. Totally agree that we should avoid using logica

Re: [PR] Simplify Variant shredding and refactor for clarity [parquet-format]

2024-12-08 Thread via GitHub
alamb commented on code in PR #461: URL: https://github.com/apache/parquet-format/pull/461#discussion_r1874839885 ## VariantShredding.md: ## @@ -25,290 +25,316 @@ The Variant type is designed to store and process semi-structured data efficiently, even with heterogeneous values