gszadovszky commented on PR #3079:
URL: https://github.com/apache/parquet-java/pull/3079#issuecomment-2511466401
At the last scenario, the "open() raises IOE" doesn't matter, right? I mean,
it can be a test coding detail to throw an exception there so we are sure
open() is not invoked, but
steveloughran commented on PR #3079:
URL: https://github.com/apache/parquet-java/pull/3079#issuecomment-2511530962
> We might use Mockito to check if the method was invoked or not, no need
for an exception
Good point, and yes same codepath.
My feelings about mockito are _mixed_
steveloughran commented on PR #3079:
URL: https://github.com/apache/parquet-java/pull/3079#issuecomment-2511428665
I'm going to propose the following tests to simulate failure and validate
handling.
### openFile() raises IllegalArgumentException, open() works.
open() succeeds s
steveloughran commented on code in PR #3079:
URL: https://github.com/apache/parquet-java/pull/3079#discussion_r1865749087
##
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopInputFile.java:
##
@@ -70,9 +93,38 @@ public long getLength() {
return stat.getLen(
gszadovszky commented on code in PR #3079:
URL: https://github.com/apache/parquet-java/pull/3079#discussion_r1865759470
##
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopInputFile.java:
##
@@ -70,9 +93,38 @@ public long getLength() {
return stat.getLen();
wgtmac commented on issue #3088:
URL: https://github.com/apache/parquet-java/issues/3088#issuecomment-2510842900
Thanks for pinging me @Fokko!
I agree that `FixedSizeBinary` is more appropriate than `Binary`. However, I
would argue that it is invalid to use INT96 for non-timestamp typ
