Re: [PR] GH-3078: Use Hadoop FileSystem.openFile() to open files [parquet-java]

2024-11-29 Thread via GitHub
steveloughran commented on code in PR #3079: URL: https://github.com/apache/parquet-java/pull/3079#discussion_r1863799758 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/wrapped/io/FutureIO.java: ## @@ -70,6 +70,29 @@ public static T awaitFuture(final Future futu

Re: [PR] GH-3078: Use Hadoop FileSystem.openFile() to open files [parquet-java]

2024-11-29 Thread via GitHub
steveloughran commented on code in PR #3079: URL: https://github.com/apache/parquet-java/pull/3079#discussion_r1863804254 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopInputFile.java: ## @@ -70,9 +93,38 @@ public long getLength() { return stat.getLen(

Re: [PR] GH-3078: Use Hadoop FileSystem.openFile() to open files [parquet-java]

2024-11-29 Thread via GitHub
steveloughran commented on code in PR #3079: URL: https://github.com/apache/parquet-java/pull/3079#discussion_r1863799758 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/wrapped/io/FutureIO.java: ## @@ -70,6 +70,29 @@ public static T awaitFuture(final Future futu

Re: [PR] GH-3078: Use Hadoop FileSystem.openFile() to open files [parquet-java]

2024-11-29 Thread via GitHub
gszadovszky commented on code in PR #3079: URL: https://github.com/apache/parquet-java/pull/3079#discussion_r1863829269 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/wrapped/io/FutureIO.java: ## @@ -70,6 +70,29 @@ public static T awaitFuture(final Future future

Re: [PR] GH-3078: Use Hadoop FileSystem.openFile() to open files [parquet-java]

2024-11-29 Thread via GitHub
gszadovszky commented on code in PR #3079: URL: https://github.com/apache/parquet-java/pull/3079#discussion_r1863833209 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopInputFile.java: ## @@ -70,9 +93,38 @@ public long getLength() { return stat.getLen();