wgtmac commented on PR #3079:
URL: https://github.com/apache/parquet-java/pull/3079#issuecomment-2505167772
@Fokko @gszadovszky Could you help review this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
wgtmac commented on PR #3075:
URL: https://github.com/apache/parquet-java/pull/3075#issuecomment-2505169009
Could you try to rebase it? I think the CI failure is due to based on a
problematic commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Fokko merged PR #3082:
URL: https://github.com/apache/parquet-java/pull/3082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.
Fokko merged PR #3081:
URL: https://github.com/apache/parquet-java/pull/3081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.
wgtmac commented on PR #466:
URL: https://github.com/apache/parquet-format/pull/466#issuecomment-2503398615
Perhaps add them like this? @pitrou
```
WARNING: WRITERS SHOULD NOT PRODUCE LIST TYPES LIKE THESE EXAMPLES!
THEY ARE FOR THE PURPOSE OF READING EXISTING DATA ONLY.
// L
pitrou commented on PR #466:
URL: https://github.com/apache/parquet-format/pull/466#issuecomment-2503421529
Ok, please don't use UPPERCASE :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on PR #466:
URL: https://github.com/apache/parquet-format/pull/466#issuecomment-2503273594
@rdblue @wgtmac I'm not sure I agree with removing the examples. They make
it less likely that an implementation would interpret the written rules
wrongly, IMO. Maybe we can instead s
pitrou commented on PR #466:
URL: https://github.com/apache/parquet-format/pull/466#issuecomment-2503276670
Concretely, if I have to review a PR implementing said compatibility rules,
I'd rather have the spec spell out the examples because it makes it easier to
check the PR's implementation
wgtmac commented on code in PR #466:
URL: https://github.com/apache/parquet-format/pull/466#discussion_r1860313055
##
LogicalTypes.md:
##
@@ -609,9 +609,20 @@ that is neither contained by a `LIST`- or `MAP`-annotated
group nor annotated
by `LIST` or `MAP` should be interpreted
