Re: [PR] MINOR: Clarify offsets etc are unsigned integers [parquet-format]

2024-12-06 Thread via GitHub
emkornfield merged PR #475: URL: https://github.com/apache/parquet-format/pull/475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@pa

Re: [PR] MINOR: Clarify offsets etc are unsigned integers [parquet-format]

2024-12-04 Thread via GitHub
emkornfield commented on PR #475: URL: https://github.com/apache/parquet-format/pull/475#issuecomment-2518422458 Thanks for the quick review @gene-db I'll merge this end of week unless there are more comments. @aihuaxu -- This is an automated message from the Apache Git Service. To

Re: [PR] MINOR: Clarify offsets etc are unsigned integers [parquet-format]

2024-12-04 Thread via GitHub
gene-db commented on code in PR #475: URL: https://github.com/apache/parquet-format/pull/475#discussion_r1870179241 ## VariantEncoding.md: ## @@ -88,9 +88,9 @@ metadata |header | +---+ ``` -The metadata is encoded first with the

Re: [PR] MINOR: Clarify offsets etc are unsigned integers [parquet-format]

2024-12-04 Thread via GitHub
emkornfield commented on PR #475: URL: https://github.com/apache/parquet-format/pull/475#issuecomment-2518262268 @gene-db is unsigned correct or should these be signed? CC @rdblue -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] MINOR: Clarify offsets etc are unsigned integers [parquet-format]

2024-12-04 Thread via GitHub
emkornfield opened a new pull request, #475: URL: https://github.com/apache/parquet-format/pull/475 ### Rationale for this change We should clarify whether metadata integers are signed or unsigned. ### What changes are included in this PR? Clarify signedness for Varia