Re: [PR] HDDS-11974. Split Container Safemode Rule into Ratis & EC Container Safemode Rules [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on PR #7951: URL: https://github.com/apache/ozone/pull/7951#issuecomment-2804194367 Thanks @aryangupta1998, @nandakumar131 for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] HDDS-12484. Allow ini files to configure ColumnFamilyOptions for rocksDB [ozone]

2025-04-15 Thread via GitHub
fapifta commented on code in PR #8173: URL: https://github.com/apache/ozone/pull/8173#discussion_r2044355150 ## pom.xml: ## @@ -1559,6 +1559,7 @@ org.rocksdb.TransactionLogIterator.BatchResult org.rocksdb.TickerType

Re: [PR] HDDS-12596. OM fs snapshot max limit is not enforced [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on code in PR #8157: URL: https://github.com/apache/ozone/pull/8157#discussion_r2044313178 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOzoneManagerHASnapshot.java: ## @@ -345,6 +345,29 @@ public void testKeyAndSnapsh

Re: [PR] HDDS-12596. OM fs snapshot max limit is not enforced [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on PR #8157: URL: https://github.com/apache/ozone/pull/8157#issuecomment-2804800091 > which can be detected by implementing > NotifyLeaderChanged(I am not really sure if we need this, maybe it could be helpful resetting the counters in the followers @swamirishi

Re: [PR] HDDS-12524. Reuse TestDataUtil.createKey in more tests [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on code in PR #8270: URL: https://github.com/apache/ozone/pull/8270#discussion_r2044366917 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java: ## @@ -342,12 +343,10 @@ void testListStatusWithInterm

[jira] [Updated] (HDDS-12844) Fix wrong condition for RENAME diff

2025-04-15 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-12844: --- Description: When checking for RENAME diff, it will use the following check [https://github.com/apac

[jira] [Assigned] (HDDS-12847) Use DatanodeID instead of DatanodeDetails.getUuidString

2025-04-15 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee reassigned HDDS-12847: Assignee: (was: Peter Lee) > Use DatanodeID instead of DatanodeDetails.getUuidString > ---

[jira] [Assigned] (HDDS-12847) Use DatanodeID instead of DatanodeDetails.getUuidString

2025-04-15 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Chuan Yu reassigned HDDS-12847: Assignee: Chia-Chuan Yu > Use DatanodeID instead of DatanodeDetails.getUuidString > --

[jira] [Assigned] (HDDS-6631) Fix typos in output/error messages in Ozone.

2025-04-15 Thread Anastasia Kostryukova (Jira)
[ https://issues.apache.org/jira/browse/HDDS-6631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anastasia Kostryukova reassigned HDDS-6631: --- Assignee: Anastasia Kostryukova (was: Jyotinder Singh) > Fix typos in output

Re: [PR] HDDS-12524. Reuse TestDataUtil.createKey in more tests [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on code in PR #8270: URL: https://github.com/apache/ozone/pull/8270#discussion_r2040667234 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java: ## @@ -342,12 +343,10 @@ void testListStatusWithInterm

[jira] [Assigned] (HDDS-12846) Log DatanodeDetails instead of DatanodeDetails.getUuidString

2025-04-15 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee reassigned HDDS-12846: Assignee: (was: Peter Lee) > Log DatanodeDetails instead of DatanodeDetails.getUuidString > --

Re: [PR] HDDS-12796. [DiskBalancer] Exclude UNHEALTHY DNs from status subcommand output [ozone]

2025-04-15 Thread via GitHub
Gargi-jais11 commented on code in PR #8286: URL: https://github.com/apache/ozone/pull/8286#discussion_r2044291322 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerDeadNodeHandler.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

Re: [PR] HDDS-12524. Reuse TestDataUtil.createKey in more tests [ozone]

2025-04-15 Thread via GitHub
adoroszlai commented on code in PR #8270: URL: https://github.com/apache/ozone/pull/8270#discussion_r2044209063 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java: ## @@ -342,12 +343,10 @@ void testListStatusWithInter

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-15 Thread via GitHub
xichen01 commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2044365834 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLifecycleConfiguration.java: ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-15 Thread via GitHub
xichen01 commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2044363951 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLifecycleRuleAndOperator.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-15 Thread via GitHub
xichen01 commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2044366343 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCRule.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] HDDS-12524. Reuse TestDataUtil.createKey in more tests [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on code in PR #8270: URL: https://github.com/apache/ozone/pull/8270#discussion_r2044363626 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java: ## @@ -342,12 +343,10 @@ void testListStatusWithInterm

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-15 Thread via GitHub
xichen01 commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2044367039 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCRule.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] HDDS-12524. Reuse TestDataUtil.createKey in more tests [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on code in PR #8270: URL: https://github.com/apache/ozone/pull/8270#discussion_r2044366917 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java: ## @@ -342,12 +343,10 @@ void testListStatusWithInterm

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-15 Thread via GitHub
xichen01 commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2044366633 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCRule.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[jira] [Commented] (HDDS-8342) S3 Lifecycle Configurations - Object Expiration

2025-04-15 Thread ChenXi (Jira)
[ https://issues.apache.org/jira/browse/HDDS-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944702#comment-17944702 ] ChenXi commented on HDDS-8342: -- > (1) TTL vs trash: we often encounter users accidentally dat

Re: [PR] HDDS-12412. Make hdds-common compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-15 Thread via GitHub
myskov merged PR #7967: URL: https://github.com/apache/ozone/pull/7967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.o

Re: [PR] HDDS-12599. Create an ozone debug CLI command to list all the containers based on final state [ozone]

2025-04-15 Thread via GitHub
sreejasahithi commented on code in PR #8282: URL: https://github.com/apache/ozone/pull/8282#discussion_r2044839581 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/containerlog/parser/ContainerDatanodeDatabase.java: ## @@ -233,5 +238,65 @@ private void dropTable(Strin

[jira] [Resolved] (HDDS-12845) Reuse TestDataUtil.createKey in OzoneRpcClientTests

2025-04-15 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-12845. - Fix Version/s: 2.1.0 Resolution: Implemented > Reuse TestDataUtil.createKey in Ozo

Re: [PR] HDDS-12845. Reuse TestDataUtil.createKey in OzoneRpcClientTests [ozone]

2025-04-15 Thread via GitHub
adoroszlai merged PR #8274: URL: https://github.com/apache/ozone/pull/8274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

[jira] [Updated] (HDDS-12845) Reuse TestDataUtil.createKey in OzoneRpcClientTests

2025-04-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12845: -- Labels: pull-request-available (was: ) > Reuse TestDataUtil.createKey in OzoneRpcClientTests >

[jira] [Created] (HDDS-12851) Investigate failure to create a read only rocksdb instance

2025-04-15 Thread Rishabh Patel (Jira)
Rishabh Patel created HDDS-12851: Summary: Investigate failure to create a read only rocksdb instance Key: HDDS-12851 URL: https://issues.apache.org/jira/browse/HDDS-12851 Project: Apache Ozone

[jira] [Commented] (HDDS-12842) Handle "Expect: 100-continue" header

2025-04-15 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944905#comment-17944905 ] Ivan Andika commented on HDDS-12842: Seems Jetty will handle the "Expect: 100-continu

[jira] [Updated] (HDDS-12848) Split submodule for admin CLI

2025-04-15 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12848: Parent Issue: HDDS-11276 (was: HDDS-11965) > Split submodule for admin CLI > -

[jira] [Created] (HDDS-12852) Create a sliding window based utility to track events

2025-04-15 Thread Rishabh Patel (Jira)
Rishabh Patel created HDDS-12852: Summary: Create a sliding window based utility to track events Key: HDDS-12852 URL: https://issues.apache.org/jira/browse/HDDS-12852 Project: Apache Ozone Is

Re: [PR] HDDS-12723. Handle Volume Db failure in volume scanner [ozone]

2025-04-15 Thread via GitHub
ptlrs commented on code in PR #8256: URL: https://github.com/apache/ozone/pull/8256#discussion_r2046169782 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java: ## @@ -288,6 +306,40 @@ public synchronized VolumeCheckResul

Re: [PR] HDDS-12723. Handle Volume Db failure in volume scanner [ozone]

2025-04-15 Thread via GitHub
ptlrs commented on code in PR #8256: URL: https://github.com/apache/ozone/pull/8256#discussion_r2046172469 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java: ## @@ -97,6 +102,11 @@ public class HddsVolume extends Stora

Re: [PR] HDDS-12518. Auto-compact tables which can tend to be large in size at intervals [ozone]

2025-04-15 Thread via GitHub
Tejaskriya commented on PR #8260: URL: https://github.com/apache/ozone/pull/8260#issuecomment-2808452855 Thanks @aryangupta1998 for the approval, just another change, I hope you are good with it: @swamirishi @jojochuang , to not reduce the performance of snapshots, compactionService is d

Re: [PR] HDDS-12350. Reduce duplication between OmBucketReadWrite tests [ozone]

2025-04-15 Thread via GitHub
priyeshkaratha commented on code in PR #8241: URL: https://github.com/apache/ozone/pull/8241#discussion_r2046148577 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestOmBucketReadWriteFileOps.java: ## @@ -54,7 +52,8 @@ static List parameters() {

[jira] [Created] (HDDS-12850) Compact tables by priority in the background service

2025-04-15 Thread Tejaskriya Madhan (Jira)
Tejaskriya Madhan created HDDS-12850: Summary: Compact tables by priority in the background service Key: HDDS-12850 URL: https://issues.apache.org/jira/browse/HDDS-12850 Project: Apache Ozone

Re: [PR] HDDS-12518. Auto-compact tables which can tend to be large in size at intervals [ozone]

2025-04-15 Thread via GitHub
Tejaskriya commented on PR #8260: URL: https://github.com/apache/ozone/pull/8260#issuecomment-2808346008 @aryangupta1998 thanks for the suggestion, created [HDDS-12850](https://issues.apache.org/jira/browse/HDDS-12850) for adding this good-to-have logic. -- This is an automated message

Re: [PR] HDDS-12560. Reclaimable Filter for Snaphost Garbage Collections [ozone]

2025-04-15 Thread via GitHub
aswinshakil commented on code in PR #8053: URL: https://github.com/apache/ozone/pull/8053#discussion_r2046195004 ## hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/CheckedFunction.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] HDDS-8802. Added pagination support for ListSnapshotDiff jobs [ozone]

2025-04-15 Thread via GitHub
hemantk-12 commented on code in PR #8124: URL: https://github.com/apache/ozone/pull/8124#discussion_r2045137639 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java: ## @@ -1436,19 +1436,26 @@ private CancelSnapshotDiffRe

Re: [PR] HDDS-12827. Move out NodeStateMap.Entry and ContainerMap.Entry. [ozone]

2025-04-15 Thread via GitHub
adoroszlai merged PR #8273: URL: https://github.com/apache/ozone/pull/8273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12827. Move out NodeStateMap.Entry and ContainerMap.Entry. [ozone]

2025-04-15 Thread via GitHub
adoroszlai commented on PR #8273: URL: https://github.com/apache/ozone/pull/8273#issuecomment-2807223974 Thanks @szetszwo for the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Resolved] (HDDS-12827) Move out NodeStateMap.Entry and ContainerMap.Entry

2025-04-15 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-12827. - Fix Version/s: 2.1.0 Resolution: Done > Move out NodeStateMap.Entry and ContainerM

[jira] [Created] (HDDS-12848) Split submodule for admin CLI

2025-04-15 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-12848: --- Summary: Split submodule for admin CLI Key: HDDS-12848 URL: https://issues.apache.org/jira/browse/HDDS-12848 Project: Apache Ozone Issue Type: Sub-task

Re: [PR] HDDS-12742. Make RDBStoreAbstractIterator Return Reference-Counted KeyValues to Improve Consistency and Performance [ozone]

2025-04-15 Thread via GitHub
szetszwo commented on code in PR #8203: URL: https://github.com/apache/ozone/pull/8203#discussion_r2045408163 ## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java: ## @@ -78,38 +82,50 @@ final RAW getPrefix() { @Override pu

[jira] [Updated] (HDDS-9108) Delete bucket with force fails while using S3 API for FSO bucket in s3v volume

2025-04-15 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-9108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-9108: -- Fix Version/s: 2.0.0 1.4.1 > Delete bucket with force fails while using S3 AP

Re: [PR] HDDS-8802. Added pagination support for ListSnapshotDiff jobs [ozone]

2025-04-15 Thread via GitHub
hemantk-12 commented on code in PR #8124: URL: https://github.com/apache/ozone/pull/8124#discussion_r2045137639 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java: ## @@ -1436,19 +1436,26 @@ private CancelSnapshotDiffRe

Re: [PR] HDDS-8802. Added pagination support for ListSnapshotDiff jobs [ozone]

2025-04-15 Thread via GitHub
hemantk-12 commented on code in PR #8124: URL: https://github.com/apache/ozone/pull/8124#discussion_r2045137639 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java: ## @@ -1436,19 +1436,26 @@ private CancelSnapshotDiffRe

[jira] [Updated] (HDDS-9108) Improve error message when force deleting FSO bucket via S3

2025-04-15 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-9108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-9108: -- Summary: Improve error message when force deleting FSO bucket via S3 (was: Delete bucket with f

[jira] [Commented] (HDDS-9108) Delete bucket with force fails while using S3 API for FSO bucket in s3v volume

2025-04-15 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-9108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944807#comment-17944807 ] Wei-Chiu Chuang commented on HDDS-9108: --- Per [~SaketaChalamchala] the pull request i

Re: [PR] HDDS-12518. Auto-compact tables which can tend to be large in size at intervals [ozone]

2025-04-15 Thread via GitHub
aryangupta1998 commented on PR #8260: URL: https://github.com/apache/ozone/pull/8260#issuecomment-2800889228 @Tejaskriya, thanks for adding the tests. Regarding the priority handling, I checked the code and noticed that BackgroundTaskQueue is backed by a PriorityQueue using: `Comparato

[jira] [Updated] (HDDS-12838) Bump awssdk to 2.31.21

2025-04-15 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12838: Fix Version/s: 2.1.0 Resolution: Done Status: Resolved (was: Patch Availa

Re: [PR] HDDS-12740. Use DatanodeID in HddsTestUtils [ozone]

2025-04-15 Thread via GitHub
szetszwo commented on PR #8281: URL: https://github.com/apache/ozone/pull/8281#issuecomment-2802573848 @peterxcli , there is a test failure. Please take a look. ``` org.apache.hadoop.hdds.scm.node.TestDecommissionAndMaintenance.testSingleNodeWithOpenPipelineCanGotoMaintenance -- Time

[jira] [Updated] (HDDS-12723) Volume scanner should fail volume if rocksDB is inaccessible

2025-04-15 Thread Rishabh Patel (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishabh Patel updated HDDS-12723: - Status: Patch Available (was: In Progress) > Volume scanner should fail volume if rocksDB is ina

Re: [PR] HDDS-12742. Make RDBStoreAbstractIterator Return Reference-Counted KeyValues to Improve Consistency and Performance [ozone]

2025-04-15 Thread via GitHub
szetszwo commented on code in PR #8203: URL: https://github.com/apache/ozone/pull/8203#discussion_r2045242409 ## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreCodecBufferIterator.java: ## @@ -84,38 +92,77 @@ CodecBuffer getFromDb() { } } -

Re: [PR] HDDS-8802. Added pagination support for ListSnapshotDiff jobs [ozone]

2025-04-15 Thread via GitHub
hemantk-12 commented on code in PR #8124: URL: https://github.com/apache/ozone/pull/8124#discussion_r2045137639 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java: ## @@ -1436,19 +1436,26 @@ private CancelSnapshotDiffRe

[jira] [Updated] (HDDS-12773) bad substitution in bats test

2025-04-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12773: -- Labels: pull-request-available (was: ) > bad substitution in bats test > -

[PR] HDDS-12773. bad substitution in bats test [ozone]

2025-04-15 Thread via GitHub
adoroszlai opened a new pull request, #8290: URL: https://github.com/apache/ozone/pull/8290 ## What changes were proposed in this pull request? Fix `bad substitution` in bats test: ``` 1..5 Using Docker Compose v2 /home/runner/work/ozone/ozone/hadoop-ozone/dist/src/tes

Re: [PR] HDDS-12599. Create an ozone debug CLI command to list all the containers based on final state [ozone]

2025-04-15 Thread via GitHub
aryangupta1998 commented on code in PR #8282: URL: https://github.com/apache/ozone/pull/8282#discussion_r2045417040 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/container/ListContainers.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] HDDS-12599. Create an ozone debug CLI command to list all the containers based on final state [ozone]

2025-04-15 Thread via GitHub
aryangupta1998 commented on code in PR #8282: URL: https://github.com/apache/ozone/pull/8282#discussion_r2045417331 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/container/ListContainers.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] HDDS-12599. Create an ozone debug CLI command to list all the containers based on final state [ozone]

2025-04-15 Thread via GitHub
aryangupta1998 commented on code in PR #8282: URL: https://github.com/apache/ozone/pull/8282#discussion_r2045416686 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/container/ListContainers.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] HDDS-12599. Create an ozone debug CLI command to list all the containers based on final state [ozone]

2025-04-15 Thread via GitHub
aryangupta1998 commented on code in PR #8282: URL: https://github.com/apache/ozone/pull/8282#discussion_r2045425900 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/containerlog/parser/ContainerDatanodeDatabase.java: ## @@ -233,5 +240,99 @@ private void dropTable(Stri

[jira] [Commented] (HDDS-10284) Replace GenericTestUtils temp dir in MiniOzoneCluster

2025-04-15 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944777#comment-17944777 ] Chia-Chuan Yu commented on HDDS-10284: -- Currently not, [~kostacie] can have it, than

Re: [PR] HDDS-12493. Move container upgrade under repair [ozone]

2025-04-15 Thread via GitHub
adoroszlai commented on PR #8205: URL: https://github.com/apache/ozone/pull/8205#issuecomment-2806537373 Thanks @nandakumar131 for the review and resolving conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (HDDS-12412) Rearrange code accordingly in hdds-common

2025-04-15 Thread Maksim Myskov (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Myskov updated HDDS-12412: - Resolution: Fixed Status: Resolved (was: Patch Available) > Rearrange code accordingly i

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-15 Thread via GitHub
xichen01 commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2044367362 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCExpiration.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Updated] (HDDS-12841) Remove unnecessary getBucketInfo() call under OFS#readFile API

2025-04-15 Thread Tanvi Penumudy (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tanvi Penumudy updated HDDS-12841: -- Description: As of today, the readFile API for the OFS client makes two round trips to the Ozo

Re: [PR] HDDS-12596. OM fs snapshot max limit is not enforced [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on PR #8157: URL: https://github.com/apache/ozone/pull/8157#issuecomment-2803988575 @hemantk-12 @swamirishi Just came up one question: Does `notifyStatusChanged` happen before any request applied on new leader node and also executed in serial? -- This is an automat

Re: [PR] HDDS-8802. Added pagination support for ListSnapshotDiff jobs [ozone]

2025-04-15 Thread via GitHub
sadanand48 commented on code in PR #8124: URL: https://github.com/apache/ozone/pull/8124#discussion_r2043763369 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java: ## @@ -1436,19 +1436,26 @@ private CancelSnapshotDiffRe

[jira] [Resolved] (HDDS-12830) Add RocksDatabaseException

2025-04-15 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze resolved HDDS-12830. --- Fix Version/s: 2.1.0 Resolution: Fixed The pull request is merged. > Add RocksDatabaseExcepti

Re: [PR] HDDS-12704. adding missing audit logs for operations. [ozone]

2025-04-15 Thread via GitHub
adoroszlai commented on PR #8251: URL: https://github.com/apache/ozone/pull/8251#issuecomment-2803938840 Please remove duplicate `checkAdminAccess` (the one outside try block): https://github.com/apache/ozone/blob/929d7178762ffcf92ffd77ac42be78f800aeb3be/hadoop-hdds/server-scm/src/mai

[jira] [Updated] (HDDS-12842) Handle "Expect: 100-continue" header

2025-04-15 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-12842: --- Description: AWS S3 SDK might send "Expect: 100-continue" header for PUT request (UploadObject / Upl

[jira] [Created] (HDDS-12836) Bump JUnit to 5.12.2

2025-04-15 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-12836: --- Summary: Bump JUnit to 5.12.2 Key: HDDS-12836 URL: https://issues.apache.org/jira/browse/HDDS-12836 Project: Apache Ozone Issue Type: Task Co

Re: [PR] HDDS-12771. xcompat fails if run in itself due to undefined OZONE_CURRENT_VERSION [ozone]

2025-04-15 Thread via GitHub
adoroszlai merged PR #8236: URL: https://github.com/apache/ozone/pull/8236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12745. Container checksum should be reported during container close and DN restart [ozone]

2025-04-15 Thread via GitHub
aswinshakil merged PR #8204: URL: https://github.com/apache/ozone/pull/8204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apa

[jira] [Updated] (HDDS-11763) Implement container repair logic within datanodes

2025-04-15 Thread Aswin Shakil (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aswin Shakil updated HDDS-11763: Resolution: Fixed Status: Resolved (was: Patch Available) > Implement container repair log

Re: [PR] HDDS-12113. Move HAProxy test to HA environment [ozone]

2025-04-15 Thread via GitHub
adoroszlai commented on code in PR #8271: URL: https://github.com/apache/ozone/pull/8271#discussion_r2044232175 ## hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test-haproxy-s3g.sh: ## @@ -15,34 +15,29 @@ # See the License for the specific language governing permissions and

Re: [PR] HDDS-12524. Reuse TestDataUtil.createKey in more tests [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on code in PR #8270: URL: https://github.com/apache/ozone/pull/8270#discussion_r2044366917 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java: ## @@ -342,12 +343,10 @@ void testListStatusWithInterm

[jira] [Updated] (HDDS-12745) Container checksum should be reported during container close and DN restart

2025-04-15 Thread Aswin Shakil (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aswin Shakil updated HDDS-12745: Resolution: Fixed Status: Resolved (was: Patch Available) > Container checksum should be r

Re: [PR] HDDS-12704. adding missing audit logs for operations. [ozone]

2025-04-15 Thread via GitHub
priyeshkaratha commented on PR #8251: URL: https://github.com/apache/ozone/pull/8251#issuecomment-2804513130 Thank you @adoroszlai for the detailed review. Addressed all the mentioned changes. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Updated] (HDDS-12493) Move container upgrade under repair

2025-04-15 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12493: Fix Version/s: 2.1.0 Resolution: Done Status: Resolved (was: Patch Availa

Re: [PR] HDDS-12796. [DiskBalancer] Exclude UNHEALTHY DNs from status subcommand output [ozone]

2025-04-15 Thread via GitHub
ChenSammi commented on code in PR #8286: URL: https://github.com/apache/ozone/pull/8286#discussion_r2044238794 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java: ## @@ -333,6 +334,22 @@ public void processDiskBalancerReport(DiskBal

Re: [PR] HDDS-12524. Reuse TestDataUtil.createKey in more tests [ozone]

2025-04-15 Thread via GitHub
adoroszlai commented on code in PR #8270: URL: https://github.com/apache/ozone/pull/8270#discussion_r2045063700 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java: ## @@ -274,6 +274,7 @@ void initClusterAndEnv() throw

[jira] [Commented] (HDDS-10284) Replace GenericTestUtils temp dir in MiniOzoneCluster

2025-04-15 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944776#comment-17944776 ] Attila Doroszlai commented on HDDS-10284: - [~chiacyu], have you made progress on

Re: [PR] HDDS-12762. [Ozone 2.0] Update Apache Release Manager Guide. [ozone-site]

2025-04-15 Thread via GitHub
jojochuang commented on code in PR #143: URL: https://github.com/apache/ozone-site/pull/143#discussion_r2043185891 ## docs/08-developer-guide/04-project/02-release-guide.md: ## @@ -426,6 +479,10 @@ git tag -s "ozone-$VERSION" -m "Ozone $VERSION release" git push origin "ozone-$

[PR] HDDS-12830. Add RocksDatabaseException. [ozone]

2025-04-15 Thread via GitHub
szetszwo opened a new pull request, #8277: URL: https://github.com/apache/ozone/pull/8277 ## What changes were proposed in this pull request? When rocksdb throws a RocksDBException, we convert it to an IOException. It is better to add a new RocksDatabaseException. Then, callers is eas

Re: [PR] HDDS-12779. Parallelize table iteration across different ranges [ozone]

2025-04-15 Thread via GitHub
swamirishi commented on PR #8243: URL: https://github.com/apache/ozone/pull/8243#issuecomment-2802912616 Closing this PR in favour breaking into small PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Assigned] (HDDS-10284) Replace GenericTestUtils temp dir in MiniOzoneCluster

2025-04-15 Thread Anastasia Kostryukova (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anastasia Kostryukova reassigned HDDS-10284: Assignee: Anastasia Kostryukova (was: Chia-Chuan Yu) > Replace GenericTes

[jira] [Updated] (HDDS-12842) Handle "Expect: 100-continue" header

2025-04-15 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-12842: --- Description: AWS S3 SDK might send "Expect: 100-continue" header for PUT request (UploadObject / Upl

[jira] [Updated] (HDDS-12837) Bump vite to 4.5.13

2025-04-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12837: -- Labels: pull-request-available (was: ) > Bump vite to 4.5.13 > --- > >

Re: [PR] HDDS-8802. Added pagination support for ListSnapshotDiff jobs [ozone]

2025-04-15 Thread via GitHub
hemantk-12 commented on code in PR #8124: URL: https://github.com/apache/ozone/pull/8124#discussion_r2045137639 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java: ## @@ -1436,19 +1436,26 @@ private CancelSnapshotDiffRe

[PR] HDDS-12841. Remove unnecessary getBucketInfo() call under OFS#readFile API [ozone]

2025-04-15 Thread via GitHub
tanvipenumudy opened a new pull request, #8288: URL: https://github.com/apache/ozone/pull/8288 ## What changes were proposed in this pull request? As of today, the readFile API for the OFS client makes two round trips to the Ozone Manager impacting performance: - First, it call

[jira] [Created] (HDDS-12842) Handle "Expect: 100-continue" header

2025-04-15 Thread Ivan Andika (Jira)
Ivan Andika created HDDS-12842: -- Summary: Handle "Expect: 100-continue" header Key: HDDS-12842 URL: https://issues.apache.org/jira/browse/HDDS-12842 Project: Apache Ozone Issue Type: Sub-task

Re: [PR] HDDS-11974. Split Container Safemode Rule into Ratis & EC Container Safemode Rules [ozone]

2025-04-15 Thread via GitHub
nandakumar131 commented on PR #7951: URL: https://github.com/apache/ozone/pull/7951#issuecomment-2804164272 @aryangupta1998 If you're ok with the changes, we can go ahead and merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] HDDS-12524. Reuse TestDataUtil.createKey in more tests [ozone]

2025-04-15 Thread via GitHub
chiacyu commented on PR #8274: URL: https://github.com/apache/ozone/pull/8274#issuecomment-2804163169 Hey, @adoroszlai Good to have you back, would fix these soon, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Updated] (HDDS-12842) Handle "Expect: 100-continue" header

2025-04-15 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-12842: --- Description: AWS S3 SDK might send "Expect: 100-continue" header for PUT request (UploadObject / Upl

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-15 Thread via GitHub
ChenSammi commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2043912231 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCExpiration.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] HDDS-11974. Split Container Safemode Rule into Ratis & EC Container Safemode Rules [ozone]

2025-04-15 Thread via GitHub
nandakumar131 commented on code in PR #7951: URL: https://github.com/apache/ozone/pull/7951#discussion_r2043899093 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/ECContainerSafeModeRule.java: ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-15 Thread via GitHub
ChenSammi commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2043922457 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCExpiration.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (AS

[jira] [Updated] (HDDS-11974) Split Container Safemode Rule into Ratis & EC Container Safemode Rules

2025-04-15 Thread Aryan Gupta (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aryan Gupta updated HDDS-11974: --- Fix Version/s: 2.1.0 Resolution: Fixed Status: Resolved (was: Patch Available) > S

Re: [PR] HDDS-12823. SnapshotDiffReportOzone#fromProtobuf empty token handling [ozone]

2025-04-15 Thread via GitHub
peterxcli commented on code in PR #8280: URL: https://github.com/apache/ozone/pull/8280#discussion_r2043928160 ## hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/snapshot/SnapshotDiffHandler.java: ## @@ -156,7 +156,7 @@ private ObjectNode getJsonObject(Snapsho

Re: [PR] HDDS-12740. Use DatanodeID in HddsTestUtils [ozone]

2025-04-15 Thread via GitHub
adoroszlai commented on PR #8281: URL: https://github.com/apache/ozone/pull/8281#issuecomment-2804197571 Thanks @peterxcli for testing the test. Can you please check if HDDS-5626 has subtask for this flaky test, and if not, file one? -- This is an automated message from the Apache Git Se

  1   2   >