adoroszlai merged PR #8104:
URL: https://github.com/apache/ozone/pull/8104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apac
adoroszlai commented on PR #8104:
URL: https://github.com/apache/ozone/pull/8104#issuecomment-2751059129
Thanks @chiacyu for the patch, @peterxcli, @swamirishi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
peterxcli commented on PR #8104:
URL: https://github.com/apache/ozone/pull/8104#issuecomment-2745293282
New ci run: https://github.com/chiacyu/ozone/actions/runs/14008980447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
peterxcli commented on PR #8104:
URL: https://github.com/apache/ozone/pull/8104#issuecomment-2745244883
Thanks @chiacyu for updating the patch.
The `cleanup the "set value with property name" part in testWriteTimeout`
means:
Want:
```java
@Test
public void testWriteTim
chiacyu commented on PR #8104:
URL: https://github.com/apache/ozone/pull/8104#issuecomment-2739788894
@Hi, @peterxcli
I implemented almost all the suggested comments, except for `cleanup the
"set value with property name" part in testWriteTimeout`. I'm a little bit
confused about the re
chiacyu commented on PR #8104:
URL: https://github.com/apache/ozone/pull/8104#issuecomment-2736875593
Hi, @peterxcli
Thanks for the reviews indeed!, would apply the review comments soon. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
peterxcli commented on code in PR #8104:
URL: https://github.com/apache/ozone/pull/8104#discussion_r2003360140
##
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/TestContainerStateMachine.java:
##
@@ -137,45 +162,46 @@
peterxcli commented on PR #8104:
URL: https://github.com/apache/ozone/pull/8104#issuecomment-2736809515
Hi @chiacyu, if you have time, it would be really helpful to include the CI
run link in the PR description. Thank you!
--
This is an automated message from the Apache Git Service.
To re
adoroszlai commented on PR #8104:
URL: https://github.com/apache/ozone/pull/8104#issuecomment-2735919242
@peterxcli would you like to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
