Re: [PR] NIFI-14783 Start Embedded ZooKeeper before State Manager operations [nifi]

2025-08-04 Thread via GitHub
exceptionfactory commented on PR #10170: URL: https://github.com/apache/nifi/pull/10170#issuecomment-3152993075 Marked as ready for review following several successful builds. The latest update to shift starting the embedded ZooKeeper server earlier in `FlowController` helps avoid sit

[PR] NIFI-14783 Start Embedded ZooKeeper before State Manager operations [nifi]

2025-08-04 Thread via GitHub
exceptionfactory opened a new pull request, #10170: URL: https://github.com/apache/nifi/pull/10170 # Summary [NIFI-14783](https://issues.apache.org/jira/browse/NIFI-14783) Includes the following changes to improve stability in system tests with more predictable behavior when starting

Re: [PR] NIFI-14783 Stop Node Protocol Listener before Controller [nifi]

2025-08-04 Thread via GitHub
exceptionfactory closed pull request #10169: NIFI-14783 Stop Node Protocol Listener before Controller URL: https://github.com/apache/nifi/pull/10169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] NIFI-14783 Stop Node Protocol Listener before Controller [nifi]

2025-08-04 Thread via GitHub
exceptionfactory commented on PR #10169: URL: https://github.com/apache/nifi/pull/10169#issuecomment-3152284508 Thanks @pvillard31, after several successful runs on my fork, I also see the failure. I will review the logs and open a new pull request after further investigation. -- This is

Re: [PR] NIFI-14783 Stop Node Protocol Listener before Controller [nifi]

2025-08-04 Thread via GitHub
pvillard31 commented on PR #10169: URL: https://github.com/apache/nifi/pull/10169#issuecomment-3152273969 > Error: Errors: Error:FlowSynchronizationIT.testComponentsRecreatedOnRestart » Timeout testComponentsRecreatedOnRestart() timed out after 5 minutes :( -- This is an a

[PR] NIFI-14783 Stop Node Protocol Listener before Controller [nifi]

2025-08-04 Thread via GitHub
exceptionfactory opened a new pull request, #10169: URL: https://github.com/apache/nifi/pull/10169 # Summary [NIFI-14783](https://issues.apache.org/jira/browse/NIFI-14783) Changes the `StandardFlowService.stop()` method to stop the Node Protocol Sender Listener before shutting down t

Re: [PR] NIFI-14615: Added a parquet content viewer to the nifi-parquet-bundle. [nifi]

2025-08-04 Thread via GitHub
exceptionfactory commented on code in PR #10013: URL: https://github.com/apache/nifi/pull/10013#discussion_r2252385620 ## nifi-extension-bundles/nifi-parquet-bundle/nifi-parquet-shared/pom.xml: ## @@ -0,0 +1,42 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="htt

Re: [PR] NIFI-14615: Added a parquet content viewer to the nifi-parquet-bundle. [nifi]

2025-08-04 Thread via GitHub
exceptionfactory commented on code in PR #10013: URL: https://github.com/apache/nifi/pull/10013#discussion_r2252384082 ## nifi-extension-bundles/nifi-parquet-bundle/nifi-parquet-content-viewer/src/main/java/org/apache/parquet/web/controller/ParquetContentViewerController.java: #

Re: [PR] NIFI-14818 - Bump GCP SDK to 26.65.0, Azure SDK to 1.2.37 and others [nifi]

2025-08-04 Thread via GitHub
pvillard31 commented on PR #10168: URL: https://github.com/apache/nifi/pull/10168#issuecomment-3151580643 Yep, good hint. The output is not 100% the same when displaying usage but very very close so should be good enough. -- This is an automated message from the Apache Git Service. To res

Re: [PR] MINIFICPP-2558 Revamp site to site communication [nifi-minifi-cpp]

2025-08-04 Thread via GitHub
lordgamez commented on code in PR #1966: URL: https://github.com/apache/nifi-minifi-cpp/pull/1966#discussion_r2252000884 ## libminifi/src/sitetosite/RawSiteToSiteClient.cpp: ## @@ -0,0 +1,431 @@ +/** + * Site2SiteProtocol class implementation + * + * Licensed to the Apache Softw

Re: [PR] MINIFICPP-2558 Revamp site to site communication [nifi-minifi-cpp]

2025-08-04 Thread via GitHub
lordgamez commented on code in PR #1966: URL: https://github.com/apache/nifi-minifi-cpp/pull/1966#discussion_r2251990479 ## libminifi/src/sitetosite/HttpSiteToSiteClient.cpp: ## @@ -0,0 +1,415 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

Re: [PR] NIFI-14789 In PutSQL send incoming invalid FlowFiles to failure. [nifi]

2025-08-04 Thread via GitHub
exceptionfactory commented on code in PR #10136: URL: https://github.com/apache/nifi/pull/10136#discussion_r2251811324 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java: ## @@ -701,46 +703,64 @@

Re: [PR] MINIFICPP-2597 Replace removed thirdparty actions [nifi-minifi-cpp]

2025-08-04 Thread via GitHub
fgerlits commented on code in PR #1998: URL: https://github.com/apache/nifi-minifi-cpp/pull/1998#discussion_r2251771804 ## .github/workflows/ci.yml: ## @@ -183,7 +183,7 @@ jobs: ${{ runner.os }}-2022-sccache-refs/heads/main ${{ runner.os }}-2022-sccache

Re: [PR] MINIFICPP-2591 Add new value option to FetchOPCProcessor lazy mode [nifi-minifi-cpp]

2025-08-04 Thread via GitHub
fgerlits commented on code in PR #1994: URL: https://github.com/apache/nifi-minifi-cpp/pull/1994#discussion_r2251706659 ## extensions/opc/src/fetchopc.cpp: ## @@ -140,7 +205,7 @@ bool FetchOPCProcessor::nodeFoundCallBack(const UA_ReferenceDescription *ref, co return true; }

Re: [PR] NIFI-14818 - Bump GCP SDK to 26.65.0, Azure SDK to 1.2.37 and others [nifi]

2025-08-04 Thread via GitHub
dan-s1 commented on PR #10168: URL: https://github.com/apache/nifi/pull/10168#issuecomment-3151106368 How about `org.apache.commons.cli.help.HelpAppendable` which you can access from `org.apache.commons.cli.help.HelpFormatter`? -- This is an automated message from the Apache Git Service.

Re: [PR] NIFI-14789 In PutSQL send incoming invalid FlowFiles to failure. [nifi]

2025-08-04 Thread via GitHub
tpalfy commented on code in PR #10136: URL: https://github.com/apache/nifi/pull/10136#discussion_r2251715505 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java: ## @@ -805,50 +825,50 @@ boolean is

Re: [PR] NIFI-14789 In PutSQL send incoming invalid FlowFiles to failure. [nifi]

2025-08-04 Thread via GitHub
tpalfy commented on code in PR #10136: URL: https://github.com/apache/nifi/pull/10136#discussion_r2251712324 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java: ## @@ -701,46 +703,64 @@ private Fl

Re: [PR] NIFI-14789 In PutSQL send incoming invalid FlowFiles to failure. [nifi]

2025-08-04 Thread via GitHub
tpalfy commented on code in PR #10136: URL: https://github.com/apache/nifi/pull/10136#discussion_r2251709344 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java: ## @@ -701,46 +703,64 @@ private Fl

Re: [PR] NIFI-14818 - Bump GCP SDK to 26.65.0, Azure SDK to 1.2.37 and others [nifi]

2025-08-04 Thread via GitHub
pvillard31 commented on PR #10168: URL: https://github.com/apache/nifi/pull/10168#issuecomment-3150975801 Fixed some but not sure to see a straightforward way to replace the use of `printWrapped` at the moment. -- This is an automated message from the Apache Git Service. To respond to the

[PR] MINIFICPP-2597 Replace removed thirdparty actions [nifi-minifi-cpp]

2025-08-04 Thread via GitHub
lordgamez opened a new pull request, #1998: URL: https://github.com/apache/nifi-minifi-cpp/pull/1998 https://issues.apache.org/jira/browse/MINIFICPP-2597 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of

Re: [PR] MINIFICPP-2587 Add Sparkplug B support for ConsumeMQTT processor [nifi-minifi-cpp]

2025-08-04 Thread via GitHub
fgerlits commented on code in PR #1990: URL: https://github.com/apache/nifi-minifi-cpp/pull/1990#discussion_r2245787019 ## docker/test/integration/cluster/checkers/sparkplug_b_pb2.py: ## Review Comment: Could we generate this when building (or before running) the tests inst

Re: [PR] NIFI-14728 Allow git Flow Registry sync interval to be user defined [nifi]

2025-08-04 Thread via GitHub
exceptionfactory merged PR #10141: URL: https://github.com/apache/nifi/pull/10141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

Re: [PR] NIFI-14818 - Bump GCP SDK to 26.65.0, Azure SDK to 1.2.37 and others [nifi]

2025-08-04 Thread via GitHub
dan-s1 commented on PR #10168: URL: https://github.com/apache/nifi/pull/10168#issuecomment-3150804366 I think part of this PR would be fine. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] NIFI-14757 update theme support to include sass partials and icons [nifi]

2025-08-04 Thread via GitHub
rfellows merged PR #10098: URL: https://github.com/apache/nifi/pull/10098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache

Re: [PR] NIFI-14818 - Bump GCP SDK to 26.65.0, Azure SDK to 1.2.37 and others [nifi]

2025-08-04 Thread via GitHub
pvillard31 commented on PR #10168: URL: https://github.com/apache/nifi/pull/10168#issuecomment-3150793102 Do you want me to address those warnings as part of this PR? or should it be a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] NIFI-14789 In PutSQL send incoming invalid FlowFiles to failure. [nifi]

2025-08-04 Thread via GitHub
exceptionfactory commented on code in PR #10136: URL: https://github.com/apache/nifi/pull/10136#discussion_r2251478121 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java: ## @@ -701,46 +703,64 @@

Re: [PR] NIFI-14818 - Bump GCP SDK to 26.65.0, Azure SDK to 1.2.37 and others [nifi]

2025-08-04 Thread via GitHub
dan-s1 commented on PR #10168: URL: https://github.com/apache/nifi/pull/10168#issuecomment-3150725806 I noticed these warnings in the build due to the upgrade to CLI ``` 2025-08-04T10:13:40.5456904Z [WARNING] /home/runner/work/nifi/nifi/nifi-registry/nifi-registry-toolkit/nifi-registry

Re: [PR] NIFI-14424 Support for confluent encoded protobuf headers [nifi]

2025-08-04 Thread via GitHub
sfc-gh-lkucharski commented on code in PR #10105: URL: https://github.com/apache/nifi/pull/10105#discussion_r2251426433 ## nifi-extension-bundles/nifi-confluent-platform-bundle/nifi-confluent-platform-api/src/main/java/org/apache/nifi/confluent/schema/ProtobufMessageSchema.java: ###

Re: [PR] NIFI-14424 Support for confluent encoded protobuf headers [nifi]

2025-08-04 Thread via GitHub
sfc-gh-lkucharski commented on code in PR #10105: URL: https://github.com/apache/nifi/pull/10105#discussion_r2251391472 ## nifi-extension-bundles/nifi-confluent-platform-bundle/nifi-confluent-platform-api/src/main/java/org/apache/nifi/confluent/schema/ProtobufMessageSchemaParser.java: #

Re: [PR] NIFI-14696 Fixed KinesisRecordProcessorRecord schema changes handling [nifi]

2025-08-04 Thread via GitHub
dariuszseweryn commented on code in PR #10053: URL: https://github.com/apache/nifi/pull/10053#discussion_r2251343995 ## nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/record/StateHandlerStrategy.java: ## @@

[PR] MINIFICPP-2596 Add XMLRecordSetWriter controller service [nifi-minifi-cpp]

2025-08-04 Thread via GitHub
lordgamez opened a new pull request, #1997: URL: https://github.com/apache/nifi-minifi-cpp/pull/1997 https://issues.apache.org/jira/browse/MINIFICPP-2596 Depends on https://github.com/apache/nifi-minifi-cpp/pull/1995 --- Thank you for submitting a contribution to

[PR] NIFI-14818 - Bump GCP SDK to 26.65.0, Azure SDK to 1.2.37 and others [nifi]

2025-08-04 Thread via GitHub
pvillard31 opened a new pull request, #10168: URL: https://github.com/apache/nifi/pull/10168 # Summary NIFI-14818 - Bump GCP SDK to 26.65.0, Azure SDK to 1.2.37 and others - Azure SDK from 1.2.36 to 1.2.37 - https://github.com/Azure/azure-sdk-for-java/releases/tag/azure-sdk-bom

[PR] NIFI-8269 - Add support for schema inference in ForkRecord processor when extracting array records [nifi]

2025-08-03 Thread via GitHub
pvillard31 opened a new pull request, #10167: URL: https://github.com/apache/nifi/pull/10167 # Summary NIFI-8269 - Add support for schema inference in ForkRecord processor when extracting array records > At the moment the ForkRecord processor will require the writer to be conf

Re: [PR] NIFI-14319: Create initial project structure for new NiFi Registry UI [nifi]

2025-08-02 Thread via GitHub
scottyaslan commented on PR #9855: URL: https://github.com/apache/nifi/pull/9855#issuecomment-3146549952 @sardell I hope to get back to reviewing this next week. Sorry for the delay! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] NIFI-14815 Rename Max Connections to Worker Threads in ListenSyslog [nifi]

2025-08-02 Thread via GitHub
pvillard31 closed pull request #10165: NIFI-14815 Rename Max Connections to Worker Threads in ListenSyslog URL: https://github.com/apache/nifi/pull/10165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] NIFI-14728 Allow git Flow Registry sync interval to be user defined [nifi]

2025-08-01 Thread via GitHub
exceptionfactory commented on code in PR #10141: URL: https://github.com/apache/nifi/pull/10141#discussion_r2249049789 ## nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java: ## @@ -1079,7 +1085,7 @@ public void i

Re: [PR] NIFI-14599 - Use parameter context revision when updating multiple PCs via parameter groups from parameter provider [nifi]

2025-08-01 Thread via GitHub
exceptionfactory merged PR #10145: URL: https://github.com/apache/nifi/pull/10145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

[PR] NIFI-14816 - Add Azure Git DevOps Flow Registry Client [nifi]

2025-08-01 Thread via GitHub
pvillard31 opened a new pull request, #10166: URL: https://github.com/apache/nifi/pull/10166 # Summary NIFI-14816 - Add Azure Git DevOps Flow Registry Client We currently have support for Github, Gitlab and Bitbucket. This Jira is for adding a new implementation for Azure Git D

[PR] NIFI-14815 Rename Max Connections to Worker Threads in ListenSyslog [nifi]

2025-08-01 Thread via GitHub
exceptionfactory opened a new pull request, #10165: URL: https://github.com/apache/nifi/pull/10165 # Summary [NIFI-14815](https://issues.apache.org/jira/browse/NIFI-14815) Renames the `Max Number of TCP Connections` property to `Worker Threads` in the `ListenSyslog` Processor, along

Re: [PR] NIFI-14696 Fixed KinesisRecordProcessorRecord schema changes handling [nifi]

2025-08-01 Thread via GitHub
exceptionfactory commented on code in PR #10053: URL: https://github.com/apache/nifi/pull/10053#discussion_r2248924987 ## nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java: ## @@ -319,

Re: [PR] NIFI-14731 Updates Couchbase plugin to support newest couchbase SDK a… [nifi]

2025-08-01 Thread via GitHub
exceptionfactory commented on PR #10080: URL: https://github.com/apache/nifi/pull/10080#issuecomment-3145822042 @chedim Actually pull request #10031 already contains significant rework, addressing a number of the latent concerns in the earlier version of these components. I recommend review

Re: [PR] NIFI-14731 Updates Couchbase plugin to support newest couchbase SDK a… [nifi]

2025-08-01 Thread via GitHub
exceptionfactory closed pull request #10080: NIFI-14731 Updates Couchbase plugin to support newest couchbase SDK a… URL: https://github.com/apache/nifi/pull/10080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] NIFI-14731 Updates Couchbase plugin to support newest couchbase SDK [nifi]

2025-08-01 Thread via GitHub
exceptionfactory closed pull request #10163: NIFI-14731 Updates Couchbase plugin to support newest couchbase SDK URL: https://github.com/apache/nifi/pull/10163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Update common.sh [nifi]

2025-08-01 Thread via GitHub
exceptionfactory closed pull request #10158: Update common.sh URL: https://github.com/apache/nifi/pull/10158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Update common.sh [nifi]

2025-08-01 Thread via GitHub
exceptionfactory commented on PR #10158: URL: https://github.com/apache/nifi/pull/10158#issuecomment-3145769617 Closing for now, feel free to reopen after creating an issue the [Apache NiFi Jira project](https://issues.apache.org/jira/browse/NIFI) summarizing the changes needed. -- This

Re: [PR] NIFI-14807 - Policy deletion - Skip parent authorization if no parent [nifi]

2025-08-01 Thread via GitHub
exceptionfactory merged PR #10155: URL: https://github.com/apache/nifi/pull/10155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

Re: [PR] NIFI-14813 - Fix javadoc generation, remove unnecessary dependency overrides, and others [nifi]

2025-08-01 Thread via GitHub
exceptionfactory merged PR #10161: URL: https://github.com/apache/nifi/pull/10161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

Re: [PR] NIFI-14812 Replaced use of deprecated method replaceFirst in Apache Commons RegExUtils class which took a String with the non deprecated one which takes a CharSequence. [nifi]

2025-08-01 Thread via GitHub
exceptionfactory merged PR #10162: URL: https://github.com/apache/nifi/pull/10162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

Re: [PR] NIFI-14804 Replaced the use of deprecated GzipCompressorInputStream and ZstdCompressorOutputStream constructors with builder classes. [nifi]

2025-08-01 Thread via GitHub
exceptionfactory merged PR #10164: URL: https://github.com/apache/nifi/pull/10164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

Re: [PR] NIFI-14170 - Fix WebSocket isSecure handling and add Idle Timeout configuration [nifi]

2025-08-01 Thread via GitHub
exceptionfactory merged PR #10154: URL: https://github.com/apache/nifi/pull/10154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

Re: [PR] NIFI-14808 Introduce MockParameterLookup class for parameters passing [nifi]

2025-08-01 Thread via GitHub
exceptionfactory merged PR #10159: URL: https://github.com/apache/nifi/pull/10159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

[PR] NIFI-14804 Replaced the use of deprecated GzipCompressorInputStream and ZstdCompressorOutputStream constructors with builder classes. [nifi]

2025-08-01 Thread via GitHub
dan-s1 opened a new pull request, #10164: URL: https://github.com/apache/nifi/pull/10164 # Summary [NIFI-14804](https://issues.apache.org/jira/browse/NIFI-14804) # Tracking Please complete the following tracking steps pr

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
markobean commented on PR #10097: URL: https://github.com/apache/nifi/pull/10097#issuecomment-3145020218 @exceptionfactory Sure thing. Rebase to latest `main` complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
exceptionfactory commented on PR #10097: URL: https://github.com/apache/nifi/pull/10097#issuecomment-3145006146 Thanks @markobean! Can you rebase on the current `main` branch? There is an issue with the GitHub Action for the `ci-workflow` that is now resolved. -- This is an automated mess

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
markobean commented on code in PR #10097: URL: https://github.com/apache/nifi/pull/10097#discussion_r2248265148 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.ts: ## @@ -12

Re: [PR] NIFI-14812 Replaced use of deprecated method replaceFirst in Apache Commons RegExUtils class which took a String with the non deprecated one which takes a CharSequence. [nifi]

2025-08-01 Thread via GitHub
pvillard31 commented on PR #10162: URL: https://github.com/apache/nifi/pull/10162#issuecomment-3144949258 Please rebase to include #10160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] NIFI-14812 Replaced use of deprecated method replaceFirst in Apache Commons RegExUtils class which took a String with the non deprecated one which takes a CharSequence. [nifi]

2025-08-01 Thread via GitHub
dan-s1 commented on PR #10162: URL: https://github.com/apache/nifi/pull/10162#issuecomment-3144940055 @exceptionfactory Is there a reason the other checks were not kicked off for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] NIFI-14811 Change paths-filter action to use hash instead of version [nifi]

2025-08-01 Thread via GitHub
pvillard31 closed pull request #10160: NIFI-14811 Change paths-filter action to use hash instead of version URL: https://github.com/apache/nifi/pull/10160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] NIFI-14731 Updates Couchbase plugin to support newest couchbase SDK [nifi]

2025-08-01 Thread via GitHub
chedim opened a new pull request, #10163: URL: https://github.com/apache/nifi/pull/10163 # Summary This is part of NIFI-14731 that re-introduces GetCouchbaseKey and PutCouchbaseKey processors. [NIFI-14731](https://issues.apache.org/ji

Re: [PR] [NIFI-14173] Codemirror V6 [nifi]

2025-08-01 Thread via GitHub
scottyaslan commented on code in PR #10144: URL: https://github.com/apache/nifi/pull/10144#discussion_r2248154337 ## nifi-frontend/src/main/frontend/libs/shared/src/components/tooltips/el-function-tip/el-function-tip.component.html: ## Review Comment: ok this was a tricky o

[PR] NIFI-14812 Replaced use of deprecated method replaceFirst in Apache Commons RegExUtils class which took a String with the non deprecated one which takes a CharSequence. [nifi]

2025-08-01 Thread via GitHub
dan-s1 opened a new pull request, #10162: URL: https://github.com/apache/nifi/pull/10162 # Summary [NIFI-14812](https://issues.apache.org/jira/browse/NIFI-14812) # Tracking Please complete the following tracking steps pr

Re: [PR] NIFI-14808 Introduce MockParameterLookup class for parameters passing [nifi]

2025-08-01 Thread via GitHub
kubaugust commented on code in PR #10159: URL: https://github.com/apache/nifi/pull/10159#discussion_r2248094760 ## nifi-mock/src/main/java/org/apache/nifi/util/MockValidationContext.java: ## @@ -40,20 +40,30 @@ import java.util.Set; import java.util.stream.Collectors; -publi

[PR] NIFI-14813 - Fix javadoc generation, remove unnecessary dependency overrides, and others [nifi]

2025-08-01 Thread via GitHub
pvillard31 opened a new pull request, #10161: URL: https://github.com/apache/nifi/pull/10161 # Summary [NIFI-14813](https://issues.apache.org/jira/browse/NIFI-14813) - Fix javadoc generation, remove unnecessary dependency overrides, and others - fix javadoc generation by removi

Re: [PR] NIFI-14808 Introduce MockParameterLookup class for parameters passing [nifi]

2025-08-01 Thread via GitHub
sfc-gh-dhandermann commented on code in PR #10159: URL: https://github.com/apache/nifi/pull/10159#discussion_r2248025418 ## nifi-mock/src/main/java/org/apache/nifi/util/MockValidationContext.java: ## @@ -40,20 +40,30 @@ import java.util.Set; import java.util.stream.Collectors;

Re: [PR] Update common.sh [nifi]

2025-08-01 Thread via GitHub
sfc-gh-dhandermann commented on PR #10158: URL: https://github.com/apache/nifi/pull/10158#issuecomment-3144630248 Thanks for proposing this improvement @mukulgargg. As noted in the pull request template, every change requires an associated Jira issue. If you can create a reference Jira issu

Re: [PR] NIFI-14811 Change paths-filter action to use hash instead of version [nifi]

2025-08-01 Thread via GitHub
pvillard31 commented on PR #10160: URL: https://github.com/apache/nifi/pull/10160#issuecomment-3144619319 Thanks @exceptionfactory - will merge after green build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] NIFI-14811 Change paths-filter action to use hash instead of version [nifi]

2025-08-01 Thread via GitHub
exceptionfactory opened a new pull request, #10160: URL: https://github.com/apache/nifi/pull/10160 # Summary [NIFI-14811](https://issues.apache.org/jira/browse/NIFI-14811) Changes the `dorny/paths-filter` GitHub Action to reference the hash for version 3.0.2 instead of the version re

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
exceptionfactory commented on code in PR #10097: URL: https://github.com/apache/nifi/pull/10097#discussion_r2247977745 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.ts: ##

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
markobean commented on code in PR #10097: URL: https://github.com/apache/nifi/pull/10097#discussion_r2247858668 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.ts: ## @@ -12

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
markobean commented on code in PR #10097: URL: https://github.com/apache/nifi/pull/10097#discussion_r2247843909 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html: ## @@ -

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
nifiguy commented on code in PR #10097: URL: https://github.com/apache/nifi/pull/10097#discussion_r2247833460 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html: ## @@ -19

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
nifiguy commented on code in PR #10097: URL: https://github.com/apache/nifi/pull/10097#discussion_r2247833460 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html: ## @@ -19

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
markobean commented on code in PR #10097: URL: https://github.com/apache/nifi/pull/10097#discussion_r2247843909 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html: ## @@ -

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-08-01 Thread via GitHub
nifiguy commented on code in PR #10097: URL: https://github.com/apache/nifi/pull/10097#discussion_r2247833460 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html: ## @@ -19

[PR] Introduce MockParameterLookup class for parameters passing [nifi]

2025-08-01 Thread via GitHub
kubaugust opened a new pull request, #10159: URL: https://github.com/apache/nifi/pull/10159 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps

[PR] Update common.sh [nifi]

2025-08-01 Thread via GitHub
mukulgargg opened a new pull request, #10158: URL: https://github.com/apache/nifi/pull/10158 Because of this line, it is causing only to add new lines in nifi.properties, which leads to duplicate property key error in nifi startup. #

Re: [PR] NIFI-14170 - Fix WebSocket isSecure handling and add Idle Timeout configuration [nifi]

2025-08-01 Thread via GitHub
pvillard31 commented on code in PR #10154: URL: https://github.com/apache/nifi/pull/10154#discussion_r2247386367 ## nifi-extension-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/RoutingWebSocketListener.java: ## @@ -27,6

Re: [PR] NIFI-14807 - Policy deletion - Skip parent authorization if no parent [nifi]

2025-08-01 Thread via GitHub
pvillard31 commented on PR #10155: URL: https://github.com/apache/nifi/pull/10155#issuecomment-3143757318 Done, thanks for the review @exceptionfactory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] NIFI-14809 Remove unused util class and methods [nifi]

2025-08-01 Thread via GitHub
pvillard31 closed pull request #10156: NIFI-14809 Remove unused util class and methods URL: https://github.com/apache/nifi/pull/10156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] NIFI-14810 Upgrade OpenTelemetry Proto from 1.1.0 to 1.7.0 [nifi]

2025-08-01 Thread via GitHub
pvillard31 closed pull request #10157: NIFI-14810 Upgrade OpenTelemetry Proto from 1.1.0 to 1.7.0 URL: https://github.com/apache/nifi/pull/10157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[PR] NIFI-14810 Upgrade OpenTelemetry Proto from 1.1.0 to 1.7.0 [nifi]

2025-07-31 Thread via GitHub
exceptionfactory opened a new pull request, #10157: URL: https://github.com/apache/nifi/pull/10157 # Summary [NIFI-14810](https://issues.apache.org/jira/browse/NIFI-14810) Upgrades the OpenTelemetry Proto library from 1.1.0 to [1.7.0](https://github.com/open-telemetry/opentelemetry-p

[PR] NIFI-14809 Remove unused util class and methods [nifi]

2025-07-31 Thread via GitHub
exceptionfactory opened a new pull request, #10156: URL: https://github.com/apache/nifi/pull/10156 # Summary [NIFI-14809](https://issues.apache.org/jira/browse/NIFI-14809) Removes an used class and several methods from the `util` package in the `nifi-standard-processors` module.

Re: [PR] NIFI-14243 add Load Balance Status to the Connections tab of the Summ… [nifi]

2025-07-31 Thread via GitHub
exceptionfactory commented on code in PR #10097: URL: https://github.com/apache/nifi/pull/10097#discussion_r2246776203 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html:

Re: [PR] NIFI-14170: Fix WebSocket NullPointerExceptions [nifi]

2025-07-31 Thread via GitHub
exceptionfactory closed pull request #10126: NIFI-14170: Fix WebSocket NullPointerExceptions URL: https://github.com/apache/nifi/pull/10126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] NIFI-14170: Fix WebSocket NullPointerExceptions [nifi]

2025-07-31 Thread via GitHub
exceptionfactory commented on PR #10126: URL: https://github.com/apache/nifi/pull/10126#issuecomment-3141970955 Thanks for the helpful initial work on this issue @ravinarayansingh! I provided some feedback on the linked pull request, as that seems like the best way to address all the issues

Re: [PR] NIFI-14170 - Fix WebSocket isSecure handling and add Idle Timeout configuration [nifi]

2025-07-31 Thread via GitHub
exceptionfactory commented on code in PR #10154: URL: https://github.com/apache/nifi/pull/10154#discussion_r2246753365 ## nifi-extension-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketServer.java: ## @@ -25

Re: [PR] MINIFICPP-2587 Add Sparkplug B support for ConsumeMQTT processor [nifi-minifi-cpp]

2025-07-31 Thread via GitHub
szaszm commented on code in PR #1990: URL: https://github.com/apache/nifi-minifi-cpp/pull/1990#discussion_r2246494405 ## PROCESSORS.md: ## @@ -433,10 +436,15 @@ In the list below, the names of required properties appear in bold. Any other pr ### Output Attributes -| Attrib

Re: [PR] NIFI-14736 Add EOF attribute to ExecuteSQL for the last FlowFile output for a ResultSet [nifi]

2025-07-31 Thread via GitHub
exceptionfactory commented on PR #10121: URL: https://github.com/apache/nifi/pull/10121#issuecomment-3141392773 Based on the discussion in the linked pull request regarding use of existing `fragment` attributes, leading to the need to reconsider the general approach, I'm closing this pull r

Re: [PR] NIFI-14736 Add EOF attribute to ExecuteSQL for the last FlowFile output for a ResultSet [nifi]

2025-07-31 Thread via GitHub
exceptionfactory closed pull request #10121: NIFI-14736 Add EOF attribute to ExecuteSQL for the last FlowFile output for a ResultSet URL: https://github.com/apache/nifi/pull/10121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] NIFI-14086 - NiFi CLI - Add PGRename and possibility to rename in PGImport [nifi]

2025-07-31 Thread via GitHub
exceptionfactory merged PR #10152: URL: https://github.com/apache/nifi/pull/10152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nif

Re: [PR] [NIFI-14173] Codemirror V6 [nifi]

2025-07-31 Thread via GitHub
scottyaslan commented on code in PR #10144: URL: https://github.com/apache/nifi/pull/10144#discussion_r2246082156 ## nifi-frontend/src/main/frontend/libs/shared/src/components/map-table/editors/text-editor/text-editor.component.ts: ## @@ -122,50 +158,67 @@ export class TextEdito

Re: [PR] [NIFI-14173] Codemirror V6 [nifi]

2025-07-31 Thread via GitHub
scottyaslan commented on code in PR #10144: URL: https://github.com/apache/nifi/pull/10144#discussion_r2246082626 ## nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/property-table/editors/nf-editor/nf-editor.component.ts: ## @@ -88,40 +129,126 @@ export class NfEdito

[PR] NIFI-14807 - Policy deletion - Skip parent authorization if no parent [nifi]

2025-07-31 Thread via GitHub
pvillard31 opened a new pull request, #10155: URL: https://github.com/apache/nifi/pull/10155 # Summary [NIFI-14807](https://issues.apache.org/jira/browse/NIFI-14807) - Policy deletion - Skip parent authorization if no parent # Tracking Please complete the following track

Re: [PR] NIFI-14170: Fix WebSocket NullPointerExceptions [nifi]

2025-07-31 Thread via GitHub
pvillard31 commented on PR #10126: URL: https://github.com/apache/nifi/pull/10126#issuecomment-3140607838 Thanks for your contribution @ravinarayansingh - I confirmed that your change is fixing the issue and I took the liberty of adding a couple of things on top of your commit in #10154. We

[PR] NIFI-14170 - Fix WebSocket isSecure handling and add Idle Timeout configuration [nifi]

2025-07-31 Thread via GitHub
pvillard31 opened a new pull request, #10154: URL: https://github.com/apache/nifi/pull/10154 # Summary [NIFI-14170](https://issues.apache.org/jira/browse/NIFI-14170) - Fix WebSocket isSecure handling and add Idle Timeout configuration This is just a few additional changes on to

Re: [PR] NIFI-14736 Add EOF attribute to ExecuteSQL for the last FlowFile output for a ResultSet [nifi]

2025-07-31 Thread via GitHub
takraj commented on PR #10102: URL: https://github.com/apache/nifi/pull/10102#issuecomment-3140550513 @exceptionfactory > ... what about another method like isAfterLast()? It can depend on the JDBC implementation, but could be an option to consider. This sounds very risky, sin

Re: [PR] NIFI-14806 Change OIDC and SAML login timeout to 5 minutes [nifi]

2025-07-31 Thread via GitHub
pvillard31 closed pull request #10153: NIFI-14806 Change OIDC and SAML login timeout to 5 minutes URL: https://github.com/apache/nifi/pull/10153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] NIFI-14789 In PutSQL send incoming invalid FlowFiles to failure. [nifi]

2025-07-31 Thread via GitHub
exceptionfactory commented on PR #10136: URL: https://github.com/apache/nifi/pull/10136#issuecomment-3140541418 > @exceptionfactory I think I could come up with an implementation according to your suggested idea. Thanks @tpalfy, the revised direction looks like a good path, I will tak

Re: [PR] MINIFICPP-2567 C++23 Support [nifi-minifi-cpp]

2025-07-31 Thread via GitHub
martinzink commented on PR #1968: URL: https://github.com/apache/nifi-minifi-cpp/pull/1968#issuecomment-3140525104 https://github.com/martinzink/nifi-minifi-cpp/actions/runs/16651051825/job/47123587158 🟢 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] MINIFICPP-2567 C++23 Support [nifi-minifi-cpp]

2025-07-31 Thread via GitHub
martinzink commented on code in PR #1968: URL: https://github.com/apache/nifi-minifi-cpp/pull/1968#discussion_r2245776336 ## CMakeLists.txt: ## @@ -316,8 +316,12 @@ else() if(MINIFI_FAIL_ON_WARNINGS) list(APPEND MINIFI_CPP_COMPILE_OPTIONS -Werror) # -Wrest

  1   2   3   4   5   6   7   8   9   10   >