Re: [PR] Bump mavenVersion from 3.2.5 to 3.9.9 [maven-source-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] commented on PR #61: URL: https://github.com/apache/maven-source-plugin/pull/61#issuecomment-2948262104 Superseded by #72. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] Bump mavenVersion from 3.2.5 to 3.9.10 [maven-source-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #72: URL: https://github.com/apache/maven-source-plugin/pull/72 Bumps `mavenVersion` from 3.2.5 to 3.9.10. Updates `org.apache.maven:maven-model` from 3.2.5 to 3.9.10 Updates `org.apache.maven:maven-plugin-api` from 3.2.5 to 3.9.10 R

Re: [PR] Bump mavenVersion from 3.2.5 to 3.9.9 [maven-source-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] closed pull request #61: Bump mavenVersion from 3.2.5 to 3.9.9 URL: https://github.com/apache/maven-source-plugin/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump mavenVersion from 3.9.9 to 3.9.10 [maven-resolver]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #738: URL: https://github.com/apache/maven-resolver/pull/738 Bumps `mavenVersion` from 3.9.9 to 3.9.10. Updates `org.apache.maven:maven-resolver-provider` from 3.9.9 to 3.9.10 Updates `org.apache.maven:maven-model-builder` from 3.9.9 to 3.9

[PR] Bump mavenVersion from 3.9.9 to 3.9.10 [maven-clean-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #259: URL: https://github.com/apache/maven-clean-plugin/pull/259 Bumps `mavenVersion` from 3.9.9 to 3.9.10. Updates `org.apache.maven:maven-plugin-api` from 3.9.9 to 3.9.10 Release notes Sourced from https://github.com/apache/maven/relea

[PR] Bump mavenVersion from 3.9.9 to 3.9.10 [maven-plugin-testing]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #105: URL: https://github.com/apache/maven-plugin-testing/pull/105 Bumps `mavenVersion` from 3.9.9 to 3.9.10. Updates `org.apache.maven:maven-artifact` from 3.9.9 to 3.9.10 Updates `org.apache.maven:maven-core` from 3.9.9 to 3.9.10 U

[PR] Bump org.apache.maven:maven-artifact from 3.6.3 to 3.9.10 [maven-jlink-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #611: URL: https://github.com/apache/maven-jlink-plugin/pull/611 Bumps org.apache.maven:maven-artifact from 3.6.3 to 3.9.10. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-

[PR] Bump org.apache.maven:maven-model from 3.6.3 to 3.9.10 [maven-jlink-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #610: URL: https://github.com/apache/maven-jlink-plugin/pull/610 Bumps org.apache.maven:maven-model from 3.6.3 to 3.9.10. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-nam

[PR] Bump mavenVersion from 3.6.3 to 3.9.10 [maven-jmod-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #78: URL: https://github.com/apache/maven-jmod-plugin/pull/78 Bumps `mavenVersion` from 3.6.3 to 3.9.10. Updates `org.apache.maven:maven-plugin-api` from 3.6.3 to 3.9.10 Release notes Sourced from https://github.com/apache/maven/releases

[PR] Bump mavenVersion from 3.9.9 to 3.9.10 [maven-changelog-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #41: URL: https://github.com/apache/maven-changelog-plugin/pull/41 Bumps `mavenVersion` from 3.9.9 to 3.9.10. Updates `org.apache.maven:maven-plugin-api` from 3.9.9 to 3.9.10 Release notes Sourced from https://github.com/apache/maven/rel

[PR] Bump mavenVersion from 3.9.9 to 3.9.10 [maven-jar-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #146: URL: https://github.com/apache/maven-jar-plugin/pull/146 Bumps `mavenVersion` from 3.9.9 to 3.9.10. Updates `org.apache.maven:maven-plugin-api` from 3.9.9 to 3.9.10 Release notes Sourced from https://github.com/apache/maven/release

[PR] Bump mavenVersion from 3.9.9 to 3.9.10 [maven-install-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #350: URL: https://github.com/apache/maven-install-plugin/pull/350 Bumps `mavenVersion` from 3.9.9 to 3.9.10. Updates `org.apache.maven:maven-plugin-api` from 3.9.9 to 3.9.10 Release notes Sourced from https://github.com/apache/maven/rel

[jira] [Updated] (MNG-8768) Add a function for conditional profile activation evaluating to true if a certain executable can be found in the system path

2025-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juan Farré updated MNG-8768: Description: I have a use case that I think is of general interest. I am generating a native image with Graa

[jira] [Created] (MNG-8768) Add a conditional expression for profile activation evaluating to true if a certain executable can be found in the system path

2025-06-05 Thread Jira
Juan Farré created MNG-8768: --- Summary: Add a conditional expression for profile activation evaluating to true if a certain executable can be found in the system path Key: MNG-8768 URL: https://issues.apache.org/jira/bro

[PR] Bump mavenVersion from 3.9.9 to 3.9.10 [maven-toolchains-plugin]

2025-06-05 Thread via GitHub
dependabot[bot] opened a new pull request, #60: URL: https://github.com/apache/maven-toolchains-plugin/pull/60 Bumps `mavenVersion` from 3.9.9 to 3.9.10. Updates `org.apache.maven:maven-plugin-api` from 3.9.9 to 3.9.10 Release notes Sourced from https://github.com/apache/maven/re

Re: [PR] Declare used dependency on org.apache.maven.reporting:maven-reporting… [maven-pmd-plugin]

2025-06-05 Thread via GitHub
pzygielo commented on code in PR #215: URL: https://github.com/apache/maven-pmd-plugin/pull/215#discussion_r2130431368 ## pom.xml: ## @@ -193,6 +193,11 @@ under the License. + + org.apache.maven.reporting + maven-reporting-api + 4.0.0 Review Com

Re: [PR] Declare used dependency on org.apache.maven.reporting:maven-reporting… [maven-pmd-plugin]

2025-06-05 Thread via GitHub
pzygielo commented on code in PR #215: URL: https://github.com/apache/maven-pmd-plugin/pull/215#discussion_r2130431368 ## pom.xml: ## @@ -193,6 +193,11 @@ under the License. + + org.apache.maven.reporting + maven-reporting-api + 4.0.0 Review Com

Re: [PR] Declare used dependency on org.apache.maven.reporting:maven-reporting… [maven-pmd-plugin]

2025-06-05 Thread via GitHub
pzygielo commented on code in PR #215: URL: https://github.com/apache/maven-pmd-plugin/pull/215#discussion_r2130431368 ## pom.xml: ## @@ -193,6 +193,11 @@ under the License. + + org.apache.maven.reporting + maven-reporting-api + 4.0.0 Review Com

[jira] [Updated] (MDEP-933) Document new output format: JSON of dependency:tree

2025-06-05 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MDEP-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MDEP-933: -- Fix Version/s: next-release > Document new output format: JSON of dependency:tree > -

[jira] [Assigned] (MDEP-933) Document new output format: JSON of dependency:tree

2025-06-05 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MDEP-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy reassigned MDEP-933: - Assignee: Olivier Lamy > Document new output format: JSON of dependency:tree > ---

[jira] [Closed] (MDEP-933) Document new output format: JSON of dependency:tree

2025-06-05 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MDEP-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MDEP-933. - Resolution: Fixed PR merged https://github.com/apache/maven-dependency-plugin/pull/535 > Document new outp

Re: [PR] Document dependency tree output formats [maven-dependency-plugin]

2025-06-05 Thread via GitHub
olamy merged PR #535: URL: https://github.com/apache/maven-dependency-plugin/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Add build, breaking, deprecated and removed labels [maven-gh-actions-shared]

2025-06-05 Thread via GitHub
slawekjaranowski merged PR #166: URL: https://github.com/apache/maven-gh-actions-shared/pull/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

Re: [PR] Declare used dependency on org.apache.maven.reporting:maven-reporting… [maven-pmd-plugin]

2025-06-05 Thread via GitHub
elharo commented on code in PR #215: URL: https://github.com/apache/maven-pmd-plugin/pull/215#discussion_r2130208307 ## pom.xml: ## @@ -137,6 +137,12 @@ under the License. ${mavenVersion} provided + + org.apache.maven.reporting + maven-reporting

Re: [PR] use `try-with-resources` statement in `MavenProperties` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on PR #2441: URL: https://github.com/apache/maven/pull/2441#issuecomment-2946058853 why is my system broken please? - `mvn instal -PversionlessMavenDist ` - `mvn -Prun-its verify` ``` ``` -- This is an automated message from the Apac

Re: [PR] Maven 3.9.10 - release notes [maven-site]

2025-06-05 Thread via GitHub
slawekjaranowski merged PR #806: URL: https://github.com/apache/maven-site/pull/806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] use `try-with-resources` statement in `Mojos` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2443: URL: https://github.com/apache/maven/pull/2443#discussion_r2130184033 ## its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java: ## @@ -117,21 +117,11 @@ public vo

[PR] use `try-with-resources` statement in `Mojos` [maven]

2025-06-05 Thread via GitHub
Pankraz76 opened a new pull request, #2443: URL: https://github.com/apache/maven/pull/2443 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[PR] Maven 3.9.10 - update doap [maven]

2025-06-05 Thread via GitHub
slawekjaranowski opened a new pull request, #2442: URL: https://github.com/apache/maven/pull/2442 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [S1161] rule: category/java/bestpractices.xml/MissingOverride [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on PR #2403: URL: https://github.com/apache/maven/pull/2403#issuecomment-2945962889 fixed `.*/compat/maven-compat/.*` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [S1161] rule: category/java/bestpractices.xml/MissingOverride [maven]

2025-06-05 Thread via GitHub
slachiewicz commented on PR #2403: URL: https://github.com/apache/maven/pull/2403#issuecomment-2945779365 Small comment, issue template contains some statements about license and copyright. Please restore the template and agree to terms -- This is an automated message from the Apache Git

Re: [PR] [S1161] rule: category/java/bestpractices.xml/MissingOverride [maven]

2025-06-05 Thread via GitHub
slachiewicz commented on code in PR #2403: URL: https://github.com/apache/maven/pull/2403#discussion_r2113602203 ## pom.xml: ## @@ -853,6 +873,7 @@ under the License. **/*.odg **/*.svg .asf.yaml +.pmd/ruleset.xml

Re: [PR] Don't ignore SVG files [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2435: URL: https://github.com/apache/maven/pull/2435#discussion_r2129875905 ## .gitignore: ## @@ -3,17 +3,22 @@ .classpath .settings/ .svn/ + # Intellij *.ipr *.iml .idea !.idea/icon.png -.DS_Store /bootstrap /dependencies.xml .java-

Re: [PR] Don't ignore SVG files [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on PR #2435: URL: https://github.com/apache/maven/pull/2435#issuecomment-2945717886 > Which SVG ? seems like having more obsoletes or might be intended. My wc clean with way less ignored then actually configured: - https://github.com/apache/maven/pull/2439

Re: [I] Remove manually update release notes [maven-pmd-plugin]

2025-06-05 Thread via GitHub
slawekjaranowski closed issue #204: Remove manually update release notes URL: https://github.com/apache/maven-pmd-plugin/issues/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Replace manually maintained release notes by link to GitHub [maven-pmd-plugin]

2025-06-05 Thread via GitHub
slawekjaranowski merged PR #214: URL: https://github.com/apache/maven-pmd-plugin/pull/214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

Re: [PR] Declare used dependency on org.apache.maven.reporting:maven-reporting… [maven-pmd-plugin]

2025-06-05 Thread via GitHub
slawekjaranowski commented on code in PR #215: URL: https://github.com/apache/maven-pmd-plugin/pull/215#discussion_r2129837495 ## pom.xml: ## @@ -137,6 +137,12 @@ under the License. ${mavenVersion} provided + + org.apache.maven.reporting + maven

Re: [PR] use `try-with-resources` statement in `MavenProperties` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2441: URL: https://github.com/apache/maven/pull/2441#discussion_r2129819133 ## compat/maven-embedder/src/main/java/org/apache/maven/cli/props/MavenProperties.java: ## @@ -486,39 +486,40 @@ public void substitute(UnaryOperator callback) {

Re: [PR] use `try-with-resources` statement in `MavenProperties` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2441: URL: https://github.com/apache/maven/pull/2441#discussion_r2129820852 ## compat/maven-embedder/src/main/java/org/apache/maven/cli/props/MavenProperties.java: ## @@ -486,39 +486,40 @@ public void substitute(UnaryOperator callback) {

[PR] use `try-with-resources` statement in `MavenProperties` [maven]

2025-06-05 Thread via GitHub
Pankraz76 opened a new pull request, #2441: URL: https://github.com/apache/maven/pull/2441 isolating issue found in: - https://github.com/apache/maven/pull/2401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] use `try-with-resources` statement in `impl/maven-cli/src/main/java/org/apache/maven/cling/invoker` [maven]

2025-06-05 Thread via GitHub
Pankraz76 opened a new pull request, #2440: URL: https://github.com/apache/maven/pull/2440 isolating issue found in: -https://github.com/apache/maven/pull/2401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Declare used dependency on org.apache.maven.reporting:maven-reporting… [maven-pmd-plugin]

2025-06-05 Thread via GitHub
elharo commented on code in PR #215: URL: https://github.com/apache/maven-pmd-plugin/pull/215#discussion_r2129756021 ## pom.xml: ## @@ -137,6 +137,12 @@ under the License. ${mavenVersion} provided + + org.apache.maven.reporting + maven-reporting

Re: [PR] Declare used dependency on org.apache.maven.reporting:maven-reporting… [maven-pmd-plugin]

2025-06-05 Thread via GitHub
slawekjaranowski commented on code in PR #215: URL: https://github.com/apache/maven-pmd-plugin/pull/215#discussion_r2129733778 ## pom.xml: ## @@ -137,6 +137,12 @@ under the License. ${mavenVersion} provided + + org.apache.maven.reporting + maven

Re: [PR] [S1161] rule: category/java/bestpractices.xml/MissingOverride [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2403: URL: https://github.com/apache/maven/pull/2403#discussion_r2129731128 ## compat/maven-compat/pom.xml: ## @@ -248,6 +248,13 @@ under the License. + +org.apache.maven.plugins +maven-pmd-pl

Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.6.0 to 3.6.1 [maven]

2025-06-05 Thread via GitHub
slachiewicz merged PR #2432: URL: https://github.com/apache/maven/pull/2432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.6.0 to 3.6.1 [maven]

2025-06-05 Thread via GitHub
slachiewicz merged PR #2433: URL: https://github.com/apache/maven/pull/2433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

Re: [PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven-plugin-testing]

2025-06-05 Thread via GitHub
slachiewicz merged PR #89: URL: https://github.com/apache/maven-plugin-testing/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

Re: [PR] Remove deprecated DefaultArtifactRepository dependency we don't need [maven-javadoc-plugin]

2025-06-05 Thread via GitHub
elharo merged PR #393: URL: https://github.com/apache/maven-javadoc-plugin/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [I] simplify our GH issue templates boilerplate [maven-gh-actions-shared]

2025-06-05 Thread via GitHub
slawekjaranowski commented on issue #165: URL: https://github.com/apache/maven-gh-actions-shared/issues/165#issuecomment-2945538282 Simple proposition for PR template: ```markdown --- To make clear that you license your contribution under the [Apache L

Re: [PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2436: URL: https://github.com/apache/maven/pull/2436#discussion_r2129582571 ## src/mdo/java/WrapperProperties.java: ## @@ -302,20 +301,17 @@ public synchronized void load(InputStream inStream) throws IOException { @Override public

Re: [PR] Add build, breaking, deprecated and removed labels [maven-gh-actions-shared]

2025-06-05 Thread via GitHub
Bukama commented on code in PR #166: URL: https://github.com/apache/maven-gh-actions-shared/pull/166#discussion_r2129152098 ## .github/labels.js: ## @@ -66,6 +66,26 @@ module.exports = [ color: "912E29", description: "" }, +{ +name: "build", +

Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.6.0 to 3.6.1 [maven-build-cache-extension]

2025-06-05 Thread via GitHub
Bukama merged PR #219: URL: https://github.com/apache/maven-build-cache-extension/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Commented] (SCM-1029) JGit performing empty commit on CheckIn command if includes or excludes fileset is defined but no files changed in it

2025-06-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956379#comment-17956379 ] Michael Osipov commented on SCM-1029: - U don't have any > JGit performing empty commit

Re: [PR] Buffer the writers [maven-pmd-plugin]

2025-06-05 Thread via GitHub
elharo merged PR #218: URL: https://github.com/apache/maven-pmd-plugin/pull/218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven

Re: [PR] Don't ignore SVG files [maven]

2025-06-05 Thread via GitHub
elharo commented on PR #2435: URL: https://github.com/apache/maven/pull/2435#issuecomment-2944808109 Don't know, but it's not an IDE or file system artifact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[I] NullPointerException: Cannot invoke "java.lang.CharSequence.toString()" because "target" is null [maven-changes-plugin]

2025-06-05 Thread via GitHub
garydgregory opened a new issue, #130: URL: https://github.com/apache/maven-changes-plugin/issues/130 ### Affected version 3.0.0-M3 ### Bug description Whatever the actual problem is, the plugin should log an actionable error message instead of throwing a `NullPointerExc

Re: [PR] [2436] centralize domain init logic `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
rmannibucau commented on PR #2430: URL: https://github.com/apache/maven/pull/2430#issuecomment-2944481800 Removing the cache doesn't have this negative impact, current impl neither, only your proposal which was optimizing "the other side" implied that issue @gnodet was the intent a ca

Re: [PR] Inherit identical method [maven-pmd-plugin]

2025-06-05 Thread via GitHub
elharo closed pull request #216: Inherit identical method URL: https://github.com/apache/maven-pmd-plugin/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] chore: remove `.gitignore` obsoletes [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2439: URL: https://github.com/apache/maven/pull/2439#discussion_r2128883749 ## .gitignore: ## @@ -1,19 +1,12 @@ +!.idea/icon.png **/target/** -.project -.classpath -.settings/ -.svn/ -# Intellij -*.ipr *.iml -.idea -!.idea/icon.png +*.ipr .D

Re: [PR] [S1161] rule: category/java/bestpractices.xml/MissingOverride [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2403: URL: https://github.com/apache/maven/pull/2403#discussion_r2128887798 ## .gitignore: ## @@ -16,4 +16,5 @@ .factorypath .vscode/ repo/ -/*.svg \ No newline at end of file +/*.svg Review Comment: - https://github.com/apache/maven/pul

Re: [PR] chore: remove `.gitignore` obsoletes [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2439: URL: https://github.com/apache/maven/pull/2439#discussion_r2128887528 ## .gitignore: ## @@ -1,19 +1,12 @@ +!.idea/icon.png **/target/** -.project -.classpath -.settings/ -.svn/ -# Intellij -*.ipr *.iml -.idea -!.idea/icon.png +*.ipr .D

Re: [PR] chore: remove `.gitignore` obsoletes [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2439: URL: https://github.com/apache/maven/pull/2439#discussion_r2128883749 ## .gitignore: ## @@ -1,19 +1,12 @@ +!.idea/icon.png **/target/** -.project -.classpath -.settings/ -.svn/ -# Intellij -*.ipr *.iml -.idea -!.idea/icon.png +*.ipr .D

Re: [PR] chore: remove `.gitignore` obsoletes [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2439: URL: https://github.com/apache/maven/pull/2439#discussion_r2128879011 ## .gitignore: ## @@ -1,19 +1,12 @@ +!.idea/icon.png **/target/** -.project -.classpath -.settings/ -.svn/ -# Intellij -*.ipr *.iml -.idea -!.idea/icon.png +*.ipr .D

[PR] remove .gitignore obsoletes [maven]

2025-06-05 Thread via GitHub
Pankraz76 opened a new pull request, #2439: URL: https://github.com/apache/maven/pull/2439 - https://github.com/apache/maven/pull/2403#discussion_r2128510652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] use `try-with-resources` statement in `CheckThreadSafetyMojo` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on PR #2427: URL: https://github.com/apache/maven/pull/2427#issuecomment-2944342830 fixed the correct root dir now: investing 24.202 s for code we rely on seems good indentation. https://github.com/user-attachments/assets/a3d6e533-bed0-48e9-8b32-891380ce38c6

Re: [PR] use `try-with-resources` statement in `CheckThreadSafetyMojo` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on PR #2427: URL: https://github.com/apache/maven/pull/2427#issuecomment-2944331103 only done on root, which does not include anything. yes we working on this code so it should be checked for good. - https://github.com/apache/maven/pull/2315 -- This is an

[PR] [MNGSITE-393] remove references to Maven 2 [maven]

2025-06-05 Thread via GitHub
elharo opened a new pull request, #2438: URL: https://github.com/apache/maven/pull/2438 Not sure where this has moved to in Maven 4, but for now this seems to be where the live site is pulled from. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2436: URL: https://github.com/apache/maven/pull/2436#discussion_r2128851337 ## src/mdo/java/WrapperProperties.java: ## @@ -350,28 +325,32 @@ public synchronized void loadFromXML(InputStream in) throws IOException, Invalid @Override

Re: [PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-05 Thread via GitHub
gnodet commented on code in PR #2436: URL: https://github.com/apache/maven/pull/2436#discussion_r2128841420 ## src/mdo/java/WrapperProperties.java: ## @@ -350,28 +325,32 @@ public synchronized void loadFromXML(InputStream in) throws IOException, Invalid @Override pu

Re: [PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-05 Thread via GitHub
gnodet commented on code in PR #2436: URL: https://github.com/apache/maven/pull/2436#discussion_r2128841812 ## src/mdo/java/WrapperProperties.java: ## @@ -324,22 +302,19 @@ public synchronized void load(InputStream inStream) throws IOException { @Override public voi

Re: [PR] [2436] centralize domain init logic `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on PR #2430: URL: https://github.com/apache/maven/pull/2430#issuecomment-2944284590 > 2\. about compat would like to ignore to avoid any further, as happens over and over. Im silly, so ignore would really help. Will do this locally somehow. > 1. so everytime

[jira] [Commented] (SCM-1029) JGit performing empty commit on CheckIn command if includes or excludes fileset is defined but no files changed in it

2025-06-05 Thread Markus Hoffrogge (Jira)
[ https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956341#comment-17956341 ] Markus Hoffrogge commented on SCM-1029: --- [~michael-o] Is there a schedule when *maven

Re: [PR] test `NPE` in `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on PR #2437: URL: https://github.com/apache/maven/pull/2437#issuecomment-2944258461 yes. i would save current state ahead to be able to fix impl. and adjust/remove failing tests. at the end its the same. so no need to rush. -- This is an automated message from t

Re: [PR] use `try-with-resources` statement in `LookupWagonMojo` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on PR #2426: URL: https://github.com/apache/maven/pull/2426#issuecomment-2944248971 thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2436: URL: https://github.com/apache/maven/pull/2436#discussion_r2128796874 ## src/mdo/java/WrapperProperties.java: ## @@ -101,102 +88,89 @@ public void list(PrintWriter out) { @Override public int size() { -ensureInitialize

Re: [PR] [2436] centralize domain init logic `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
rmannibucau commented on PR #2430: URL: https://github.com/apache/maven/pull/2430#issuecomment-2944101352 I can be wrong since I didn't reopen vi to check but your PR looks like: 1. there is a global regression on the write pattern now write pattern are no more bulked by designed (the

Re: [PR] Bump pmdVersion from 7.12.0 to 7.14.0 [maven-pmd-plugin]

2025-06-05 Thread via GitHub
slawekjaranowski merged PR #213: URL: https://github.com/apache/maven-pmd-plugin/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[PR] Buffer the writers [maven-pmd-plugin]

2025-06-05 Thread via GitHub
elharo opened a new pull request, #218: URL: https://github.com/apache/maven-pmd-plugin/pull/218 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] Declare used dependency on org.apache.maven.reporting:maven-reporting… [maven-pmd-plugin]

2025-06-05 Thread via GitHub
elharo opened a new pull request, #215: URL: https://github.com/apache/maven-pmd-plugin/pull/215 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Added Dependabot for 3.x branch [maven-pmd-plugin]

2025-06-05 Thread via GitHub
slachiewicz closed pull request #217: Added Dependabot for 3.x branch URL: https://github.com/apache/maven-pmd-plugin/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] test `NPE` in `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
gnodet commented on PR #2437: URL: https://github.com/apache/maven/pull/2437#issuecomment-2943873975 I'm not sure it makes sense to test a broken implementation. Imho, we should fix the WrapperProperties first by remove the cache, then (or at the same time), improve test coverage. -- Thi

[PR] Added Dependabot for 3.x branch [maven-pmd-plugin]

2025-06-05 Thread via GitHub
slachiewicz opened a new pull request, #217: URL: https://github.com/apache/maven-pmd-plugin/pull/217 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] Inherit identical method [maven-pmd-plugin]

2025-06-05 Thread via GitHub
elharo opened a new pull request, #216: URL: https://github.com/apache/maven-pmd-plugin/pull/216 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] test domain init logic `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2434: URL: https://github.com/apache/maven/pull/2434#discussion_r2128631088 ## impl/maven-core/src/test/java/org/apache/maven/model/WrapperPropertiesTest.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] test domain init logic `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2434: URL: https://github.com/apache/maven/pull/2434#discussion_r2128631088 ## impl/maven-core/src/test/java/org/apache/maven/model/WrapperPropertiesTest.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] test domain init logic `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2434: URL: https://github.com/apache/maven/pull/2434#discussion_r2128625758 ## impl/maven-core/src/test/java/org/apache/maven/model/WrapperPropertiesTest.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] test domain init logic `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2434: URL: https://github.com/apache/maven/pull/2434#discussion_r2128623871 ## impl/maven-core/src/test/java/org/apache/maven/model/WrapperPropertiesTest.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Prefer https [maven-javadoc-plugin]

2025-06-05 Thread via GitHub
elharo closed pull request #392: Prefer https URL: https://github.com/apache/maven-javadoc-plugin/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] test `NPE` in `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
Pankraz76 opened a new pull request, #2437: URL: https://github.com/apache/maven/pull/2437 isolate NPE throwing test: - https://github.com/apache/maven/pull/2434 - https://github.com/apache/maven/pull/2434#discussion_r2128503938 -- This is an automated message from the Apache Git

[PR] Refactor WrapperProperties template to remove caching and simplify implementation [maven]

2025-06-05 Thread via GitHub
gnodet opened a new pull request, #2436: URL: https://github.com/apache/maven/pull/2436 This commit refactors the WrapperProperties template used for Maven model properties: TEMPLATE CHANGES (src/mdo/java/WrapperProperties.java): - Removed caching mechanism (orderedProps field and

Re: [PR] test domain init logic `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
gnodet commented on PR #2434: URL: https://github.com/apache/maven/pull/2434#issuecomment-2943784733 Raised https://github.com/apache/maven/pull/2436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Don't ignore SVG files [maven]

2025-06-05 Thread via GitHub
gnodet commented on PR #2435: URL: https://github.com/apache/maven/pull/2435#issuecomment-2943772186 > SVG is a data file, not autogenerated Which SVG ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] centralize domain init logic `WrapperProperties#init` [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2430: URL: https://github.com/apache/maven/pull/2430#discussion_r2128588841 ## impl/maven-core/src/test/java/org/apache/maven/model/WrapperPropertiesTest.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Remove plexus components.xml [maven-war-plugin]

2025-06-05 Thread via GitHub
elharo commented on PR #81: URL: https://github.com/apache/maven-war-plugin/pull/81#issuecomment-2943757624 Leaving open for useful context -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] Remove deprecated class dependency we don't need [maven-javadoc-plugin]

2025-06-05 Thread via GitHub
elharo opened a new pull request, #393: URL: https://github.com/apache/maven-javadoc-plugin/pull/393 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [S1161] rule: category/java/bestpractices.xml/MissingOverride [maven]

2025-06-05 Thread via GitHub
Pankraz76 commented on code in PR #2403: URL: https://github.com/apache/maven/pull/2403#discussion_r2128570309 ## .gitignore: ## @@ -16,4 +16,5 @@ .factorypath .vscode/ repo/ -/*.svg \ No newline at end of file +/*.svg Review Comment: agree -- This is an automated mes

[PR] Prefer https [maven-javadoc-plugin]

2025-06-05 Thread via GitHub
elharo opened a new pull request, #392: URL: https://github.com/apache/maven-javadoc-plugin/pull/392 might be moot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[I] ITs leave some uncleanable files behind [maven-javadoc-plugin]

2025-06-05 Thread via GitHub
elharo opened a new issue, #391: URL: https://github.com/apache/maven-javadoc-plugin/issues/391 ### Affected version HEAD ### Bug description These files tend to show up in local checkouts: ``` Untracked files: (use "git add ..." to include in what will be

Re: [PR] Use Java 7 relativization instead of hand-rolled code [maven-javadoc-plugin]

2025-06-05 Thread via GitHub
elharo merged PR #385: URL: https://github.com/apache/maven-javadoc-plugin/pull/385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] Add build, breaking, deprecated and removed labels [maven-gh-actions-shared]

2025-06-05 Thread via GitHub
elharo commented on code in PR #166: URL: https://github.com/apache/maven-gh-actions-shared/pull/166#discussion_r2128523784 ## .github/labels.js: ## @@ -66,6 +66,26 @@ module.exports = [ color: "912E29", description: "" }, +{ +name: "build", +

  1   2   >