[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078913#comment-16078913 ] Lefty Leverenz commented on HIVE-6348: -- Thank you for the documentation, Rui Li. I re

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074180#comment-16074180 ] Rui Li commented on HIVE-6348: -- Thanks [~leftylev] for the doc note. I've updated the configur

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071980#comment-16071980 ] Lefty Leverenz commented on HIVE-6348: -- Doc note: This adds *hive.remove.orderby.in.s

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067731#comment-16067731 ] Vineet Garg commented on HIVE-6348: --- [~cartershanklin] Good to know (y) > Order by/Sort

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067709#comment-16067709 ] Carter Shanklin commented on HIVE-6348: --- It's trivia at this point but ORDER BY in su

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067612#comment-16067612 ] Rui Li commented on HIVE-6348: -- Thanks [~vgarg] for reviewing. Yeah I think it's in compliance

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067427#comment-16067427 ] Vineet Garg commented on HIVE-6348: --- +1 Looks good to me > Order by/Sort by in subquery

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067372#comment-16067372 ] Vineet Garg commented on HIVE-6348: --- Looks like I am wrong. According to https://mariadb

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067348#comment-16067348 ] Vineet Garg commented on HIVE-6348: --- {{udf_row_sequence.q}} test is another example where

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067345#comment-16067345 ] Vineet Garg commented on HIVE-6348: --- [~lirui] Your patch removes order by from queries su

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066223#comment-16066223 ] Rui Li commented on HIVE-6348: -- Latest failures are not related. [~vgarg], [~ashutoshc] could

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065458#comment-16065458 ] Hive QA commented on HIVE-6348: --- Here are the results of testing the latest attachment: htt

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063234#comment-16063234 ] Ashutosh Chauhan commented on HIVE-6348: I don't think its 'breaking' those cases.

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057207#comment-16057207 ] Rui Li commented on HIVE-6348: -- [~ashutoshc], do you mean it's OK to break cases like input20?

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056874#comment-16056874 ] Ashutosh Chauhan commented on HIVE-6348: I am not sure why can't order by removed i

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055603#comment-16055603 ] Rui Li commented on HIVE-6348: -- Hi [~ashutoshc], [~vgarg], either doing this in CBO or not is

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048697#comment-16048697 ] Vineet Garg commented on HIVE-6348: --- {{HiveSortRemoveRule}} removes HiveSortLimit only if

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047217#comment-16047217 ] Ashutosh Chauhan commented on HIVE-6348: Turns out we already have such rules. They

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046396#comment-16046396 ] Rui Li commented on HIVE-6348: -- Hi [~vgarg], it turns out we do need the sub query being sorte

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046081#comment-16046081 ] Vineet Garg commented on HIVE-6348: --- [~lirui] Latest patch looks fine. Can you add tests?

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046080#comment-16046080 ] Vineet Garg commented on HIVE-6348: --- [~ashutoshc] Plan generated after subquery remove ru

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043226#comment-16043226 ] Hive QA commented on HIVE-6348: --- Here are the results of testing the latest attachment: htt

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042415#comment-16042415 ] Rui Li commented on HIVE-6348: -- Hi [~ashutoshc], I didn't put it in calcite because it won't w

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041275#comment-16041275 ] Ashutosh Chauhan commented on HIVE-6348: I am not sure doing it on AST is better (o

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041187#comment-16041187 ] Xuefu Zhang commented on HIVE-6348: --- Sounds good, [~lirui], [~vgarg]. As this is an optim

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040710#comment-16040710 ] Rui Li commented on HIVE-6348: -- Hi [~xuefuz], [~vgarg], I also think it's easier to do this in

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038237#comment-16038237 ] Vineet Garg commented on HIVE-6348: --- I think it's better to remove it in AST or during lo

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037986#comment-16037986 ] Xuefu Zhang commented on HIVE-6348: --- [~lirui], I think it's better to remove it from oper

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037930#comment-16037930 ] Rui Li commented on HIVE-6348: -- Thanks guys for the suggestions. Yeah I agree ignoring such or

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037458#comment-16037458 ] Carter Shanklin commented on HIVE-6348: --- I don't think banning is a good idea, there'

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037261#comment-16037261 ] Vineet Garg commented on HIVE-6348: --- I agree with [~ashutoshc] and [~xuefuz]. If we do in

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037241#comment-16037241 ] Ashutosh Chauhan commented on HIVE-6348: Indeed optimizing away inner query sort (w

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037185#comment-16037185 ] Xuefu Zhang commented on HIVE-6348: --- I'm wondering if it makes more sense to optimize the

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036612#comment-16036612 ] Rui Li commented on HIVE-6348: -- The latest failures are due to the sub-query order/sort by in

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034637#comment-16034637 ] Hive QA commented on HIVE-6348: --- Here are the results of testing the latest attachment: htt

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034529#comment-16034529 ] Rui Li commented on HIVE-6348: -- Fix some tests in v2 patch. The plan is to disallow order/sort

[jira] [Commented] (HIVE-6348) Order by/Sort by in subquery

[ https://issues.apache.org/jira/browse/HIVE-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031049#comment-16031049 ] Hive QA commented on HIVE-6348: --- Here are the results of testing the latest attachment: htt