[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336304#comment-16336304 ] Hive QA commented on HIVE-17833: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336255#comment-16336255 ] Hive QA commented on HIVE-17833: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336216#comment-16336216 ] Hive QA commented on HIVE-17833: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336141#comment-16336141 ] Hive QA commented on HIVE-17833: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334772#comment-16334772 ] Prasanth Jayachandran commented on HIVE-17833: -- Fixes NPE in test > Publish

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334307#comment-16334307 ] Hive QA commented on HIVE-17833: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334251#comment-16334251 ] Hive QA commented on HIVE-17833: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334175#comment-16334175 ] Hive QA commented on HIVE-17833: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334142#comment-16334142 ] Hive QA commented on HIVE-17833: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334104#comment-16334104 ] Hive QA commented on HIVE-17833: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332899#comment-16332899 ] Sergey Shelukhin commented on HIVE-17833: - Looks like test output still changes fo

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332155#comment-16332155 ] Hive QA commented on HIVE-17833: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332123#comment-16332123 ] Hive QA commented on HIVE-17833: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329305#comment-16329305 ] Sergey Shelukhin commented on HIVE-17833: - +1 pending tests, one small nit on RB

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329303#comment-16329303 ] Prasanth Jayachandran commented on HIVE-17833: -- [~sershe] can you please take

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329180#comment-16329180 ] Hive QA commented on HIVE-17833: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329109#comment-16329109 ] Hive QA commented on HIVE-17833: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324426#comment-16324426 ] Sergey Shelukhin commented on HIVE-17833: - The files might need to be updated...

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324105#comment-16324105 ] Hive QA commented on HIVE-17833: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324020#comment-16324020 ] Hive QA commented on HIVE-17833: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323792#comment-16323792 ] Hive QA commented on HIVE-17833: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323744#comment-16323744 ] Hive QA commented on HIVE-17833: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || S

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323123#comment-16323123 ] Sergey Shelukhin commented on HIVE-17833: - Couple of non-nits on RB :) > Publish

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323074#comment-16323074 ] Prasanth Jayachandran commented on HIVE-17833: -- [~sershe] Not sure if you had

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222984#comment-16222984 ] Sergey Shelukhin commented on HIVE-17833: - Is there a RB? > Publish split generat

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221604#comment-16221604 ] Sergey Shelukhin commented on HIVE-17833: - Ok I rescind my +1 > Publish split gen

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221555#comment-16221555 ] Prasanth Jayachandran commented on HIVE-17833: -- [~sershe] Commented in wrong

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221546#comment-16221546 ] Sergey Shelukhin commented on HIVE-17833: - Nit: is it possible to rename reason in

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219789#comment-16219789 ] Prasanth Jayachandran commented on HIVE-17833: -- Unit test case for triggers b

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210403#comment-16210403 ] Sergey Shelukhin commented on HIVE-17833: - Another nit: probably cheaper to check

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210394#comment-16210394 ] Sergey Shelukhin commented on HIVE-17833: - Nit: it appears that getVertexCounterNa

[jira] [Commented] (HIVE-17833) Publish split generation counters

[ https://issues.apache.org/jira/browse/HIVE-17833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210389#comment-16210389 ] Prasanth Jayachandran commented on HIVE-17833: -- The patch is small if we igno