[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-08-02 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112210#comment-16112210 ] Lefty Leverenz commented on HIVE-16998: --- Doc note: This adds *hive.spark.dynamic.pa

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-08-02 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112207#comment-16112207 ] Lefty Leverenz commented on HIVE-16998: --- [~stakiar], please set the fix version for

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-30 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106720#comment-16106720 ] Sahil Takiar commented on HIVE-16998: - Thanks [~janulatha], committed to master. > Ad

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-29 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106177#comment-16106177 ] Sahil Takiar commented on HIVE-16998: - +1 > Add config to enable HoS DPP only for map

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-28 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106053#comment-16106053 ] Hive QA commented on HIVE-16998: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-28 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105400#comment-16105400 ] Sahil Takiar commented on HIVE-16998: - Final patch LGTM pending results from Hive QA.

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-28 Thread Janaki Lahorani (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105383#comment-16105383 ] Janaki Lahorani commented on HIVE-16998: Resolved merge conflicts with HIVE-17087.

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104108#comment-16104108 ] Hive QA commented on HIVE-16998: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-27 Thread Janaki Lahorani (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104048#comment-16104048 ] Janaki Lahorani commented on HIVE-16998: Thanks [~stakiar]. I will rebase. > Add

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-27 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104042#comment-16104042 ] Sahil Takiar commented on HIVE-16998: - You'll probably need to rebase this too, since

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-27 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103871#comment-16103871 ] Sahil Takiar commented on HIVE-16998: - [~janulatha], some minor comments on the change

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103742#comment-16103742 ] Hive QA commented on HIVE-16998: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-27 Thread Janaki Lahorani (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103523#comment-16103523 ] Janaki Lahorani commented on HIVE-16998: Addressed comments from [~stakiar]. DPP f

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-27 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102855#comment-16102855 ] Lefty Leverenz commented on HIVE-16998: --- Thanks for the newline fix, [~janulatha].

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-26 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102262#comment-16102262 ] Sahil Takiar commented on HIVE-16998: - [~janulatha] looks like there are some issues w

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-26 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102253#comment-16102253 ] Hive QA commented on HIVE-16998: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-26 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102223#comment-16102223 ] Sahil Takiar commented on HIVE-16998: - [~janulatha] I changed the status of this JIRA

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-26 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102221#comment-16102221 ] Sahil Takiar commented on HIVE-16998: - Overall, the approach LGTM, just a few more com

[jira] [Commented] (HIVE-16998) Add config to enable HoS DPP only for map-joins

2017-07-24 Thread Lefty Leverenz (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099513#comment-16099513 ] Lefty Leverenz commented on HIVE-16998: --- I suggest adding a second sentence to the p