[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-20 Thread Gunther Hagleitner (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633945#comment-14633945 ] Gunther Hagleitner commented on HIVE-11281: --- offline discussion: There's two th

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-17 Thread Gunther Hagleitner (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631874#comment-14631874 ] Gunther Hagleitner commented on HIVE-11281: --- How many places do we have that tra

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Eugene Koifman (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630640#comment-14630640 ] Eugene Koifman commented on HIVE-11281: --- perhaps another overloaded toStringTree(boo

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Eugene Koifman (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630599#comment-14630599 ] Eugene Koifman commented on HIVE-11281: --- Imagine someone implemented HashMap.toStrin

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630584#comment-14630584 ] Ashutosh Chauhan commented on HIVE-11281: - I checked UpdateDeleteSemanticAnalyzer

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630566#comment-14630566 ] Hive QA commented on HIVE-11281: {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Eugene Koifman (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630562#comment-14630562 ] Eugene Koifman commented on HIVE-11281: --- UpdateDeleteSemanticAnalyzer does mutate AS

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630531#comment-14630531 ] Ashutosh Chauhan commented on HIVE-11281: - Thats a valid concern. But AFAIK we don

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Eugene Koifman (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630427#comment-14630427 ] Eugene Koifman commented on HIVE-11281: --- What happens when someone programmatically

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Hari Sankar Sivarama Subramaniyan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630402#comment-14630402 ] Hari Sankar Sivarama Subramaniyan commented on HIVE-11281: -- +1 >

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Hari Sankar Sivarama Subramaniyan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630280#comment-14630280 ] Hari Sankar Sivarama Subramaniyan commented on HIVE-11281: -- [~ash

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Prasanth Jayachandran (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630255#comment-14630255 ] Prasanth Jayachandran commented on HIVE-11281: -- the white space is not an iss

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630249#comment-14630249 ] Ashutosh Chauhan commented on HIVE-11281: - Didn't follow you about double spacing.

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630200#comment-14630200 ] Hive QA commented on HIVE-11281: {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-11281) Memoize toStringTree() for ASTNode

2015-07-16 Thread Prasanth Jayachandran (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630078#comment-14630078 ] Prasanth Jayachandran commented on HIVE-11281: -- nits: Shouldn't the following