Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog file [flink-cdc]

2024-07-02 Thread via GitHub
shiyiky commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1654671986 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## Revie

[PR] [FLINK-35271][doc] Add doc for syntax DESCRIBE JOB [flink]

2024-07-02 Thread via GitHub
xuyangzhong opened a new pull request, #24984: URL: https://github.com/apache/flink/pull/24984 ## What is the purpose of the change *Add doc for syntax DESCRIBE JOB * ## Brief change log - *add doc for en and zh* ## Verifying this change This pr is no need

Re: [PR] [FLINK-35271][doc] Add doc for syntax DESCRIBE JOB [flink]

2024-07-02 Thread via GitHub
xuyangzhong commented on code in PR #24984: URL: https://github.com/apache/flink/pull/24984#discussion_r1654746594 ## docs/content/docs/dev/table/sql/describe.md: ## @@ -26,25 +26,25 @@ under the License. # DESCRIBE Statements -DESCRIBE statements are used to describe the s

Re: [PR] [FLINK-35271][doc] Add doc for syntax DESCRIBE JOB [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #24984: URL: https://github.com/apache/flink/pull/24984#issuecomment-2191596027 ## CI report: * 9cdced1ce814bc30f779f7c8f55c1ea0b75fcaf6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog file [flink-cdc]

2024-07-02 Thread via GitHub
whhe commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1654752149 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## @@ -324,11

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog file [flink-cdc]

2024-07-02 Thread via GitHub
shiyiky commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1654774127 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## @@ -324

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog file [flink-cdc]

2024-07-02 Thread via GitHub
whhe commented on PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#issuecomment-2191654815 Thanks for the update, now we know the blocking is caused by two reasons: 1. We did not deal with empty queue. 2. The BinaryLogClient is missing LifecycleListener, or more specificall

[PR] [BP-1.20] [FLINK-35691][table] Fix unexpected behavior of repeated suspend and resume materialized table [flink]

2024-07-02 Thread via GitHub
lsyldliu opened a new pull request, #24985: URL: https://github.com/apache/flink/pull/24985 [BP-1.20] [FLINK-35691][table] Fix unexpected behavior of repeated suspend and resume materialized table -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [BP-1.20] [FLINK-35691][table] Fix unexpected behavior of repeated suspend and resume materialized table [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #24985: URL: https://github.com/apache/flink/pull/24985#issuecomment-2191682344 ## CI report: * 40bac18a7c025e54ff6c7438b8982d6b76c9597c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35691][table] Fix unexpected behavior of repeated suspend and resume materialized table [flink]

2024-07-02 Thread via GitHub
lsyldliu merged PR #24978: URL: https://github.com/apache/flink/pull/24978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35704] Use ForkJoinPool in NonSplittingRecursiveEnumerator [flink]

2024-07-02 Thread via GitHub
gliter commented on PR #24986: URL: https://github.com/apache/flink/pull/24986#issuecomment-2191702558 I would prefer the code be structured a bit differently, mainly by not creating ArrayList just to be passed as parameter and return stream instead in `addSplitsForPath` but it have to be

Re: [PR] [FLINK-35704] Use ForkJoinPool in NonSplittingRecursiveEnumerator [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #24986: URL: https://github.com/apache/flink/pull/24986#issuecomment-2191696248 ## CI report: * 5cc83326c8958e4795b9d77d11d0c2793ad7366c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35704] Use ForkJoinPool in NonSplittingRecursiveEnumerator [flink]

2024-07-02 Thread via GitHub
gliter opened a new pull request, #24986: URL: https://github.com/apache/flink/pull/24986 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

Re: [PR] [FLINK-35704] Use ForkJoinPool in NonSplittingRecursiveEnumerator [flink]

2024-07-02 Thread via GitHub
gliter commented on PR #24986: URL: https://github.com/apache/flink/pull/24986#issuecomment-2194649007 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-35344][cdc-base] Move same code from multiple subclasses to JdbcSourceChunkSplitter [flink-cdc]

2024-07-02 Thread via GitHub
loserwang1024 commented on code in PR #3319: URL: https://github.com/apache/flink-cdc/pull/3319#discussion_r1657064426 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/splitter/JdbcSourceChunkSplitter.java

Re: [PR] Flink 33386 review splited commits for ci [flink]

2024-07-02 Thread via GitHub
RocMarshal commented on PR #24229: URL: https://github.com/apache/flink/pull/24229#issuecomment-2194703794 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-35551][runtime] Introduces RescaleManager#onTrigger endpoint [flink]

2024-07-02 Thread via GitHub
XComp commented on PR #24910: URL: https://github.com/apache/flink/pull/24910#issuecomment-2194727428 [CI failure](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=60525&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=10037) du

Re: [PR] [FLINK-35551][runtime] Introduces RescaleManager#onTrigger endpoint [flink]

2024-07-02 Thread via GitHub
XComp commented on PR #24910: URL: https://github.com/apache/flink/pull/24910#issuecomment-2194727822 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-35552][runtime] Moves CheckpointStatsTracker out of DefaultExecutionGraphFactory into Scheduler [flink]

2024-07-02 Thread via GitHub
ztison commented on code in PR #24911: URL: https://github.com/apache/flink/pull/24911#discussion_r1657013866 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -214,402 +60,49 @@ void reportRestoredCheckpoint(RestoredCheckpoint

Re: [PR] [FLINK-35702][format][parquet] support parquet read nested. [flink]

2024-07-02 Thread via GitHub
empathy87 commented on PR #24991: URL: https://github.com/apache/flink/pull/24991#issuecomment-2197002034 @Stephen0421, could you, please, look at this issue https://issues.apache.org/jira/projects/FLINK/issues/FLINK-35698 It seems to be connected to your work. There is a problem Parquet

Re: [PR] [FLINK-35553][runtime] Wires up the RescaleManager with the CheckpointLifecycleListener interface [flink]

2024-07-02 Thread via GitHub
XComp commented on PR #24912: URL: https://github.com/apache/flink/pull/24912#issuecomment-2197023625 I addressed the last two comments and rebased the branch to most-recent version of parent PR #24911 . That way we also have the CI debug commit included -- This is an automated message fr

Re: [PR] [WIP] [FLINK-XXXX] [core] WIP Watermarking [flink]

2024-07-02 Thread via GitHub
jeyhunkarimov closed pull request #24995: [WIP] [FLINK-] [core] WIP Watermarking URL: https://github.com/apache/flink/pull/24995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] [WIP] [FLINK-XXXX] [core] WIP Watermarking [flink]

2024-07-02 Thread via GitHub
jeyhunkarimov opened a new pull request, #24995: URL: https://github.com/apache/flink/pull/24995 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring t

Re: [PR] [WIP] [FLINK-XXXX] [core] WIP Watermarking [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #24995: URL: https://github.com/apache/flink/pull/24995#issuecomment-2197770924 ## CI report: * b739e000f1ad7e9ce6f1dcbb3fbd2bfb27016083 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35654][docs] Add CDC release verification & Installation guide [flink-cdc]

2024-07-02 Thread via GitHub
yuxiqian commented on code in PR #3430: URL: https://github.com/apache/flink-cdc/pull/3430#discussion_r1659427878 ## docs/content/docs/developer-guide/contribute-to-flink-cdc.md: ## @@ -82,3 +83,56 @@ not need a long description. 3. Are the Documentation Updated? If the pull

Re: [PR] [FLINK-35654][docs] Add CDC release verification & Installation guide [flink-cdc]

2024-07-02 Thread via GitHub
yuxiqian commented on code in PR #3430: URL: https://github.com/apache/flink-cdc/pull/3430#discussion_r1659416389 ## README.md: ## @@ -27,7 +27,15 @@ full database synchronization, sharding table synchronization, schema evolution ![Flink CDC framework desigin](docs/static/fi

Re: [PR] [FLINK-35654][docs] Add CDC release verification & Installation guide [flink-cdc]

2024-07-02 Thread via GitHub
yuxiqian commented on PR #3430: URL: https://github.com/apache/flink-cdc/pull/3430#issuecomment-2197864754 Thanks for @morazow's comments! Addressed most of them, and left several requires further discussion. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [FLINK-35357][docs] Add kubernetes.operator.plugins.listeners config [flink-kubernetes-operator]

2024-07-02 Thread via GitHub
1996fanrui commented on code in PR #845: URL: https://github.com/apache/flink-kubernetes-operator/pull/845#discussion_r1659491268 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -182,5 +182,11 @@ Map Custom HTTP header for HttpArtifact

Re: [PR] [FLINK-35702][format][parquet] support parquet read nested. [flink]

2024-07-02 Thread via GitHub
Stephen0421 commented on code in PR #24991: URL: https://github.com/apache/flink/pull/24991#discussion_r1659515022 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/ParquetSplitReaderUtil.java: ## @@ -578,4 +569,167 @@ public static WritableCol

Re: [PR] [FLINK-35702][format][parquet] support parquet read nested. [flink]

2024-07-02 Thread via GitHub
Stephen0421 commented on PR #24991: URL: https://github.com/apache/flink/pull/24991#issuecomment-2197896793 > @Stephen0421, could you, please, look at this issue https://issues.apache.org/jira/projects/FLINK/issues/FLINK-35698 It seems to be connected to your work. There is a problem Parque

Re: [PR] [FLINK-35734][table] Do not override the user-defined checkpoint interval in continuous mode. [flink]

2024-07-02 Thread via GitHub
lsyldliu merged PR #25002: URL: https://github.com/apache/flink/pull/25002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[PR] [hotfix][parquet] fix dependences and variable name problems in FLINK-35702 [flink]

2024-07-02 Thread via GitHub
Stephen0421 opened a new pull request, #25004: URL: https://github.com/apache/flink/pull/25004 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transfer

Re: [PR] [hotfix][parquet] fix dependences and variable name problems in FLINK-35702 [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #25004: URL: https://github.com/apache/flink/pull/25004#issuecomment-2200079714 ## CI report: * 9fba47c2d98e83aeebc51347847f14ee7f067445 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35643][doc] Add materialized table statement doc [flink]

2024-07-02 Thread via GitHub
lsyldliu commented on code in PR #24975: URL: https://github.com/apache/flink/pull/24975#discussion_r1660970466 ## docs/content/docs/dev/table/materialized-table/syntax.md: ## @@ -0,0 +1,337 @@ +--- +title: Syntax Review Comment: Statements ## docs/content/docs/de

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-07-02 Thread via GitHub
hlteoh37 commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1660998380 ## flink-connector-aws-e2e-tests/flink-connector-aws-sqs-e2e-tests/pom.xml: ## @@ -0,0 +1,111 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:

Re: [PR] [FLINK-35552][runtime] Moves CheckpointStatsTracker out of DefaultExecutionGraphFactory into Scheduler [flink]

2024-07-02 Thread via GitHub
XComp commented on code in PR #24911: URL: https://github.com/apache/flink/pull/24911#discussion_r1647485917 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionGraphHandler.java: ## @@ -81,23 +82,20 @@ public void reportCheckpointMetrics( public void

Re: [PR] Release flink-shaded 19.0 [flink-web]

2024-07-02 Thread via GitHub
MartijnVisser commented on code in PR #749: URL: https://github.com/apache/flink-web/pull/749#discussion_r1661043966 ## docs/data/additional_components.yml: ## @@ -33,12 +39,6 @@ flink-shaded-17.0: source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-17.0

[PR] [BP-1.20][FLINK-35734][table] Do not override the user-defined checkpoint interval in continuous mode [flink]

2024-07-02 Thread via GitHub
hackergin opened a new pull request, #25005: URL: https://github.com/apache/flink/pull/25005 ## What is the purpose of the change Currently, in continuous mode, the checkpoint interval is set based on freshness by default. However, if the user explicitly sets a checkpoint interval, w

Re: [PR] [BP-1.20][FLINK-35734][table] Do not override the user-defined checkpoint interval in continuous mode [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #25005: URL: https://github.com/apache/flink/pull/25005#issuecomment-2200185822 ## CI report: * 765d5ce23ee57c25cde2ac93c22596eff314e6e7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. [flink]

2024-07-02 Thread via GitHub
JunRuiLee commented on PR #24998: URL: https://github.com/apache/flink/pull/24998#issuecomment-2203161525 Squashed the commits and rebased onto master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [FLINK-35742] Don't create RocksDB CF if task cancellation is in progress [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #25011: URL: https://github.com/apache/flink/pull/25011#issuecomment-2203191141 ## CI report: * 30dc775c032759e64215775dba3f7528aa3b5301 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35743][cdc-runtime] Fix the time zone configuration for temporal functions is not effective [flink-cdc]

2024-07-02 Thread via GitHub
aiwenmo commented on PR #3449: URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2203201015 @yuxiqian PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2. [flink]

2024-07-02 Thread via GitHub
fapaul commented on code in PR #24998: URL: https://github.com/apache/flink/pull/24998#discussion_r1661069156 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -337,6 +337,20 @@ void testChainNodeSetParallelism(

Re: [PR] [FLINK-35643][doc] Add materialized table statement doc [flink]

2024-07-02 Thread via GitHub
hackergin commented on code in PR #24975: URL: https://github.com/apache/flink/pull/24975#discussion_r166970 ## docs/content/docs/dev/table/materialized-table/quick-start.md: ## @@ -0,0 +1,333 @@ +--- +title: Quick Start +weight: 3 +type: docs +aliases: +- /dev/table/materia

Re: [PR] [FLINK-35643][doc] Add materialized table statement doc [flink]

2024-07-02 Thread via GitHub
hackergin commented on code in PR #24975: URL: https://github.com/apache/flink/pull/24975#discussion_r1662619373 ## docs/content/docs/dev/table/materialized-table/quick-start.md: ## @@ -0,0 +1,333 @@ +--- +title: Quick Start +weight: 3 +type: docs +aliases: +- /dev/table/materia

[PR] [FLINK-35742] Don't create RocksDB CF if task cancellation is in progress [flink]

2024-07-02 Thread via GitHub
rkhachatryan opened a new pull request, #25011: URL: https://github.com/apache/flink/pull/25011 We observe a lot of TMs stuck for > 30s in RocksDBHandle.registerStateColumnFamilyHandleWithImport which boil down to native calls to create Column Family. This change registers prevents CF crea

Re: [PR] [FLINK-35730][cdc-cli] PipelineDefinitionParser add parse string method [flink-cdc]

2024-07-02 Thread via GitHub
aiwenmo commented on PR #3444: URL: https://github.com/apache/flink-cdc/pull/3444#issuecomment-2203208303 @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Support config yaml [flink-kubernetes-operator]

2024-07-02 Thread via GitHub
ctrlaltdilj commented on PR #848: URL: https://github.com/apache/flink-kubernetes-operator/pull/848#issuecomment-2203244208 Thanks @mateczagany for all the info! I have requested a JIRA account, and will file a ticket -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Flink Kubernetes Operator 1.9.0 [flink-web]

2024-07-02 Thread via GitHub
gyfora merged PR #747: URL: https://github.com/apache/flink-web/pull/747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-31215] [autoscaler] Backpropagate processing rate limits from non-scalable bottlenecks to upstream operators [flink-kubernetes-operator]

2024-07-02 Thread via GitHub
aplyusnin commented on PR #847: URL: https://github.com/apache/flink-kubernetes-operator/pull/847#issuecomment-2203883673 Hi, @gyfora, could you review the code and run the workflows, please? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [FLINK-34341] Initial implementation of DynamoDBStreams Source. Marke… [flink-connector-aws]

2024-07-02 Thread via GitHub
gguptp commented on code in PR #146: URL: https://github.com/apache/flink-connector-aws/pull/146#discussion_r1662903713 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/proxy/DynamoDbStreamsProxy.java: ## @@ -0,0 +1,184 @@

Re: [PR] [FLINK-34341] Initial implementation of DynamoDBStreams Source. Marke… [flink-connector-aws]

2024-07-02 Thread via GitHub
gguptp commented on code in PR #146: URL: https://github.com/apache/flink-connector-aws/pull/146#discussion_r1662903043 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/DynamoDbStreamsSourceEnumerator.java: ## @

Re: [PR] [FLINK-34341] Initial implementation of DynamoDBStreams Source. Marke… [flink-connector-aws]

2024-07-02 Thread via GitHub
gguptp commented on code in PR #146: URL: https://github.com/apache/flink-connector-aws/pull/146#discussion_r1662903372 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/enumerator/DynamoDbStreamsSourceEnumerator.java: ## @

Re: [PR] [FLINK-34341] Initial implementation of DynamoDBStreams Source. Marke… [flink-connector-aws]

2024-07-02 Thread via GitHub
gguptp commented on code in PR #146: URL: https://github.com/apache/flink-connector-aws/pull/146#discussion_r1662905134 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/proxy/DynamoDbStreamsProxy.java: ## @@ -0,0 +1,184 @@

Re: [PR] [FLINK-34341] Initial implementation of DynamoDBStreams Source. Marke… [flink-connector-aws]

2024-07-02 Thread via GitHub
gguptp commented on code in PR #146: URL: https://github.com/apache/flink-connector-aws/pull/146#discussion_r1662907223 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/proxy/DynamoDbStreamsProxy.java: ## @@ -0,0 +1,184 @@

Re: [PR] [FLINK-34341] Initial implementation of DynamoDBStreams Source. Marke… [flink-connector-aws]

2024-07-02 Thread via GitHub
gguptp commented on code in PR #146: URL: https://github.com/apache/flink-connector-aws/pull/146#discussion_r1662908016 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/proxy/DynamoDbStreamsProxy.java: ## @@ -0,0 +1,184 @@

Re: [PR] [FLINK-34341] Initial implementation of DynamoDBStreams Source. Marke… [flink-connector-aws]

2024-07-02 Thread via GitHub
gguptp commented on code in PR #146: URL: https://github.com/apache/flink-connector-aws/pull/146#discussion_r1662908458 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/proxy/FullJitterBackoff.java: ## @@ -0,0 +1,65 @@ +/*

Re: [PR] [FLINK-34341] Initial implementation of DynamoDBStreams Source. Marke… [flink-connector-aws]

2024-07-02 Thread via GitHub
gguptp commented on code in PR #146: URL: https://github.com/apache/flink-connector-aws/pull/146#discussion_r1662905134 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/proxy/DynamoDbStreamsProxy.java: ## @@ -0,0 +1,184 @@

Re: [PR] [FLINK-35742] Don't create RocksDB Column Family if task cancellation is in progress [flink]

2024-07-02 Thread via GitHub
rkhachatryan commented on PR #25011: URL: https://github.com/apache/flink/pull/25011#issuecomment-2204034788 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-35742] Don't create RocksDB Column Family if task cancellation is in progress [flink]

2024-07-02 Thread via GitHub
rkhachatryan commented on PR #25011: URL: https://github.com/apache/flink/pull/25011#issuecomment-2204412181 @flinkbot run azure please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [FLINK-35638] Refactor OceanBase test cases and remove dependency on host network [flink-cdc]

2024-07-02 Thread via GitHub
whhe commented on PR #3439: URL: https://github.com/apache/flink-cdc/pull/3439#issuecomment-2204779815 @GOODBOY008 @ruanhang1993 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35743][cdc-runtime] Fix the time zone configuration for temporal functions is not effective [flink-cdc]

2024-07-02 Thread via GitHub
yuxiqian commented on code in PR #3449: URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1663358098 ## flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/transform/TransformDataOperatorTest.java: ## Review Comment: I could still reproduce `

Re: [PR] [FLINK-35272][cdc][runtime] Pipeline Transform job supports omitting / renaming calculation column [flink-cdc]

2024-07-02 Thread via GitHub
lvyanquan commented on code in PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#discussion_r1663360564 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformProcessor.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35736][tests] Add migration test scripts & CI workflows [flink-cdc]

2024-07-02 Thread via GitHub
lvyanquan commented on code in PR #3447: URL: https://github.com/apache/flink-cdc/pull/3447#discussion_r1663361163 ## tools/mig-test/README.md: ## @@ -0,0 +1,36 @@ +# Flink CDC Migration Test Utilities + +## Pipeline Jobs +### Preparation + +1. Install Ruby (macOS has embedded i

Re: [PR] [FLINK-35272][cdc][runtime] Pipeline Transform job supports omitting / renaming calculation column [flink-cdc]

2024-07-02 Thread via GitHub
lvyanquan commented on code in PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#discussion_r1663360564 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformProcessor.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35272][cdc][runtime] Pipeline Transform job supports omitting / renaming calculation column [flink-cdc]

2024-07-02 Thread via GitHub
yuxiqian commented on code in PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#discussion_r1663376970 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformProcessor.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-07-02 Thread via GitHub
FangYongs commented on PR #24618: URL: https://github.com/apache/flink/pull/24618#issuecomment-2204890224 Thanks @HuangZhenQiu , +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-07-02 Thread via GitHub
FangYongs merged PR #24618: URL: https://github.com/apache/flink/pull/24618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-35318][table-planner] use UTC timezone to handle TIMESTAMP_WITHOUT_TIME_ZONE type in RexNodeToExpressionConverter [flink]

2024-07-02 Thread via GitHub
lshangq commented on PR #24787: URL: https://github.com/apache/flink/pull/24787#issuecomment-2204906269 @leonardBang Could you help to take a look at it. Or how do you think it should be changed? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [FLINK-35735][sql-gateway] Don't list all catalogs when closing session [flink]

2024-07-02 Thread via GitHub
fsk119 merged PR #25010: URL: https://github.com/apache/flink/pull/25010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-35733] Change org.jetbrains.annotations.NotNull to javax.annotation.Nonnull [flink]

2024-07-02 Thread via GitHub
1996fanrui merged PR #25001: URL: https://github.com/apache/flink/pull/25001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-35272][cdc][runtime] Pipeline Transform job supports omitting / renaming calculation column [flink-cdc]

2024-07-02 Thread via GitHub
melin commented on code in PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#discussion_r1663449011 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformProcessor.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-35272][cdc][runtime] Pipeline Transform job supports omitting / renaming calculation column [flink-cdc]

2024-07-02 Thread via GitHub
yuxiqian commented on code in PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#discussion_r1663450759 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformProcessor.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35643][doc] Add materialized table statement doc [flink]

2024-07-02 Thread via GitHub
Myasuka commented on code in PR #24975: URL: https://github.com/apache/flink/pull/24975#discussion_r1663472146 ## docs/content/docs/dev/table/materialized-table/statements.md: ## @@ -0,0 +1,344 @@ +--- +title: Statements +weight: 2 +type: docs +aliases: +- /dev/table/materialize

[PR] [cdc-connector][jdbc-db2]Flink cdc pipeline support db2 source [flink-cdc]

2024-07-02 Thread via GitHub
ChengJie1053 opened a new pull request, #3450: URL: https://github.com/apache/flink-cdc/pull/3450 Flink cdc pipeline support db2 source ![image](https://github.com/apache/flink-cdc/assets/125547374/69eadc27-6a90-4bf4-97e1-4a6746d14db8) ![image](https://github.com/apache/flink-

Re: [PR] [FLINK-35318][table-planner] use UTC timezone to handle TIMESTAMP_WITHOUT_TIME_ZONE type in RexNodeToExpressionConverter [flink]

2024-07-02 Thread via GitHub
leonardBang commented on code in PR #24787: URL: https://github.com/apache/flink/pull/24787#discussion_r1663518072 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ## @@ -455,7 +449,7 @@ class RexNodeToExpression

Re: [PR] [FLINK-35552][runtime] Moves CheckpointStatsTracker out of DefaultExecutionGraphFactory into Scheduler [flink]

2024-07-02 Thread via GitHub
XComp commented on PR #24911: URL: https://github.com/apache/flink/pull/24911#issuecomment-2205155149 [CI with AdaptiveScheduler enabled](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=60616) was successful. I'm gonna go ahead and prepare this

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-07-02 Thread via GitHub
morazow commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2205212666 Great, thanks @XComp, @HuangXingBo for the help 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [FLINK-33211][table] support flink table lineage [flink]

2024-07-02 Thread via GitHub
HuangZhenQiu opened a new pull request, #25012: URL: https://github.com/apache/flink/pull/25012 ## What is the purpose of the change 1. Add Table Lineage Vertex into transformation in planner. The final LineageGraph is generated from transformation and put into StreamGraph. The lineage g

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-07-03 Thread via GitHub
flinkbot commented on PR #25012: URL: https://github.com/apache/flink/pull/25012#issuecomment-2205241298 ## CI report: * ac8b90883eb1bf69b8b0b8bc3611c346ab0f2fc6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [minor][cdc][docs] Optimize markdown formats in doris quickstart doc [flink-cdc]

2024-07-03 Thread via GitHub
gtk96 commented on PR #3324: URL: https://github.com/apache/flink-cdc/pull/3324#issuecomment-2205263171 cc @leonardBang @ruanhang1993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [docs] Add 'scan.incremental.snapshot.backfill.skip' to docs. [flink-cdc]

2024-07-03 Thread via GitHub
gtk96 commented on code in PR #3030: URL: https://github.com/apache/flink-cdc/pull/3030#discussion_r1663652660 ## docs/content/connectors/mongodb-cdc(ZH).md: ## @@ -285,6 +285,13 @@ upstart 流需要一个唯一的密钥,所以我们必须声明 `_id` 作为 是否在快照结束后关闭空闲的 Reader。 此特性需要 flink 版本大于等于 1.14 并且 'ex

Re: [PR] [docs] Add 'scan.incremental.snapshot.backfill.skip' to docs. [flink-cdc]

2024-07-03 Thread via GitHub
gtk96 commented on code in PR #3030: URL: https://github.com/apache/flink-cdc/pull/3030#discussion_r1663653505 ## docs/content/connectors/mysql-cdc(ZH).md: ## @@ -202,6 +202,13 @@ Flink SQL> SELECT * FROM orders; Integer 表快照的块大小(行数),读取表的快照时,捕获的表被拆分为多个块。

Re: [PR] [FLINK-33607][build]: Add checksum verification for Maven wrapper [flink]

2024-07-03 Thread via GitHub
showuon commented on PR #24852: URL: https://github.com/apache/flink/pull/24852#issuecomment-2205288373 @XComp , please help have another look when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-35553][runtime] Wires up the RescaleManager with the CheckpointLifecycleListener interface [flink]

2024-07-03 Thread via GitHub
XComp commented on PR #24912: URL: https://github.com/apache/flink/pull/24912#issuecomment-2205289738 The [CI failure](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=60613) doesn't seem to be related to this PR. I created FLINK-35748 to cover

[PR] Rebuild website [flink-web]

2024-07-03 Thread via GitHub
mateczagany opened a new pull request, #750: URL: https://github.com/apache/flink-web/pull/750 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] [FLINK-35747][yarn]Fix customer ‘rest.bind-address' config overwrite … [flink]

2024-07-03 Thread via GitHub
DNCBA opened a new pull request, #25013: URL: https://github.com/apache/flink/pull/25013 ### What is the purpose of the change - [FLINK-35747][yarn]Fix ccustomer ‘rest.bind-address' config overwrite by code ### Brief change log - [FLINK-35747][yarn]Fix ccust

Re: [PR] [FLINK-35747][yarn]Fix customer ‘rest.bind-address' config overwrite … [flink]

2024-07-03 Thread via GitHub
flinkbot commented on PR #25013: URL: https://github.com/apache/flink/pull/25013#issuecomment-2205560236 ## CI report: * 4934d88d595f3bd6afc517156608c6206fc4d855 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Rebuild website [flink-web]

2024-07-03 Thread via GitHub
gyfora merged PR #750: URL: https://github.com/apache/flink-web/pull/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-07-03 Thread via GitHub
paulh86 commented on PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2205851900 Any updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [FLINK-34315][table-planner] Temporarily force disabling window join, window rank and window deduplicate optimization when using session window tvf [flink]

2024-07-03 Thread via GitHub
xuyangzhong closed pull request #24241: [FLINK-34315][table-planner] Temporarily force disabling window join, window rank and window deduplicate optimization when using session window tvf URL: https://github.com/apache/flink/pull/24241 -- This is an automated message from the Apache Git Serv

Re: [PR] [FLINK-35552][runtime] Moves CheckpointStatsTracker out of DefaultExecutionGraphFactory into Scheduler [flink]

2024-07-03 Thread via GitHub
XComp merged PR #24911: URL: https://github.com/apache/flink/pull/24911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-07-03 Thread via GitHub
whhe commented on PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2205953828 > Hi, @whhe Thx for the contribution. Would you mind fixing the failed CI action before the next review ? Hi @RocMarshal, the CI failure is fixed now. PTAL -- This is an

Re: [PR] [FLINK-35553][runtime] Wires up the RescaleManager with the CheckpointLifecycleListener interface [flink]

2024-07-03 Thread via GitHub
XComp commented on PR #24912: URL: https://github.com/apache/flink/pull/24912#issuecomment-2205962967 Rebased to `master`after base PR #24911 was merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Release flink-shaded 19.0 [flink-web]

2024-07-03 Thread via GitHub
dawidwys commented on code in PR #749: URL: https://github.com/apache/flink-web/pull/749#discussion_r1664119375 ## docs/data/additional_components.yml: ## @@ -33,12 +39,6 @@ flink-shaded-17.0: source_release_asc_url: "https://downloads.apache.org/flink/flink-shaded-17.0/flin

[PR] Split python condition from correlate rule [flink]

2024-07-03 Thread via GitHub
liuyongvs opened a new pull request, #25014: URL: https://github.com/apache/flink/pull/25014 ## What is the purpose of the change A bit reasoning for the change The reason is that since 1.28.0 ( [CALCITE-4787](https://issues.apache.org/jira/browse/CALCITE-4787) - Move core to

[PR] [FLINK-34268] Removing exclusions for FLINK-33676 33805 [flink]

2024-07-03 Thread via GitHub
jnh5y opened a new pull request, #25015: URL: https://github.com/apache/flink/pull/25015 ## What is the purpose of the change When FLINK-34268 was initially implemented, FLINK-3367 and FLINK-33805 had not landed. ## Brief change log Given that, there were exclusions hard

[PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow for 1.18 [flink]

2024-07-03 Thread via GitHub
morazow opened a new pull request, #25016: URL: https://github.com/apache/flink/pull/25016 ## What is the purpose of the change Integrates Python Wheels build into the GitHub Actions (GHA) nightly workflow for 1.18 releases. ## Brief change log - Adds Python Wheels GHA w

[PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow for 1.19 [flink]

2024-07-03 Thread via GitHub
morazow opened a new pull request, #25017: URL: https://github.com/apache/flink/pull/25017 ## What is the purpose of the change Integrates Python Wheels build into the GitHub Actions (GHA) nightly workflow for 1.19 releases. ## Brief change log - Adds Python Wheels GHA w

[PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow for 1.20 [flink]

2024-07-03 Thread via GitHub
morazow opened a new pull request, #25018: URL: https://github.com/apache/flink/pull/25018 ## What is the purpose of the change Integrates Python Wheels build into the GitHub Actions (GHA) nightly workflow for 1.20 releases. ## Brief change log - Adds Python Wheels GHA w

<    2   3   4   5   6   7   8   9   10   11   >