Re: [PR] Add Flink 1.19.1 release [flink-web]

2024-06-18 Thread via GitHub
hlteoh37 commented on code in PR #745: URL: https://github.com/apache/flink-web/pull/745#discussion_r1645001549 ## docs/content/posts/2024-06-14-release-1.19.1.md: ## @@ -0,0 +1,128 @@ +--- +title: "Apache Flink 1.19.1 Release Announcement" +date: "2024-06-14T00:00:00.000Z" +al

Re: [PR] Add Flink 1.19.1 release [flink-web]

2024-06-18 Thread via GitHub
hlteoh37 merged PR #745: URL: https://github.com/apache/flink-web/pull/745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] FLINK-35596: Make DescriptionElement serializable [flink]

2024-06-18 Thread via GitHub
venkata91 commented on PR #24935: URL: https://github.com/apache/flink/pull/24935#issuecomment-2177001198 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] FLINK-35641 ParquetSchemaConverter supports required fields [flink]

2024-06-21 Thread via GitHub
Ge opened a new pull request, #24956: URL: https://github.com/apache/flink/pull/24956 ## What is the purpose of the change The purpose of this change is to fix 2 scenarios where Flink produces incorrect Parquet files. Scenario 1: Convert nullable Flink types

Re: [PR] FLINK-35641 ParquetSchemaConverter supports required fields [flink]

2024-06-21 Thread via GitHub
flinkbot commented on PR #24956: URL: https://github.com/apache/flink/pull/24956#issuecomment-2177383141 ## CI report: * 50ebce3b2636d1e4f8b49db0035abe0101e610c3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35542] Set the correct class loader to lookup for the class CheckpointedOffset [flink-connector-jdbc]

2024-06-21 Thread via GitHub
RocMarshal commented on code in PR #130: URL: https://github.com/apache/flink-connector-jdbc/pull/130#discussion_r1645289417 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/split/JdbcSourceSplitSerializer.java: ## @@ -106,7 +106,7 @@ public JdbcSour

[PR] [FLINK-34111] [table] Add support for json_quote, json_unquote, address PR feedback #24156 [flink]

2024-06-21 Thread via GitHub
anupamaggarwal opened a new pull request, #24967: URL: https://github.com/apache/flink/pull/24967 ## What is the purpose of the change Adds implementation of `json_quote` and `json_unquote` functions. PR is a continuation of https://github.com/apache/flink/pull/24156 and addres

Re: [PR] [FLINK-34111][table] Add JSON_QUOTE and JSON_UNQUOTE function [flink]

2024-06-21 Thread via GitHub
anupamaggarwal commented on PR #24156: URL: https://github.com/apache/flink/pull/24156#issuecomment-2180544647 thanks @jeyhunkarimov! linking the PR https://github.com/apache/flink/pull/24967 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [FLINK-34111] [table] Add support for json_quote, json_unquote, address PR feedback #24156 [flink]

2024-06-21 Thread via GitHub
flinkbot commented on PR #24967: URL: https://github.com/apache/flink/pull/24967#issuecomment-2180545397 ## CI report: * 0056727733c5f34f201fec83c8945aeecc418102 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35552][runtime] Moves CheckpointStatsTracker out of DefaultExecutionGraphFactory into Scheduler [flink]

2024-06-21 Thread via GitHub
XComp commented on code in PR #24911: URL: https://github.com/apache/flink/pull/24911#discussion_r1647485917 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionGraphHandler.java: ## @@ -81,23 +82,20 @@ public void reportCheckpointMetrics( public void

Re: [PR] [FLINK-35649] Bump Flink version to 1.19.1 in k8s-operator [flink-kubernetes-operator]

2024-06-21 Thread via GitHub
mateczagany commented on code in PR #842: URL: https://github.com/apache/flink-kubernetes-operator/pull/842#discussion_r1647489599 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java: ## @@ -48,8 +48,8 @@

Re: [PR] [FLINK-35648][runtime] Allow applying multiple route rules for one single source table [flink-cdc]

2024-06-21 Thread via GitHub
yuxiqian commented on code in PR #3425: URL: https://github.com/apache/flink-cdc/pull/3425#discussion_r1647487080 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaDerivation.java: ## @@ -84,34 +88,50 @@ public List applySchemaCh

Re: [PR] [hotfix][streaming] Move the TestProcessingTimeService.java down to the corresponding test package. [flink]

2024-06-21 Thread via GitHub
RocMarshal commented on PR #24965: URL: https://github.com/apache/flink/pull/24965#issuecomment-2182071760 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [Oracle][MySQL][SqlServer][PostgresSQL] Fix Oracle/MySQL/SqlServer/PostgresSQL CDC parser schema change event failed [flink-cdc]

2024-06-21 Thread via GitHub
mdzz9527 commented on PR #2315: URL: https://github.com/apache/flink-cdc/pull/2315#issuecomment-2182073190 合并到哪个版本了呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [Flink-35587][runtime] Revert the change of memory decoupling with the job topology [flink]

2024-06-21 Thread via GitHub
flinkbot commented on PR #24968: URL: https://github.com/apache/flink/pull/24968#issuecomment-2182093489 ## CI report: * 4198a0fba3ea585b8f9015c987f43626db76b46c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35318][table-planner] use UTC timezone to handle TIMESTAMP_WITHOUT_TIME_ZONE type in RexNodeToExpressionConverter [flink]

2024-06-21 Thread via GitHub
LadyForest commented on PR #24787: URL: https://github.com/apache/flink/pull/24787#issuecomment-2182122967 > Hi, @LadyForest. Do you plan to continue reviewing it? If you're busy, I'd be happy to continue the review. Free feel to go ahead. -- This is an automated message from the A

Re: [PR] [FLINK-35318][table-planner] use UTC timezone to handle TIMESTAMP_WITHOUT_TIME_ZONE type in RexNodeToExpressionConverter [flink]

2024-06-21 Thread via GitHub
LadyForest commented on code in PR #24787: URL: https://github.com/apache/flink/pull/24787#discussion_r1616495849 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala: ## @@ -455,7 +449,7 @@ class RexNodeToExpressionC

Re: [PR] [FLINK-35659][testutils] Fix TestFileSystem Connector error setting execution mode [flink]

2024-06-21 Thread via GitHub
lsyldliu merged PR #24966: URL: https://github.com/apache/flink/pull/24966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[PR] [Flink-35587][runtime] Revert the change of memory decoupling [flink]

2024-06-21 Thread via GitHub
TanYuxin-tyx opened a new pull request, #24968: URL: https://github.com/apache/flink/pull/24968 ## What is the purpose of the change *When running the large-scale job, the job may hang due to the memory decoupling, so we decide to revert it temporarily.* ## Brief ch

Re: [PR] [FLINK-35318][table-planner] use UTC timezone to handle TIMESTAMP_WITHOUT_TIME_ZONE type in RexNodeToExpressionConverter [flink]

2024-06-21 Thread via GitHub
xuyangzhong commented on PR #24787: URL: https://github.com/apache/flink/pull/24787#issuecomment-2182118825 Hi, @LadyForest. Do you plan to continue reviewing it? If you're busy, I'd be happy to continue the review. -- This is an automated message from the Apache Git Service. To respond

[PR] [hotfix][docs] add missing output method in Context interface [flink]

2024-06-21 Thread via GitHub
showuon opened a new pull request, #24969: URL: https://github.com/apache/flink/pull/24969 ## What is the purpose of the change 1. Add the missing `output` method in `ProcessWindowFunction#Context` interface. 2. Fix typo in Chinese doc. ## Brief change log

Re: [PR] [FLINK-35165][runtime/coordination] AdaptiveBatch Scheduler should not restrict the default source parall… [flink]

2024-06-23 Thread via GitHub
JunRuiLee commented on PR #24736: URL: https://github.com/apache/flink/pull/24736#issuecomment-2184726093 > > > > Thanks, @venkata91, for your contribution! After reviewing this PR, I'm concerned that it entirely removes limit that source parallelism should lower than source jobVertex's max

Re: [PR] [FLINK-35479][e2e] Add end-to-end test for materialized table [flink]

2024-06-23 Thread via GitHub
lsyldliu commented on code in PR #24953: URL: https://github.com/apache/flink/pull/24953#discussion_r1650020249 ## flink-end-to-end-tests/flink-sql-gateway-test/src/test/java/org/apache/flink/table/gateway/SqlGatewayE2ECase.java: ## @@ -126,6 +134,299 @@ public void testSqlClien

Re: [PR] [FLINK-35479][e2e] Add end-to-end test for materialized table [flink]

2024-06-23 Thread via GitHub
lsyldliu commented on code in PR #24953: URL: https://github.com/apache/flink/pull/24953#discussion_r1650020249 ## flink-end-to-end-tests/flink-sql-gateway-test/src/test/java/org/apache/flink/table/gateway/SqlGatewayE2ECase.java: ## @@ -126,6 +134,299 @@ public void testSqlClien

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-23 Thread via GitHub
lvyanquan commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1650032276 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/main/java/org/apache/flink/cdc/connectors/maxcompute/utils/SessionCommitCoord

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-23 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2185009821 > Yep, sorry, testing took a bit longer, than expected however it looks ok .. > UPD: currently there is a feature freeze, let's wait until it will be ended Hey, may I

Re: [PR] [FLINK-35648][runtime] Allow applying multiple route rules for one single source table [flink-cdc]

2024-06-23 Thread via GitHub
ruanhang1993 merged PR #3425: URL: https://github.com/apache/flink-cdc/pull/3425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [FLINK-35479][e2e] Add end-to-end test for materialized table [flink]

2024-06-23 Thread via GitHub
lsyldliu merged PR #24953: URL: https://github.com/apache/flink/pull/24953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [docs][minor] Optimize styles of the Flink CDC index page [flink-cdc]

2024-06-23 Thread via GitHub
leonardBang merged PR #3423: URL: https://github.com/apache/flink-cdc/pull/3423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [docs][minor] Optimize styles of the Flink CDC index page [flink-cdc]

2024-06-23 Thread via GitHub
leonardBang merged PR #3422: URL: https://github.com/apache/flink-cdc/pull/3422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-35673][test] Correct the SELF type of TestFileSourceBuilder [flink]

2024-06-23 Thread via GitHub
flinkbot commented on PR #24971: URL: https://github.com/apache/flink/pull/24971#issuecomment-2185491418 ## CI report: * 051bcf4e73901bb3dfac69fedac48f83181ceb26 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35673][test] Correct the SELF type of TestFileSourceBuilder [flink]

2024-06-23 Thread via GitHub
reswqa commented on code in PR #24971: URL: https://github.com/apache/flink/pull/24971#discussion_r1650279626 ## flink-test-utils-parent/flink-table-filesystem-test-utils/src/main/java/org/apache/flink/connector/file/src/TestFileSource.java: ## @@ -156,7 +156,8 @@ public static

[PR] [FLINK-26940][Table SQL / API] Add SUBSTRING_INDEX supported in SQL & Table API [flink]

2024-06-23 Thread via GitHub
dylanhz opened a new pull request, #24972: URL: https://github.com/apache/flink/pull/24972 ## What is the purpose of the change Add SUBSTRING_INDEX supported in SQL & Table API. Examples: ```sql > SELECT substring_index('www.apache.org', '.', 2); www.apache ``` ## B

Re: [PR] [BP-1.19][FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-06-23 Thread via GitHub
reswqa merged PR #24961: URL: https://github.com/apache/flink/pull/24961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [BP-1.18][FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-06-23 Thread via GitHub
reswqa merged PR #24960: URL: https://github.com/apache/flink/pull/24960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-26943][table-planner-blink] Support date_add function in sql [flink]

2024-06-23 Thread via GitHub
lsyldliu closed pull request #20901: [FLINK-26943][table-planner-blink] Support date_add function in sql URL: https://github.com/apache/flink/pull/20901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-26940][Table SQL / API] Add SUBSTRING_INDEX supported in SQL & Table API [flink]

2024-06-23 Thread via GitHub
flinkbot commented on PR #24972: URL: https://github.com/apache/flink/pull/24972#issuecomment-2185520911 ## CI report: * 47da25a4c3a730d937531bd64136c3577619e147 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-23 Thread via GitHub
dingxin-tech commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1650294562 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/main/java/org/apache/flink/cdc/connectors/maxcompute/utils/SessionCommitCo

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-23 Thread via GitHub
dingxin-tech commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1650295347 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/main/java/org/apache/flink/cdc/connectors/maxcompute/coordinator/SessionMa

Re: [PR] [hotfix][runtime] Change the location for test cases files of SlotSelectionStrategy [flink]

2024-06-23 Thread via GitHub
RocMarshal commented on PR #24946: URL: https://github.com/apache/flink/pull/24946#issuecomment-2185532604 Hi @1996fanrui Could you help have look for the pr if you had the free time ? Thx a lot~ -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [hotfix][streaming] Move the TestProcessingTimeService.java down to the corresponding test package. [flink]

2024-06-23 Thread via GitHub
RocMarshal commented on PR #24965: URL: https://github.com/apache/flink/pull/24965#issuecomment-2185534744 Hi, @GOODBOY008 Could you help review it If you had the free time ? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] [hotfix][runtime] Fix the issue of registering and unregistering a job for shuffle master [flink]

2024-06-23 Thread via GitHub
TanYuxin-tyx opened a new pull request, #24973: URL: https://github.com/apache/flink/pull/24973 ## What is the purpose of the change * Fix the issue of registering and unregistering a job for shuffle master* ## Brief change log - *Fix the issue of re

Re: [PR] [hotfix][runtime] Fix the issue of registering and unregistering a job for shuffle master [flink]

2024-06-23 Thread via GitHub
flinkbot commented on PR #24973: URL: https://github.com/apache/flink/pull/24973#issuecomment-2185580458 ## CI report: * ea147f2ca7c7fa2bc91eddeee33ff3e81e9b7a39 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-23 Thread via GitHub
snuyanzin commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2185697062 As it was mentioned earlier there is feature freeze currently https://lists.apache.org/thread/ftj0mcs2843yrx1tog9lfhfrbzkrbfvp so need to wait -- This is an automated message fr

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-23 Thread via GitHub
lvyanquan commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1650076654 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-maxcompute/src/main/java/org/apache/flink/cdc/connectors/maxcompute/coordinator/SessionManag

Re: [PR] [FLINK-25538][Connectors/Kafka] Migration flink-connector-kafka from Junit4 to Junit5 [flink-connector-kafka]

2024-06-23 Thread via GitHub
snuyanzin commented on code in PR #106: URL: https://github.com/apache/flink-connector-kafka/pull/106#discussion_r1650411180 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilderTest.java: ## @@ -47,33 +48,34 @@ impo

Re: [PR] [FLINK-25538][Connectors/Kafka] Migration flink-connector-kafka from Junit4 to Junit5 [flink-connector-kafka]

2024-06-23 Thread via GitHub
snuyanzin commented on code in PR #106: URL: https://github.com/apache/flink-connector-kafka/pull/106#discussion_r1650413510 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java: ## @@ -401,16 +401,16 @@ void usePoolForTransactiona

Re: [PR] [FLINK-25538][Connectors/Kafka] Migration flink-connector-kafka from Junit4 to Junit5 [flink-connector-kafka]

2024-06-23 Thread via GitHub
snuyanzin commented on code in PR #106: URL: https://github.com/apache/flink-connector-kafka/pull/106#discussion_r1650422693 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java: ## @@ -160,25 +168,17 @@ public void

Re: [PR] [FLINK-25538][Connectors/Kafka] Migration flink-connector-kafka from Junit4 to Junit5 [flink-connector-kafka]

2024-06-23 Thread via GitHub
snuyanzin commented on code in PR #106: URL: https://github.com/apache/flink-connector-kafka/pull/106#discussion_r1650422938 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java: ## @@ -197,17 +197,9 @@ public void t

[PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog [flink-cdc]

2024-06-24 Thread via GitHub
shiyiky opened a new pull request, #3432: URL: https://github.com/apache/flink-cdc/pull/3432 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-24 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2185785024 > As it was mentioned earlier there is feature freeze currently https://lists.apache.org/thread/ftj0mcs2843yrx1tog9lfhfrbzkrbfvp so need to wait OK, get your point. Thanks!

Re: [PR] [FLINK-35673][test] Correct the SELF type of TestFileSourceBuilder [flink]

2024-06-24 Thread via GitHub
reswqa merged PR #24971: URL: https://github.com/apache/flink/pull/24971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [hotfix][runtime] Fix the issue of registering and unregistering a job for shuffle master [flink]

2024-06-24 Thread via GitHub
reswqa merged PR #24973: URL: https://github.com/apache/flink/pull/24973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog [flink-cdc]

2024-06-24 Thread via GitHub
yuxiqian commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1650472226 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## @@ -32

Re: [PR] [Flink-35587][runtime] Revert the change of memory decoupling with the job topology [flink]

2024-06-24 Thread via GitHub
reswqa merged PR #24968: URL: https://github.com/apache/flink/pull/24968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog [flink-cdc]

2024-06-24 Thread via GitHub
shiyiky commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1650521744 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## @@ -324

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog [flink-cdc]

2024-06-24 Thread via GitHub
shiyiky commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1650522375 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## @@ -324

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog [flink-cdc]

2024-06-24 Thread via GitHub
shiyiky commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1650524761 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## Revie

Re: [PR] FLINK-35596: Make Description and DescriptionElement serializable [flink]

2024-06-24 Thread via GitHub
dawidwys commented on PR #24935: URL: https://github.com/apache/flink/pull/24935#issuecomment-2185860772 I think it is not the best idea to make description java serializable. It doesn't feel right to me to make serializable something that never meant to be serializable. The only purpose of

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog [flink-cdc]

2024-06-24 Thread via GitHub
yuxiqian commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1650541336 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## Revi

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog [flink-cdc]

2024-06-24 Thread via GitHub
yuxiqian commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1650541336 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## Revi

[PR] Update master version to 2.0-SNAPSHOT [flink]

2024-06-24 Thread via GitHub
reswqa opened a new pull request, #24974: URL: https://github.com/apache/flink/pull/24974 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Update master version to 2.0-SNAPSHOT [flink]

2024-06-24 Thread via GitHub
reswqa commented on PR #24974: URL: https://github.com/apache/flink/pull/24974#issuecomment-2185925097 cc @XComp as this touch the nightly GH CI config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Update master version to 2.0-SNAPSHOT [flink]

2024-06-24 Thread via GitHub
flinkbot commented on PR #24974: URL: https://github.com/apache/flink/pull/24974#issuecomment-2185928518 ## CI report: * 253174faac92bd024ec16aa79631bf36c30a634f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35682] Bump Flink version to 1.20-SNAPSHOT [flink-benchmarks]

2024-06-24 Thread via GitHub
reswqa closed pull request #91: [FLINK-35682] Bump Flink version to 1.20-SNAPSHOT URL: https://github.com/apache/flink-benchmarks/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [FLINK-35643][doc] Add materialized table statement doc [flink]

2024-06-24 Thread via GitHub
hackergin opened a new pull request, #24975: URL: https://github.com/apache/flink/pull/24975 ## What is the purpose of the change *Add doc for materialized table* ## Brief change log - Add materialized table statement doc. ## Verifying this change This chang

Re: [PR] [FLINK-35585] Add documentation for distribution [flink]

2024-06-24 Thread via GitHub
twalthr commented on PR #24929: URL: https://github.com/apache/flink/pull/24929#issuecomment-2185966780 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35643][doc] Add materialized table statement doc [flink]

2024-06-24 Thread via GitHub
flinkbot commented on PR #24975: URL: https://github.com/apache/flink/pull/24975#issuecomment-2185970933 ## CI report: * e5e265751bea6e900d8db3a685c177c45e1308d2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35662] Use maven batch mode in CI workflows [flink-kubernetes-operator]

2024-06-24 Thread via GitHub
1996fanrui merged PR #844: URL: https://github.com/apache/flink-kubernetes-operator/pull/844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-33607][build]: Add checksum verification for Maven wrapper [flink]

2024-06-24 Thread via GitHub
showuon commented on PR #24852: URL: https://github.com/apache/flink/pull/24852#issuecomment-2186208571 @XComp , I added another git action test today. I modified the `wrapperSha256Sum` to verify if we can successfully detect it, and the result works as expected [here](https://github.com/s

Re: [PR] [FLINK-35022][Connector/DynamoDB] Add TypeInformed DDB Element Converter as default element converter [flink-connector-aws]

2024-06-24 Thread via GitHub
vahmed-hamdy commented on PR #136: URL: https://github.com/apache/flink-connector-aws/pull/136#issuecomment-2186211486 @hlteoh37 Do you have other comments or could we merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [FLINK-35656][hive] Fix the issue that Hive Source incorrectly set max parallelism in dynamic inference mode [flink]

2024-06-24 Thread via GitHub
zhuzhurk commented on code in PR #24962: URL: https://github.com/apache/flink/pull/24962#discussion_r1650686355 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveSourceTest.java: ## @@ -202,14 +195,16 @@ void testDynamicParallelismInfere

Re: [PR] [FLINK-35022][Connector/DynamoDB] Add TypeInformed DDB Element Converter as default element converter [flink-connector-aws]

2024-06-24 Thread via GitHub
hlteoh37 commented on code in PR #136: URL: https://github.com/apache/flink-connector-aws/pull/136#discussion_r1650817669 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbTypeInformedElementConverter.java: ## @@ -0,0

Re: [PR] [FLINK-35022][Connector/DynamoDB] Add TypeInformed DDB Element Converter as default element converter [flink-connector-aws]

2024-06-24 Thread via GitHub
hlteoh37 commented on PR #136: URL: https://github.com/apache/flink-connector-aws/pull/136#issuecomment-2186279507 Hi @vahmed-hamdy, my preference would be for us to refactor the code in `DynamoDbTypeInformedElementConverter` to use a cleaner structure rather than a long list of `if-else`.

Re: [PR] [FLINK-35656][hive] Fix the issue that Hive Source incorrectly set max parallelism in dynamic inference mode [flink]

2024-06-24 Thread via GitHub
SinBex commented on PR #24962: URL: https://github.com/apache/flink/pull/24962#issuecomment-2186295086 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Update master version to 2.0-SNAPSHOT [flink]

2024-06-24 Thread via GitHub
XComp commented on code in PR #24974: URL: https://github.com/apache/flink/pull/24974#discussion_r1650882902 ## .github/workflows/nightly-trigger.yml: ## @@ -31,8 +31,8 @@ jobs: matrix: branch: - master + - release-1.20 - release-1.

Re: [PR] Update master version to 2.0-SNAPSHOT [flink]

2024-06-24 Thread via GitHub
reswqa commented on code in PR #24974: URL: https://github.com/apache/flink/pull/24974#discussion_r1650907110 ## .github/workflows/nightly-trigger.yml: ## @@ -31,8 +31,8 @@ jobs: matrix: branch: - master + - release-1.20 - release-1

Re: [PR] [FLINK-35550][runtime] Move rescaling functionality into dedicated class RescaleManager [flink]

2024-06-24 Thread via GitHub
XComp commented on code in PR #24909: URL: https://github.com/apache/flink/pull/24909#discussion_r1650914361 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -1048,8 +1044,8 @@ public void goToExecuting(

Re: [PR] Update master version to 2.0-SNAPSHOT [flink]

2024-06-24 Thread via GitHub
reswqa commented on PR #24974: URL: https://github.com/apache/flink/pull/24974#issuecomment-2186413637 Thanks @XComp and @1996fanrui for the review! > I know that we agreed on 1.20 being the last minor 1.x release. But did you reconfirm with the 2.0 release managers on the state of th

Re: [PR] [FLINK-35585] Add documentation for distribution [flink]

2024-06-24 Thread via GitHub
twalthr merged PR #24929: URL: https://github.com/apache/flink/pull/24929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] Update master version to 2.0-SNAPSHOT [flink]

2024-06-24 Thread via GitHub
reswqa commented on code in PR #24974: URL: https://github.com/apache/flink/pull/24974#discussion_r1650907110 ## .github/workflows/nightly-trigger.yml: ## @@ -31,8 +31,8 @@ jobs: matrix: branch: - master + - release-1.20 - release-1

Re: [PR] [FLINK-35550][runtime] Move rescaling functionality into dedicated class RescaleManager [flink]

2024-06-24 Thread via GitHub
XComp commented on PR #24909: URL: https://github.com/apache/flink/pull/24909#issuecomment-2186454160 Thanks for your reviews, @ztison and @1996fanrui . I addressed your changes and squashed the commits in a separate force-push (see [diff](https://github.com/apache/flink/compare/e365b8860b2

Re: [PR] [FLINK-35550][runtime] Move rescaling functionality into dedicated class RescaleManager [flink]

2024-06-24 Thread via GitHub
XComp commented on PR #24909: URL: https://github.com/apache/flink/pull/24909#issuecomment-2186460177 args, I forgot the commit on move the factory instantiation into the `AdaptiveScheduler` constructor (https://github.com/apache/flink/pull/24909/commits/1fca0a10ff19d038dbac3722cf5047de4fba

Re: [PR] [FLINK-35550][runtime] Move rescaling functionality into dedicated class RescaleManager [flink]

2024-06-24 Thread via GitHub
XComp commented on PR #24909: URL: https://github.com/apache/flink/pull/24909#issuecomment-2186462260 Final force-push to rebase to most-recent `master`. Can you approve this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-35551][runtime] Introduces RescaleManager#onTrigger endpoint [flink]

2024-06-24 Thread via GitHub
XComp commented on PR #24910: URL: https://github.com/apache/flink/pull/24910#issuecomment-2186472875 Rebased this PR onto the most-recent version of the base PR #24909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-35552][runtime] Moves CheckpointStatsTracker out of DefaultExecutionGraphFactory into Scheduler [flink]

2024-06-24 Thread via GitHub
XComp commented on PR #24911: URL: https://github.com/apache/flink/pull/24911#issuecomment-2186476457 Force-pushed the rebase onto the most-recent version of base PR #24910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-35553][runtime] Wires up the RescaleManager with the CheckpointLifecycleListener interface [flink]

2024-06-24 Thread via GitHub
XComp commented on code in PR #24912: URL: https://github.com/apache/flink/pull/24912#discussion_r1651045471 ## docs/layouts/shortcodes/generated/all_jobmanager_section.html: ## @@ -26,6 +32,12 @@ Duration The maximum time the JobManager will wait to ac

[PR] [FLINK-35687] JSON_QUERY should return a well formatted nested objects/arrays for ARRAY [flink]

2024-06-24 Thread via GitHub
dawidwys opened a new pull request, #24976: URL: https://github.com/apache/flink/pull/24976 ## What is the purpose of the change Fix a bug that objects and arrays were incorrectly formatted for `JSON QUERY` with `RETURNING ARRAY` clause. ## Verifying this change Adde

Re: [PR] [FLINK-35687] JSON_QUERY should return a well formatted nested objects/arrays for ARRAY [flink]

2024-06-24 Thread via GitHub
flinkbot commented on PR #24976: URL: https://github.com/apache/flink/pull/24976#issuecomment-2186630310 ## CI report: * dda23d4c2d9dbefecb9cb8533d076ed8bb8c9a8f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35553][runtime] Wires up the RescaleManager with the CheckpointLifecycleListener interface [flink]

2024-06-24 Thread via GitHub
ztison commented on code in PR #24912: URL: https://github.com/apache/flink/pull/24912#discussion_r1651071044 ## docs/layouts/shortcodes/generated/all_jobmanager_section.html: ## @@ -26,6 +32,12 @@ Duration The maximum time the JobManager will wait to a

[PR] [hotfix][parquet] fix row group filter support issue [flink]

2024-07-02 Thread via GitHub
empathy87 opened a new pull request, #24979: URL: https://github.com/apache/flink/pull/24979 ## What is the purpose of the change In `ParquetVectorizedInputFormat.java` the row group filter is set ``` FilterCompat.Filter filter = getFilter(hadoopConfig.conf()); ParquetReadOpti

Re: [PR] [FLINK-35699][k8s] Fix shading fabric8 Jackson [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #24980: URL: https://github.com/apache/flink/pull/24980#issuecomment-2189567860 ## CI report: * 31b89a3e4db0ded7135e92ef1126910af1b9b97e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][Table SQL / API] fix create table from values decimal issue [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #24981: URL: https://github.com/apache/flink/pull/24981#issuecomment-2189619803 ## CI report: * bdb76285d78797c9e77b4e9c236c51e8fc1dd251 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][parquet] fix row group filter support issue [flink]

2024-07-02 Thread via GitHub
flinkbot commented on PR #24979: URL: https://github.com/apache/flink/pull/24979#issuecomment-2189539272 ## CI report: * 60fe0a3b19ac3da1b4b2da2eaa9e74d908fe6dda UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35699][k8s] Fix shading fabric8 Jackson [flink]

2024-07-02 Thread via GitHub
ferenc-csaky opened a new pull request, #24980: URL: https://github.com/apache/flink/pull/24980 ## What is the purpose of the change The `flink-kubernetes` artifact shades Jackson classes coming through fabric8, but since Jackson 2.15, Jackson is a [multi-release JAR](https://github.com/

[PR] [hotfix][Table SQL / API] fix create table from values decimal issue [flink]

2024-07-02 Thread via GitHub
empathy87 opened a new pull request, #24981: URL: https://github.com/apache/flink/pull/24981 ## What is the purpose of the change The following code fails on the second `fromValues`: ``` List rows1 = new ArrayList<>(); rows1.add(Row.of(new BigDecimal("1.01"))); final Table

Re: [PR] [FLINK-35625][cli] Merge "flink run" and "flink run-application" functionality, deprecate "run-application" [flink]

2024-07-02 Thread via GitHub
ferenc-csaky commented on PR #24948: URL: https://github.com/apache/flink/pull/24948#issuecomment-2189650846 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] FLINK-35596: Make Description and DescriptionElement serializable [flink]

2024-07-02 Thread via GitHub
venkata91 commented on PR #24935: URL: https://github.com/apache/flink/pull/24935#issuecomment-2189737194 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Handle map and array types binary record data [flink-cdc]

2024-07-02 Thread via GitHub
leonardBang commented on PR #3434: URL: https://github.com/apache/flink-cdc/pull/3434#issuecomment-2191532930 Thanks for your contribution @umeshdangat , @loserwang1024 Would you like to help review this PR? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] [FLINK-35674][cdc-connector][mysql]Fix blocking caused by searching for timestamp in binlog file [flink-cdc]

2024-07-02 Thread via GitHub
yuxiqian commented on code in PR #3432: URL: https://github.com/apache/flink-cdc/pull/3432#discussion_r1654662884 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java: ## Revi

<    1   2   3   4   5   6   7   8   9   10   >