Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2024-06-17 Thread via GitHub
snuyanzin commented on code in PR #22775: URL: https://github.com/apache/flink/pull/22775#discussion_r1642482796 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -1038,9 +1112,9 @@ private static List toStri

Re: [PR] [FLINK-34366][table] Add support to group rows by column ordinals [flink]

2024-06-17 Thread via GitHub
MartijnVisser commented on PR #24270: URL: https://github.com/apache/flink/pull/24270#issuecomment-2172856367 @jeyhunkarimov Are you still working on this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2024-06-17 Thread via GitHub
snuyanzin commented on PR #22775: URL: https://github.com/apache/flink/pull/22775#issuecomment-2172858716 Thanks for your feedback >Could we change sth so that we don't lose data when a precision >3 is used? Could we throw an exception somewhere explicitly? This seems a questionabl

Re: [PR] [FLINK-32562][connectors/filesystem] Handle compressed streams correctly in ConcatFileCompactor [flink]

2024-06-17 Thread via GitHub
gaborgsomogyi commented on PR #24914: URL: https://github.com/apache/flink/pull/24914#issuecomment-2172892978 Seems like the actual change set is working for particular compression types and not working for others (an example is snappy). Solving the problem partially would generate bad UX f

Re: [PR] [FLINK-35297][mysql] Add validation for option connect.timeout [flink-cdc]

2024-06-17 Thread via GitHub
ruanhang1993 merged PR #3295: URL: https://github.com/apache/flink-cdc/pull/3295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [hotfix] [docs] reference.md: Add missing FlinkSessionJob CRD [flink-kubernetes-operator]

2024-06-17 Thread via GitHub
gyfora merged PR #838: URL: https://github.com/apache/flink-kubernetes-operator/pull/838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-34366][table] Add support to group rows by column ordinals [flink]

2024-06-17 Thread via GitHub
jeyhunkarimov commented on PR #24270: URL: https://github.com/apache/flink/pull/24270#issuecomment-2173019643 Hi @MartijnVisser yes I am active on this and was waiting for a review. Hi @twalthr thanks for your comments. Should I proceed with the FLIP process? -- This is an automated

Re: [PR] [FLINK-34366][table] Add support to group rows by column ordinals [flink]

2024-06-17 Thread via GitHub
twalthr commented on PR #24270: URL: https://github.com/apache/flink/pull/24270#issuecomment-2173082479 @jeyhunkarimov First, it would be great to identify the motivation behind this ticket. Is it just because we want to be compatible with BigQuery? How many vendors support it this way? -

[PR] [hotfix][runtime] Change the location for test cases files of SlotSelectionStrategy [flink]

2024-06-17 Thread via GitHub
RocMarshal opened a new pull request, #24946: URL: https://github.com/apache/flink/pull/24946 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

Re: [PR] [hotfix][runtime] Change the location for test cases files of SlotSelectionStrategy [flink]

2024-06-17 Thread via GitHub
flinkbot commented on PR #24946: URL: https://github.com/apache/flink/pull/24946#issuecomment-2173115461 ## CI report: * 774c8b99baf87a5b06f968a8ed2191a311c70cca UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [docs]Flink sql group-agg: Incorrect syntax near the keyword 'GROUPING',"GROUPING SET" is missing an S [flink]

2024-06-17 Thread via GitHub
ZmmBigdata opened a new pull request, #24947: URL: https://github.com/apache/flink/pull/24947 ## What is the purpose of the change Flink SQL group-agg.md "GROUPING SET" is missing an S Incorrect syntax near the keyword 'GROUPING' ![2c3c0991043ab1446934743af7c50d5](https://g

Re: [PR] [docs]Flink sql group-agg: Incorrect syntax near the keyword 'GROUPING',"GROUPING SET" is missing an S [flink]

2024-06-17 Thread via GitHub
ZmmBigdata commented on PR #24947: URL: https://github.com/apache/flink/pull/24947#issuecomment-2173141366 @reswqa please help take a look at the doc update PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[PR] [ci] Add Flink 1.19 version to e2e test matrix [flink-kubernetes-operator]

2024-06-17 Thread via GitHub
gyfora opened a new pull request, #840: URL: https://github.com/apache/flink-kubernetes-operator/pull/840 Add missing 1.19 from e2e matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [docs]Flink sql group-agg: Incorrect syntax near the keyword 'GROUPING',"GROUPING SET" is missing an S [flink]

2024-06-17 Thread via GitHub
flinkbot commented on PR #24947: URL: https://github.com/apache/flink/pull/24947#issuecomment-2173142248 ## CI report: * cc5927cc0c9f1052a626fe19eaf8b46ff8b352cf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [ci] Add Flink 1.19 version to e2e test matrix [flink-kubernetes-operator]

2024-06-17 Thread via GitHub
gyfora opened a new pull request, #841: URL: https://github.com/apache/flink-kubernetes-operator/pull/841 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] Update GPG key for 1.19.1 release to full key ID [flink-docker]

2024-06-17 Thread via GitHub
hlteoh37 opened a new pull request, #196: URL: https://github.com/apache/flink-docker/pull/196 Verified key lookup successful on pgp https://keyserver.ubuntu.com/pks/lookup?search=6378E37EB3AAEA188B9CB0D396C2914BB78A5EA1&fingerprint=on&op=index -- This is an automated message from

[PR] Update GPG key for 1.19.1 release to full key ID [flink-docker]

2024-06-17 Thread via GitHub
hlteoh37 opened a new pull request, #197: URL: https://github.com/apache/flink-docker/pull/197 Update GPG key for 1.19.1 release to full key ID Verified that lookup on pgp works https://keyserver.ubuntu.com/pks/lookup?search=6378E37EB3AAEA188B9CB0D396C2914BB78A5EA1&fingerprint=on&o

Re: [PR] [ci] Add Flink 1.19 version to e2e test matrix [flink-kubernetes-operator]

2024-06-17 Thread via GitHub
gyfora merged PR #840: URL: https://github.com/apache/flink-kubernetes-operator/pull/840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [ci] Add Flink 1.19 version to e2e test matrix [flink-kubernetes-operator]

2024-06-17 Thread via GitHub
gyfora merged PR #841: URL: https://github.com/apache/flink-kubernetes-operator/pull/841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [hotfix] [docs] Fix broken link to "Anatomy of the Flink distribution" in dev/configuration/connector [flink]

2024-06-17 Thread via GitHub
mattayes commented on PR #24906: URL: https://github.com/apache/flink/pull/24906#issuecomment-2173447447 @gyfora can you point me to someone who can review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-35558] [docs]: Change 'Edit This Page' feature to edit against master branch [flink]

2024-06-17 Thread via GitHub
mattayes commented on PR #24915: URL: https://github.com/apache/flink/pull/24915#issuecomment-2173448845 @gyfora can you point me to someone who can review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [optimised][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-17 Thread via GitHub
pnowojski commented on code in PR #24941: URL: https://github.com/apache/flink/pull/24941#discussion_r1642415271 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java: ## @@ -136,19 +154,28 @@ private

Re: [PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-17 Thread via GitHub
karubian commented on code in PR #143: URL: https://github.com/apache/flink-connector-aws/pull/143#discussion_r1642914129 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/util/TestUtil.java: ## @@ -36,6 +45,8 @@

Re: [PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-17 Thread via GitHub
karubian commented on code in PR #143: URL: https://github.com/apache/flink-connector-aws/pull/143#discussion_r1642914450 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/metrics/KinesisSourceShardMetrics.java: #

Re: [PR] [optimised][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-17 Thread via GitHub
pnowojski commented on code in PR #24941: URL: https://github.com/apache/flink/pull/24941#discussion_r1642915046 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java: ## @@ -136,19 +154,28 @@ private

Re: [PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-17 Thread via GitHub
z3d1k commented on code in PR #143: URL: https://github.com/apache/flink-connector-aws/pull/143#discussion_r1642998408 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/reader/KinesisStreamsSourceReaderTest.java:

Re: [PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-17 Thread via GitHub
karubian commented on code in PR #143: URL: https://github.com/apache/flink-connector-aws/pull/143#discussion_r1643015195 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/reader/KinesisStreamsSourceReaderTest.java: #

Re: [PR] FLINK-35596: Make DescriptionElement serializable [flink]

2024-06-17 Thread via GitHub
venkata91 commented on PR #24935: URL: https://github.com/apache/flink/pull/24935#issuecomment-2173952163 > ## CI report: > * [8c396c5](https://github.com/apache/flink/commit/8c396c54eeda5bc8f8f656847a372b3421c25a7f) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620

[PR] [FLINK-35625][cli] Merge "flink run" and "flink run-application" functionality, deprecate "run-application" [flink]

2024-06-17 Thread via GitHub
ferenc-csaky opened a new pull request, #24948: URL: https://github.com/apache/flink/pull/24948 ## What is the purpose of the change Merge the functionality of "flink run" and "flink run-application" under the "run" command to make job deployment more consistent. Also deprecate "run-

Re: [PR] [FLINK-35625][cli] Merge "flink run" and "flink run-application" functionality, deprecate "run-application" [flink]

2024-06-17 Thread via GitHub
flinkbot commented on PR #24948: URL: https://github.com/apache/flink/pull/24948#issuecomment-2174199321 ## CI report: * 98b001d178efab91349e344bbb450374acfc535d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Update GPG key for 1.19.1 release to full key ID [flink-docker]

2024-06-17 Thread via GitHub
mbalassi merged PR #197: URL: https://github.com/apache/flink-docker/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] Update GPG key for 1.19.1 release to full key ID [flink-docker]

2024-06-17 Thread via GitHub
mbalassi merged PR #196: URL: https://github.com/apache/flink-docker/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-35623] Bump mongo-driver version from 4.7.2 to 5.1.1 to support MongoDB 7.0 [flink-connector-mongodb]

2024-06-17 Thread via GitHub
Jiabao-Sun commented on PR #36: URL: https://github.com/apache/flink-connector-mongodb/pull/36#issuecomment-2174733929 Hi @GOODBOY008, could you help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [optimised][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-17 Thread via GitHub
1996fanrui commented on code in PR #24941: URL: https://github.com/apache/flink/pull/24941#discussion_r1643610727 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java: ## @@ -52,12 +53,22 @@ public c

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-17 Thread via GitHub
1996fanrui merged PR #24942: URL: https://github.com/apache/flink/pull/24942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-17 Thread via GitHub
1996fanrui merged PR #24943: URL: https://github.com/apache/flink/pull/24943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-17 Thread via GitHub
1996fanrui merged PR #24944: URL: https://github.com/apache/flink/pull/24944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-6895][table]Add STR_TO_DATE supported in SQL [flink]

2024-06-17 Thread via GitHub
lsyldliu commented on PR #6359: URL: https://github.com/apache/flink/pull/6359#issuecomment-2174763866 @Jiayi-Liao Does this have any progress? Can you continue to do this work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-26940][Table SQL/API] Add SUBSTRING_INDEX supported in SQL & Table API [flink]

2024-06-17 Thread via GitHub
lsyldliu closed pull request #20330: [FLINK-26940][Table SQL/API] Add SUBSTRING_INDEX supported in SQL & Table API URL: https://github.com/apache/flink/pull/20330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-17 Thread via GitHub
lvyanquan commented on PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#issuecomment-2174808090 @yuxiqian CC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]

2024-06-17 Thread via GitHub
gong commented on PR #3417: URL: https://github.com/apache/flink-cdc/pull/3417#issuecomment-2174846031 @ChengJie1053 https://issues.apache.org/jira/projects/FLINK/issues/FLINK-34908?filter=allissues Hello, I found starrocks only support second level precision, so I did't modify starrocks p

Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]

2024-06-17 Thread via GitHub
ChengJie1053 commented on PR #3417: URL: https://github.com/apache/flink-cdc/pull/3417#issuecomment-2174850613 > @ChengJie1053 https://issues.apache.org/jira/projects/FLINK/issues/FLINK-34908?filter=allissues Hello, I found starrocks only support second level precision, so I did't modify s

Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]

2024-06-17 Thread via GitHub
ChengJie1053 closed pull request #3417: [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type URL: https://github.com/apache/flink-cdc/pull/3417 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-33607][build]: Add checksum verification for Maven wrapper [flink]

2024-06-17 Thread via GitHub
showuon commented on PR #24852: URL: https://github.com/apache/flink/pull/24852#issuecomment-2174890801 @snuyanzin @JingGe @XComp , please take a look when available. This PR is doing similar things as https://github.com/apache/flink/pull/23766 , just bump the Maven wrapper version to allow

[PR] [FLINK-35616][Connectors/MongoDB] Support upsert into sharded collections [flink-connector-mongodb]

2024-06-17 Thread via GitHub
Jiabao-Sun opened a new pull request, #37: URL: https://github.com/apache/flink-connector-mongodb/pull/37 As [Mongo Reference](https://www.mongodb.com/docs/manual/reference/method/db.collection.update/#upsert-on-a-sharded-collection) says: > To use db.collection.updateOne() on a sharded

Re: [PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-17 Thread via GitHub
snuyanzin commented on PR #24940: URL: https://github.com/apache/flink/pull/24940#issuecomment-2175033193 Hm, it seems there are still tests failing `NonDeterministicDagTest` https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=60330&view=logs&j=0c940707-2659-5648-cbe6-a

Re: [PR] [FLINK-35616][Connectors/MongoDB] Support upsert into sharded collections [flink-connector-mongodb]

2024-06-17 Thread via GitHub
Jiabao-Sun commented on PR #37: URL: https://github.com/apache/flink-connector-mongodb/pull/37#issuecomment-2175058341 @leonardBang @yuxiqian, could you help review this when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] [FLINK-35627][pepeline-connector][paimon] store MultiTableCommittable… [flink-cdc]

2024-06-17 Thread via GitHub
lvyanquan opened a new pull request, #3419: URL: https://github.com/apache/flink-cdc/pull/3419 … in state to avoid conflict when job restarted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Flink Kubernetes Operator 1.9.0 [flink-web]

2024-06-17 Thread via GitHub
gyfora commented on PR #747: URL: https://github.com/apache/flink-web/pull/747#issuecomment-2175089274 @mateczagany please only include the changes you made, and do not generate the new website files. That makes it much easier to review. We usually include the generated htmls as a se

[PR] [docs][minor] Optimize styles of the Flink CDC index page [flink-cdc]

2024-06-17 Thread via GitHub
Laffery opened a new pull request, #3420: URL: https://github.com/apache/flink-cdc/pull/3420 Improve layout of index page https://github.com/apache/flink-cdc/assets/49607541/fb58f591-74e8-4061-bc80-c11204e92a99 -- This is an automated message from the Apache Git Service. To

Re: [PR] [docs][minor] Optimize styles of the Flink CDC index page [flink-cdc]

2024-06-17 Thread via GitHub
leonardBang merged PR #3420: URL: https://github.com/apache/flink-cdc/pull/3420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-33607][build]: Add checksum verification for Maven wrapper [flink]

2024-06-18 Thread via GitHub
XComp commented on PR #24852: URL: https://github.com/apache/flink/pull/24852#issuecomment-2175389275 Hi @showuon, can you create a custom GitHub Action on your fork that shows that the change works on a windows image (you can probably set up a matrix with all three OS to show that it's wor

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-18 Thread via GitHub
morazow commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2175396160 Hello @HuangXingBo, thanks for the feedback! Is the current state fine? It uses the `manylinux2014` for Linux: ``` [tool.cibuildwheel.linux] archs = ["x86_64"] manyli

Re: [PR] [FLINK-35234][hotfix][cdc-common] Fix NullPointerException of org.apache.flink.cdc.common.configuration.ConfigurationUtils#convertToString [flink-cdc]

2024-06-18 Thread via GitHub
Jiabao-Sun commented on code in PR #3255: URL: https://github.com/apache/flink-cdc/pull/3255#discussion_r1643978407 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/configuration/ConfigurationUtils.java: ## @@ -130,7 +130,9 @@ static Duration convertToDuration(Objec

Re: [PR] [hotfix][ci] Add new pipeline connectors into `labeler.yml` [flink-cdc]

2024-06-18 Thread via GitHub
Jiabao-Sun merged PR #3340: URL: https://github.com/apache/flink-cdc/pull/3340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [optimised][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-18 Thread via GitHub
pnowojski merged PR #24941: URL: https://github.com/apache/flink/pull/24941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[PR] [minor][cdc-connector][sqlserver] Fix some words error [flink-cdc]

2024-06-18 Thread via GitHub
gong opened a new pull request, #3421: URL: https://github.com/apache/flink-cdc/pull/3421 Fix some words error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [1.19][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-18 Thread via GitHub
flinkbot commented on PR #24949: URL: https://github.com/apache/flink/pull/24949#issuecomment-2175481741 ## CI report: * 5a43b2c4b2cefa7c78fdb4ef0575ef087181269f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35391][cdc-connector][paimon] Bump dependency of Paimon Pipeline connector to 0.8.0 [flink-cdc]

2024-06-18 Thread via GitHub
lvyanquan commented on PR #3335: URL: https://github.com/apache/flink-cdc/pull/3335#issuecomment-2175489350 Considering this optimization, upgrading the payment version is necessary. https://github.com/apache/paimon/pull/2943 -- This is an automated message from the Apache Git Service.

Re: [PR] [minor][cdc-connector][sqlserver] Fix some words error [flink-cdc]

2024-06-18 Thread via GitHub
gong commented on PR #3421: URL: https://github.com/apache/flink-cdc/pull/3421#issuecomment-2175468479 @leonardBang @GOODBOY008 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] [1.19][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-18 Thread via GitHub
pnowojski opened a new pull request, #24949: URL: https://github.com/apache/flink/pull/24949 This is a 1.19 backport of: https://github.com/apache/flink/pull/24941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] [1.18][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-18 Thread via GitHub
pnowojski opened a new pull request, #24950: URL: https://github.com/apache/flink/pull/24950 This is a 1.18 backport of: https://github.com/apache/flink/pull/24941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-23190][runtime] Make AdaptiveScheduler and DefaultScheduler allocate slot more evenly. [flink]

2024-06-18 Thread via GitHub
loyispa closed pull request #16929: [FLINK-23190][runtime] Make AdaptiveScheduler and DefaultScheduler allocate slot more evenly. URL: https://github.com/apache/flink/pull/16929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [1.18][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-18 Thread via GitHub
flinkbot commented on PR #24950: URL: https://github.com/apache/flink/pull/24950#issuecomment-2175538797 ## CI report: * a47052aeec0c9f5383ef4de756a6623e647e675b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35585] Add documentation for distribution [flink]

2024-06-18 Thread via GitHub
rmetzger commented on PR #24929: URL: https://github.com/apache/flink/pull/24929#issuecomment-2175539579 Reads well. +1 to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-18 Thread via GitHub
HuangXingBo commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2175616974 @morazow I am not sure whether our wheel package can be manylinux2014 without auditwheel. We can try to remove auditwheel to see the effect -- This is an automated message from the

[PR] Documentation typo [flink]

2024-06-18 Thread via GitHub
MWschutte opened a new pull request, #24951: URL: https://github.com/apache/flink/pull/24951 There might be a missing Override annotation in the Window Apply operator in the Javas example. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Documentation typo [flink]

2024-06-18 Thread via GitHub
flinkbot commented on PR #24951: URL: https://github.com/apache/flink/pull/24951#issuecomment-2175646723 ## CI report: * 6bbcd16ed4311ac28f5bd2677fcd62213418c2b0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33607][build]: Add checksum verification for Maven wrapper [flink]

2024-06-18 Thread via GitHub
showuon commented on PR #24852: URL: https://github.com/apache/flink/pull/24852#issuecomment-2175732063 @XComp , I've tried to run the `./mvnw clean package -DskipTests` in all 3 different OS [here](https://github.com/showuon/flink/actions/runs/9563064965/job/26360788830), and so far the b

Re: [PR] [FLINK-35539][tests] Fix artifactId of flink-migration-test-utils module [flink]

2024-06-18 Thread via GitHub
XComp merged PR #24901: URL: https://github.com/apache/flink/pull/24901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-18 Thread via GitHub
morazow commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2175766542 Hey @HuangXingBo, I think one of the runs above was with `manylinux2014` and without auditwheel step. But I will do another workflow run to create the wheels. I'll let you know

Re: [PR] [docs]Flink sql group-agg: Incorrect syntax near the keyword 'GROUPING',"GROUPING SET" is missing an S [flink]

2024-06-18 Thread via GitHub
reswqa commented on PR #24947: URL: https://github.com/apache/flink/pull/24947#issuecomment-2175758036 I think we can merge this even though 1.20 has been feature froze: 1. This only touch the documentation, not production code. 2. This is a valid bug-fix for release-1.20. -- Thi

Re: [PR] [docs]Flink sql group-agg: Incorrect syntax near the keyword 'GROUPING',"GROUPING SET" is missing an S [flink]

2024-06-18 Thread via GitHub
reswqa merged PR #24947: URL: https://github.com/apache/flink/pull/24947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-18 Thread via GitHub
Zakelly closed pull request #24933: [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM URL: https://github.com/apache/flink/pull/24933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] [FLINK-35632] Fix the example provided in the kafkaSource documentation for topic regex subscription [flink-connector-kafka]

2024-06-18 Thread via GitHub
elon-X opened a new pull request, #104: URL: https://github.com/apache/flink-connector-kafka/pull/104 Fix the example provided in the kafkaSource documentation for topic regex subscription see the issue: https://issues.apache.org/jira/browse/FLINK-35632 -- This is an automated mess

[PR] [hotfix][docs-zh] fix doc for maven version and DataStream operators link URL [flink]

2024-06-18 Thread via GitHub
showuon opened a new pull request, #24952: URL: https://github.com/apache/flink/pull/24952 ## What is the purpose of the change Fix documentation error. 1. We required Maven version 3.8.6, not 3. 2. `DataStream operators` in [First step](https://nightlies.apache.org/flin

Re: [PR] [hotfix][docs] fix doc for maven version and DataStream operators link URL [flink]

2024-06-18 Thread via GitHub
flinkbot commented on PR #24952: URL: https://github.com/apache/flink/pull/24952#issuecomment-2175922891 ## CI report: * aed3d7f4cd7f0bcbeffcec42979090488e1ec902 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [1.18][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-18 Thread via GitHub
pnowojski merged PR #24950: URL: https://github.com/apache/flink/pull/24950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [1.19][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-18 Thread via GitHub
pnowojski merged PR #24949: URL: https://github.com/apache/flink/pull/24949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-06-18 Thread via GitHub
X-czh commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1644393072 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/OneInputTransformation.java: ## @@ -42,7 +42,7 @@ * @param The type of the element

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-06-18 Thread via GitHub
X-czh commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1644395633 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/LineageEdgeImpl.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-06-18 Thread via GitHub
X-czh commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1644414070 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java: ## @@ -174,6 +180,18 @@ protected Transformati

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-06-18 Thread via GitHub
X-czh commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1644417751 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java: ## @@ -209,15 +227,28 @@ protected Transformat

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-06-18 Thread via GitHub
X-czh commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1644420673 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java: ## @@ -175,15 +200,32 @@ protected

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-06-18 Thread via GitHub
X-czh commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1644422069 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java: ## @@ -175,15 +200,32 @@ protected

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-06-18 Thread via GitHub
X-czh commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1644427363 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/lineage/TableColumnLineageEdge.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache So

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-06-18 Thread via GitHub
X-czh commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1644429269 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java: ## @@ -175,15 +200,32 @@ protected

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-06-18 Thread via GitHub
X-czh commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1644431010 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/OneInputTransformation.java: ## @@ -42,7 +42,7 @@ * @param The type of the element

[PR] [FLINK-35479][e2e] Add end-to-end test for materialized table [flink]

2024-06-18 Thread via GitHub
hackergin opened a new pull request, #24953: URL: https://github.com/apache/flink/pull/24953 ## What is the purpose of the change *Add e2e test case for materialized table. * ## Brief change log *(for example:)* - *Add e2e test for materialized table*

Re: [PR] [FLINK-35479][e2e] Add end-to-end test for materialized table [flink]

2024-06-18 Thread via GitHub
flinkbot commented on PR #24953: URL: https://github.com/apache/flink/pull/24953#issuecomment-2176182627 ## CI report: * 9de73310d2fd9327977a09edb09bf22bee3a6be7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-18 Thread via GitHub
hlteoh37 commented on code in PR #143: URL: https://github.com/apache/flink-connector-aws/pull/143#discussion_r1644537365 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/metrics/KinesisSourceShardMetrics.java: #

Re: [PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-18 Thread via GitHub
hlteoh37 commented on PR #143: URL: https://github.com/apache/flink-connector-aws/pull/143#issuecomment-2176248413 For > New feature has been introduced If yes, how is this documented? (not applicable / docs / JavaDocs / not documented) Can we put is as `docs` and link th

Re: [PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-18 Thread via GitHub
karubian commented on code in PR #143: URL: https://github.com/apache/flink-connector-aws/pull/143#discussion_r1644592506 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/metrics/KinesisSourceShardMetrics.java: #

Re: [PR] Add release announcement for Flink CDC 3.1.1 [flink-web]

2024-06-18 Thread via GitHub
PatrickRen merged PR #746: URL: https://github.com/apache/flink-web/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-18 Thread via GitHub
dawidwys commented on PR #24940: URL: https://github.com/apache/flink/pull/24940#issuecomment-2176422039 This caused me some serious headache. :( I feel there are multiple issues around validation. 1. We run `SqlNode#validate` twice for `INSERT INTO` queries. Once in `PreValidateR

[PR] [FLINK-35639][runtime] Fixes wrong deprecation in RestartStrategies#FixedDelayRestartStrategyConfiguration [flink]

2024-06-18 Thread via GitHub
XComp opened a new pull request, #24954: URL: https://github.com/apache/flink/pull/24954 ## What is the purpose of the change The package-private constructor slipped through when deprecating the `Time` classes in FLINK-32570 causing the the `ClassCastException` when deserializing the

Re: [PR] [FLINK-35639][runtime] Fixes wrong deprecation in RestartStrategies#FixedDelayRestartStrategyConfiguration [flink]

2024-06-18 Thread via GitHub
flinkbot commented on PR #24954: URL: https://github.com/apache/flink/pull/24954#issuecomment-2176466090 ## CI report: * 3415ed350998c3bfc49a1a8a29f2ab41d2e2aac9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35639][runtime] Fixes wrong deprecation in RestartStrategies#FixedDelayRestartStrategyConfiguration [flink]

2024-06-18 Thread via GitHub
XComp opened a new pull request, #24955: URL: https://github.com/apache/flink/pull/24955 1.19 backport for PR #24954 ## What is the purpose of the change The package-private constructor slipped through when deprecating the `Time` classes in FLINK-32570 causing the the `ClassCa

Re: [PR] [FLINK-35639][runtime] Fixes wrong deprecation in RestartStrategies#FixedDelayRestartStrategyConfiguration [flink]

2024-06-18 Thread via GitHub
flinkbot commented on PR #24955: URL: https://github.com/apache/flink/pull/24955#issuecomment-2176477813 ## CI report: * 7578630c5536fd2f9a5c74e0c0c395c2f8a85c09 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-18 Thread via GitHub
morazow commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2176882275 Hey @HuangXingBo, I have run two builds, one is with default using `auditwheel` (together with patchelf) and another without `auditwheel`. Both on the `manylinux2014` on Linux.

<    1   2   3   4   5   6   7   8   9   10   >