Re: [PR] [FLINK-35593][Kubernetes Operator] Add Apache 2 License to docker image [flink-kubernetes-operator]

2024-06-14 Thread via GitHub
rmetzger merged PR #839: URL: https://github.com/apache/flink-kubernetes-operator/pull/839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[PR] [hotfix][ForSt] Fix exception when setting 'state.backend.forst.compression.per.level' in yaml [flink]

2024-06-14 Thread via GitHub
Zakelly opened a new pull request, #24938: URL: https://github.com/apache/flink/pull/24938 ## What is the purpose of the change Just like #24902, the bug also exist in forst side, which should also be fixed. ## Brief change log - Fix `ForStStateBackend#mergeConfigurable

Re: [PR] [hotfix][ForSt] Fix exception when setting 'state.backend.forst.compression.per.level' in yaml [flink]

2024-06-14 Thread via GitHub
flinkbot commented on PR #24938: URL: https://github.com/apache/flink/pull/24938#issuecomment-2167713775 ## CI report: * 762958f1dab95a0e3c7dc8433cb04880c4b17e9a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core [flink]

2024-06-14 Thread via GitHub
GOODBOY008 opened a new pull request, #24939: URL: https://github.com/apache/flink/pull/24939 The left in core module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core [flink]

2024-06-14 Thread via GitHub
flinkbot commented on PR #24939: URL: https://github.com/apache/flink/pull/24939#issuecomment-2167744579 ## CI report: * 299695761f9ed43f73dc5bbca025e2bd29a8477c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32091][checkpoint] Add file size metrics for file-merging [flink]

2024-06-14 Thread via GitHub
fredia merged PR #24922: URL: https://github.com/apache/flink/pull/24922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-14 Thread via GitHub
morazow commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1639647084 ## .github/workflows/nightly.yml: ## @@ -28,69 +28,131 @@ jobs: name: "Pre-compile Checks" uses: ./.github/workflows/template.pre-compile-checks.yml - java

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-14 Thread via GitHub
morazow commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2167770793 Thanks @HuangXingBo for the feedback! Should we still support `manylinux1`? It seems already end of life for some years -- This is an automated message from the Apache Git Servic

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-14 Thread via GitHub
GOODBOY008 commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639708043 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/factory/OceanBaseDataSink

[PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-14 Thread via GitHub
dawidwys opened a new pull request, #24940: URL: https://github.com/apache/flink/pull/24940 ## What is the purpose of the change Fix the bug that it is not possible to name arguments in a windowed rank query if the results are inserted into explicit columns of the sink. ## Veri

Re: [PR] [FLINK-35598][sql-parser] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep [flink]

2024-06-14 Thread via GitHub
wzx140 commented on PR #24937: URL: https://github.com/apache/flink/pull/24937#issuecomment-216707 > > Could you please review it? Really thanks! > > Sorry, I'm not familiar with sql or table module, I'm unable to review this PR. Thank you for your response! I understand. I

Re: [PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-14 Thread via GitHub
flinkbot commented on PR #24940: URL: https://github.com/apache/flink/pull/24940#issuecomment-2167896279 ## CI report: * 6bf34deca7f4a8bd7c8ed9a2b988a47f263a83d3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35598][sql-parser] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep [flink]

2024-06-14 Thread via GitHub
wzx140 commented on PR #24937: URL: https://github.com/apache/flink/pull/24937#issuecomment-2167901878 @dawidwys Could you please review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [FLINK-34917][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-14 Thread via GitHub
LadyForest merged PR #24934: URL: https://github.com/apache/flink/pull/24934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[PR] [optimised][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-14 Thread via GitHub
pnowojski opened a new pull request, #24941: URL: https://github.com/apache/flink/pull/24941 This is an optimised version of https://github.com/apache/flink/pull/24211 that supersedes it. This newer version avoids having to check current time per each record, as syscalls are quite expensive

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-14 Thread via GitHub
Zakelly commented on code in PR #24933: URL: https://github.com/apache/flink/pull/24933#discussion_r1639554722 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -153,6 +152,22 @@ public abstract class FileMe

Re: [PR] [optimised][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-14 Thread via GitHub
flinkbot commented on PR #24941: URL: https://github.com/apache/flink/pull/24941#issuecomment-2168025371 ## CI report: * 0d9257b66d6fb3d41f31e01a5cdb35fe92b2e55d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-14 Thread via GitHub
pnowojski commented on PR #24211: URL: https://github.com/apache/flink/pull/24211#issuecomment-2168078012 I've prepared an improved version of this PR: https://github.com/apache/flink/pull/24941 Closing this in favour the newer one. -- This is an automated message from the Apache G

Re: [PR] [FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-14 Thread via GitHub
pnowojski closed pull request #24211: [FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator URL: https://github.com/apache/flink/pull/24211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core [flink]

2024-06-14 Thread via GitHub
GOODBOY008 commented on PR #24939: URL: https://github.com/apache/flink/pull/24939#issuecomment-2168138750 @1996fanrui @Jiabao-Sun The last pr of core module. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-14 Thread via GitHub
zoltar9264 commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2168176482 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-14 Thread via GitHub
snuyanzin commented on code in PR #24940: URL: https://github.com/apache/flink/pull/24940#discussion_r1639924796 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MiscTests.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-14 Thread via GitHub
snuyanzin commented on code in PR #24940: URL: https://github.com/apache/flink/pull/24940#discussion_r1639926653 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MiscTests.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-35585] Add documentation for distribution [flink]

2024-06-14 Thread via GitHub
twalthr commented on code in PR #24929: URL: https://github.com/apache/flink/pull/24929#discussion_r1639919185 ## docs/content/docs/dev/table/sql/create.md: ## @@ -406,6 +413,14 @@ Flink will assume correctness of the primary key by assuming that the columns nu Partition the

Re: [PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-14 Thread via GitHub
snuyanzin commented on code in PR #24940: URL: https://github.com/apache/flink/pull/24940#discussion_r1639927000 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MiscTests.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-14 Thread via GitHub
LadyForest commented on code in PR #24932: URL: https://github.com/apache/flink/pull/24932#discussion_r1639931090 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogChange.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-14 Thread via GitHub
snuyanzin commented on code in PR #24940: URL: https://github.com/apache/flink/pull/24940#discussion_r1639927000 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MiscTests.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-14 Thread via GitHub
dawidwys commented on code in PR #24940: URL: https://github.com/apache/flink/pull/24940#discussion_r1639952320 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MiscTests.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-35619] Window rank query fails with 'must call validate first' [flink]

2024-06-14 Thread via GitHub
dawidwys commented on code in PR #24940: URL: https://github.com/apache/flink/pull/24940#discussion_r1639946641 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MiscTests.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-14 Thread via GitHub
liyubin117 commented on code in PR #24932: URL: https://github.com/apache/flink/pull/24932#discussion_r1639976003 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogChange.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-14 Thread via GitHub
liyubin117 commented on code in PR #24932: URL: https://github.com/apache/flink/pull/24932#discussion_r1639976276 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java: ## @@ -59,6 +59,10 @@ public Optional getComment() {

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-14 Thread via GitHub
zoltar9264 commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2168264529 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-14 Thread via GitHub
liyubin117 commented on PR #24932: URL: https://github.com/apache/flink/pull/24932#issuecomment-2168280767 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-35371][security] Add configuration for SSL keystore and truststore type [flink]

2024-06-14 Thread via GitHub
gaborgsomogyi merged PR #24919: URL: https://github.com/apache/flink/pull/24919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-14 Thread via GitHub
liyubin117 commented on PR #24932: URL: https://github.com/apache/flink/pull/24932#issuecomment-2168329905 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [hotfix] Fix exception when setting 'state.backend.forst.compression.per.level' in yaml [flink]

2024-06-14 Thread via GitHub
Zakelly closed pull request #24938: [hotfix] Fix exception when setting 'state.backend.forst.compression.per.level' in yaml URL: https://github.com/apache/flink/pull/24938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Update Dockerfiles for 1.19.1 release [flink-docker]

2024-06-14 Thread via GitHub
hlteoh37 merged PR #195: URL: https://github.com/apache/flink-docker/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] Add GPG key for 1.19.1 release [flink-docker]

2024-06-14 Thread via GitHub
hlteoh37 merged PR #194: URL: https://github.com/apache/flink-docker/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-14 Thread via GitHub
reswqa commented on PR #24932: URL: https://github.com/apache/flink/pull/24932#issuecomment-2168431495 I didn't review every detail since @LadyForest has already carefully reviewed this, but this basically looks good to me. -- This is an automated message from the Apache Git Service. To r

[PR] Flink Kubernetes Operator 1.9.0 [flink-web]

2024-06-14 Thread via GitHub
mateczagany opened a new pull request, #747: URL: https://github.com/apache/flink-web/pull/747 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-14 Thread via GitHub
Zakelly commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2168527783 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-14 Thread via GitHub
Zakelly commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2168543823 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34918][table] Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-14 Thread via GitHub
reswqa merged PR #24932: URL: https://github.com/apache/flink/pull/24932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-14 Thread via GitHub
karubian opened a new pull request, #143: URL: https://github.com/apache/flink-connector-aws/pull/143 ## Purpose of the change Add millisBehindLatest metric to the Kinesis source implementation. ## Verifying this change This change added tests and can be verified as follo

Re: [PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-14 Thread via GitHub
boring-cyborg[bot] commented on PR #143: URL: https://github.com/apache/flink-connector-aws/pull/143#issuecomment-2168811002 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-14 Thread via GitHub
Zakelly commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2169093315 Ah, the CI is not stable. There seems to be some network issue between agents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-14 Thread via GitHub
Zakelly commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2169093495 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [cdc][postgres]PostgresDialect removes useless code [flink-cdc]

2024-06-14 Thread via GitHub
ChengJie1053 opened a new pull request, #3416: URL: https://github.com/apache/flink-cdc/pull/3416 ![image](https://github.com/apache/flink-cdc/assets/125547374/aaa86d18-5998-4925-bae4-20e28daa4ff4) ![image](https://github.com/apache/flink-cdc/assets/125547374/1ae58704-59ff-482d-96eb-

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-15 Thread via GitHub
Zakelly commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2169206187 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-15 Thread via GitHub
Zakelly commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2169206125 It seems the CI get stuck again. Restarting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-15 Thread via GitHub
zoltar9264 commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2169301167 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-15 Thread via GitHub
yuanoOo commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1641142897 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/factory/OceanBaseDataSinkFac

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-15 Thread via GitHub
yuanoOo commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1641144855 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/sink/OceanBaseMetadataApplie

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-15 Thread via GitHub
Zakelly commented on PR #24933: URL: https://github.com/apache/flink/pull/24933#issuecomment-2170246403 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-15 Thread via GitHub
HuangXingBo commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2171014919 @morazow Since a lot of our dependencies are manyLinux2014, I think we can indeed build manyLinux2014. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-15 Thread via GitHub
Zakelly commented on code in PR #24933: URL: https://github.com/apache/flink/pull/24933#discussion_r1641600159 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsMergingCheckpointStorageLocation.java: ## @@ -80,6 +80,9 @@ public FsMergingCheckpointStorage

[PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish (#24757) [flink]

2024-06-15 Thread via GitHub
elon-X opened a new pull request, #24942: URL: https://github.com/apache/flink/pull/24942 [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish (#24757) ## What is the purpose of the change *(For example: This pull request makes tas

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-15 Thread via GitHub
flinkbot commented on PR #24942: URL: https://github.com/apache/flink/pull/24942#issuecomment-2171037635 ## CI report: * 8899d14ad618b510d4ce73ed4306ff1ce909a87d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-15 Thread via GitHub
elon-X opened a new pull request, #24943: URL: https://github.com/apache/flink/pull/24943 [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish ## What is the purpose of the change *(For example: This pull request makes task deploym

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-15 Thread via GitHub
flinkbot commented on PR #24943: URL: https://github.com/apache/flink/pull/24943#issuecomment-2171039260 ## CI report: * 52f30d7931f6da3605e813e0824613381bf9cedf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-15 Thread via GitHub
elon-X opened a new pull request, #24944: URL: https://github.com/apache/flink/pull/24944 [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish ## What is the purpose of the change *(For example: This pull request makes task deploym

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-15 Thread via GitHub
flinkbot commented on PR #24944: URL: https://github.com/apache/flink/pull/24944#issuecomment-2171040780 ## CI report: * d5818ed937108ff91ad69bb8120659f7f8477c56 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35548] Add E2E tests for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-06-16 Thread via GitHub
snuyanzin commented on code in PR #28: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1641831775 ## flink-connector-gcp-pubsub/src/main/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/EmulatorCredentialsProvider.java: ## @@ -20,12 +

Re: [PR] [FLINK-35548] Add E2E tests for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-06-16 Thread via GitHub
snuyanzin commented on code in PR #28: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1641832027 ## flink-connector-gcp-pubsub/src/main/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/EmulatorCredentialsProvider.java: ## @@ -20,12 +

Re: [PR] [FLINK-35548] Add E2E tests for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-06-16 Thread via GitHub
snuyanzin commented on code in PR #28: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1641831775 ## flink-connector-gcp-pubsub/src/main/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/EmulatorCredentialsProvider.java: ## @@ -20,12 +

Re: [PR] [FLINK-34111][table] Add JSON_QUOTE and JSON_UNQUOTE function [flink]

2024-06-16 Thread via GitHub
jeyhunkarimov commented on PR #24156: URL: https://github.com/apache/flink/pull/24156#issuecomment-2171513067 Hi @anupamaggarwal thanks for your proposal. Please feel free to continue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-32086][checkpointing] Cleanup useless file-merging managed directory on exit of TM [flink]

2024-06-16 Thread via GitHub
zoltar9264 commented on code in PR #24933: URL: https://github.com/apache/flink/pull/24933#discussion_r1641835072 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsMergingCheckpointStorageLocation.java: ## @@ -80,6 +80,9 @@ public FsMergingCheckpointStor

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-06-16 Thread via GitHub
XComp commented on PR #24471: URL: https://github.com/apache/flink/pull/24471#issuecomment-2171654110 Yeah, the test failure is unrelated (FLINK-35042). Unfortunately, we missed to get it in before the feature freeze. Let's merge it after the release branch for 1.20 is created. -- This i

Re: [PR] [mysql] Mysql-cdc adapt mariadb. [flink-cdc]

2024-06-16 Thread via GitHub
ThisisWilli commented on PR #2494: URL: https://github.com/apache/flink-cdc/pull/2494#issuecomment-2171678737 > hello en how about this fix going still in progress now, maybe finish in the end of June. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] [FLINK-35548] Add E2E tests for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-06-16 Thread via GitHub
snuyanzin commented on PR #28: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/28#issuecomment-2171763168 Thanks for addressing feedback There is one more finding a put in comments -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-16 Thread via GitHub
yuanoOo commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1642033832 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/catalog/OceanBaseCatalogFact

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-16 Thread via GitHub
yuanoOo commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1641144855 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/sink/OceanBaseMetadataApplie

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
lvyanquan commented on PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#issuecomment-2171998668 What's more, considering that the number of buckets and parallelism may not be consistent, should we remove the constraint on [EventPartitioner](https://github.com/apache/flink-cdc/bl

Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]

2024-06-16 Thread via GitHub
yuxiqian commented on PR #3417: URL: https://github.com/apache/flink-cdc/pull/3417#issuecomment-2172008618 Thanks for @ChengJie1053's great work, could you please add some test cases to verify this change? Also some existed testcases might need to be tweaked to reflect this change: `

Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]

2024-06-16 Thread via GitHub
ChengJie1053 commented on PR #3417: URL: https://github.com/apache/flink-cdc/pull/3417#issuecomment-2172020816 > Thanks for @ChengJie1053's great work, could you please add some tests to verify this change? Also some existing testcases might need to be tweaked to reflect this change: >

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
dingxin-tech commented on PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#issuecomment-2172040689 > What's more, considering that the number of buckets and parallelism may not be consistent, should we remove the constraint on [EventPartitioner](https://github.com/apache/flink-c

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-16 Thread via GitHub
yuanoOo commented on PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2172064348 @GOODBOY008 I made some changes according to your review. Please review these changes. Thank you. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
lvyanquan commented on PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#issuecomment-2172081220 Got it, There is indeed no need for adjustment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [hotfix][test] Revert the junit5 migration of InitOutputPathTest [flink]

2024-06-16 Thread via GitHub
reswqa opened a new pull request, #24945: URL: https://github.com/apache/flink/pull/24945 PR#24881 introduce some issue during the migration to junit5, temporarily revert the changes to `InitOutputPathTest` file. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1642102553 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunctionProvider.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1642104736 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunctionProvider.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1642104736 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunctionProvider.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1642104736 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunctionProvider.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35601][test] Revert the junit5 migration of InitOutputPathTest [flink]

2024-06-16 Thread via GitHub
flinkbot commented on PR #24945: URL: https://github.com/apache/flink/pull/24945#issuecomment-2172111552 ## CI report: * 4b510674aee2557067a8da5ce536e23415d06340 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1642102553 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunctionProvider.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35601][test] Revert the junit5 migration of InitOutputPathTest [flink]

2024-06-16 Thread via GitHub
reswqa commented on PR #24945: URL: https://github.com/apache/flink/pull/24945#issuecomment-2172114912 > would you mind adding some background to explain the issue caused by https://github.com/apache/flink/pull/24881? I didn't look into the exact reasons, but as Matthias said in [FLI

Re: [PR] [FLINK-35601][test] Revert the junit5 migration of InitOutputPathTest [flink]

2024-06-16 Thread via GitHub
reswqa commented on PR #24945: URL: https://github.com/apache/flink/pull/24945#issuecomment-2172123699 I don't want to block our testing pipeline and things like migrating to juint5 didn't have to be in 1.20. IMHO, it makes sense to revert it first. -- This is an automated message from th

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
dingxin-tech commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1642206938 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunctionProvider.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-16 Thread via GitHub
dingxin-tech commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1642207213 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunctionProvider.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [FLINK-35601][test] Revert the junit5 migration of InitOutputPathTest [flink]

2024-06-16 Thread via GitHub
1996fanrui merged PR #24945: URL: https://github.com/apache/flink/pull/24945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-17 Thread via GitHub
superdiaodiao commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2172455196 > Thanks for the contribution @superdiaodiao thanks for the review @HuangXingBo , @davidradl > > it looks ok to me, I will test it a bit more and in case of succeed will merg

Re: [PR] [optimised][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-17 Thread via GitHub
1996fanrui commented on code in PR #24941: URL: https://github.com/apache/flink/pull/24941#discussion_r1642312751 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java: ## @@ -190,4 +217,35 @@ public

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-06-17 Thread via GitHub
affo commented on PR #24471: URL: https://github.com/apache/flink/pull/24471#issuecomment-2172535386 > Yeah, the test failure is unrelated ([FLINK-35042](https://issues.apache.org/jira/browse/FLINK-35042)). Unfortunately, we missed to get it in before the feature freeze. Let's merge it aft

Re: [PR] [optimised][FLINK-34252][table] Fix lastRecordTime tracking in WatermarkAssignerOperator [flink]

2024-06-17 Thread via GitHub
pnowojski commented on code in PR #24941: URL: https://github.com/apache/flink/pull/24941#discussion_r1642349315 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java: ## @@ -100,11 +114,15 @@ public

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-06-17 Thread via GitHub
whhe commented on PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2172572094 Anyone available? @eskabetxe @GOODBOY008 @leonardBang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-17 Thread via GitHub
dingxin-tech commented on PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#issuecomment-2172575564 Can this PR be merged before the other [PR](https://github.com/apache/flink-cdc/pull/3254)? Both PRs are marked for inclusion in version 3.2, but the other PR depends on this one.

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-17 Thread via GitHub
lvyanquan commented on PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#issuecomment-2172630960 @leonardBang @PatrickRen can you help to review and merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-06-17 Thread via GitHub
snuyanzin commented on PR #24773: URL: https://github.com/apache/flink/pull/24773#issuecomment-2172705717 Yep, sorry, testing took a bit longer, than expected however it looks ok >db2 https://www.ibm.com/docs/en/db2-for-zos/12?topic=functions-urlencode-urldecode >max compute https:

Re: [PR] [FLINK-32229][Connector/Kinesis] Add millisBehindLatest metric to Kinesis source implementation [flink-connector-aws]

2024-06-17 Thread via GitHub
z3d1k commented on code in PR #143: URL: https://github.com/apache/flink-connector-aws/pull/143#discussion_r1642396219 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/util/TestUtil.java: ## @@ -36,6 +45,8 @@ pub

Re: [PR] [FLINK-17224][table] Support precision for TIME [flink]

2024-06-17 Thread via GitHub
snuyanzin commented on PR #22775: URL: https://github.com/apache/flink/pull/22775#issuecomment-2172834841 Rebased to solve the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

<    1   2   3   4   5   6   7   8   9   10   >