[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

2017-03-13 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3040#discussion_r105600606 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/forwarding/FieldForwardingUtils.scala --- @@ -0,0 +1,143

[GitHub] flink issue #3040: [FLINK-3850] Add forward field annotations to DataSet

2017-03-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3040 @fhueske I fixed commented points. Could you explain the join keys forwarding? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-14 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r105972317 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -17,29 +17,34 @@ */ package

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-14 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r105972293 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/Types.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #3297: [FLINK-5431] Add configurable timePattern for clie...

2017-03-15 Thread tonycox
Github user tonycox closed the pull request at: https://github.com/apache/flink/pull/3297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3269: [FLINK-5698] Add NestedFieldsProjectableTableSourc...

2017-03-15 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3269#discussion_r106208275 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/util/RexProgramProjectExtractor.scala --- @@ -84,6 +108,49 @@ object

[GitHub] flink issue #3269: [FLINK-5698] Add NestedFieldsProjectableTableSource trait

2017-03-15 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3269 Hi @fhueske I've addressed all comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] flink issue #3127: [FLINK-5481] Simplify Row creation

2017-03-15 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 Hi @StephanEwen I added javadoc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3166: [FLINK-3849] Add FilterableTableSource interface a...

2017-03-17 Thread tonycox
Github user tonycox closed the pull request at: https://github.com/apache/flink/pull/3166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-17 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r106647040 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -17,29 +17,51 @@ */ package

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-17 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r106668425 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -17,29 +17,51 @@ */ package

[GitHub] flink pull request #3127: [FLINK-5481] Simplify Row creation

2017-03-20 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3127#discussion_r106862331 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/Types.scala --- @@ -17,29 +17,51 @@ */ package

[GitHub] flink issue #3269: [FLINK-5698] Add NestedFieldsProjectableTableSource trait

2017-03-23 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3269 @fhueske What dou you think about this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3127: [FLINK-5481] Simplify Row creation

2017-03-23 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @StephanEwen I fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2810: [FLINK-3848] Add ProjectableTableSource interface ...

2016-11-15 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/2810 [FLINK-3848] Add ProjectableTableSource interface and translation rule. Extend CsvTableSource to implement projection You can merge this pull request into a Git repository by running: $ git

[GitHub] flink pull request #2810: [FLINK-3848] Add ProjectableTableSource interface ...

2016-11-20 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2810#discussion_r88841542 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala --- @@ -0,0 +1,67

[GitHub] flink pull request #2810: [FLINK-3848] Add ProjectableTableSource interface ...

2016-11-21 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2810#discussion_r88849756 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala --- @@ -0,0 +1,67

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-11-22 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 > In addition, the TableSource should know project information (including order) not just fieldIncluded. So maybe we should also adapt RowCsvInputFormat. Do you mean we need to shuffle fi

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-11-22 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 @wuchong I added noticed items --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-11-25 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 @wuchong could you review my changes? cc @fhueske @StephanEwen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-11-28 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 Hi @wuchong , thank you for the review. Do you mean only for `Stream`? And why we shouldn't to override computeSelfCost for DataStreamRel ? --- If your project is set up for it, yo

[GitHub] flink pull request #2810: [FLINK-3848] Add ProjectableTableSource interface ...

2016-11-29 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2810#discussion_r90010696 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchProjectableTableSourceScanRule.scala --- @@ -0,0

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-05 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 Hi @fhueske , I see conflicts PR check, should I rebase new commits, or merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-05 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 @wuchong, @fhueske, question about field shuffling, should I shuffle it in RowCsvInputFormat by setting an order to scan, or let LogicalCal do it? --- If your project is set up for it, you can

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-05 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 I see. @fhueske. Set an order of scaning is much better way. I have problem when plan is choosing. Best expression is not correct. Rules work, but planner decides to choose `MapFunction` anyway

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 Hi @fhueske, your PR do solve my problem. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 @fhueske Basically yes, but I think we need finish projection rule for Stream, after FLINK-5251 merging --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-07 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 Hi @fhueske and @KurtYoung I totally agree with the plan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-08 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 #2926 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91548803 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowComparator.java --- @@ -0,0 +1,698 @@ +/* + * Licensed to the

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91544114 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java --- @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91550465 --- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java --- @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91551621 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowComparator.java --- @@ -0,0 +1,698 @@ +/* + * Licensed to the

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91547968 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowComparator.java --- @@ -0,0 +1,698 @@ +/* + * Licensed to the

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91547877 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowComparator.java --- @@ -0,0 +1,698 @@ +/* + * Licensed to the

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-08 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91546359 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java --- @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache

[GitHub] flink issue #2923: [FLINK-5220] [Table API & SQL] Flink SQL projection pushd...

2016-12-08 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2923 Hi @fhueske, this PR looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91670483 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowComparator.java --- @@ -326,8 +326,8 @@ public int getNormalizeKeyLen

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91674126 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91704437 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91721721 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91748535 --- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...

2016-12-12 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2968 Hi @wuchong, maybe we should move `RowCsvInputFormat` also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #2968: [FLINK-5187] [core] Create analog of Row and RowTy...

2016-12-12 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2968#discussion_r91941722 --- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] flink issue #2968: [FLINK-5187] [core] Create analog of Row and RowTypeInfo ...

2016-12-12 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2968 @fhueske Yes. I already started https://github.com/tonycox/flink/tree/FLINK-5188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 Hi @fhueske , what should I finish first, this PR or FLINK-5188 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #3003: [Flink-5188] Create analog of RowCsvInputFormat in...

2016-12-13 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3003 [Flink-5188] Create analog of RowCsvInputFormat in java and adjust all the imports of Row and RowTypeInfo Thanks for contributing to Apache Flink. Before you open your pull request, please take

[GitHub] flink pull request #3004: [Flink-5189] Delete Row and its related classes fr...

2016-12-14 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3004 [Flink-5189] Delete Row and its related classes from table api Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #3003: [FLINK-5188] Create analog of RowCsvInputFormat in java a...

2016-12-14 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3003 Hi @fhueske okay, as you wish --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #2926: [FLINK-5226] [table] Use correct DataSetCostFactory and i...

2016-12-14 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2926 @fhueske is there any sense to createcost optimization for Stream? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2016-12-15 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3012 [FLINK-2186] Add readCsvAsRow methods to CsvReader and scala ExecutionEnv Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink issue #2810: [FLINK-3848] Add ProjectableTableSource interface and tra...

2016-12-15 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2810 @fhueske I update this PR according to last changes in master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #3018: [FLINK-5336] Remove IOReadableWritable interface f...

2016-12-16 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3018 [FLINK-5336] Remove IOReadableWritable interface from Path Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #3020: [FLINK-5348] [core] Support custom field names for RowTyp...

2016-12-16 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3020 Hi @wuchong , in this case I think you should adapt `getFieldIndex` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #3020: [FLINK-5348] [core] Support custom field names for RowTyp...

2016-12-16 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3020 @wuchong sorry, my fault, didn't spot duplicate field names checkers. What about cases, Is flink-table case-sensitive? --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request #3027: [FLINK-5358] add RowTypeInfo exctraction in TypeEx...

2016-12-19 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3027 [FLINK-5358] add RowTypeInfo exctraction in TypeExtractor Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If

[GitHub] flink issue #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader and sc...

2016-12-20 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3012 Hi @StephanEwen could you look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-25 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3760 @ramkrish86 Hi, Thank you for the PR. Could you repush commit? ``` git commit --amend gut push origin FLINK-5752 -f ``` --- If your project is set up for it, you can reply to this

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-10-24 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/2686 [FLINK-4743] The sqrt/power function not accept the real data types. Add supporting of variety types on "power" function. Add casting for Float and BigDecimal. You can merge this pull re

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-10-28 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2686#discussion_r85514611 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/PowerExpressionTest.scala --- @@ -0,0 +1,149

[GitHub] flink pull request #2720: [FLINK-4623] Create Physical Execution Plan of a D...

2016-10-28 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/2720 [FLINK-4623] Create Physical Execution Plan of a DataStream You can merge this pull request into a Git repository by running: $ git pull https://github.com/tonycox/flink FLINK-4623

[GitHub] flink issue #2686: [FLINK-4743] The sqrt/power function not accept the real ...

2016-10-28 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2686 Hi @wuchong I agree that users can cast types manually. And that BuiltInMethods.POWER_DEC should be bound power(double, BigDecimal), but it's trouble of Calcite https://issues.apach

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-10-28 Thread tonycox
Github user tonycox closed the pull request at: https://github.com/apache/flink/pull/2686 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-10-28 Thread tonycox
GitHub user tonycox reopened a pull request: https://github.com/apache/flink/pull/2686 [FLINK-4743] The sqrt/power function not accept the real data types. Add supporting of variety types on "power" function. Add casting for Float and BigDecimal. You can merge this pu

[GitHub] flink issue #2686: [FLINK-4743] The sqrt/power function not accept the real ...

2016-10-31 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2686 Hi @wuchong , native java implementation of "power" function suits to most cases. So i deleted POWER_DEC from flink, because it has no proper types. Actually we don't make use

[GitHub] flink issue #2686: [FLINK-4743] The sqrt/power function not accept the real ...

2016-10-31 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2686 @wuchong if choosing second option, why not to solve this issue https://issues.apache.org/jira/browse/CALCITE-1468 instead of solve on flink side ? --- If your project is set up for it, you can

[GitHub] flink issue #2686: [FLINK-4743] The sqrt/power function not accept the real ...

2016-11-01 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2686 I agree with @wuchong that we need create a new issue in JIRA for supporting `BigDecimal` in functions (`log`,`ln`,`exp` etc), but I suppose that if problem in calcite with `DECIMAL` is done we will

[GitHub] flink issue #2686: [FLINK-4743] The sqrt/power function not accept the real ...

2016-11-01 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/2686 @wuchong, second option supports only in SQL. in table api we still cast manually. in first option where should I create power(double, BigDecimal) function, which package or util class

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-11-01 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2686#discussion_r86081029 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java --- @@ -0,0 +1,29

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-11-02 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2686#discussion_r86090398 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java --- @@ -0,0 +1,29

[GitHub] flink pull request #2686: [FLINK-4743] The sqrt/power function not accept th...

2016-11-02 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/2686#discussion_r86108721 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/api/table/functions/utils/MathFunctions.java --- @@ -0,0 +1,29

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r100337562 --- Diff: flink-tests/src/test/java/org/apache/flink/test/io/CsvReaderITCase.java --- @@ -122,6 +127,80 @@ public void testValueTypes() throws Exception

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

2017-02-09 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3012#discussion_r10033 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/ExecutionEnvironment.scala --- @@ -348,6 +349,47 @@ class ExecutionEnvironment(javaEnv

[GitHub] flink issue #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader and sc...

2017-02-09 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3012 @ex00 Thank you for review, If typeMap does not match with fields type in file it will fall with `ParseException`. But if `Double parser` try to parse an integer it will be okay. Do

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-09 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 what is your environment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-10 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 Try to add ``` -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath="/tmp" ``` as parameter of JVM --- If your project is set up for it, you can reply to

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-02-10 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 I think I should rename this issuea to "Simplify Row creation". What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] flink issue #3271: FLINK-5710

2017-02-10 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3271 Hi @huawei-flink, please name your PR with "[FLINK-XXX] Jira title text" pattern --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] flink pull request #3297: [FLINK-5431] Add configurable timePattern for clie...

2017-02-12 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3297 [FLINK-5431] Add configurable timePattern for client akka status Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 You can use jhat to read hprof dump file. If set `-XX:MaxPermSize=128m` ```xml org.apache.maven.plugins maven-surefire-plugin 2.19.1

[GitHub] flink issue #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader and sc...

2017-02-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3012 @ex00 default value of any empty field is null --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-13 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 java8 has different memory model, https://dzone.com/articles/java-8-permgen-metaspace --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #3166: [FLINK-3849] Add FilterableTableSource interface and Rule...

2017-02-14 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3166 Hi @fhueske, what do you think about this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #3040: [FLINK-3850] Add forward field annotations to DataSet

2017-02-15 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3040 Hi, Do we need field forwarding in `DataSetMinus`, `DataSetIntersect` and `DataSetSort`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #3166: [FLINK-3849] Add FilterableTableSource interface and Rule...

2017-02-21 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3166 @fhueske could you look at this approach of transfering `RexNode` to `Expression`, it's stil in wip state, but I need your adjustment --- If your project is set up for it, you can reply to

[GitHub] flink issue #3127: [FLINK-5481] Simplify Row creation

2017-03-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @StephanEwen @twalthr What do you think about this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3040: [FLINK-3850] Add forward field annotations to DataSet

2017-03-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3040 @fhueske @KurtYoung @twalthr What do you think about this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3297: [FLINK-5431] Add configurable timePattern for client akka...

2017-03-06 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3297 @zentol What do you think about this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3166: [FLINK-3849] Add FilterableTableSource interface and Rule...

2017-03-09 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3166 Hi @fhueske I cant continue on this PR, have not enough time for now. If you need implementation of it immediately I will unassign --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #3027: [FLINK-5358] add RowTypeInfo exctraction in TypeExtractor

2016-12-22 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3027 Hi @fhueske could you look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3027: [FLINK-5358] add RowTypeInfo exctraction in TypeEx...

2016-12-25 Thread tonycox
Github user tonycox commented on a diff in the pull request: https://github.com/apache/flink/pull/3027#discussion_r93848593 --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/TypeExtractorTest.java --- @@ -345,8 +346,25 @@ public CustomType cross(CustomType

[GitHub] flink pull request #3044: [FLINK-5388] Change private Graph.() to prot...

2016-12-26 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3044 [FLINK-5388] Change private Graph.() to protected Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request #3018: [FLINK-5336] Remove IOReadableWritable interface f...

2017-01-08 Thread tonycox
Github user tonycox closed the pull request at: https://github.com/apache/flink/pull/3018 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3127: [FLINK-5481] Add type extraction from collection

2017-01-16 Thread tonycox
GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3127 [FLINK-5481] Add type extraction from collection Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink issue #243: [FLINK-1293] Add support for out-of-place aggregations

2017-01-16 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/243 Is this PR still alive? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #243: [FLINK-1293] Add support for out-of-place aggregations

2017-01-16 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/243 Ok, cool. I can go through abandoned PRs and add them to https://issues.apache.org/jira/browse/FLINK-5384. Wouldn't you mind @fhueske ? --- If your project is set up for it, you can reply to

[GitHub] flink issue #3127: [FLINK-5481] Add type extraction from collection

2017-01-17 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3127 @zentol I rewrite as you pointed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 You need to recompile `TableSource` trait manually and implement `DefinedFieldNames` in `HBaseTableSource` --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 @ramkrish86 @fhueske what do you think about to throw `Tuple` (`T extends Tuple`) out of `org.apache.flink.addons.hbase.TableInputFormat` and implement this abstract class in your

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3149 I think it can be solved in different issue to provide a new api in `table.api` for selecting from HBase --- If your project is set up for it, you can reply to this email and have your reply appear

  1   2   >