GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2428
[FLINK-4517] scala code refactoring
the refacter type:
1. case class does't need `new`
2. case block does't need `{ ... }`
3. match-case instead of is
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2429
[FLINK-4519] scala maxLineLength increased to 120
Because Scala function's parameter is more long than Java code, We can set
the maxLineLength to 120.
The pull request reference
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2429
@rehevkor5
https://builds.apache.org/job/flink-github-ci/274/org.apache.flink$flink-connector-kafka-0.8_2.10/testReport/org.apache.flink.streaming.connectors.kafka/Kafka08ITCase
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2428
@StephanEwen Thank for your reply.
These code change such as case class usage are not forced to observe. But
there are scala best practice. We can update every kind of problem, at same
time
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2429
@StephanEwen Thanks for your reply.
That's OK. We can discuss first
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user shijinkui closed the pull request at:
https://github.com/apache/flink/pull/2429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2458
[FLINK-4560] enforcer java version as 1.7
[FLINK-4560](https://issues.apache.org/jira/browse/FLINK-4560) enforcer
java version as 1.7
1. maven-enforcer-plugin add java version enforce
2
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2459
[FLINK-4561] replace all the scala version as a `scala.binary.version`
property
Replace all the scala version(2.10) as a property `scala.binary.version`
defined in root pom properties. default
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2460
[FLINK-4562] table examples make an divided module in flink-examples
only move table examle code to a divided module in flink-examples.
Table API module should't contain example
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2459
@chiwanpark @StephanEwen thanks for the reply. dependency's version which
contain scala 2.10 replace as property?
---
If your project is set up for it, you can reply to this email and have
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2459
@StephanEwen I can accept "don't change it unless it is broken".
I explain why I made such a insipid and too much changes PR. I have such
habit, that is the code
Github user shijinkui closed the pull request at:
https://github.com/apache/flink/pull/2459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2459
@StephanEwen Thank for your reply, understand it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2458
hi, @StephanEwen
There are much difference between JDK 6 and JDK 7+. It's better for
compatible low version JDKï¼but there are better performance for Scala with
Lambda support, and
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2458
@greghogan exactly 3.0.3 will be OK. This limit is some module require, I
forget where it is, I am sorry..
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2458
enforce java 7 before compile. There is no conflict between source/target
and enforcer java version.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2459
hi, @StephanEwen I have an idea in mind, If there are to much tricky bugs,
and follow "don't change it unless it is broken", after two years can you image
the code like? Full of
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2541
[FLINK-4669] scala api createLocalEnvironment() function add default
Configuration parameter
1. add Configuration as createLocalEnvironment second default paramter
2. fix the mistake scaladoc
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3540
[FLINK-6056] apache-rat exclude flink directory in tools
The flink* directory in the tools is temporary cloned when build
distribution.
So when build the Flink project, we should exclude the
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
ping @wuchong @fhueske @twalthr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3540
> Why exactly is it a problem if the rat-plugin checks the tools directory?
There no necessary to check the tmp flink project in the tools, because it
will extra cost some time when build
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3540
> I am a bit confused... I think there is no tools/flink* directory that
would need an exclusion...
When execute `tools/create_release_files.sh`, it will clone flink project
from apa
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106411203
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/UnboundedRowtimeOverTest.scala
---
@@ -0,0 +1,138
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3386
@hongyuhong , IMO, all the function should have detail doc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106605509
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106600464
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106599719
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106601075
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -785,7 +785,7 @@ object
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106411491
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -136,13 +229,13
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106604502
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106605103
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106602970
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106599975
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106600097
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106411557
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -191,3 +287,31
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106602209
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateWindowFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106605456
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataStreamProcTimeAggregateGlobalWindowFunction.scala
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590692
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590304
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -91,6 +91,35 @@ object
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590402
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -91,6 +91,35 @@ object
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106592513
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106592195
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106590214
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -159,6 +167,46
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3386#discussion_r106589672
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala
---
@@ -0,0
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3550#discussion_r106617241
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -119,6 +154,64
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3600
@Rucongzhang Please review it whether it meet your requirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
> I agree with @wuchong , that we should follow the example of Gelly and
add the flink-table-examples JAR file to the opt folder.
@fhueske Thanks for your review.
IMO, direct
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3609#discussion_r108059875
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -0,0 +1,241
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3609#discussion_r108059835
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -0,0 +1,241
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3628
[FLINK-6201][example] move python example files from resources to the
examples
Python example in the resource dir is not suitable. Move them to the
examples/python dir.
- [X] General
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3628
> I would also suggest to run an example at least once to make sure you
don't break anything.
You are right. Only move the example files
---
If your project is set up for it,
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
@StephanEwen have any improvement needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2874
[FLINK-5167] StreamExecutionEnvironment set function return `this` inâ¦
StreamExecutionEnvironment's set function return `this` instead of void
for example :
public
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2875
[FLINK-5168] Scaladoc annotation link use [[]] instead of {@link}
`{@link StreamExecutionEnvironment#readFile(FileInputFormat, * String,
FileProcessingMode, long
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2874
> The PR changes several @Public and @PublicEvolving methods.
hi, @fhueske
Today when set some config, find some function cant't chained one by one.
So want to complete all the
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2876
[FLINK-5166] TextInputFormatTest.testNestedFileRead
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pu
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2876
> The test should be changed to use more specific folder names including a
random component. If the directory we are trying to create already exists we
should not delete everything there (since
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/2875#discussion_r89750780
--- Diff:
flink-libraries/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -294,7 +294,7 @@ object Graph
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2874
> Can you add them to this list here? That is where we collect all
API-.breaking changes that we want to add.
Done.
---
If your project is set up for it, you can reply to this email
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
> In general, I think it is good to not have too many method options, but
only those that add significant functionality. For the method that starts the
WebUI, that is the case, for the method w
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
@StephanEwen review it again please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/2876#discussion_r90246314
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/TextInputFormatTest.java
---
@@ -90,7 +91,9 @@ public void testSimpleRead
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
> Hi @shijinkui, yes that sounds good to me.
Thanks. When will we merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
@fhueske Thanks : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3769
[FLINK-6367] support custom header settings of allow origin
`jobmanager.web.access-control-allow-origin`: Enable custom access control
parameter for allow origin header, default is
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3769#discussion_r113226235
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -701,6 +701,9 @@
@Deprecated
public static
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3769
@zentol fix that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3777
[FLINK-6387] [webfrontend]Flink UI support access log
Record the use request to the access log. Append use access to the log file.
- [X] General
- The pull request references the
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3777
> I can see this flooding the logs like crazy, especially with things like
metrics and watermarks that update often. Some kind of filtering is probably
necessary here.
You are right.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3777
@StephanEwen @zentol The Flink webmonitor is netty inside. In generally,
Netty is used as a tcp transfer. For a web or API server, jetty or
Playframework maybe more suitable. Especially we must
GitHub user shijinkui reopened a pull request:
https://github.com/apache/flink/pull/3769
[FLINK-6367] support custom header settings of allow origin
`jobmanager.web.access-control-allow-origin`: Enable custom access control
parameter for allow origin header, default is
Github user shijinkui closed the pull request at:
https://github.com/apache/flink/pull/3769
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3769
hi, @zentol @StephanEwen It didn't merge in. @zentol Please check again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2458
@StephanEwen OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/2460#discussion_r80955413
--- Diff:
flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/StreamSQLExample.scala
---
@@ -15,7 +15,7 @@
* See the
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/2460#discussion_r80955533
--- Diff: flink-examples/flink-examples-table/pom.xml ---
@@ -0,0 +1,24 @@
+
+http://maven.apache.org/POM/4.0.0";
+xmlns:xsi=
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
@wuchong you are right. Different package of scala/java can avoid same
class conflict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/2541#discussion_r80963928
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
---
@@ -124,7 +125,7 @@ class
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/2541#discussion_r80966754
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
---
@@ -124,7 +125,7 @@ class
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/2541#discussion_r81031381
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
---
@@ -124,7 +125,7 @@ class
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
@StephanEwen Iâve a new function name `createCustomLocalEnv`. Sorry for
late ack.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shijinkui closed the pull request at:
https://github.com/apache/flink/pull/2428
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
hi, @StephanEwen
follow your exact suggest, have add the functions at four place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
> The repackaging is good.
> Unfortunately this breaks the Table API tests, because they use one of
the examples.
>
> The Table API IT cases probably need to use their
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3290#discussion_r100516387
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerServices.java
---
@@ -116,12 +116,17 @@ public static
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3319
[FLINK-5806] TaskExecutionState toString format have wrong key
The key of jobID should be executionId in the string format.
- [X] General
- The pull request references the related
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3211
@StephanEwen Thank for your quickly reviewing.
>`**/*Test.*`
This can clearly show what unit test's file name like, just like
`integration-tests` does. If omitting the `include`,
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
> Here is a related issue: https://issues.apache.org/jira/browse/FLINK-5817
I sounds good. I want to change the default system property
`java.io.tmpdir` to be in the `target` direct
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3211
@StephanEwen have finished that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
@StephanEwen The FileCacheDeleteValidationTest had been fixed in
FLINK-5817. This PR have rollback it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
hi, @StephanEwen I have re-submit this pull request base on current master
branch which had merged FLINK-5817.
---
If your project is set up for it, you can reply to this email and have your
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2460
@wuchong @StephanEwen can you review this pull request.
Generating independent example runnable jar will increase the size of flink
distribution.
This table example jar is 13Mb or so
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
Get it. Run single test, having no temp created, it should use the default
java.io.tmpdir property.
Let me check that.
In the base test class have a double check about the target
---
If
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3190
> Can we just use the ${project.build.directory} as java.io.tmpdir ?
@wenlong88 Sorry for late reply.
It's good question. If use `${project.build.directory}` without sub
direct
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3408#discussion_r104277608
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -317,6 +319,10 @@ public AbstractYarnClusterDescriptor
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3459#discussion_r104282393
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java
---
@@ -0,0 +1,162
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3459
@stefanobortoli One PR should has only one commit as soon as possible. If
having so many commit, it's hard to review..
---
If your project is set up for it, you can reply to this email and
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3468
Good changes. `ConfigConstants.DEFAULT_CHARSET` change to
`ConfigConstants.UTF_8 ` may be more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear
1 - 100 of 260 matches
Mail list logo
