[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-13 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 Ran those two tests individually they seem to pass. But the Rocks_DB version failed due to some initialization error. Thank you @StephanEwen for your comments. --- If your project is set up for

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-15 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74874857 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseSink.java --- @@ -0,0 +1,104

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-15 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74877942 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-15 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74878005 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-16 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 @uce Updated with changes so that all the configs are renamed from 'recovery' to 'high-availability'. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request #2342: FLINK-4253 - Rename "recovery.mode" config key to ...

2016-08-16 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2342#discussion_r75065676 --- Diff: docs/setup/config.md --- @@ -285,7 +285,7 @@ of the JobManager, because the same ActorSystem is used. Its not possible to use ## High

[GitHub] flink pull request #2342: FLINK-4253 - Rename "recovery.mode" config key to ...

2016-08-16 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2342#discussion_r75065679 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java --- @@ -77,7 +77,7 @@ /** * Shutdown hook

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-17 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 @uce Updated the PR with suitable doc updates and also renamed the enum > RecoveryMode to > HighAvailabilityMode --- If your project is set up for it, y

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-17 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 @uce The test case failures seems to be unrelated. Want to have a look at the updated PR? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-17 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 @uce I saw that there were conflicts after yesterday's updates to the master. Hence I have rebased my PR and force pushed the changes. Thanks. --- If your project is set up for it, yo

[GitHub] flink issue #2366: [FLINK-4322] Unify CheckpointCoordinator and SavepointCoo...

2016-08-17 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2366 The unification looks great and now things are simple in terms of restoration. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #2366: [FLINK-4322] Unify CheckpointCoordinator and SavepointCoo...

2016-08-18 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2366 Reading the code once again, just few doubts/questions ->If a save point is triggered and that is happening with in the duration of the 'MINIMUM_TIME_BETWEEN_CHECKPOINTS' we still

[GitHub] flink issue #2366: [FLINK-4322] Unify CheckpointCoordinator and SavepointCoo...

2016-08-18 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2366 Ya. So may be this code `if (lastTriggeredCheckpoint + minPauseBetweenCheckpoints > timestamp) {` The if block should also go inside the previous 'if' condition that checks f

[GitHub] flink issue #2366: [FLINK-4322] Unify CheckpointCoordinator and SavepointCoo...

2016-08-18 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2366 Yes. I can do it. Thanks. Is it better to raise a JIRA for that for accounting or just raise a PR with the same issue ID? --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request #2385: FLINK-4322 (addendum)Issue with savepoint consider...

2016-08-18 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2385 FLINK-4322 (addendum)Issue with savepoint considering the time interval like that of check… Thanks for contributing to Apache Flink. Before you open your pull request, please take the

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-18 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 @uce Got a green build. Any feedback/reviews here. I know you guys are busy, just a gentle reminder. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-19 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 @uce Got some time to check this? A gentle reminder !!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2390: [FLINK-4431] [core] Introduce a "VisibleForTesting" annot...

2016-08-19 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2390 +1. Very useful one. Also I saw some of the interfaces though they are supposed to be Public it is not marked with those types. Is it better to fix all of them ? Or add a test case that ensures

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-19 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 @uce Thanks. No problem. I can wait. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2390: [FLINK-4431] [core] Introduce a "VisibleForTesting" annot...

2016-08-22 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2390 @StephanEwen Sorry for continuing in this thread. I did not meant to mean the StabilityAnnotations. I was only talking about other interfaces without annotations - Public/ Internal

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-22 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 @uce Thank you very much for checking it out. I can see in the branch that you have created you have updated some doc comment that I had added - from 'config' to 'key&#x

[GitHub] flink issue #2390: [FLINK-4431] [core] Introduce a "VisibleForTesting" annot...

2016-08-23 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2390 Thanks @StephanEwen . I can work on such Util. Will get back to it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #2407: FLINK-4417 Checkpoints should be subsumed by Check...

2016-08-23 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2407 FLINK-4417 Checkpoints should be subsumed by CheckpointID not, by timestamp (Ram) Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check

[GitHub] flink issue #2409: FLINK-4437 Lock evasion around lastTriggeredCheckpoint ma...

2016-08-23 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2409 If the lock scope is going to be moved for the entire triggerCheckpoint() method then `// since we released the lock in the meantime, we need to re-check

[GitHub] flink pull request #2412: FLINK-4462 Add RUN_TIME retention policy for all t...

2016-08-24 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2412 FLINK-4462 Add RUN_TIME retention policy for all the flink annotations Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink issue #2412: FLINK-4462 Add RUN_TIME retention policy for all the flin...

2016-08-24 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2412 > Would be great if that plugin can check the presence of annotations, that seems like the right place. I see. I have not worked with 'japicmp'. My intention was to u

[GitHub] flink issue #2412: FLINK-4462 Add RUN_TIME retention policy for all the flin...

2016-08-24 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2412 Is 'jApiCmp' added in class path? I am not able to see the API/Interfaces exposed. Trying to make use of it. --- If your project is set up for it, you can reply to this email and

[GitHub] flink issue #2412: FLINK-4462 Add RUN_TIME retention policy for all the flin...

2016-08-25 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2412 @StephanEwen I meant the library only. I did not mean it is added in code. Am not sure what are the APIs in that library to make use. --- If your project is set up for it, you can reply to

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-31 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2332 How should I view your latest commit ? Am not able to see the changes that you have mentioned above. Thanks @delding --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-01 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2332 @delding Am not able to see the recent changes at all. Under 'commit' tab it shows 2 commits. If I open the merge commit I am not able to see the changes that you are saying her

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-05 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r77547550 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseClient.java --- @@ -0,0 +1,69

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-05 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r77547840 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java --- @@ -0,0 +1,46

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-05 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r77547915 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java --- @@ -0,0 +1,46

[GitHub] flink issue #2412: FLINK-4462 Add RUN_TIME retention policy for all the flin...

2016-09-08 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2412 @StephanEwen As said above am not sure how to use the japicmp library. I can see that from the IDE am not able to use any of the APIs provided from the library. May be am missing something

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-09 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r78136477 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java --- @@ -0,0 +1,46

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-12 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r78422242 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java --- @@ -0,0 +1,46

[GitHub] flink pull request #2495: FLINK-3322 - Make sorters to reuse the memory page...

2016-09-12 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2495 FLINK-3322 - Make sorters to reuse the memory pages allocated for iterative tasks Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check

[GitHub] flink pull request #2496: FLINK-4615 Reusing the memory allocated for the dr...

2016-09-13 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2496 FLINK-4615 Reusing the memory allocated for the drivers and iterators Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink issue #2495: FLINK-3322 - Make sorters to reuse the memory pages alloc...

2016-09-13 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2495 Will need to make an update in this PR. Will do that and push that change shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #2496: FLINK-4615 Reusing the memory allocated for the drivers a...

2016-09-14 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2496 The pageRank test failure is a genuine one. I think the problem is because resetting of some of the states are not done correctly. I think we have to be more careful here and ensure we reset

[GitHub] flink issue #2496: FLINK-4615 Reusing the memory allocated for the drivers a...

2016-09-14 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2496 Updated PR. Handles reset()in a much better way. PageRankITCase exposed some cases. Also does the clean up of the driver now. Still wondering there should be a reason why the driver was

[GitHub] flink issue #2496: FLINK-4615 Reusing the memory allocated for the drivers a...

2016-09-15 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2496 Builds seems to pass with this latest commit. Any feedback here @ggevay and @StephanEwen . --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #2495: FLINK-3322 - Make sorters to reuse the memory pages alloc...

2016-09-15 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2495 The build shows failure but not sure what is the failure. It does not show any specific test case. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #2496: FLINK-4615 Reusing the memory allocated for the dr...

2016-09-15 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2496#discussion_r79006658 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationIntermediateTask.java --- @@ -82,43 +82,46 @@ protected void

[GitHub] flink pull request #2496: FLINK-4615 Reusing the memory allocated for the dr...

2016-09-15 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2496#discussion_r79007600 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java --- @@ -87,4 +87,6 @@ * @throws Exception Exceptions may be

[GitHub] flink issue #2495: FLINK-3322 - Make sorters to reuse the memory pages alloc...

2016-09-15 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2495 @ggevay and @StephanEwen - any feedback/reviews here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #2496: FLINK-4615 Reusing the memory allocated for the dr...

2016-09-15 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2496#discussion_r79017956 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java --- @@ -87,4 +87,6 @@ * @throws Exception Exceptions may be

[GitHub] flink pull request #2496: FLINK-4615 Reusing the memory allocated for the dr...

2016-09-15 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2496#discussion_r79021152 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java --- @@ -87,4 +87,6 @@ * @throws Exception Exceptions may be

[GitHub] flink issue #2495: FLINK-3322 - Make sorters to reuse the memory pages alloc...

2016-09-18 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2495 > SingleSourceShortestPathsITCase Sure. Actually I ran mvn clean verify to ensure there are no code style issues in runtime package and ran tests in that package. I was not sure w

[GitHub] flink pull request #2496: FLINK-4615 Reusing the memory allocated for the dr...

2016-09-19 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2496#discussion_r79347430 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java --- @@ -87,4 +87,6 @@ * @throws Exception Exceptions may be

[GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...

2016-09-19 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2510 FLINK-3322 Allow drivers and iterators to reuse the memory segments Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...

2016-09-19 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2510#discussion_r79381731 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/JoinTaskIterator.java --- @@ -68,4 +72,9 @@ * method signals an

[GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...

2016-09-19 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2510#discussion_r79382231 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/resettable/AbstractBlockResettableIterator.java --- @@ -183,4 +183,24

[GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...

2016-09-19 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2510#discussion_r79382611 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/AbstractIterativeTask.java --- @@ -125,6 +125,16 @@ protected void

[GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...

2016-09-19 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2510#discussion_r79384469 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/JoinDriver.java --- @@ -128,17 +130,22 @@ public void prepare() throws Exception

[GitHub] flink issue #2495: FLINK-3322 - Make sorters to reuse the memory pages alloc...

2016-09-19 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2495 @StephanEwen Thank you. I agree this is a super important piece of FLINK where the memory is involved and that is one reason why I wanted to know its managment and usage and wanted to work

[GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...

2016-09-19 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2510#discussion_r79539655 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/JoinDriver.java --- @@ -128,17 +130,22 @@ public void prepare() throws Exception

[GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...

2016-09-20 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2510#discussion_r79755676 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/JoinDriver.java --- @@ -128,17 +130,22 @@ public void prepare() throws Exception

[GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...

2016-09-20 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2510#discussion_r79761429 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/JoinDriver.java --- @@ -128,17 +130,22 @@ public void prepare() throws Exception

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-21 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2332 ` #2330 updates the version of the batch TableInputFormat to HBase 1.1.2. I think we should use the same version here.` Valid point. But is it possible to upgrade to even newer version like

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-09-21 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2332 I agree with @delding here. >* Method that does a batch call on Deletes, Gets, Puts, Increments and Appends. * The ordering of execution of the actions is not defined. Mean

[GitHub] flink issue #2495: FLINK-3322 - Make sorters to reuse the memory pages alloc...

2016-09-22 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2495 @StephanEwen Just trying to explain what my intention was. This is particularly to address the sorters. Solution We could create memory allocators inside the batch task corresponding

[GitHub] flink issue #2510: FLINK-3322 Allow drivers and iterators to reuse the memor...

2016-11-25 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2510 @StephanEwen Do you have some time to check this? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #2195: FLINK-3397 Failed streaming jobs should fall back ...

2016-07-04 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2195 FLINK-3397 Failed streaming jobs should fall back to the most recent Initial patch to see if this is what is intended out of the JIRA. Thought a PR could help me in getting a better feedback. I

[GitHub] flink issue #2195: FLINK-3397 Failed streaming jobs should fall back to the ...

2016-07-04 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2195 @uce - any feedback/suggestions are welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2195: FLINK-3397 Failed streaming jobs should fall back to the ...

2016-07-05 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2195 Sure. I can close this. I always had a doubt on the scope of this JIRA. As per the suggestion I have already started working on a doc. I will try to list out how things are working now and may be

[GitHub] flink pull request #2195: FLINK-3397 Failed streaming jobs should fall back ...

2016-07-05 Thread ramkrish86
Github user ramkrish86 closed the pull request at: https://github.com/apache/flink/pull/2195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2301: FLINK-3674 Add an interface for EventTime aware Us...

2016-07-27 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2301 FLINK-3674 Add an interface for EventTime aware User Function (Ram) Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink issue #2301: FLINK-3674 Add an interface for EventTime aware User Func...

2016-07-27 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2301 Created two interfaces EventTimeFunction and a WindowTimer (interface). The WindowTimer interface allows users to implement their own watermark timers and the way they could be fired. The

[GitHub] flink pull request #2301: FLINK-3674 Add an interface for EventTime aware Us...

2016-07-27 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2301#discussion_r72417108 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractUdfStreamOperator.java --- @@ -55,13 +56,18

[GitHub] flink pull request #2301: FLINK-3674 Add an interface for EventTime aware Us...

2016-07-27 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2301#discussion_r72417872 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractUdfStreamOperator.java --- @@ -55,13 +56,18

[GitHub] flink pull request #2301: FLINK-3674 Add an interface for EventTime aware Us...

2016-07-29 Thread ramkrish86
Github user ramkrish86 closed the pull request at: https://github.com/apache/flink/pull/2301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2301: FLINK-3674 Add an interface for EventTime aware User Func...

2016-07-29 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2301 Closing this as discussed. I will wait for more feedback on what is expected here and then proceed. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #2336: FLINK-4094 Off heap memory deallocation might not ...

2016-08-04 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2336 FLINK-4094 Off heap memory deallocation might not properly work (Ram) Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-06 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r73788475 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java --- @@ -0,0 +1,97

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-06 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r73788502 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java --- @@ -0,0 +1,97

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-06 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r73788575 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java --- @@ -0,0 +1,97

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-07 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r73820969 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseSink.java --- @@ -0,0 +1,100

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-07 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r73821038 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseSink.java --- @@ -0,0 +1,100

[GitHub] flink pull request #2342: FLINK-4253 - Rename "recovery.mode" config key to ...

2016-08-09 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/2342 FLINK-4253 - Rename "recovery.mode" config key to "high-availability" (Ram) Thanks for contributing to Apache Flink. Before you open your pull request, please take the follo

[GitHub] flink pull request #2342: FLINK-4253 - Rename "recovery.mode" config key to ...

2016-08-09 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2342#discussion_r74105158 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingUtils.scala --- @@ -502,7 +503,8 @@ object TestingUtils

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-09 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 Looks like only this build failed `https://travis-ci.org/apache/flink/jobs/150992610` and that too due to a cassandra-connector test case. Should be unrelated to this PR. --- If your

[GitHub] flink issue #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-11 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2332 Thanks for the update @delding . I can check this PR more closely tomorrow my time. Had a glance at it. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74549333 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74549521 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74549919 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74550242 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74550400 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74550914 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 > Can you add such a test? Sure I can. The existing test cases helped to ensure that if there are no old configs we are able to fetch from the new config. I can add a test case to ens

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74551046 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseClient.java --- @@ -0,0 +1,69

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 Just a query, If there are both old and new configs available - we should give priority to the new one right? Even if the value for the old and new configs are different? --- If your

[GitHub] flink pull request #2332: [FLINK-2055] Implement Streaming HBaseSink

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/2332#discussion_r74549599 --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java --- @@ -0,0

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-12 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 Updated PR request. Handles all other configs and renames them from 'recovery.* to 'high-availability.*'. Also added test case and suitably modified code to ensure that if ther

[GitHub] flink issue #2342: FLINK-4253 - Rename "recovery.mode" config key to "high-a...

2016-08-13 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/2342 github build shows two failure > org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITCase.org.apache.flink.test.checkpointing.EventTimeWindowCheckpointingITC

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-24 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3760 @fhueske , @tonycox Can you have a look at this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #3760: FLINK-5752 Support push down projections for HBase...

2017-04-24 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/3760 FLINK-5752 Support push down projections for HBaseTableSource (Ram) Ran mvn clean verify -DskipTests In this patch `Arrays.sort(nestedFields[i]);` Am doing this before doing

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-24 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3760 The failures seems not directly related. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-25 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3760 @tonycox Thanks for the comment? Just curious. Any reason for the repush - is it for checking the test failures again? --- If your project is set up for it, you can reply to this email and

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-26 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3760 I checked the recent failure. `Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 20.417 sec <<< FAILURE! - in org.apache.flink.runtime.jobmanager.JobManagerRegistr

  1   2   3   4   >