[GitHub] flink pull request #2002: Support for bz2 compression in flink-core

2016-08-24 Thread mtanski
Github user mtanski commented on a diff in the pull request: https://github.com/apache/flink/pull/2002#discussion_r76121574 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/compression/InflaterInputStreamFactory.java --- @@ -23,13 +23,12 @@ import

[GitHub] flink issue #2002: Support for bz2 compression in flink-core

2016-07-12 Thread mtanski
Github user mtanski commented on the issue: https://github.com/apache/flink/pull/2002 This has been sitting around for a month. Any chance to merge or clear todo in order to get this in shape. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2002: Support for bz2 compression in flink-core

2016-07-31 Thread mtanski
Github user mtanski commented on the issue: https://github.com/apache/flink/pull/2002 Added support for XZ as well and update the documentation. Newer versions of commons compression (1.12) add support for snappy and lzma. But the version included as a (transitive) dependency

[GitHub] flink issue #2002: Support for bz2 compression in flink-core

2016-08-09 Thread mtanski
Github user mtanski commented on the issue: https://github.com/apache/flink/pull/2002 Now that 1.1 one is out, is it possible to get this in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2002: Support for bz2 compression in flink-core

2016-08-09 Thread mtanski
Github user mtanski commented on the issue: https://github.com/apache/flink/pull/2002 @StephanEwen would you like me to use the same version as the one being current include (transitive) or bump it to a recent version that include Snappy? --- If your project is set up for it, you

[GitHub] flink issue #2002: Support for bz2 compression in flink-core

2016-10-03 Thread mtanski
Github user mtanski commented on the issue: https://github.com/apache/flink/pull/2002 I tried changing the name from to InflaterInputStreamFactory -> DecompressingStreamFactory But now it will not build because of: [ERROR] Failed to execute goal com.github.sio

[GitHub] flink pull request #2002: Support for bz2 compression in flink-core

2016-10-03 Thread mtanski
Github user mtanski commented on a diff in the pull request: https://github.com/apache/flink/pull/2002#discussion_r81589240 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/compression/InflaterInputStreamFactory.java --- @@ -23,13 +23,12 @@ import

[GitHub] flink pull request: Support for bz2 compression in flink-core

2016-05-17 Thread mtanski
GitHub user mtanski opened a pull request: https://github.com/apache/flink/pull/2002 Support for bz2 compression in flink-core Add support for bz2 compression to flink. Right now this requires using Hadoop InputFormats. Doesn't require any extra dependencies as flink

[GitHub] flink pull request: Support for bz2 compression in flink-core

2016-05-18 Thread mtanski
Github user mtanski commented on a diff in the pull request: https://github.com/apache/flink/pull/2002#discussion_r63755827 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/compression/Bzip2InputStreamFactory.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] flink pull request: Support for bz2 compression in flink-core

2016-05-18 Thread mtanski
Github user mtanski commented on the pull request: https://github.com/apache/flink/pull/2002#issuecomment-220115838 My big question is: should I implement the other compressors from apache commons-io (snappy, xz). And if so should flink apache commons-io for gzip deflate as well