Github user joshfg commented on the issue:
https://github.com/apache/flink/pull/2269
Hi Aljoscha, just wanted to remind you about this - any idea when the
changes will be merged in? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user joshfg closed the pull request at:
https://github.com/apache/flink/pull/2269
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user joshfg commented on the issue:
https://github.com/apache/flink/pull/2269
That's great, thanks Aljoscha!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user joshfg commented on the issue:
https://github.com/apache/flink/pull/2157
Cool, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user joshfg opened a pull request:
https://github.com/apache/flink/pull/2269
[FLINK-4190] Generalise RollingSink to work with arbitrary buckets
I've created a new bucketing package with a BucketingSink, which improves
on the existing RollingSink by enabling arbi
Github user joshfg commented on the issue:
https://github.com/apache/flink/pull/2269
Thanks! Oh nice, this looks like a better solution for checking for bucket
inactivity...
For the tests, is there any reason not to fold all of those tests into the
new `BucketingSinkTest
Github user joshfg commented on the issue:
https://github.com/apache/flink/pull/2269
Ah I see, that makes sense.
I've began refactoring the tests here:
https://github.com/joshfg/flink/blob/flink-4190/flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/a
Github user joshfg commented on the issue:
https://github.com/apache/flink/pull/2269
That works, thanks! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user joshfg commented on the issue:
https://github.com/apache/flink/pull/2269
Ok I've migrated `BucketingSinkITCase` and
`BucketingSinkMultipleActiveBucketsCase` over to `BucketingSinkTest` using the
test harness with `TimeServiceProvider`. I've left the two fault to
