[GitHub] flink issue #3110: [FLINK-2184] Cannot get last element with maxBy/minBy.

2017-04-05 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/3110 @fhueske @twalthr . Can you help with reviewing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #2179: [FLINK-4128] compile error about git-commit-id-plugin

2016-06-29 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2179 This problem appears occasionally when i build source code, but not always. The modified line corrects the right directory of `.git`. In the case where maven using the plugin, this fix is

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-07-01 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2078 Hi, @fhueske , sorry for the late update for this PR. Codes have been modified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-07-02 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2078 @fhueske the failure of CI build is relevant with `testJoinWithDisjunctivePred` in `JoinITCase`. The case is `val joinT = ds1.join(ds2).filter('a === 'd && ('b === '

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-07-03 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2078 Hi @wuchong , thanks a lot for your advice. With default fieldnames may cause same content of `input1` and `input2` in `CodeGenerator`. Comparing the `inputTerm` is a easy and effective way to

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-07-10 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2078 Conflict resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2282: Support order by with offset and fetch.

2016-07-21 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/2282 Support order by with offset and fetch. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes

[GitHub] flink issue #2282: [FLINK-3940] [table] Add support for ORDER BY OFFSET FETC...

2016-07-23 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2282 @wuchong thanks for your advice and i have addressed your comments in the new commit. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #2290: [FLINK-4242] [table] Improve validation exception ...

2016-07-23 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/2290 [FLINK-4242] [table] Improve validation exception messages Improve validation exception messages in table api. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink issue #2291: [FLINK-4226] Typo: Define Keys using Field Expressions ex...

2016-07-24 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2291 Hi @nssalian , welcome to join the community. :) This PR may be duplicate to [#2261](https://github.com/apache/flink/pull/2261) for the same issue. --- If your project is set up for it

[GitHub] flink issue #2290: [FLINK-4242] [table] Improve validation exception message...

2016-07-27 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2290 Will update later to include the issue of [flink-4241](https://issues.apache.org/jira/browse/FLINK-4241) . --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2303: [FLINK-4248] [core] [table] CsvTableSource does not suppo...

2016-07-27 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2303 Hi @twalthr , the logical of parserFields method in Date/Time/TimeStamp (also in the lastest PR for BigDecimal/BigInteger) is same, is it better to refactor by creating super class for them to

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73272805 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala --- @@ -71,11 +78,57 @@ class

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73287941 --- Diff: docs/apis/table.md --- @@ -606,6 +606,28 @@ Table result = in.orderBy("a.asc"); + +

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-03 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73452976 --- Diff: docs/apis/table.md --- @@ -606,6 +606,28 @@ Table result = in.orderBy("a.asc"); + +

[GitHub] flink issue #2282: [FLINK-3940] [table] Add support for ORDER BY OFFSET FETC...

2016-08-04 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/2282 @twalthr PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #3788: [FLINK-6393] [gelly] Add Evenly Graph Generator to...

2017-04-27 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/3788#discussion_r113842976 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/EvenlyGraph.java --- @@ -0,0 +1,145 @@ +/* + * Licensed to

[GitHub] flink issue #3788: [FLINK-6393] [gelly] Add Evenly Graph Generator to Flink ...

2017-04-27 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/3788 @fanzhidongyzby , thanks for the pr. Just a minor comment, mostly looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #1975: [FLINK-2184] Cannot get last element with maxBy/mi...

2017-01-12 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/1975 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3110: [FLINK-2184] Cannot get last element with maxBy/mi...

2017-01-12 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/3110 [FLINK-2184] Cannot get last element with maxBy/minBy. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If

[GitHub] flink pull request #3121: [FLINK-5434] Remove unsupported project() transfor...

2017-01-13 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/3121 [FLINK-5434] Remove unsupported project() transformation from Scala DataStream docs. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check

[GitHub] flink pull request #3121: [FLINK-5434] Remove unsupported project() transfor...

2017-01-18 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/3121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #3898: [FLINK-6492] Fix unclosed DataOutputViewStream usage

2017-05-18 Thread gallenvara
Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/3898 Hi, @huafengw . Welcome to Flink family. Thanks for your PR and the changes look good to me. :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #4649: [FLINK-6116] Watermarks don't work when unioning w...

2017-09-06 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/4649 [FLINK-6116] Watermarks don't work when unioning with same DataStream. ## What is the purpose of the change In self-union case, the stream edges between the source and target wi

[GitHub] flink pull request: [FLINK-2077] [core] Rework Path class and add ...

2015-08-20 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1035#discussion_r37610286 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/Path.java --- @@ -430,40 +296,127 @@ public int depth

[GitHub] flink pull request: [FLINK-2077] [core] Rework Path class and add ...

2015-08-21 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1035#issuecomment-133315613 @tillrohrmann I'm new to Flink. Thanks for your words and if i have any mistake please point it out. My idea on this issue is : the ```Path``` clas

[GitHub] flink pull request: [FLINK-2077] [core] Rework Path class and add ...

2015-08-30 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/1035 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2533] [core] Gap based random sample op...

2015-09-08 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1110 [FLINK-2533] [core] Gap based random sample optimization. For random sampler with fraction, like BernoulliSampler and PoissonSampler, Gap based random sampler could exploit O(np) sample

[GitHub] flink pull request: [FLINK-3192] Add explain support to print ast ...

2015-12-25 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1477 [FLINK-3192] Add explain support to print ast and sql physical execution. Table API doesn't support sql-explanation now. Add the explain support to print ast (abstract syntax tree) an

[GitHub] flink pull request: [FLINK-3192] Add explain support to print ast ...

2016-01-05 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1477#issuecomment-169261591 @fhueske ,thanks a lot for the review work! I'll modify the code and update the PR according to your advice. --- If your project is set up for it, you can rep

[GitHub] flink pull request: [FLINK-3192] Add explain support to print ast ...

2016-01-06 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1477#issuecomment-169532718 @fhueske , codes has been finished. I have drop previous method of plan-generator and rewrite a new parser named `PlanJsonParser` to parse the existing JSON plan

[GitHub] flink pull request: [FLINK-3192] Add explain support to print ast ...

2016-01-07 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1477#issuecomment-169882956 @fhueske , @rmetzger , thanks for review work. I have modified related code as you adviced and submitted a new commit. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-3192] Add explain support to print ast ...

2016-01-08 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1477#issuecomment-169967055 @ChengXiangLi @fhueske @rmetzger , thanks a lot for your suggestions. The codes have been modified. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-3192] Add explain support to print ast ...

2016-01-11 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1477#issuecomment-170467184 @fhueske , i"m favor of showing the whole plan. First, `Table` API converts `DataSet` to a `Table` and provides several operations on the `DataSource`. It

[GitHub] flink pull request: Enable range partition with custom data distri...

2016-01-21 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1540 Enable range partition with custom data distribution. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gallenvara/flink flink-2997

[GitHub] flink pull request: Enable range partition with custom data distri...

2016-01-24 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/1540 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-08 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1776 [FLINK-2997] Support range partition with user customized data distribution. Sometime user have better knowledge of the source data, and they can build customized `data distribution` to do range

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-09 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1776#issuecomment-194310643 @fhueske @ChengXiangLi Can you please help me with review work? The error of CI build failure is not relevant. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-10 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r55650289 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java --- @@ -0,0 +1,137 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-10 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r55794734 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java --- @@ -0,0 +1,142 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-11 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r55800752 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java --- @@ -82,6 +88,7 @@ public PartitionOperator(DataSet

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-11 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r55805402 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java --- @@ -0,0 +1,142 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-14 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1776#issuecomment-196245218 Hi, @fhueske . I have modified the relevant code. I still use the generic class `CustomDistribution` for the tests because it is not flexible with build-in data

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-19 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1776#issuecomment-198676014 @fhueske , thanks a lot for review work, codes have been modified based on your advice. I change the second test with modifying the range boundary from `(bucketNum+1

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-19 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r56532523 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java --- @@ -0,0 +1,161 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-19 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1776#issuecomment-197744696 Hi, @fhueske . Thanks a lot for your patient review. I have modified the code based on your advice. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-19 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r56464954 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java --- @@ -0,0 +1,161 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-20 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r56668261 --- Diff: flink-tests/src/test/java/org/apache/flink/test/distribution/TestDataDist.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-21 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r56916757 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java --- @@ -45,35 +46,48 @@ private final

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-22 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r56980076 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java --- @@ -0,0 +1,184 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-23 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1776#issuecomment-200255451 @fhueske , PR has been updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-23 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1776#discussion_r57143853 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java --- @@ -0,0 +1,230 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2997] Support range partition with user...

2016-03-23 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1776#issuecomment-200321158 @fhueske codes has been modified :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-03-29 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1838 [FLINK-2998] Support range partition comparison for multi input nodes. The PR implements range partition comparison in operation such as join and cogroup for multi inputs, now optimizer can

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-03-29 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-203216796 @fhueske @ChengXiangLi Can you please help with review? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-03-30 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-203350617 @fhueske Yes, `TwoInputNode` rebuild the channels and `child` nodes don't have the information of `data distribution`. I have added the information into them a

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-06 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1857 [FLINK-3444] env.fromElements relies on the first input element for determining the DataSet/DataStream type Add fromElements method with based class type to avoid the exception. You can merge

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-06 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1857#issuecomment-206250467 @zentol Thanks a lot for review work. I will modify the codes base on your advice! --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-06 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1857#issuecomment-206355988 @zentol , PR updated. The scala environment determine the type with `implicitly[TypeInformation[T]]` which is always the class `Object`. In the case this issue

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-06 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1857#issuecomment-206656056 @zentol codes modified and rebase the new commit with previous one. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-208712697 @fhueske Thanks a lot for your advice. PR updated. Please forgive my limited understand about the logic of `GlobalProperties`. I added tests to

[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-11 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1857#issuecomment-208716571 The error of CI build failure is not relevant with this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-14 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59819652 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java --- @@ -84,8 +84,8 @@ public PartitionOperator(DataSet

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-14 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-210255818 @fhueske PR updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3783] [core] Support weighted random sa...

2016-04-18 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1909 [FLINK-3783] [core] Support weighted random sampling with reservoir. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-20 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-212300584 @fhueske PR updated. I am a little confused when i wrote the tests. The original dataset handled by a `map` operator to ensure that the type of partition key is

[GitHub] flink pull request: [FLINK-3783] [core] Support weighted random sa...

2016-04-20 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1909#issuecomment-212397350 @gaoyike A-ES algorithm is a weighted random sampling method with reservoir. It can create a sampler with defined size. And the probability of element distribution

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-20 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-212409952 @fhueske Thanks a lot for the explanation and the relevant codes have been modified. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-2848] [test] Apply JMH on MutableHashTa...

2015-10-16 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1261 [FLINK-2848] [test] Apply JMH on MutableHashTablePerformanceBenchmark… JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks.Use JMH to replace the old

[GitHub] flink pull request: [FLINK-2848] [test] Apply JMH on MutableHashTa...

2015-10-16 Thread gallenvara
GitHub user gallenvara reopened a pull request: https://github.com/apache/flink/pull/1261 [FLINK-2848] [test] Apply JMH on MutableHashTablePerformanceBenchmark… JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks.Use JMH to replace the old

[GitHub] flink pull request: [FLINK-2848] [test] Apply JMH on MutableHashTa...

2015-10-16 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/1261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2853] [tests] Apply JMH on MutableHashT...

2015-10-18 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/1261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2853] [tests] Apply JMH on MutableHashT...

2015-10-18 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1267 [FLINK-2853] [tests] Apply JMH on MutableHashTablePerformanceBenchmark class. JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks.Use JMH to replace the

[GitHub] flink pull request: [FLINK-2853] [tests] Apply JMH on MutableHashT...

2015-10-18 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1267#issuecomment-149116533 JMH result (We can choose the benchmark mode with througout, averagetime,sampletime and so on.Also we can set the warmup and measurement iteration number according

[GitHub] flink pull request: [FLINK-2853] [tests] Apply JMH on MutableHashT...

2015-10-19 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1267#discussion_r42448095 --- Diff: flink-benchmark/src/test/java/org/apache/flink/runtime/operators/hash/MutableHashTablePerformanceBenchmark.java --- @@ -0,0 +1,360

[GitHub] flink pull request: [FLINK-2853] [tests] Apply JMH on MutableHashT...

2015-10-19 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1267#discussion_r42448388 --- Diff: pom.xml --- @@ -163,6 +163,16 @@ under the License. jar test

[GitHub] flink pull request: [FLINK-2853] [tests] Apply JMH on MutableHashT...

2015-10-19 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1267#discussion_r42448562 --- Diff: flink-benchmark/pom.xml --- @@ -57,6 +57,13 @@ under the License. ${jmh.version} provided

[GitHub] flink pull request: [FLINK-2853] [tests] Apply JMH on MutableHashT...

2015-10-19 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1267#discussion_r42453717 --- Diff: flink-runtime/pom.xml --- @@ -210,7 +210,7 @@ under the License. ${curator.version} test

[GitHub] flink pull request: [FLINK-2853] [tests] Apply JMH on MutableHashT...

2015-10-19 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1267#discussion_r42453815 --- Diff: flink-benchmark/src/test/java/org/apache/flink/benchmark/runtime/operates/hash/MutableHashTablePerformanceBenchmark.java --- @@ -0,0 +1,361

[GitHub] flink pull request: [FLINK-2869] [tests] Apply JMH on IOManagerPer...

2015-10-20 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1270 [FLINK-2869] [tests] Apply JMH on IOManagerPerformanceBenchmark class. JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks.Use JMH to replace the old

[GitHub] flink pull request: [FLINK-2869] [tests] Apply JMH on IOManagerPer...

2015-10-20 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1270#issuecomment-149765941 Part of the JMH benchmark result : ![jmhiomanagerbenchmark](https://cloud.githubusercontent.com/assets/12931563/10626358/a82ce376-77e0-11e5-9fb6-a604167db867.PNG

[GitHub] flink pull request: [FLINK-2889] [tests] Apply JMH on LongSerializ...

2015-10-21 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1283 [FLINK-2889] [tests] Apply JMH on LongSerializationSpeedBenchmark class JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks.Use JMH to replace the old

[GitHub] flink pull request: [FLINK-2889] [tests] Apply JMH on LongSerializ...

2015-10-21 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1283#issuecomment-150094719 JMH result: ![longserializationspeed](https://cloud.githubusercontent.com/assets/12931563/10656076/c4085f44-78ad-11e5-9534-c69196b4.PNG) --- If your

[GitHub] flink pull request: [FLINK-2890] [tests] Apply JMH on StringSerial...

2015-10-22 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1284 [FLINK-2890] [tests] Apply JMH on StringSerializationSpeedBenchmark class. JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks.Use JMH to replace the old

[GitHub] flink pull request: [FLINK-2890] [tests] Apply JMH on StringSerial...

2015-10-22 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1284#issuecomment-150131741 JMH result: ![stringserializationspeed](https://cloud.githubusercontent.com/assets/12931563/10659384/f944e136-78d1-11e5-87db-f7929818774d.PNG) --- If your

[GitHub] flink pull request: [FLINK-2919] [tests] Apply JMH on FieldAccessM...

2015-10-26 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1300 [FLINK-2919] [tests] Apply JMH on FieldAccessMinibenchmark class. JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks.Use JMH to replace the old micro

[GitHub] flink pull request: [FLINK-2919] [tests] Apply JMH on FieldAccessM...

2015-10-26 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1300#issuecomment-151048797 Result (without JMH): ![fieldaccessmini](https://cloud.githubusercontent.com/assets/12931563/10723423/a52c8a00-7bf5-11e5-9784-b7d4cb25f77d.PNG) Result (with

[GitHub] flink pull request: [FLINK-2920] [tests] Apply JMH on KryoVersusAv...

2015-10-26 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1302 [FLINK-2920] [tests] Apply JMH on KryoVersusAvroMinibenchmark class. JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks.Use JMH to replace the old micro

[GitHub] flink pull request: [FLINK-2869] [tests] Apply JMH on IOManagerPer...

2015-10-27 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/1270#discussion_r43212327 --- Diff: flink-benchmark/src/test/java/org/apache/flink/benchmark/runtime/io/disk/iomanager/IOManagerPerformanceBenchmark.java --- @@ -0,0 +1,613

[GitHub] flink pull request: [FLINK-2956] [tests] Migrate integration tests...

2015-11-11 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1349 [FLINK-2956] [tests] Migrate integration tests for Table API. Migrate integration tests of Table API from temp file to `collect()` as described in umbrella jira. You can merge this pull request

[GitHub] flink pull request:

2015-11-12 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/commit/dd66e61ecc5da5b15a610f04b98c8386d141f910#commitcomment-14352150 @tillrohrmann @smarthi I have done some work of `flink-benchmark` with JMH. Can you tell me why to remove the `flink

[GitHub] flink pull request:

2015-11-12 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/commit/dd66e61ecc5da5b15a610f04b98c8386d141f910#commitcomment-14373918 @chiwanpark @sachingoel0101 Thanks for your explaination. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2956] [tests] Migrate integration tests...

2015-11-15 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1349#issuecomment-156890933 Hi, @chiwanpark . Thanks for your review. I'm not very clear about your first suggestion. Do you mean that we should remove type description when to create

[GitHub] flink pull request: [FLINK-2956] [tests] Migrate integration tests...

2015-11-16 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1349#issuecomment-157236045 Hi, @chiwanpark . I have modified the code and committed a new commit. Can you help me with review work? --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [FLINK-2956] [tests] Migrate integration tests...

2015-11-16 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1349#issuecomment-157236280 Hi, @chiwanpark . I have modified the code and submitted a new commit. Can you help me with review work? --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-2956] [tests] Migrate integration tests...

2015-11-22 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1349#issuecomment-158838162 Hi, @chiwanpark . I have modified the code format and submitted a new commit. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2956] [tests] Migrate integration tests...

2015-11-24 Thread gallenvara
Github user gallenvara closed the pull request at: https://github.com/apache/flink/pull/1349 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2220] Join on Pojo without hashCode() s...

2016-04-26 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1940 [FLINK-2220] Join on Pojo without hashCode() silently fails Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
GitHub user gallenvara opened a pull request: https://github.com/apache/flink/pull/1956 [FLINK-2044] [gelly] Implementation of Gelly HITS Algorithm Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...

2016-05-02 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1956#issuecomment-216190461 @vasia Can you help with review work? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   >