GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2782
[hotfix] Prevent possible NPE in FlumeSink.
Prevent possible NPE in FlumeSink.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chermenin/flink
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2782
1) I researched this question a little. It based on issue
[FLINK-4631](https://issues.apache.org/jira/browse/FLINK-4631) and affect PR
#2709. So, it's more wide issue and all elements of stre
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/2782
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2782
I close this PR. Changes will be included into other PR to complete solve
[FLINK-4631](https://issues.apache.org/jira/browse/FLINK-4631) (reopened issue).
---
If your project is set up for it
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2807
[FLINK-4631] Prevent some possible NPEs.
Added additional conditions in several places to check possible NPEs. This
PR must completely solve
[FLINK-4631](https://issues.apache.org/jira/browse
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/2807
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2849
[FLINK-4631] Fixed stream task that was interrupted before it was
initialized.
I think this is the best solution for this issue - to check that
initialization was finished before call `cleanup
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2723
@StephanEwen @fhueske Can we discuss this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2623
@StephanEwen What about merging this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2623
Yep, fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2856
Removed excessive tests.
It's connected with PR #2623. Excessive test methods were removed from
`GroupReduceITCase`. There are appropriate targeted unit tests in
`KryoCollectionsSerialize
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2856
I removed a method from ITCase only. There is `testJavaArraysAsList` method
in `KryoCollectionsSerializerTest` class to check it. Yep, before merging
#2623, they have not been successful.
---
If
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2856
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2937
[FLINK-4303] Examples for CEP library.
Added example programs written in Java and Scala. They based on
@tillrohrmann 's monitoring example.
This issue will be closed by this PR:
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2965
[FLINK-2980] [table] Support for SQL GROUPING SETS clause.
Support for operators GROUPING SETS / ROLLUP / CUBE was added in this PR.
Also added some tests for check execution of SQL queries
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2976
[FLINK-5303] [table] Support for SQL GROUPING SETS clause.
Support for operators GROUPING SETS / ROLLUP / CUBE was added in this PR.
Also added some tests for check execution of SQL queries
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/2965
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2965
PR closed to rename the branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/2849
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2723
I think that if some type can have `null` as value then there must be
possibility to serialize this value (it may be Option or any other type). And
by the way `CaseClassSerializer` class have been
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2723
No-no, i'm forced to disagree with you... IMHO, `null` is a value of
concrete type and it must be processed by individual serializer for this type.
---
If your project is set up for it, yo
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2723
Okay, we can add a null encoding support for serializers of containing
types, and it will be done at this weekends. But even in this case we must save
a null encoding support for serializing the
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2723
Well, sure, I understand you. Let's discuss all aspects of a improvement of
a serialization model (include `null`'s processing, of course) in mailing list
and will implement everything
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/2723
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/3021
[FLINK-3617] Prevent NPE in CaseClassSerializer and informative error
message.
To not to change current implementation of serialization now just
NullFieldException has been added.
You can merge
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/3026
[FLINK-2980] [table] Support for GROUPING SETS clause in Table API.
Support for operators GROUPING SETS / ROLLUP / CUBE in Table AP was added
in this PR.
Also added some tests for check
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/3021
Yep, i'll do a benchmark to test approaches and compare them each other at
this week. I will write the results here. Big thanks for your idea)
---
If your project is set up for it, you can
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2328
[hotfix] Fix TypeExtractor.
When function is a method reference to an instance method of an arbitrary
object of a particular type it hasn't any parameters and getting of input type
t
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/2328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2623
[FLINK-2608] Updated Twitter Chill version.
Fixed JIRA issue [[FLINK-2608] Arrays.asList(..) does not work with
CollectionInputFormat](https://issues.apache.org/jira/browse/FLINK-2608) as
issue
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2623
@rmetzger If I'm not mistaken Kryo 2.24 and 3.0 versions is compatible each
other at the level of standard IO serialization. And if it possible we will be
able to a little wait for Chill
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2623
I exclude Kryo as a dependency from Chill and add simple test to check Java
collections. Tests added to `flink-tests` because it is depends on
`flink-runtime` (where used Chill).
---
If your
Github user chermenin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2623#discussion_r85369265
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/util/CollectionDataSets.java
---
@@ -710,7 +712,103 @@ public String toString
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2709
[FLINK-4631] Avoided NPE in OneInputStreamTask.
Added additional condition to check possible NPE. This PR solve
[FLINK-4631](https://issues.apache.org/jira/browse/FLINK-4631).
You can merge this
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2723
[FLINK-3617] Simple fix for OptionSerializer.
This fix prevent possible NullPointerException at serialization process,
but after deserialization Option variable will be initialized with None
Github user chermenin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2723#discussion_r85775790
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/OptionSerializer.scala
---
@@ -65,7 +65,7 @@ class OptionSerializer[A](val
Github user chermenin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2723#discussion_r85776021
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/CaseClassComparatorTest.scala
---
@@ -34,7 +34,7 @@ import org.mockito.Mockito
Github user chermenin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2723#discussion_r85782914
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/OptionSerializer.scala
---
@@ -65,7 +65,7 @@ class OptionSerializer[A](val
Github user chermenin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2723#discussion_r85812829
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/OptionSerializer.scala
---
@@ -65,7 +65,7 @@ class OptionSerializer[A](val
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2723
@StephanEwen I think `deepEquals` method must be used for this and not
`toString`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2723
I see. I will change this code in the near future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2723
@StephanEwen I restored test to check `toString()` method. This check added
into `deepEquals()` method and performed only if `toString()` is overridden. In
other cases this check is useless, isn&#
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/3021
I've got results and here are:
Benchmark | Mode | Cnt |Score | Error | Units
---|---|--|---|-|
Just oper
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2976
I cleaned up my code and I will write tests for the plan at this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2976
Big thanks for the review @twalthr! I fixed the code for most of the
comments. I will fix the tests at this weekend.
---
If your project is set up for it, you can reply to this email and have
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/3021
@StephanEwen What do you think about merging this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2361
@mushketyk It seems needed to rebase this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/3105
[FLINK-4641] Support branching CEP patterns
Support for branched CEP patterns was added in this PR.
After merging that we will be able to use follow code to define more
complex patterns
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2396
@mushketyk Could you rebase this PR, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user chermenin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2361#discussion_r97264252
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/State.java ---
@@ -43,7 +43,14 @@ public State(final String name, final
Github user chermenin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2396#discussion_r97272232
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/ProcessingType.java
---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/3021
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2937
Thanks for your comment, but I'm afraid I don't have enough time to work on
this task now. I'll just close this PR for now. It possible I'll come back to
the task in the
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/2937
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/3026
@aljoscha I think I'll close this PR. Any way the code will be here, if
it's needed.
---
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/3026
---
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/3105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/3105
@Aitozi I just didn't have enough time to finish my work on this task and
the Pattern API was changed at the same time. Now it's needed to rewrite the
code to support all updates.
---
[
https://issues.apache.org/jira/browse/FLINK-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437141#comment-15437141
]
Alexander Chermenin commented on FLINK-2608:
This is a bu
[
https://issues.apache.org/jira/browse/FLINK-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656726#comment-15656726
]
Alexander Chermenin commented on FLINK-4631:
I think this ticket mus
[
https://issues.apache.org/jira/browse/FLINK-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714936#comment-15714936
]
Alexander Chermenin commented on FLINK-4303:
Hi all. And what about u
[
https://issues.apache.org/jira/browse/FLINK-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Chermenin reassigned FLINK-2980:
--
Assignee: Alexander Chermenin
> Add CUBE/ROLLUP/GROUPING SETS operator
Alexander Chermenin created FLINK-5303:
--
Summary: Add CUBE/ROLLUP/GROUPING SETS operator in SQL
Key: FLINK-5303
URL: https://issues.apache.org/jira/browse/FLINK-5303
Project: Flink
Alexander Chermenin created FLINK-5319:
--
Summary: ClassCastException when reusing an inherited method as
KeySelector for different classes
Key: FLINK-5319
URL: https://issues.apache.org/jira/browse/FLINK
[
https://issues.apache.org/jira/browse/FLINK-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Chermenin updated FLINK-5319:
---
Summary: ClassCastException when reusing an inherited method reference as
KeySelector
[
https://issues.apache.org/jira/browse/FLINK-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Chermenin updated FLINK-5319:
---
Description:
Code sample:
{code}static abstract class A {
int id;
A(int id
[
https://issues.apache.org/jira/browse/FLINK-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742827#comment-15742827
]
Alexander Chermenin commented on FLINK-5319:
There are no problems if
[
https://issues.apache.org/jira/browse/FLINK-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742901#comment-15742901
]
Alexander Chermenin commented on FLINK-5319:
More simple test with the
[
https://issues.apache.org/jira/browse/FLINK-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747820#comment-15747820
]
Alexander Chermenin commented on FLINK-5319:
It seems there is a Java bu
[
https://issues.apache.org/jira/browse/FLINK-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748212#comment-15748212
]
Alexander Chermenin commented on FLINK-5319:
Here is a link to the bug: h
[
https://issues.apache.org/jira/browse/FLINK-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748508#comment-15748508
]
Alexander Chermenin commented on FLINK-5319:
Well, we can change
[
https://issues.apache.org/jira/browse/FLINK-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782410#comment-15782410
]
Alexander Chermenin commented on FLINK-3615:
Hi all. Is it an actual issu
[
https://issues.apache.org/jira/browse/FLINK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Chermenin reassigned FLINK-4641:
--
Assignee: Alexander Chermenin
> Support branching CEP patte
[
https://issues.apache.org/jira/browse/FLINK-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Chermenin reassigned FLINK-3617:
--
Assignee: Alexander Chermenin
> NPE from CaseClassSerializer when dealing w
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Chermenin reassigned FLINK-4565:
--
Assignee: Alexander Chermenin (was: Nikolay Vasilishin)
> Support for SQL
[
https://issues.apache.org/jira/browse/FLINK-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Chermenin reassigned FLINK-4303:
--
Assignee: Alexander Chermenin
> Add CEP examp
[
https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Chermenin reassigned FLINK-4565:
--
Assignee: (was: Alexander Chermenin)
> Support for SQL IN opera
[
https://issues.apache.org/jira/browse/FLINK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050551#comment-16050551
]
Alexander Chermenin commented on FLINK-4641:
Hi [~dian.fu]! Yes of co
[
https://issues.apache.org/jira/browse/FLINK-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Chermenin reassigned FLINK-11968:
---
Assignee: Alexander Chermenin
> Fix runtime SingleElementIterator.itera
79 matches
Mail list logo
