[GitHub] tillrohrmann commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-07 Thread GitBox
tillrohrmann commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223209376 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescr

[GitHub] leanken commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-07 Thread GitBox
leanken commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427659457 Thanks for your review. @tillrohrmann Resolved your comment. Looking forward for further work at FLINK community.

[GitHub] leanken edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-07 Thread GitBox
leanken edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427659457 Thanks for your review. @tillrohrmann Resolved your comment. Looking forward for further work at FLINK com

[GitHub] bmeriaux opened a new pull request #6801: [FLINK-10227] Remove javax.xml.bind.DatatypeConverter

2018-10-07 Thread GitBox
bmeriaux opened a new pull request #6801: [FLINK-10227] Remove javax.xml.bind.DatatypeConverter URL: https://github.com/apache/flink/pull/6801 ## What is the purpose of the change *Remove usage of javax.xml.bind.DatatypeConverter for java 9 compatibility* ## Brief change l

[GitHub] yanghua commented on issue #6738: [FLINK-10126] There should be a Scala DataSource

2018-10-07 Thread GitBox
yanghua commented on issue #6738: [FLINK-10126] There should be a Scala DataSource URL: https://github.com/apache/flink/pull/6738#issuecomment-427664855 Hi @tillrohrmann , Perhaps we have a deviation in the understanding of "break", and my "break" is to change the signature of the API. Bec

[GitHub] leanken commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-07 Thread GitBox
leanken commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427707833 All checks passed, ready to merge. @tillrohrmann @GJL -

[GitHub] TisonKun commented on issue #6680: [FLINK-10319] [runtime] Too many requestPartitionState would crash JM

2018-10-07 Thread GitBox
TisonKun commented on issue #6680: [FLINK-10319] [runtime] Too many requestPartitionState would crash JM URL: https://github.com/apache/flink/pull/6680#issuecomment-427716261 @tillrohrmann it is better to say that `JobMaster` will be overwhelmed by too many rpc request. This issue i

[GitHub] TisonKun commented on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs

2018-10-07 Thread GitBox
TisonKun commented on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs URL: https://github.com/apache/flink/pull/6737#issuecomment-427716737 ping @GJL as a reminder :-) This is an automated message from the Apache

[GitHub] XuQianJin-Stars commented on a change in pull request #6710: [FLINK-10134] UTF-16 support for TextInputFormat bug fixed

2018-10-07 Thread GitBox
XuQianJin-Stars commented on a change in pull request #6710: [FLINK-10134] UTF-16 support for TextInputFormat bug fixed URL: https://github.com/apache/flink/pull/6710#discussion_r223259155 ## File path: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java #

[GitHub] tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223265779 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/SerializationP

[GitHub] tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223265866 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerial

[GitHub] zentol closed pull request #6798: [docs] Fixed typo, please instead of pelase

2018-10-08 Thread GitBox
zentol closed pull request #6798: [docs] Fixed typo, please instead of pelase URL: https://github.com/apache/flink/pull/6798 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] fhueske commented on issue #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API

2018-10-08 Thread GitBox
fhueske commented on issue #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API URL: https://github.com/apache/flink/pull/6790#issuecomment-427743674 merging This is an automate

[GitHub] tzulitai commented on issue #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
tzulitai commented on issue #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#issuecomment-427744344 Thanks a lot for the detailed reviews and discussions, @dawidwys and @StephanEwen. @dawidwys and I went th

[GitHub] fhueske commented on a change in pull request #6710: [FLINK-10134] UTF-16 support for TextInputFormat bug fixed

2018-10-08 Thread GitBox
fhueske commented on a change in pull request #6710: [FLINK-10134] UTF-16 support for TextInputFormat bug fixed URL: https://github.com/apache/flink/pull/6710#discussion_r223268822 ## File path: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java #

[GitHub] tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
tzulitai commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223269252 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerial

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427747927 I took a look at the different sizes of a serialized `AbstractID` with and without the transi

[GitHub] zhangxinyu1 commented on issue #6770: [FLINK-10002] [Webfrontend] WebUI shows jm/tm logs more friendly.

2018-10-08 Thread GitBox
zhangxinyu1 commented on issue #6770: [FLINK-10002] [Webfrontend] WebUI shows jm/tm logs more friendly. URL: https://github.com/apache/flink/pull/6770#issuecomment-427748392 @tillrohrmann Thanks, I'll resolve conflicts if it has until you review this PR. -

[GitHub] zentol closed pull request #6772: [FLINK-10453][travis] Move hdp 2.4 tests to cron jobs

2018-10-08 Thread GitBox
zentol closed pull request #6772: [FLINK-10453][travis] Move hdp 2.4 tests to cron jobs URL: https://github.com/apache/flink/pull/6772 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427751092 @tillrohrmann I have tried to do it the way you said it, but because the fully qualified names of

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427751527 Why are the fully qualified names different @yanghua? I actually just tried to do the same an

[GitHub] tillrohrmann edited a comment on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann edited a comment on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427752299 This is the commit: https://github.com/tillrohrmann/flink/commit/5179eac7d19b342e161cb

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427752299 This is the branch: https://github.com/tillrohrmann/flink/commit/5179eac7d19b342e161cb188f78e

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427752657 Since @StephanEwen initially rejected this PR I would still like to hear his opinion before m

[GitHub] yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427753059 > If existing savepoints have an AbstractID serialized in it, will the deserialization fail if

[GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427753255 I created the resource files with the serialized `AbstractID` before applying your changes. T

[GitHub] tillrohrmann edited a comment on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
tillrohrmann edited a comment on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427753255 I created the resource files with the serialized `AbstractID` before applying your cha

[GitHub] yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized

2018-10-08 Thread GitBox
yanghua commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized URL: https://github.com/apache/flink/pull/6755#issuecomment-427753765 Oh, @tillrohrmann I understood. --

[GitHub] tillrohrmann commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427755128 Thanks for the clarification @TisonKun. I'll give it another pass with your comments in mind. ---

[GitHub] tillrohrmann commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
tillrohrmann commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r223285835 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runt

[GitHub] GJL commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427761358 Hi, I am taking a look again. This is an automated mess

[GitHub] TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427761218 @tillrohrmann thanks for your review! This is

[GitHub] GJL closed pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL closed pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] leanken opened a new pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken opened a new pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775 ## What is the purpose of the change See. [FLINK-5542](https://issues.apache.org/jira/browse/FLINK-5542) use YarnCluste

[GitHub] GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427761358 Hi, I am taking a looking. This is an automated

[GitHub] GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427761358 Hi, I am taking a look. This is an automated mes

[GitHub] GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL edited a comment on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427761358 Hi, I am taking a look now. This is an automated

[GitHub] tillrohrmann commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
tillrohrmann commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r223286665 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runt

[GitHub] TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427768967 @tillrohrmann sounds good. As you suggest, we can replace `notifyFinalState` with `updateTaskExecutionState` s

[GitHub] rinkako opened a new pull request #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section

2018-10-08 Thread GitBox
rinkako opened a new pull request #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section URL: https://github.com/apache/flink/pull/6802 `DELETE` request to **`/jobs/:jobid/cancel`** always return {"errors": ["Not found."]}, since the correct API should be `GET` request to `/

[GitHub] TisonKun commented on issue #6778: [FLINK-10426] [tests] Port TaskTest to new code base

2018-10-08 Thread GitBox
TisonKun commented on issue #6778: [FLINK-10426] [tests] Port TaskTest to new code base URL: https://github.com/apache/flink/pull/6778#issuecomment-427769213 This pull request need a rebase on #6729 and thus now WIP. This is

[GitHub] GJL commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223300816 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.jav

[GitHub] GJL commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
GJL commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223301904 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.jav

[GitHub] GJL commented on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs

2018-10-08 Thread GitBox
GJL commented on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs URL: https://github.com/apache/flink/pull/6737#issuecomment-427774173 Taking a look now. This is an automated message from the Apache Git Service. To

[GitHub] yanghua commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file

2018-10-08 Thread GitBox
yanghua commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file URL: https://github.com/apache/flink/pull/6542#issuecomment-427774371 @StephanEwen @tillrohrmann and @zentol ,Any opinions about this PR?

[GitHub] leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223303030 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor

[GitHub] Clarkkkkk commented on issue #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-10-08 Thread GitBox
Clark commented on issue #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#issuecomment-427780030 Thanks for your review @tillrohrmann . I have replace the RPC service with actor system and get rid of the add

[GitHub] zhijiangW commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
zhijiangW commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r223309406 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/net

[GitHub] leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223309660 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor

[GitHub] zentol closed pull request #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section

2018-10-08 Thread GitBox
zentol closed pull request #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section URL: https://github.com/apache/flink/pull/6802 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#discussion_r223309773 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor

[GitHub] zentol commented on issue #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section

2018-10-08 Thread GitBox
zentol commented on issue #6802: [hotfix][docs] fix rest_api.md mistakes at Cancel Job section URL: https://github.com/apache/flink/pull/6802#issuecomment-427780402 -1 for a few reasons: * That part of the documentation is for legacy mode => legacy mode indeed requires a DELETE to

[GitHub] leanken commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation

2018-10-08 Thread GitBox
leanken commented on issue #6775: [FLINK-5542] use YarnCluster vcores setting to do MaxVCore validation URL: https://github.com/apache/flink/pull/6775#issuecomment-427780528 @GJL resolved yours comments. This is an automated

[GitHub] tillrohrmann commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#issuecomment-427780989 Alright @TisonKun. I'll do the removal of `notifyFinalState` as a follow up. -

[GitHub] zentol opened a new pull request #6803: [FLINK-10512][rest][docs] Remove legacy docs

2018-10-08 Thread GitBox
zentol opened a new pull request #6803: [FLINK-10512][rest][docs] Remove legacy docs URL: https://github.com/apache/flink/pull/6803 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC

[GitHub] zentol closed pull request #6803: [FLINK-10512][rest][docs] Remove legacy docs

2018-10-08 Thread GitBox
zentol closed pull request #6803: [FLINK-10512][rest][docs] Remove legacy docs URL: https://github.com/apache/flink/pull/6803 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] tillrohrmann commented on issue #6680: [FLINK-10319] [runtime] Too many requestPartitionState would crash JM

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6680: [FLINK-10319] [runtime] Too many requestPartitionState would crash JM URL: https://github.com/apache/flink/pull/6680#issuecomment-427783408 I see the problem with very large jobs. Maybe we could solve it a bit differently, by deploying tasks in topolo

[GitHub] tillrohrmann opened a new pull request #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState

2018-10-08 Thread GitBox
tillrohrmann opened a new pull request #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState URL: https://github.com/apache/flink/pull/6804 ## What is the purpose of the change Simplify TaskManagerActions interface by replacing calls to notif

[GitHub] tillrohrmann commented on issue #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system URL: https://github.com/apache/flink/pull/6759#issuecomment-427786350 Thanks for updating this PR @Clark. I'll give it a pass later today. I think we should not insta

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223311517 ## File path: flink-core/src/main/java/org/apache/flink/core/io/VersionedIOReadableWrit

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223302936 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerial

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223315346 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedBackendSe

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223310411 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerial

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223310741 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/EnumS

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223321240 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBacken

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223305539 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerial

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223315401 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedBackendSe

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223324434 ## File path: flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/EnumValue

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223325908 ## File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerial

[GitHub] dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints

2018-10-08 Thread GitBox
dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state backends] Remove serializers from checkpoints URL: https://github.com/apache/flink/pull/6711#discussion_r223313725 ## File path: flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerial

[GitHub] yanghua commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions

2018-10-08 Thread GitBox
yanghua commented on issue #6675: [FLINK-10258] [sql-client] Allow streaming sources to be present for batch executions URL: https://github.com/apache/flink/pull/6675#issuecomment-427798069 cc @twalthr This is an automated m

[GitHub] zentol closed pull request #6634: [FLINK-10208][build] Bump mockito to 2.21.0 / powermock to 2.0.0-beta.5

2018-10-08 Thread GitBox
zentol closed pull request #6634: [FLINK-10208][build] Bump mockito to 2.21.0 / powermock to 2.0.0-beta.5 URL: https://github.com/apache/flink/pull/6634 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] asfgit closed pull request #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API

2018-10-08 Thread GitBox
asfgit closed pull request #6790: [FLINK-10487] [table] fix invalid Flink SQL example and add runnable SQL example for Java API URL: https://github.com/apache/flink/pull/6790 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below fo

[GitHub] zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API

2018-10-08 Thread GitBox
zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API URL: https://github.com/apache/flink/pull/6754#discussion_r223331981 ## File path: flink-runtime-web/src/test/java/org/apache/flink/runtime

[GitHub] zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API

2018-10-08 Thread GitBox
zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API URL: https://github.com/apache/flink/pull/6754#discussion_r223330322 ## File path: flink-runtime-web/src/test/java/org/apache/flink/runtime

[GitHub] zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API

2018-10-08 Thread GitBox
zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API URL: https://github.com/apache/flink/pull/6754#discussion_r223329566 ## File path: flink-runtime-web/src/test/java/org/apache/flink/runtime

[GitHub] zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API

2018-10-08 Thread GitBox
zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API URL: https://github.com/apache/flink/pull/6754#discussion_r223325748 ## File path: flink-runtime-web/src/main/java/org/apache/flink/runtime

[GitHub] zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API

2018-10-08 Thread GitBox
zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API URL: https://github.com/apache/flink/pull/6754#discussion_r22232 ## File path: docs/_includes/generated/rest_v1_dispatcher.html ###

[GitHub] zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API

2018-10-08 Thread GitBox
zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API URL: https://github.com/apache/flink/pull/6754#discussion_r223328469 ## File path: flink-runtime-web/src/test/java/org/apache/flink/runtime

[GitHub] zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API

2018-10-08 Thread GitBox
zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API URL: https://github.com/apache/flink/pull/6754#discussion_r223332302 ## File path: flink-runtime-web/src/test/java/org/apache/flink/runtime

[GitHub] zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API

2018-10-08 Thread GitBox
zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API URL: https://github.com/apache/flink/pull/6754#discussion_r223329522 ## File path: flink-runtime-web/src/test/java/org/apache/flink/runtime

[GitHub] tillrohrmann commented on issue #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState URL: https://github.com/apache/flink/pull/6804#issuecomment-427807542 I think `notifyFinalState` will also be called if the `Task` reaches the `CANCELED` or `FINI

[GitHub] TisonKun commented on issue #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState

2018-10-08 Thread GitBox
TisonKun commented on issue #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState URL: https://github.com/apache/flink/pull/6804#issuecomment-427808066 Yes, I mean inline as `...ExecutionState.FAILED))`/`...ExecutionState.CANCELED))`/`...ExecutionS

[GitHub] tillrohrmann commented on issue #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState

2018-10-08 Thread GitBox
tillrohrmann commented on issue #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState URL: https://github.com/apache/flink/pull/6804#issuecomment-427808601 I would not inline it, because `notifyFinalState` gives a little bit more context (namely th

[GitHub] zjuwangg commented on a change in pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar source connector

2018-10-08 Thread GitBox
zjuwangg commented on a change in pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar source connector URL: https://github.com/apache/flink/pull/6200#discussion_r223341191 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streamin

[GitHub] zjuwangg commented on a change in pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar source connector

2018-10-08 Thread GitBox
zjuwangg commented on a change in pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar source connector URL: https://github.com/apache/flink/pull/6200#discussion_r223338960 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streamin

[GitHub] zjuwangg commented on a change in pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar source connector

2018-10-08 Thread GitBox
zjuwangg commented on a change in pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar source connector URL: https://github.com/apache/flink/pull/6200#discussion_r223340555 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streamin

[GitHub] zjuwangg commented on a change in pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar source connector

2018-10-08 Thread GitBox
zjuwangg commented on a change in pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar source connector URL: https://github.com/apache/flink/pull/6200#discussion_r223342019 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streamin

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r223342148 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r222015562 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r223292943 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r221851168 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r221851878 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r221894938 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r221894761 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r223290657 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r223340950 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r223291788 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r223292589 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

[GitHub] NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty

2018-10-08 Thread GitBox
NicoK commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty URL: https://github.com/apache/flink/pull/6698#discussion_r222017678 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network

  1   2   3   4   5   6   7   8   9   10   >