Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

2025-05-11 Thread via GitHub
xishuaidelin commented on code in PR #26430: URL: https://github.com/apache/flink/pull/26430#discussion_r2083708808 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java: ## @@ -429,4 +461,30 @@ private File createSourceSinkTables()

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-11 Thread via GitHub
fsk119 commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2083710337 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java: ## @@ -130,6 +150,15 @@ static String buildCreateFormattedPref

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-11 Thread via GitHub
fsk119 commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2083722961 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java: ## @@ -177,6 +206,17 @@ static String extractFormattedColumns

[jira] [Updated] (FLINK-35854) Upgrade Calcite version to 1.35.0

2025-05-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35854: --- Labels: pull-request-available (was: ) > Upgrade Calcite version to 1.35.0 > --

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2025-05-11 Thread via GitHub
gyfora commented on code in PR #957: URL: https://github.com/apache/flink-kubernetes-operator/pull/957#discussion_r2083845851 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java: ## @@ -55,4 +63,146 @@ public

[jira] [Closed] (FLINK-37767) Update ref version for es connector

2025-05-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-37767. -- Fix Version/s: 2.1.0 Resolution: Done master(2.1) via fc1aeb2a537e9e097111af6563e29421e1a5661b.

Re: [PR] [FLINK-37767][doc] Update reference branch/version for es connector [flink]

2025-05-11 Thread via GitHub
reswqa merged PR #26533: URL: https://github.com/apache/flink/pull/26533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Assigned] (FLINK-35854) Upgrade Calcite version to 1.35.0

2025-05-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-35854: --- Assignee: Sergey Nuyanzin > Upgrade Calcite version to 1.35.0 > ---

Re: [PR] [FLINK-36876] Add proxy for restClient [flink-kubernetes-operator]

2025-05-11 Thread via GitHub
gyfora commented on code in PR #956: URL: https://github.com/apache/flink-kubernetes-operator/pull/956#discussion_r2083854374 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/RestClientProxy.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to t

[jira] [Commented] (FLINK-37747) GlobalCommitterOperator cannot commit after scaling writer/committer

2025-05-11 Thread David (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950839#comment-17950839 ] David commented on FLINK-37747: --- [~arvid] yep, I am making PRs to 1.20 and 1.19. > Global

Re: [PR] [FLINK-xx][table] Remove RelBuilder [flink]

2025-05-11 Thread via GitHub
github-actions[bot] commented on PR #25823: URL: https://github.com/apache/flink/pull/25823#issuecomment-2871029083 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-xx][table] Remove RelBuilder [flink]

2025-05-11 Thread via GitHub
github-actions[bot] closed pull request #25823: [FLINK-xx][table] Remove RelBuilder URL: https://github.com/apache/flink/pull/25823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [hotfix][docs] Fix Apache Avro Specification Link [flink]

2025-05-11 Thread via GitHub
github-actions[bot] commented on PR #25850: URL: https://github.com/apache/flink/pull/25850#issuecomment-2871029218 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [hotfix][docs] Fix Apache Avro Specification Link [flink]

2025-05-11 Thread via GitHub
github-actions[bot] closed pull request #25850: [hotfix][docs] Fix Apache Avro Specification Link URL: https://github.com/apache/flink/pull/25850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-36992][table] Migrate SplitAggregateRule to java [flink]

2025-05-11 Thread via GitHub
github-actions[bot] closed pull request #25883: [FLINK-36992][table] Migrate SplitAggregateRule to java URL: https://github.com/apache/flink/pull/25883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [FLINK-36992][table] Migrate SplitAggregateRule to java [flink]

2025-05-11 Thread via GitHub
github-actions[bot] commented on PR #25883: URL: https://github.com/apache/flink/pull/25883#issuecomment-2871029402 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

[PR] [FLINK-37747][runtime] Use old subtask count for restored committable… [flink]

2025-05-11 Thread via GitHub
bjlovegithub opened a new pull request, #26546: URL: https://github.com/apache/flink/pull/26546 Backport of https://github.com/apache/flink/pull/26518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-37747][runtime] Use old subtask count for restored committable… [flink]

2025-05-11 Thread via GitHub
flinkbot commented on PR #26546: URL: https://github.com/apache/flink/pull/26546#issuecomment-2871045219 ## CI report: * 770c2310086060cfba48bc6a4903bd2b64f2d980 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-37747) GlobalCommitterOperator cannot commit after scaling writer/committer

2025-05-11 Thread David (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950842#comment-17950842 ] David commented on FLINK-37747: --- hey [~arvid] i made a PR to path release-2.0: [https://g

[PR] [FLINK-35854][table] Upgrade Calcite version to 1.35.0 [flink]

2025-05-11 Thread via GitHub
snuyanzin opened a new pull request, #26547: URL: https://github.com/apache/flink/pull/26547 ## What is the purpose of the change Upgrade Calcite to 1.35.0 ## Brief change log TBD ## Verifying this change existing tests ## Does this pull request poten

Re: [PR] [FLINK-35854][table] Upgrade Calcite version to 1.35.0 [flink]

2025-05-11 Thread via GitHub
flinkbot commented on PR #26547: URL: https://github.com/apache/flink/pull/26547#issuecomment-2871098626 ## CI report: * 8bb4c36c24faee6947a844c5449fbd80d7e9e164 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36876] Add proxy for restClient [flink-kubernetes-operator]

2025-05-11 Thread via GitHub
chenyuzhi459 commented on PR #956: URL: https://github.com/apache/flink-kubernetes-operator/pull/956#issuecomment-2870721397 Is there any other problem with this pr? I don't know why CI check was cancelled @gyfora -- This is an automated message from the Apache Git Service. To re

Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

2025-05-11 Thread via GitHub
xishuaidelin commented on code in PR #26430: URL: https://github.com/apache/flink/pull/26430#discussion_r2083772219 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java: ## @@ -203,7 +204,13 @@ private static WatermarkPu

Re: [PR] [FLINK-37128][pipeline-connector/mysql] Binlog reader skip `shouldEmit` filter when snapshot reader skip backfill [flink-cdc]

2025-05-11 Thread via GitHub
beryllw commented on PR #3874: URL: https://github.com/apache/flink-cdc/pull/3874#issuecomment-2870630316 > Hi, @beryllw , would you like to push forward this pr? Yes, I will push forward this pr this week. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] [hotfix][state] Remove duplicate comparing about intersect group range. [flink]

2025-05-11 Thread via GitHub
littleeleventhwolf commented on PR #26544: URL: https://github.com/apache/flink/pull/26544#issuecomment-2870632050 Hi,@StefanRRichter. I notice there's a duplicate comparison in the `Score.compareTo` method. Would you mind taking a look since you're familiar with this part of the code? --

Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

2025-05-11 Thread via GitHub
xishuaidelin commented on code in PR #26430: URL: https://github.com/apache/flink/pull/26430#discussion_r2083760128 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java: ## @@ -203,7 +204,13 @@ private static WatermarkPu

Re: [PR] [FLINK-37128][pipeline-connector/mysql] Binlog reader skip `shouldEmit` filter when snapshot reader skip backfill [flink-cdc]

2025-05-11 Thread via GitHub
loserwang1024 commented on PR #3874: URL: https://github.com/apache/flink-cdc/pull/3874#issuecomment-2870576110 Hi, @beryllw , would you like to push forward this pr? I found the minor modifaction: ```java // org.apache.flink.cdc.connectors.mysql.source.assigners.MySqlHybridSpli

Re: [PR] [FLINK-37552] Support switching between ForStKeyedStatebackend and ForStSyncKeyedStatebackend [flink]

2025-05-11 Thread via GitHub
fredia merged PR #26466: URL: https://github.com/apache/flink/pull/26466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Assigned] (FLINK-37552) Made StateMetaInfo consistent for ForStKeyeStateBackend and ForStSyncKeyeStateBackend.

2025-05-11 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei reassigned FLINK-37552: -- Assignee: Yanfei Lei > Made StateMetaInfo consistent for ForStKeyeStateBackend and > ForStSy

[jira] [Assigned] (FLINK-37552) Made StateMetaInfo consistent for ForStKeyeStateBackend and ForStSyncKeyeStateBackend.

2025-05-11 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei reassigned FLINK-37552: -- Assignee: Yue Ma (was: Yanfei Lei) > Made StateMetaInfo consistent for ForStKeyeStateBackend

[jira] [Resolved] (FLINK-37552) Made StateMetaInfo consistent for ForStKeyeStateBackend and ForStSyncKeyeStateBackend.

2025-05-11 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei resolved FLINK-37552. Resolution: Resolved Merged into master via 707bae0fb118cbe2b95bfad7a516bf19421f40d9 > Made State