leonardBang commented on code in PR #3868:
URL: https://github.com/apache/flink-cdc/pull/3868#discussion_r1963490580
##
pom.xml:
##
@@ -67,8 +67,8 @@ limitations under the License.
true
-1.19.1
-1.19
+1.20.0
Review Comment:
@feren
afedulov opened a new pull request, #26186:
URL: https://github.com/apache/flink/pull/26186
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
shameersss1 commented on code in PR #26162:
URL: https://github.com/apache/flink/pull/26162#discussion_r1963492616
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRecomputeStatisticsProgram.java:
##
@@ -115,25 +115,26 @@
flinkbot commented on PR #26186:
URL: https://github.com/apache/flink/pull/26186#issuecomment-2671403012
## CI report:
* 5938f9b7239ea97610cf00eed28ee7183f45bda2 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
ferenc-csaky commented on code in PR #3868:
URL: https://github.com/apache/flink-cdc/pull/3868#discussion_r1963507704
##
pom.xml:
##
@@ -67,8 +67,8 @@ limitations under the License.
true
-1.19.1
-1.19
+1.20.0
Review Comment:
That
snuyanzin commented on code in PR #43:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/43#discussion_r1963507015
##
python/lint-python.sh:
##
@@ -377,73 +375,62 @@ function install_environment() {
print_function "STAGE" "installing environment"
loca
leonardBang commented on code in PR #3856:
URL: https://github.com/apache/flink-cdc/pull/3856#discussion_r1963519196
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.ja
snuyanzin commented on PR #43:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/43#issuecomment-2671613384
Thanks for your contribution and for the hard work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
snuyanzin merged PR #43:
URL: https://github.com/apache/flink-connector-shared-utils/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
gyfora commented on PR #943:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/943#issuecomment-2671596293
please rebase on main for docker fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/FLINK-31238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Somogyi updated FLINK-31238:
--
Fix Version/s: 2.0-preview
(was: 1.20.0)
> Use IngestDB to speed up Roc
gyfora commented on PR #944:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/944#issuecomment-2671597770
rebase on main for docker fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/FLINK-37364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-37364:
---
Labels: pull-request-available (was: )
> Bump Flink 1.19, 1.20 patch versions in Flink CDC
ferenc-csaky opened a new pull request, #3927:
URL: https://github.com/apache/flink-cdc/pull/3927
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
[
https://issues.apache.org/jira/browse/FLINK-36900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928808#comment-17928808
]
Sergey Nuyanzin commented on FLINK-36900:
-
Merged to flink-connector-shared-util
gaborgsomogyi opened a new pull request, #26187:
URL: https://github.com/apache/flink/pull/26187
## What is the purpose of the change
`state.backend.type` exists in the state SQL connector as well as in
`StateBackendOptions`. At the first glance it seemed better to define it in the
c
gaborgsomogyi commented on PR #26187:
URL: https://github.com/apache/flink/pull/26187#issuecomment-2671641608
cc @Zakelly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
[
https://issues.apache.org/jira/browse/FLINK-37363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-37363:
---
Labels: pull-request-available (was: )
> Remove confusing and duplicated state.backend.type
flinkbot commented on PR #26187:
URL: https://github.com/apache/flink/pull/26187#issuecomment-2671683007
## CI report:
* 01c3c0719facda2394fbe5b21e2a9e0745ac3155 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
afedulov merged PR #26183:
URL: https://github.com/apache/flink/pull/26183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
afedulov merged PR #26182:
URL: https://github.com/apache/flink/pull/26182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
afedulov merged PR #26184:
URL: https://github.com/apache/flink/pull/26184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
afedulov commented on PR #26184:
URL: https://github.com/apache/flink/pull/26184#issuecomment-2671862573
CI failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
morhidi commented on PR #945:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/945#issuecomment-2671952374
Thanks for the review folks, I've pushed the requested changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
klam-shop commented on PR #26159:
URL: https://github.com/apache/flink/pull/26159#issuecomment-2671730447
Thanks for your review @davidradl ! Updated s/Rows/rows/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
sn-12-3 commented on PR #25528:
URL: https://github.com/apache/flink/pull/25528#issuecomment-2672118004
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
KevDi commented on PR #75:
URL:
https://github.com/apache/flink-connector-jdbc/pull/75#issuecomment-2672193317
@fapaul Ok i check if i found the old code. In general the question that i
have is what happens if the `flush` call in `close` is throwing an exception.
This will then been throw
Mika Naylor created FLINK-37365:
---
Summary: Add API stability annotations (@Experimental,
@PublicEvolving) to PyFlink APIs
Key: FLINK-37365
URL: https://issues.apache.org/jira/browse/FLINK-37365
Project:
afedulov merged PR #26186:
URL: https://github.com/apache/flink/pull/26186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
afedulov merged PR #26185:
URL: https://github.com/apache/flink/pull/26185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
[
https://issues.apache.org/jira/browse/FLINK-36324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928877#comment-17928877
]
Piotr Nowojski commented on FLINK-36324:
another instance (in an internal built)
bvarghese1 commented on code in PR #25753:
URL: https://github.com/apache/flink/pull/25753#discussion_r1964080867
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/NonTimeRangeUnboundedPrecedingFunction.java:
##
@@ -0,0 +1,596 @@
+/*
becketqin opened a new pull request, #26188:
URL: https://github.com/apache/flink/pull/26188
## What is the purpose of the change
There is a flaky unit test
`SplitFetcherManagerTest.testCloseBlockingWaitingForFetcherShutdown()` in
#25569 . This PR fixes that.
## Brief change log
flinkbot commented on PR #26188:
URL: https://github.com/apache/flink/pull/26188#issuecomment-2672402919
## CI report:
* 74715ae694980fda5e4aee05072fb94ccc9af67a UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-33155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928894#comment-17928894
]
Zhenqiu Huang commented on FLINK-33155:
---
[~gaborgsomogyi]
It is possible to add a
[
https://issues.apache.org/jira/browse/FLINK-37246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928895#comment-17928895
]
Zhenqiu Huang commented on FLINK-37246:
---
[~gaborgsomogyi]
Will the change resolve
autophagy commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1964228329
##
flink-python/pyflink/table/catalog.py:
##
@@ -1391,3 +1391,87 @@ def of(catalog_name: str, configuration: Configuration,
comment: str = None):
j_catalog_
autophagy commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1964230526
##
flink-python/pyflink/table/table.py:
##
@@ -1077,6 +1078,91 @@ def explain(self, *extra_details: ExplainDetail) -> str:
j_extra_details = to_j_explain_det
autophagy commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1964231144
##
flink-python/pyflink/table/catalog.py:
##
@@ -1391,3 +1391,87 @@ def of(catalog_name: str, configuration: Configuration,
comment: str = None):
j_catalog_
klam-shop commented on PR #26159:
URL: https://github.com/apache/flink/pull/26159#issuecomment-2672553872
@AHeise any chance you have bandwidth to review this PR, or can help finding
a committer to review?
--
This is an automated message from the Apache Git Service.
To respond to the mes
lihaosky commented on code in PR #25834:
URL: https://github.com/apache/flink/pull/25834#discussion_r1964269034
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterModelReset.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foun
[
https://issues.apache.org/jira/browse/FLINK-37319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928904#comment-17928904
]
Zhenqiu Huang commented on FLINK-37319:
---
I agree. It is an SLA given by cloud prov
[
https://issues.apache.org/jira/browse/FLINK-36172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928908#comment-17928908
]
Francesco commented on FLINK-36172:
---
hey, I worked on a fix of this same issue in my c
davidradl commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1963446111
##
flink-python/pyflink/table/catalog.py:
##
@@ -1391,3 +1391,87 @@ def of(catalog_name: str, configuration: Configuration,
comment: str = None):
j_catalog_
afedulov opened a new pull request, #26184:
URL: https://github.com/apache/flink/pull/26184
Mac uses BSD sed that requires an explicit extension for `-i` option. This
works universally for both GNU and BSD sed.
I believe it previously caused issues with `@PublicEvolving` javacmp
exclusi
flinkbot commented on PR #26185:
URL: https://github.com/apache/flink/pull/26185#issuecomment-2671402752
## CI report:
* a77a1784bb41de0065d9df4fbb5000173292a26f UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
leonardBang commented on PR #3868:
URL: https://github.com/apache/flink-cdc/pull/3868#issuecomment-2671449925
> Well, exchanged the `mongodb7` failure to a `mysql` one.. :) Will check on
it tomorrow
It's a known issue, maybe related to polardbx docker image, I've connected
with the p
[
https://issues.apache.org/jira/browse/FLINK-37152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu updated FLINK-37152:
---
Affects Version/s: cdc-3.3.0
> Update Flink version to 1.20 in Flink CDC
> -
[
https://issues.apache.org/jira/browse/FLINK-37152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu resolved FLINK-37152.
Resolution: Resolved
Resolved via master: 0211a136cf63a65c0b9a9c3aab322736ceed0faf
> Update Flink
leonardBang merged PR #3868:
URL: https://github.com/apache/flink-cdc/pull/3868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink
leonardBang commented on code in PR #3868:
URL: https://github.com/apache/flink-cdc/pull/3868#discussion_r1963529042
##
pom.xml:
##
@@ -67,8 +67,8 @@ limitations under the License.
true
-1.19.1
-1.19
+1.20.0
Review Comment:
As the
shameersss1 commented on PR #26162:
URL: https://github.com/apache/flink/pull/26162#issuecomment-2671472525
> Please could you add a unit test.
Sure will add a UT for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
flinkbot commented on PR #26180:
URL: https://github.com/apache/flink/pull/26180#issuecomment-2670772439
## CI report:
* 4bbd6e2b30a341fb21ba4c2fc126bc6c713676d4 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-37069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928695#comment-17928695
]
Weijie Guo commented on FLINK-37069:
Thanks for the quick fix!
I recompiled flink f
libenchao merged PR #26173:
URL: https://github.com/apache/flink/pull/26173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apa
[
https://issues.apache.org/jira/browse/FLINK-36549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benchao Li closed FLINK-36549.
--
Fix Version/s: 2.0.0
1.19.3
1.20.2
Resolution: Fixed
Than
fapaul commented on PR #75:
URL:
https://github.com/apache/flink-connector-jdbc/pull/75#issuecomment-2671230298
> @fapaul i can try to take a look at it. Question would be if it is still
enough to do the fix like i provided it here or if the solution from @tamirsagi
here
https://github.co
libenchao merged PR #26172:
URL: https://github.com/apache/flink/pull/26172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apa
davidradl commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1963437711
##
flink-python/docs/reference/pyflink.table/catalog.rst:
##
@@ -250,3 +250,31 @@ A CatalogDescriptor is a template for creating a catalog
instance. It closely re
davidradl commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1963431910
##
flink-python/docs/reference/pyflink.table/catalog.rst:
##
@@ -250,3 +250,31 @@ A CatalogDescriptor is a template for creating a catalog
instance. It closely re
afedulov opened a new pull request, #26183:
URL: https://github.com/apache/flink/pull/26183
Mac uses BSD sed that requires an explicit extension for -i option. This
works universally for both GNU and BSD sed.
I believe it previously caused issues with @PublicEvolving javacmp
exclusions n
[
https://issues.apache.org/jira/browse/FLINK-37356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928756#comment-17928756
]
Arvid Heise commented on FLINK-37356:
-
Yes that makes more sense. I just couldn't co
davidradl commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1963438709
##
flink-python/docs/reference/pyflink.table/catalog.rst:
##
@@ -250,3 +250,31 @@ A CatalogDescriptor is a template for creating a catalog
instance. It closely re
davidradl commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1963441899
##
flink-python/docs/reference/pyflink.table/descriptors.rst:
##
@@ -140,3 +140,18 @@ The set of changes contained in a changelog.
ChangelogMode.insert_only
[
https://issues.apache.org/jira/browse/FLINK-37359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-37359:
---
Labels: pull-request-available (was: )
> Docker build fails for Kubernetes operator
> -
davidradl commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1963476837
##
flink-python/pyflink/table/table_pipeline.py:
##
@@ -0,0 +1,78 @@
+
+# Licensed to
davidradl commented on code in PR #26167:
URL: https://github.com/apache/flink/pull/26167#discussion_r1963463378
##
flink-python/pyflink/table/table.py:
##
@@ -1077,6 +1078,91 @@ def explain(self, *extra_details: ExplainDetail) -> str:
j_extra_details = to_j_explain_det
flinkbot commented on PR #26184:
URL: https://github.com/apache/flink/pull/26184#issuecomment-2671371383
## CI report:
* 022971f77ada0ca135e5be21fe22f46a536ac4f4 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Ferenc Csaky created FLINK-37364:
Summary: Bump Flink 1.19, 1.20 patch versions in Flink CDC
Key: FLINK-37364
URL: https://issues.apache.org/jira/browse/FLINK-37364
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-37363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Somogyi updated FLINK-37363:
--
Affects Version/s: 2.0-preview
> Remove confusing and duplicated state.backend.type config fro
gyfora commented on PR #945:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/945#issuecomment-2671594528
Please rebase on main for the docker fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
101 - 171 of 171 matches
Mail list logo
